191223 2018-11-02 19:49:49 -0700 [WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option 2018-11-05 00:03:39 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro aboya bugs-noreply calvaris commit-queue mcatanzaro oldest_to_newest 1474722 0 mcatanzaro 2018-11-02 19:49:49 -0700 Since we need to support old versions of GStreamer, and that requires disabling ENABLE_MEDIA_SOURCE, we should expose it as a public option. It's pretty weird to tell users that they need to disable a secret hidden option in order to build WebKit. 1474735 1 353763 mcatanzaro 2018-11-02 22:10:33 -0700 Created attachment 353763 Patch 1474736 2 353764 mcatanzaro 2018-11-02 22:19:16 -0700 Created attachment 353764 Patch 1474973 3 353764 calvaris 2018-11-04 23:38:34 -0800 Comment on attachment 353764 Patch IMHO, what was weird was that this was private in the first place. 1474976 4 353764 commit-queue 2018-11-05 00:03:37 -0800 Comment on attachment 353764 Patch Clearing flags on attachment: 353764 Committed r237791: <https://trac.webkit.org/changeset/237791> 1474977 5 commit-queue 2018-11-05 00:03:39 -0800 All reviewed patches have been landed. Closing bug. 353763 2018-11-02 22:10:33 -0700 2018-11-02 22:19:14 -0700 Patch bug-191223-20181103001032.patch text/plain 1463 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGYzZDk5 ZTFkYjY2ZjEwYTY4YTE5MDA2OGQ5Mzg2YTM2MDVmNDZhZWUuLmUwNjM5N2I5NzEyNjE4NTFjYzQw YTI4NDVmYjM1NTc4NGVhMjNhOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xMzMsNiArMTMz LDcgQEAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0RSQUdfU1VQUE9S VCBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfR0VP TE9DQVRJT04gUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5B QkxFX0lDT05EQVRBQkFTRSBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfSklUIFBVQkxJQyBPTikKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZB TFVFKEVOQUJMRV9NRURJQV9TT1VSQ0UgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxU X1BPUlRfVkFMVUUoRU5BQkxFX1NBTVBMSU5HX1BST0ZJTEVSIFBVQkxJQyBPTikKIFdFQktJVF9P UFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TUEVMTENIRUNLIFBVQkxJQyBPTikKIFdF QktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9UT1VDSF9FVkVOVFMgUFVCTElD IE9OKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGZkMjExYzc1MTY2 ZjVkNjRjN2E2YmFhMDExMzJlYTZjMzVlNWNhYzAuLjlhOTVmMTZmYWQ5OTQ5YzNhNGNlZjVhZTYy NWFkZGQ0OThjZDgzMWUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxOC0xMS0wMiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJv QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRXhwb3NlIEVOQUJMRV9NRURJQV9TT1VSQ0Ug YXMgcHVibGljIG9wdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTkxMjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyBvcHRpb24gc2hvdWxkIGJlIHB1YmxpYyBiZWNhdXNlIGl0IG5lZWRzIHRv IGJlIGRpc2FibGVkIHRvIGJ1aWxkIHdpdGggR1N0cmVhbWVyIG9sZGVyCisgICAgICAgIHRoYW4g MS4xNC40LgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6CisKIDIw MTgtMTAtMzAgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAg ICBbUGxheVN0YXRpb25dIEVuYWJsZSBKYXZhU2NyaXB0Q29yZQo= 353764 2018-11-02 22:19:16 -0700 2018-11-05 00:03:37 -0800 Patch bug-191223-20181103001915.patch text/plain 1449 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvR1N0 cmVhbWVyRGVmaW5pdGlvbnMuY21ha2UgYi9Tb3VyY2UvY21ha2UvR1N0cmVhbWVyRGVmaW5pdGlv bnMuY21ha2UKaW5kZXggMDM5MzhjODc3NGU2ZmU3NWExY2VjNjBjZmNjZmNmNjdlZGRiYjQ5Yy4u ZDAwOTRiMGMzODQ1ZjBjZjZkYmM0NjE5NTkzZTI2ZWUyZTdlZGJkMyAxMDA2NDQKLS0tIGEvU291 cmNlL2NtYWtlL0dTdHJlYW1lckRlZmluaXRpb25zLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9H U3RyZWFtZXJEZWZpbml0aW9ucy5jbWFrZQpAQCAtMSw3ICsxLDcgQEAKIFdFQktJVF9PUFRJT05f REVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9WSURFTyBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9O X0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfV0VCX0FVRElPIFBVQkxJQyBPTikKIAotV0VCS0lU X09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX01FRElBX1NPVVJDRSBQUklWQVRFIE9O KQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX01FRElBX1NPVVJDRSBQ VUJMSUMgT04pCiAKIFdFQktJVF9PUFRJT05fREVGSU5FKFVTRV9HU1RSRUFNRVJfR0wgIldoZXRo ZXIgdG8gZW5hYmxlIHN1cHBvcnQgZm9yIEdTdHJlYW1lciBHTCIgUFJJVkFURSBPTikKIFdFQktJ VF9PUFRJT05fREVGSU5FKFVTRV9HU1RSRUFNRVJfTVBFR1RTICJXaGV0aGVyIHRvIGVuYWJsZSBz dXBwb3J0IGZvciBNUEVHLVRTIiBQUklWQVRFIE9GRikKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBi L0NoYW5nZUxvZwppbmRleCBmZDIxMWM3NTE2NmY1ZDY0YzdhNmJhYTAxMTMyZWE2YzM1ZTVjYWMw Li5mNjZhZmI4NmQyYTNkOWJlNThjZWFmYjA4MTdlOTVlMmI0OGU5ZWRlIDEwMDY0NAotLS0gYS9D aGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMTEtMDIgIE1p Y2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVd W0dUS10gRXhwb3NlIEVOQUJMRV9NRURJQV9TT1VSQ0UgYXMgcHVibGljIG9wdGlvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxMjIzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBvcHRpb24gc2hv dWxkIGJlIHB1YmxpYyBiZWNhdXNlIGl0IG5lZWRzIHRvIGJlIGRpc2FibGVkIHRvIGJ1aWxkIHdp dGggR1N0cmVhbWVyIG9sZGVyCisgICAgICAgIHRoYW4gMS4xNC40LgorCisgICAgICAgICogU291 cmNlL2NtYWtlL0dTdHJlYW1lckRlZmluaXRpb25zLmNtYWtlOgorCiAyMDE4LTEwLTMwICBEb24g T2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW1BsYXlTdGF0aW9u XSBFbmFibGUgSmF2YVNjcmlwdENvcmUK