191220 2018-11-02 17:54:41 -0700 Assert JSValues can fit into a pointer when API casting 2018-11-05 10:56:28 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue ews-watchlist mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1474698 0 keith_miller 2018-11-02 17:54:41 -0700 Assert JSValues can fit into a pointer when API casting 1474699 1 353752 keith_miller 2018-11-02 17:54:57 -0700 Created attachment 353752 Patch 1474705 2 353752 msaboff 2018-11-02 18:27:46 -0700 Comment on attachment 353752 Patch r=me 1474709 3 353752 commit-queue 2018-11-02 18:52:42 -0700 Comment on attachment 353752 Patch Clearing flags on attachment: 353752 Committed r237764: <https://trac.webkit.org/changeset/237764> 1474710 4 commit-queue 2018-11-02 18:52:43 -0700 All reviewed patches have been landed. Closing bug. 1474711 5 webkit-bug-importer 2018-11-02 18:53:34 -0700 <rdar://problem/45779456> 1474813 6 353752 mark.lam 2018-11-03 15:02:32 -0700 Comment on attachment 353752 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353752&action=review > Source/JavaScriptCore/API/APICast.h:83 > + static_assert(sizeof(OpaqueJSValue*) == sizeof(JSC::JSValue), "JSValue needs to fit into a boxed pointer"); > JSC::JSValue result = JSC::JSValue::decode(reinterpret_cast<JSC::EncodedJSValue>(const_cast<OpaqueJSValue*>(v))); I believe this is what bitwise_cast does. You should just use that instead. 1474953 7 saam 2018-11-04 20:58:18 -0800 (In reply to Mark Lam from comment #6) > Comment on attachment 353752 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353752&action=review > > > Source/JavaScriptCore/API/APICast.h:83 > > + static_assert(sizeof(OpaqueJSValue*) == sizeof(JSC::JSValue), "JSValue needs to fit into a boxed pointer"); > > JSC::JSValue result = JSC::JSValue::decode(reinterpret_cast<JSC::EncodedJSValue>(const_cast<OpaqueJSValue*>(v))); > > I believe this is what bitwise_cast does. You should just use that instead. +1 1475168 8 keith_miller 2018-11-05 10:56:28 -0800 (In reply to Saam Barati from comment #7) > (In reply to Mark Lam from comment #6) > > Comment on attachment 353752 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=353752&action=review > > > > > Source/JavaScriptCore/API/APICast.h:83 > > > + static_assert(sizeof(OpaqueJSValue*) == sizeof(JSC::JSValue), "JSValue needs to fit into a boxed pointer"); > > > JSC::JSValue result = JSC::JSValue::decode(reinterpret_cast<JSC::EncodedJSValue>(const_cast<OpaqueJSValue*>(v))); > > > > I believe this is what bitwise_cast does. You should just use that instead. > > +1 Good point! I filed https://bugs.webkit.org/show_bug.cgi?id=191272. 353752 2018-11-02 17:54:57 -0700 2018-11-02 18:52:42 -0700 Patch bug-191220-20181102175456.patch text/plain 2236 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ZGJkNjBhNTFmZDJhNGFiOWNiMTZmZjU0N2NiMGViYmZhYmNlMjdiLi4yNGZlNmJkOTY3Yjg1MWVl N2Q5NmE4ODE1NTYxYTEwMGUwM2VmZjAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0xMS0wMiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBBc3NlcnQgSlNWYWx1ZXMgY2FuIGZpdCBpbnRvIGEgcG9pbnRlciB3 aGVuIEFQSSBjYXN0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTEyMjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIEFQSS9BUElDYXN0Lmg6CisgICAgICAgICh0b0pTKToKKyAgICAgICAgKHRvSlNG b3JHQyk6CisgICAgICAgICh0b1JlZik6CisKIDIwMTgtMTEtMDIgIEtlaXRoIE1pbGxlciAgPGtl aXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgQVBJIHNob3VsZCB1c2Ugd3JhcHBlciBv YmplY3QgaWYgYWRkcmVzcyBpcyAzMi1iaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9BUEkvQVBJQ2FzdC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9BUElDYXN0LmgK aW5kZXggNTkyMDJjNmYzOGMzNjJlNGFhYWQ2ODQyMDYzMmI4ZWVlYTQxNGYyNi4uMGM5YzdlOTA2 MmYyZjEyYTMwMTVhZTA2MDdmMjNiNmU3NGViYjlhNiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL0FQSS9BUElDYXN0LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9B UElDYXN0LmgKQEAgLTc5LDYgKzc5LDcgQEAgaW5saW5lIEpTQzo6SlNWYWx1ZSB0b0pTKEpTQzo6 RXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlUmVmIHYpCiAgICAgZWxzZQogICAgICAgICByZXN1bHQg PSBqc0NlbGw7CiAjZWxzZQorICAgIHN0YXRpY19hc3NlcnQoc2l6ZW9mKE9wYXF1ZUpTVmFsdWUq KSA9PSBzaXplb2YoSlNDOjpKU1ZhbHVlKSwgIkpTVmFsdWUgbmVlZHMgdG8gZml0IGludG8gYSBi b3hlZCBwb2ludGVyIik7CiAgICAgSlNDOjpKU1ZhbHVlIHJlc3VsdCA9IEpTQzo6SlNWYWx1ZTo6 ZGVjb2RlKHJlaW50ZXJwcmV0X2Nhc3Q8SlNDOjpFbmNvZGVkSlNWYWx1ZT4oY29uc3RfY2FzdDxP cGFxdWVKU1ZhbHVlKj4odikpKTsKICNlbmRpZgogICAgIGlmICghcmVzdWx0KQpAQCAtOTcsNiAr OTgsNyBAQCBpbmxpbmUgSlNDOjpKU1ZhbHVlIHRvSlNGb3JHQyhKU0M6OkV4ZWNTdGF0ZSogZXhl YywgSlNWYWx1ZVJlZiB2KQogICAgICAgICByZXR1cm4gSlNDOjpKU1ZhbHVlKCk7CiAgICAgSlND OjpKU1ZhbHVlIHJlc3VsdCA9IGpzQ2VsbDsKICNlbHNlCisgICAgc3RhdGljX2Fzc2VydChzaXpl b2YoT3BhcXVlSlNWYWx1ZSopID09IHNpemVvZihKU0M6OkpTVmFsdWUpLCAiSlNWYWx1ZSBuZWVk cyB0byBmaXQgaW50byBhIGJveGVkIHBvaW50ZXIiKTsKICAgICBKU0M6OkpTVmFsdWUgcmVzdWx0 ID0gSlNDOjpKU1ZhbHVlOjpkZWNvZGUocmVpbnRlcnByZXRfY2FzdDxKU0M6OkVuY29kZWRKU1Zh bHVlPihjb25zdF9jYXN0PE9wYXF1ZUpTVmFsdWUqPih2KSkpOwogI2VuZGlmCiAgICAgaWYgKHJl c3VsdCAmJiByZXN1bHQuaXNDZWxsKCkpCkBAIC0xMzgsNiArMTQwLDcgQEAgaW5saW5lIEpTVmFs dWVSZWYgdG9SZWYoSlNDOjpFeGVjU3RhdGUqIGV4ZWMsIEpTQzo6SlNWYWx1ZSB2KQogICAgICAg ICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxKU1ZhbHVlUmVmPihKU0M6OmpzQVBJVmFsdWVXcmFw cGVyKGV4ZWMsIHYpLmFzQ2VsbCgpKTsKICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxKU1Zh bHVlUmVmPih2LmFzQ2VsbCgpKTsKICNlbHNlCisgICAgc3RhdGljX2Fzc2VydChzaXplb2YoT3Bh cXVlSlNWYWx1ZSopID09IHNpemVvZihKU0M6OkpTVmFsdWUpLCAiSlNWYWx1ZSBuZWVkcyB0byBm aXQgaW50byBhIGJveGVkIHBvaW50ZXIiKTsKICAgICBVTlVTRURfUEFSQU0oZXhlYyk7CiAgICAg cmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8SlNWYWx1ZVJlZj4oSlNDOjpKU1ZhbHVlOjplbmNvZGUo dikpOwogI2VuZGlmCg==