191210 2018-11-02 14:27:23 -0700 [IntersectionObserver] Fix isIntersecting computation when 0 is not a threshold 2018-11-05 06:48:24 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 159475 1 ajuma ajuma bfulgham cdumez commit-queue dbates esprehn+autocc ews-watchlist kangil.han simon.fraser webkit-bug-importer zalan oldest_to_newest 1474624 0 ajuma 2018-11-02 14:27:23 -0700 isIntersecting should be false if the intersection ratio is smaller than the smallest threshold value. We currently set it to true whenever the intersection ratio is non-zero, but that's incorrect if the smallest threshold is non-zero. 1474628 1 353732 ajuma 2018-11-02 14:31:35 -0700 Created attachment 353732 Patch 1475061 2 353732 commit-queue 2018-11-05 06:47:49 -0800 Comment on attachment 353732 Patch Clearing flags on attachment: 353732 Committed r237798: <https://trac.webkit.org/changeset/237798> 1475062 3 commit-queue 2018-11-05 06:47:51 -0800 All reviewed patches have been landed. Closing bug. 1475063 4 webkit-bug-importer 2018-11-05 06:48:24 -0800 <rdar://problem/45806230> 353732 2018-11-02 14:31:35 -0700 2018-11-05 06:47:49 -0800 Patch bug-191210-20181102173135.patch text/plain 3356 ajuma U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjhkZmFhZWUyN2MwOWNm ZmNmMzBhZWQ3Mzc5ODE0Njk4OGQwMDg1My4uODZjN2E5NmUwN2ZmYzhjNmVjMDVmOTMwNmMyOWIx NDk2NmY1ODUwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTExLTAyICBBbGkg SnVtYSAgPGFqdW1hQGNocm9taXVtLm9yZz4KKworICAgICAgICBbSW50ZXJzZWN0aW9uT2JzZXJ2 ZXJdIEZpeCBpc0ludGVyc2VjdGluZyBjb21wdXRhdGlvbiB3aGVuIDAgaXMgbm90IGEgdGhyZXNo b2xkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEy MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBpc0lu dGVyc2VjdGluZyBzaG91bGQgYmUgZmFsc2UgaWYgdGhlIGludGVyc2VjdGlvbiByYXRpbyBpcyBz bWFsbGVyIHRoYW4gdGhlCisgICAgICAgIHNtYWxsZXN0IHRocmVzaG9sZCB2YWx1ZS4gVXBkYXRl IHRoZSBjb21wdXRhdGlvbiBvZiBpc0ludGVyc2VjdGluZyB0byBkZXBlbmQgb24KKyAgICAgICAg dGhlIGN1cnJlbnQgdGhyZXNob2xkSW5kZXguCisKKyAgICAgICAgVGVzdDogaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9pbnRlcnNlY3Rpb24tb2JzZXJ2ZXIvaW5pdGlhbC1vYnNlcnZh dGlvbi13aXRoLXRocmVzaG9sZC1leHBlY3RlZC5odG1sCisKKyAgICAgICAgKiBkb20vRG9jdW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnVwZGF0ZUludGVyc2VjdGlvbk9i c2VydmF0aW9ucyk6CisKIDIwMTgtMTEtMDIgIEFsaSBKdW1hICA8YWp1bWFAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIEFsbG93IGNyb3NzLWRvY3VtZW50IGludGVyc2VjdGlvbiBvYnNlcnZpbmcK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDBmMzkwODhlNWU4MWJkNmEzZGZhMDgyNmEzZWFl ZjdhMTY4YTI5ZjIuLjVlNWNhNDE2ZTI2NTE1MDkzOTMzOTQ5NjUyOGVjZDNhOGM0ZWFhYWUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtNzc3Myw3ICs3NzczLDcgQEAgdm9pZCBEb2N1bWVu dDo6dXBkYXRlSW50ZXJzZWN0aW9uT2JzZXJ2YXRpb25zKCkKICAgICAgICAgICAgICAgICAgICAg eyBjbGllbnRJbnRlcnNlY3Rpb25SZWN0LngoKSwgY2xpZW50SW50ZXJzZWN0aW9uUmVjdC55KCks IGNsaWVudEludGVyc2VjdGlvblJlY3Qud2lkdGgoKSwgY2xpZW50SW50ZXJzZWN0aW9uUmVjdC5o ZWlnaHQoKSB9LAogICAgICAgICAgICAgICAgICAgICBpbnRlcnNlY3Rpb25SYXRpbywKICAgICAg ICAgICAgICAgICAgICAgdGFyZ2V0LAotICAgICAgICAgICAgICAgICAgICBpbnRlcnNlY3Rpb25T dGF0ZT8gaW50ZXJzZWN0aW9uU3RhdGUtPmlzSW50ZXJzZWN0aW5nIDogZmFsc2UsCisgICAgICAg ICAgICAgICAgICAgIHRocmVzaG9sZEluZGV4ID4gMCwKICAgICAgICAgICAgICAgICB9KSk7CiAg ICAgICAgICAgICAgICAgbmVlZE5vdGlmeSA9IHRydWU7CiAgICAgICAgICAgICAgICAgcmVnaXN0 cmF0aW9uLnByZXZpb3VzVGhyZXNob2xkSW5kZXggPSB0aHJlc2hvbGRJbmRleDsKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDIzYzdiNzc3NTg0Y2NlOTgwMzM2YjFkOGNkNzQ3Mjlm M2M4ZGRmNzUuLjgyMTA2YTg1YzY5NWJmMjczZjY1NmY5YWViOGEwMDFkMTlkY2I4ZmEgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTExLTAyICBB bGkgSnVtYSAgPGFqdW1hQGNocm9taXVtLm9yZz4KKworICAgICAgICBbSW50ZXJzZWN0aW9uT2Jz ZXJ2ZXJdIEZpeCBpc0ludGVyc2VjdGluZyBjb21wdXRhdGlvbiB3aGVuIDAgaXMgbm90IGEgdGhy ZXNob2xkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTEyMTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBV cGRhdGUgZXhwZWN0YXRpb24gZm9yIHRlc3QgdGhhdCBub3cgcGFzc2VzLgorCisgICAgICAgICog d2ViLXBsYXRmb3JtLXRlc3RzL2ludGVyc2VjdGlvbi1vYnNlcnZlci9pbml0aWFsLW9ic2VydmF0 aW9uLXdpdGgtdGhyZXNob2xkLWV4cGVjdGVkLnR4dDoKKwogMjAxOC0xMS0wMiAgQWxpIEp1bWEg IDxhanVtYUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWxsb3cgY3Jvc3MtZG9jdW1lbnQgaW50 ZXJzZWN0aW9uIG9ic2VydmluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9pbnRlcnNlY3Rpb24tb2JzZXJ2ZXIvaW5pdGlhbC1vYnNlcnZh dGlvbi13aXRoLXRocmVzaG9sZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ludGVyc2VjdGlvbi1vYnNlcnZlci9pbml0aWFsLW9ic2Vy dmF0aW9uLXdpdGgtdGhyZXNob2xkLWV4cGVjdGVkLnR4dAppbmRleCA2Yzg5NjQ5NDg2ZThkZWVj ZTIzZDFjM2ZjYTMzZGU4Nzg0OTFiMjQyLi5lMzkzMjdmZGZkMmJhOGM0NTUxNzM5ZTQ3YTY2OTMy MTk2ODZlOTA5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL2ludGVyc2VjdGlvbi1vYnNlcnZlci9pbml0aWFsLW9ic2VydmF0aW9uLXdpdGgt dGhyZXNob2xkLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2ludGVyc2VjdGlvbi1vYnNlcnZlci9pbml0aWFsLW9ic2VydmF0aW9u LXdpdGgtdGhyZXNob2xkLWV4cGVjdGVkLnR4dApAQCAtMSw1ICsxLDUgQEAKIAogUEFTUyBGaXJz dCBvYnNlcnZhdGlvbiB3aXRoIGEgdGhyZXNob2xkLiAKLUZBSUwgRmlyc3QgckFGIGFzc2VydF9l cXVhbHM6IGVudHJpZXNbMF0uaXNJbnRlcnNlY3RpbmcgZXhwZWN0ZWQgZmFsc2UgYnV0IGdvdCB0 cnVlCitQQVNTIEZpcnN0IHJBRiAKIFBBU1Mgcm9vdC5zY3JvbGxUb3AgPSAyMCAKIAo=