191181 2018-11-01 21:20:56 -0700 [LFC][BFC] BlockFormattingContext::instrinsicWidthConstraints logic should look similar to ::layout 2018-11-02 07:23:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1474394 0 zalan 2018-11-01 21:20:56 -0700 ssia. 1474395 1 353678 zalan 2018-11-01 21:23:12 -0700 Created attachment 353678 Patch 1474476 2 zalan 2018-11-02 07:22:04 -0700 Committed r237730: <https://trac.webkit.org/changeset/237730> 1474477 3 webkit-bug-importer 2018-11-02 07:23:21 -0700 <rdar://problem/45761450> 353678 2018-11-01 21:23:12 -0700 2018-11-02 06:44:28 -0700 Patch Patch.txt text/plain 4117 zalan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjODViZTkxYTFkMC4uMTBlZDZmZWM3NjggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOC0xMS0wMSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgor CisgICAgICAgIFtMRkNdW0JGQ10gQmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6aW5zdHJpbnNpY1dp ZHRoQ29uc3RyYWludHMgbG9naWMgc2hvdWxkIGxvb2sgc2ltaWxhciB0byA6OmxheW91dAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxMTgxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsYXlvdXQvYmxv Y2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TGF5b3V0OjpCbG9ja0Zvcm1hdHRpbmdDb250ZXh0OjppbnN0cmluc2ljV2lkdGhDb25zdHJh aW50cyBjb25zdCk6CisKIDIwMTgtMTEtMDEgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNv bT4KIAogICAgICAgICBbTEZDXSBBbGlnbiBzaHJpbmstdG8tZml0IHdpZHRoIGNvbXB1dGF0aW9u IHdpdGggdGhlIGxheW91dCBpbXBsZW1lbnRhdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRl eHQuY3BwCmluZGV4IDA5MWFkMTBjYzdkLi44ZmM0ZDdmMTlmZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0 dGluZ0NvbnRleHQuY3BwCkBAIC0zNzgsNyArMzc4LDYgQEAgRm9ybWF0dGluZ0NvbnRleHQ6Oklu c3RyaW5zaWNXaWR0aENvbnN0cmFpbnRzIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6Omluc3RyaW5z aWMKICAgICAvLyAzLiBBcyB3ZSBjbGltYiBiYWNrIG9uIHRoZSB0cmVlLCBjb21wdXRlIG1pbi9t YXggaW50cmluc2ljIHdpZHRoCiAgICAgLy8gKEFueSBzdWJ0cmVlcyB3aXRoIG5ldyBmb3JtYXR0 aW5nIGNvbnRleHRzIG5lZWQgdG8gbGF5b3V0IHN5bmNocm9ub3VzbHkpCiAgICAgVmVjdG9yPGNv bnN0IEJveCo+IHF1ZXVlOwotICAgIC8vIE5vbi1jb250YWluZXJzIGVhcmx5IHJldHVybi4KICAg ICBBU1NFUlQoaXM8Q29udGFpbmVyPihmb3JtYXR0aW5nUm9vdCkpOwogICAgIGlmIChhdXRvKiBm aXJzdENoaWxkID0gZG93bmNhc3Q8Q29udGFpbmVyPihmb3JtYXR0aW5nUm9vdCkuZmlyc3RJbkZs b3dPckZsb2F0aW5nQ2hpbGQoKSkKICAgICAgICAgcXVldWUuYXBwZW5kKGZpcnN0Q2hpbGQpOwpA QCAtMzg2LDI5ICszODUsMjMgQEAgRm9ybWF0dGluZ0NvbnRleHQ6Okluc3RyaW5zaWNXaWR0aENv bnN0cmFpbnRzIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6Omluc3RyaW5zaWMKICAgICBhdXRvJiBm b3JtYXR0aW5nU3RhdGUgPSB0aGlzLT5mb3JtYXR0aW5nU3RhdGUoKTsKICAgICB3aGlsZSAoIXF1 ZXVlLmlzRW1wdHkoKSkgewogICAgICAgICB3aGlsZSAodHJ1ZSkgewotICAgICAgICAgICAgYXV0 byYgY2hpbGRCb3ggPSAqcXVldWUubGFzdCgpOyAKLSAgICAgICAgICAgIC8vIEFscmVhZHkgY29t cHV0ZWQ/Ci0gICAgICAgICAgICBhdXRvIGluc3RyaW5zaWNXaWR0aENvbnN0cmFpbnRzID0gZm9y bWF0dGluZ1N0YXRlLmluc3RyaW5zaWNXaWR0aENvbnN0cmFpbnRzKGNoaWxkQm94KTsKLSAgICAg ICAgICAgIC8vIENhbiB3ZSBqdXN0IGNvbXB1dGUgdGhlbSB3aXRob3V0IGNoZWNraW5nIHRoZSBj aGlsZHJlbj8KLSAgICAgICAgICAgIGlmICghaW5zdHJpbnNpY1dpZHRoQ29uc3RyYWludHMgJiYg IUdlb21ldHJ5OjppbnN0cmluc2ljV2lkdGhDb25zdHJhaW50c05lZWRDaGlsZHJlbldpZHRoKGNo aWxkQm94KSkKLSAgICAgICAgICAgICAgICBpbnN0cmluc2ljV2lkdGhDb25zdHJhaW50cyA9IEdl b21ldHJ5OjppbnN0cmluc2ljV2lkdGhDb25zdHJhaW50cyhsYXlvdXRTdGF0ZSwgY2hpbGRCb3gp OwotICAgICAgICAgICAgLy8gSXMgaXQgYSBmb3JtYXR0aW5nIGNvbnRleHQgcm9vdD8KLSAgICAg ICAgICAgIGlmICghaW5zdHJpbnNpY1dpZHRoQ29uc3RyYWludHMgJiYgY2hpbGRCb3guZXN0YWJs aXNoZXNGb3JtYXR0aW5nQ29udGV4dCgpKQotICAgICAgICAgICAgICAgIGluc3RyaW5zaWNXaWR0 aENvbnN0cmFpbnRzID0gZm9ybWF0dGluZ1N0YXRlLmZvcm1hdHRpbmdDb250ZXh0KGNoaWxkQm94 KS0+aW5zdHJpbnNpY1dpZHRoQ29uc3RyYWludHMoKTsKLSAgICAgICAgICAgIC8vIEdvIHRvIHRo ZSBuZXh0IHNpYmxpbmcgKGFuZCBza2lwIHRoZSBkZXNjZW5kYW50cykgaWYgdGhpcyBib3gncyBt aW4vbWF4IHdpZHRoIGlzIGNvbXB1dGVkLgotICAgICAgICAgICAgaWYgKGluc3RyaW5zaWNXaWR0 aENvbnN0cmFpbnRzKSB7Ci0gICAgICAgICAgICAgICAgZm9ybWF0dGluZ1N0YXRlLnNldEluc3Ry aW5zaWNXaWR0aENvbnN0cmFpbnRzKGNoaWxkQm94LCAqaW5zdHJpbnNpY1dpZHRoQ29uc3RyYWlu dHMpOyAKKyAgICAgICAgICAgIGF1dG8mIGNoaWxkQm94ID0gKnF1ZXVlLmxhc3QoKTsKKyAgICAg ICAgICAgIGF1dG8gc2tpcERlc2NlbmRhbnRzID0gZm9ybWF0dGluZ1N0YXRlLmluc3RyaW5zaWNX aWR0aENvbnN0cmFpbnRzKGNoaWxkQm94KSB8fCAhR2VvbWV0cnk6Omluc3RyaW5zaWNXaWR0aENv bnN0cmFpbnRzTmVlZENoaWxkcmVuV2lkdGgoY2hpbGRCb3gpIHx8IGNoaWxkQm94LmVzdGFibGlz aGVzRm9ybWF0dGluZ0NvbnRleHQoKTsKKworICAgICAgICAgICAgaWYgKHNraXBEZXNjZW5kYW50 cykgeworICAgICAgICAgICAgICAgIGlmICghR2VvbWV0cnk6Omluc3RyaW5zaWNXaWR0aENvbnN0 cmFpbnRzTmVlZENoaWxkcmVuV2lkdGgoY2hpbGRCb3gpKQorICAgICAgICAgICAgICAgICAgICBm b3JtYXR0aW5nU3RhdGUuc2V0SW5zdHJpbnNpY1dpZHRoQ29uc3RyYWludHMoY2hpbGRCb3gsIEdl b21ldHJ5OjppbnN0cmluc2ljV2lkdGhDb25zdHJhaW50cyhsYXlvdXRTdGF0ZSwgY2hpbGRCb3gp KTsKKyAgICAgICAgICAgICAgICBlbHNlIGlmIChjaGlsZEJveC5lc3RhYmxpc2hlc0Zvcm1hdHRp bmdDb250ZXh0KCkpCisgICAgICAgICAgICAgICAgICAgIGZvcm1hdHRpbmdTdGF0ZS5zZXRJbnN0 cmluc2ljV2lkdGhDb25zdHJhaW50cyhjaGlsZEJveCwgZm9ybWF0dGluZ1N0YXRlLmZvcm1hdHRp bmdDb250ZXh0KGNoaWxkQm94KS0+aW5zdHJpbnNpY1dpZHRoQ29uc3RyYWludHMoKSk7CisKKyAg ICAgICAgICAgICAgICBBU1NFUlQoZm9ybWF0dGluZ1N0YXRlLmluc3RyaW5zaWNXaWR0aENvbnN0 cmFpbnRzKGNoaWxkQm94KSk7CiAgICAgICAgICAgICAgICAgcXVldWUucmVtb3ZlTGFzdCgpOwog ICAgICAgICAgICAgICAgIGlmICghY2hpbGRCb3gubmV4dEluRmxvd09yRmxvYXRpbmdTaWJsaW5n KCkpCiAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgIHF1ZXVlLmFw cGVuZChjaGlsZEJveC5uZXh0SW5GbG93T3JGbG9hdGluZ1NpYmxpbmcoKSk7CisgICAgICAgICAg ICAgICAgLy8gU2tpcCBkZXNjZW5kYW50cwogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAg ICAgICAgICAgfQotCi0gICAgICAgICAgICBpZiAoIWlzPENvbnRhaW5lcj4oY2hpbGRCb3gpIHx8 ICFkb3duY2FzdDxDb250YWluZXI+KGNoaWxkQm94KS5oYXNJbkZsb3dPckZsb2F0aW5nQ2hpbGQo KSkKLSAgICAgICAgICAgICAgICBicmVhazsKLQotICAgICAgICAgICAgcXVldWUuYXBwZW5kKGRv d25jYXN0PENvbnRhaW5lcj4oY2hpbGRCb3gpLmZpcnN0SW5GbG93T3JGbG9hdGluZ0NoaWxkKCkp OwogICAgICAgICB9CiAKICAgICAgICAgLy8gQ29tcHV0ZSBtaW4vbWF4IGludHJpbnNpYyB3aWR0 aCBib3R0b20gdXAuCg==