191173 2018-11-01 15:02:41 -0700 Uncaught Exception: TypeError: undefined is not an object (evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67) 2018-11-01 16:25:20 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1474289 0 nvasilyev 2018-11-01 15:02:41 -0700 Steps: 1. Reload Web Inspector This uncaught exceptions *may* happen: TypeError: undefined is not an object (evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67) selected @ ScopeBarItem.js:87:67 _populate @ ScopeBar.js:138:34 ScopeBar @ ScopeBar.js:40:23 LogContentView @ LogContentView.js:96:53 createFromRepresentedObject @ ContentView.js:156:41 contentViewForRepresentedObject @ ContentView.js:205:72 contentLoaded @ Main.js:256:81 ? @ [native code] TypeError: undefined is not an object (evaluating 'this.modifierKeys.metaKey') (at Main.js:1458:45) _updateModifierKeys @ Main.js:1458:45 _mouseMoved @ Main.js:1488:29 ? @ [native code] 1474295 1 353651 nvasilyev 2018-11-01 15:33:46 -0700 Created attachment 353651 Patch This was likely a recent regression. Regardless of that, it was odd to have `WI.modifierKeys` initialized somewhere in the middle of WI.contentLoaded — it should come before that. 1474298 2 hi 2018-11-01 15:38:58 -0700 r=me 1474318 3 353651 commit-queue 2018-11-01 16:24:24 -0700 Comment on attachment 353651 Patch Clearing flags on attachment: 353651 Committed r237705: <https://trac.webkit.org/changeset/237705> 1474319 4 commit-queue 2018-11-01 16:24:25 -0700 All reviewed patches have been landed. Closing bug. 1474320 5 webkit-bug-importer 2018-11-01 16:25:20 -0700 <rdar://problem/45746695> 353651 2018-11-01 15:33:46 -0700 2018-11-01 16:24:24 -0700 Patch patch.txt text/plain 1949 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGNjYzUxYzUyOTlkLi5kZDU1YjIyZDAyMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTEtMDEgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgVW5jYXVnaHQgRXhj ZXB0aW9uOiBUeXBlRXJyb3I6IHVuZGVmaW5lZCBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5n ICdXSS5tb2RpZmllcktleXMubWV0YUtleScpIChhdCBTY29wZUJhckl0ZW0uanM6ODc6NjcpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTExNzMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXSS5tb2RpZmll cktleXMgd2FzIGFjY2Vzc2VkIGJlZm9yZSBpdCB3YXMgaW5pdGlhbGl6ZWQuIE1vdmUgaXQgZnJv bSBXSS5jb250ZW50TG9hZGVkIHRvIFdJLmxvYWRlZCwKKyAgICAgICAgd2hpY2ggaGFwcGVucyBi ZWZvcmUgV0kuY29udGVudExvYWRlZC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9N YWluLmpzOgorICAgICAgICAoV0kubG9hZGVkKToKKyAgICAgICAgKFdJLmNvbnRlbnRMb2FkZWQp OgorCiAyMDE4LTExLTAxICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgog CiAgICAgICAgIFJFR1JFU1NJT04ocjIzNzY1Mik6IFdlYiBJbnNwZWN0b3I6IGR1bXBJbnNwZWN0 b3JQcm90b2NvbE1lc3NhZ2VzIGlzIGFsd2F5cyBlbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXggYmU2NzcxNzY1MTEuLmQ1 MTk0ZTU5OWQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv QmFzZS9NYWluLmpzCkBAIC0xNDMsNiArMTQzLDcgQEAgV0kubG9hZGVkID0gZnVuY3Rpb24oKQog ICAgIHRoaXMucHJpbnRTdHlsZXNFbmFibGVkID0gZmFsc2U7CiAgICAgdGhpcy5zZXRab29tRmFj dG9yKFdJLnNldHRpbmdzLnpvb21GYWN0b3IudmFsdWUpOwogICAgIHRoaXMubW91c2VDb29yZHMg PSB7eDogMCwgeTogMH07CisgICAgdGhpcy5tb2RpZmllcktleXMgPSB7YWx0S2V5OiBmYWxzZSwg bWV0YUtleTogZmFsc2UsIHNoaWZ0S2V5OiBmYWxzZX07CiAgICAgdGhpcy52aXNpYmxlID0gZmFs c2U7CiAgICAgdGhpcy5fd2luZG93S2V5ZG93bkxpc3RlbmVycyA9IFtdOwogCkBAIC0zODYsOCAr Mzg3LDYgQEAgV0kuY29udGVudExvYWRlZCA9IGZ1bmN0aW9uKCkKICAgICAgICAgdGhpcy50b29s YmFyLmFkZFRvb2xiYXJJdGVtKHRoaXMuX3NlYXJjaFRvb2xiYXJJdGVtLCBXSS5Ub29sYmFyLlNl Y3Rpb24uUmlnaHQpOwogICAgIH0KIAotICAgIHRoaXMubW9kaWZpZXJLZXlzID0ge2FsdEtleTog ZmFsc2UsIG1ldGFLZXk6IGZhbHNlLCBzaGlmdEtleTogZmFsc2V9OwotCiAgICAgbGV0IGRvY2tl ZFJlc2l6ZXJFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRvY2tlZC1yZXNpemVy Iik7CiAgICAgZG9ja2VkUmVzaXplckVsZW1lbnQuY2xhc3NMaXN0LmFkZChXSS5Qb3BvdmVyLkln bm9yZUF1dG9EaXNtaXNzQ2xhc3NOYW1lKTsKICAgICBkb2NrZWRSZXNpemVyRWxlbWVudC5hZGRF dmVudExpc3RlbmVyKCJtb3VzZWRvd24iLCB0aGlzLl9kb2NrZWRSZXNpemVyTW91c2VEb3duLmJp bmQodGhpcykpOwo=