191172 2018-11-01 14:56:38 -0700 Remove ENABLE_OPENCL fully 2018-11-04 18:15:58 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead rbuis commit-queue dino ews-watchlist kondapallykalyan rbuis webkit-bug-importer ysuzuki oldest_to_newest 1474287 0 don.olmstead 2018-11-01 14:56:38 -0700 There's still some ENABLE(OPENCL) code hanging out in the repository. 1474475 1 353697 rbuis 2018-11-02 07:17:52 -0700 Created attachment 353697 Patch 1474480 2 353697 ysuzuki 2018-11-02 07:24:40 -0700 Comment on attachment 353697 Patch r=me. Nobody is using ENABLE(OPENCL). And we do not have implementations. 1474499 3 353697 commit-queue 2018-11-02 08:39:59 -0700 Comment on attachment 353697 Patch Clearing flags on attachment: 353697 Committed r237732: <https://trac.webkit.org/changeset/237732> 1474500 4 commit-queue 2018-11-02 08:40:01 -0700 All reviewed patches have been landed. Closing bug. 1474501 5 webkit-bug-importer 2018-11-02 08:40:21 -0700 <rdar://problem/45762732> 1474561 6 353697 don.olmstead 2018-11-02 10:48:03 -0700 Comment on attachment 353697 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353697&action=review Beat me to the patch :) Anyways I didn't throw it up because of the applyAll still being there. Seems like that was just there for OPENCL support so it should probably go as well. > Source/WebCore/platform/graphics/filters/FilterEffect.h:96 > inline void applyAll() { apply(); } Should this still be here? 1474562 7 rbuis 2018-11-02 10:50:57 -0700 Hi Don, right I took the gamble since you did not assign to yourself :) The applyAll seems not needed, if you want to do a patch feel free, otherwise I can do it tomorrow. 1474868 8 rbuis 2018-11-04 05:48:06 -0800 Reopening to attach new patch. 1474869 9 353802 rbuis 2018-11-04 05:48:09 -0800 Created attachment 353802 Patch 1474919 10 353802 ysuzuki 2018-11-04 17:51:05 -0800 Comment on attachment 353802 Patch r=me 1474925 11 353802 commit-queue 2018-11-04 18:15:56 -0800 Comment on attachment 353802 Patch Clearing flags on attachment: 353802 Committed r237787: <https://trac.webkit.org/changeset/237787> 1474926 12 commit-queue 2018-11-04 18:15:58 -0800 All reviewed patches have been landed. Closing bug. 353697 2018-11-02 07:17:52 -0700 2018-11-04 05:48:02 -0800 Patch bug-191172-20181102151750.patch text/plain 3371 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTM5NzRmZDM2OWZiNDAz MzAxNWVmNzNkMmMzMGY0MWE4ZWRkYjRkMC4uMDU0MzcyNzJiNWJiN2JhZTRmMDU1ZDUzYjZkZGVk MWJlNTA2YmJhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTExLTAyICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVtb3ZlIEVOQUJMRV9PUEVOQ0wg ZnVsbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 MTE3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cyBzaW5jZSBubyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmlsdGVyRWZmZWN0Lmg6CisgICAgICAgIChXZWJD b3JlOjpGaWx0ZXJFZmZlY3Q6Omhhc1Jlc3VsdCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpG aWx0ZXJFZmZlY3Q6OmFwcGx5QWxsKToKKyAgICAgICAgKFdlYkNvcmU6OkZpbHRlckVmZmVjdDo6 b3BlbkNMSW1hZ2UpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6RmlsdGVyRWZmZWN0Ojpz ZXRPcGVuQ0xJbWFnZSk6IERlbGV0ZWQuCisKIDIwMTgtMTEtMDIgIFphbGFuIEJ1anRhcyAgPHph bGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXSBBbGlnbiBzaHJpbmstdG8tZml0IHdpZHRo IGNvbXB1dGF0aW9uIHdpdGggdGhlIGxheW91dCBpbXBsZW1lbnRhdGlvbi4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmlsdGVyRWZmZWN0Lmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZpbHRlckVmZmVjdC5o CmluZGV4IGFiYjdiMGY4ZjlmYjAyNmMxYWI3MzM0OWEwMDY4YTgzMmYxMTYyMmIuLjhjMjZlMmIz MzkwNDRkMGQ3YTc4MGMwYWVkYmM3YTNlMTQ5MmNlYTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmlsdGVyRWZmZWN0LmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GaWx0ZXJFZmZlY3QuaApAQCAtNjMs MTIgKzYzLDYgQEAgcHVibGljOgogICAgIHZvaWQgY29weVVubXVsdGlwbGllZFJlc3VsdChVaW50 OENsYW1wZWRBcnJheSYgZGVzdGluYXRpb24sIGNvbnN0IEludFJlY3QmKTsKICAgICB2b2lkIGNv cHlQcmVtdWx0aXBsaWVkUmVzdWx0KFVpbnQ4Q2xhbXBlZEFycmF5JiBkZXN0aW5hdGlvbiwgY29u c3QgSW50UmVjdCYpOwogCi0jaWYgRU5BQkxFKE9QRU5DTCkKLSAgICBPcGVuQ0xIYW5kbGUgb3Bl bkNMSW1hZ2UoKSB7IHJldHVybiBtX29wZW5DTEltYWdlUmVzdWx0OyB9Ci0gICAgdm9pZCBzZXRP cGVuQ0xJbWFnZShPcGVuQ0xIYW5kbGUgb3BlbkNMSW1hZ2UpIHsgbV9vcGVuQ0xJbWFnZVJlc3Vs dCA9IG9wZW5DTEltYWdlOyB9Ci0gICAgSW1hZ2VCdWZmZXIqIG9wZW5DTEltYWdlVG9JbWFnZUJ1 ZmZlcigpOwotI2VuZGlmCi0KICAgICBGaWx0ZXJFZmZlY3RWZWN0b3ImIGlucHV0RWZmZWN0cygp IHsgcmV0dXJuIG1faW5wdXRFZmZlY3RzOyB9CiAgICAgRmlsdGVyRWZmZWN0KiBpbnB1dEVmZmVj dCh1bnNpZ25lZCkgY29uc3Q7CiAgICAgdW5zaWduZWQgbnVtYmVyT2ZFZmZlY3RJbnB1dHMoKSBj b25zdCB7IHJldHVybiBtX2lucHV0RWZmZWN0cy5zaXplKCk7IH0KQEAgLTc4LDkgKzcyLDYgQEAg cHVibGljOgogICAgIHsKICAgICAgICAgLy8gVGhpcyBmdW5jdGlvbiBuZWVkcyBwbGF0Zm9ybSBz cGVjaWZpYyBjaGVja3MsIGlmIHRoZSBtZW1vcnkgbWFuYWdtZW50IGlzIG5vdCBkb25lIGJ5IEZp bHRlckVmZmVjdC4KICAgICAgICAgcmV0dXJuIG1faW1hZ2VCdWZmZXJSZXN1bHQKLSNpZiBFTkFC TEUoT1BFTkNMKQotICAgICAgICAgICAgfHwgbV9vcGVuQ0xJbWFnZVJlc3VsdAotI2VuZGlmCiAg ICAgICAgICAgICB8fCBtX3VubXVsdGlwbGllZEltYWdlUmVzdWx0CiAgICAgICAgICAgICB8fCBt X3ByZW11bHRpcGxpZWRJbWFnZVJlc3VsdDsKICAgICB9CkBAIC0xMDIsMTEgKzkzLDcgQEAgcHVi bGljOgogICAgIHZvaWQgc2V0TWF4RWZmZWN0UmVjdChjb25zdCBGbG9hdFJlY3QmIG1heEVmZmVj dFJlY3QpIHsgbV9tYXhFZmZlY3RSZWN0ID0gbWF4RWZmZWN0UmVjdDsgfSAKIAogICAgIHZvaWQg YXBwbHkoKTsKLSNpZiBFTkFCTEUoT1BFTkNMKQotICAgIHZvaWQgYXBwbHlBbGwoKTsKLSNlbHNl CiAgICAgaW5saW5lIHZvaWQgYXBwbHlBbGwoKSB7IGFwcGx5KCk7IH0KLSNlbmRpZgogCiAgICAg Ly8gQ29ycmVjdCBhbnkgaW52YWxpZCBwaXhlbHMsIGlmIG5lY2Vzc2FyeSwgaW4gdGhlIHJlc3Vs dCBvZiBhIGZpbHRlciBvcGVyYXRpb24uCiAgICAgLy8gVGhpcyBtZXRob2QgaXMgdXNlZCB0byBl bnN1cmUgdmFsaWQgcGl4ZWwgdmFsdWVzIG9uIGZpbHRlciBpbnB1dHMgYW5kIHRoZSBmaW5hbCBy ZXN1bHQuCkBAIC0xNjYsOSArMTUzLDYgQEAgcHJvdGVjdGVkOgogICAgIEltYWdlQnVmZmVyKiBj cmVhdGVJbWFnZUJ1ZmZlclJlc3VsdCgpOwogICAgIFVpbnQ4Q2xhbXBlZEFycmF5KiBjcmVhdGVV bm11bHRpcGxpZWRJbWFnZVJlc3VsdCgpOwogICAgIFVpbnQ4Q2xhbXBlZEFycmF5KiBjcmVhdGVQ cmVtdWx0aXBsaWVkSW1hZ2VSZXN1bHQoKTsKLSNpZiBFTkFCTEUoT1BFTkNMKQotICAgIE9wZW5D TEhhbmRsZSBjcmVhdGVPcGVuQ0xJbWFnZVJlc3VsdCh1aW50OF90KiA9IDApOwotI2VuZGlmCiAK ICAgICAvLyBSZXR1cm4gdHJ1ZSBpZiB0aGUgZmlsdGVyIHdpbGwgb25seSBvcGVyYXRlIGNvcnJl Y3RseSBvbiB2YWxpZCBSR0JBIHZhbHVlcywgd2l0aAogICAgIC8vIGFscGhhIGluIFswLDI1NV0g YW5kIGVhY2ggY29sb3IgY29tcG9uZW50IGluIFswLCBhbHBoYV0uCkBAIC0xOTgsOSArMTgyLDYg QEAgcHJpdmF0ZToKICAgICBzdGQ6OnVuaXF1ZV9wdHI8SW1hZ2VCdWZmZXI+IG1faW1hZ2VCdWZm ZXJSZXN1bHQ7CiAgICAgUmVmUHRyPFVpbnQ4Q2xhbXBlZEFycmF5PiBtX3VubXVsdGlwbGllZElt YWdlUmVzdWx0OwogICAgIFJlZlB0cjxVaW50OENsYW1wZWRBcnJheT4gbV9wcmVtdWx0aXBsaWVk SW1hZ2VSZXN1bHQ7Ci0jaWYgRU5BQkxFKE9QRU5DTCkKLSAgICBPcGVuQ0xIYW5kbGUgbV9vcGVu Q0xJbWFnZVJlc3VsdDsKLSNlbmRpZgogCiAgICAgSW50UmVjdCBtX2Fic29sdXRlUGFpbnRSZWN0 OwogICAgIAo= 353802 2018-11-04 05:48:09 -0800 2018-11-04 18:15:56 -0800 Patch bug-191172-20181104144808.patch text/plain 2492 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3Nzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGY0NzdhMTUwMzEyOTZl ZTcyMDFhNjAxNmQ4ZTM2MzQ1MTgxMTM3Zi4uNDlmNjA3ZjBkNjYxZWVkNjZlNTAzY2ZiMjc4ZjI1 MDRjNzk3MzQ4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTExLTA0ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVtb3ZlIEVOQUJMRV9PUEVOQ0wg ZnVsbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 MTE3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZv cmdvdCB0byBzaW1wbGlmeSB0aGlzLCBubyBuZWVkIGZvciBhcHBseUFsbCBhbnltb3JlCisgICAg ICAgIHNpbmNlIGl0IGp1c3QgY2FsbHMgYXBwbHkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNp bmNlIG5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvZmlsdGVycy9GaWx0ZXJFZmZlY3QuaDoKKyAgICAgICAgKFdlYkNvcmU6OkZpbHRlckVm ZmVjdDo6YXBwbHlBbGwpOiBEZWxldGVkLgorICAgICAgICAqIHJlbmRlcmluZy9zdmcvUmVuZGVy U1ZHUmVzb3VyY2VGaWx0ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU1ZHUmVzb3Vy Y2VGaWx0ZXI6OnBvc3RBcHBseVJlc291cmNlKToKKwogMjAxOC0xMS0wNCAgWW91ZW5uIEZhYmxl dCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgSURCIHNob3VsZCBhbGxvdyBzdG9yaW5n IFJUQ0NlcnRpZmljYXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9maWx0ZXJzL0ZpbHRlckVmZmVjdC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZmlsdGVycy9GaWx0ZXJFZmZlY3QuaAppbmRleCA4YzI2ZTJiMzM5MDQ0ZDBkN2E3ODBj MGFlZGJjN2EzZTE0OTJjZWE0Li45YjAwNmUzZjI5N2NjOGFjM2QwZmZkMTkwMTE5NmRkMjE0NTQ1 MjRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJz L0ZpbHRlckVmZmVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Zp bHRlcnMvRmlsdGVyRWZmZWN0LmgKQEAgLTkzLDcgKzkzLDYgQEAgcHVibGljOgogICAgIHZvaWQg c2V0TWF4RWZmZWN0UmVjdChjb25zdCBGbG9hdFJlY3QmIG1heEVmZmVjdFJlY3QpIHsgbV9tYXhF ZmZlY3RSZWN0ID0gbWF4RWZmZWN0UmVjdDsgfSAKIAogICAgIHZvaWQgYXBwbHkoKTsKLSAgICBp bmxpbmUgdm9pZCBhcHBseUFsbCgpIHsgYXBwbHkoKTsgfQogCiAgICAgLy8gQ29ycmVjdCBhbnkg aW52YWxpZCBwaXhlbHMsIGlmIG5lY2Vzc2FyeSwgaW4gdGhlIHJlc3VsdCBvZiBhIGZpbHRlciBv cGVyYXRpb24uCiAgICAgLy8gVGhpcyBtZXRob2QgaXMgdXNlZCB0byBlbnN1cmUgdmFsaWQgcGl4 ZWwgdmFsdWVzIG9uIGZpbHRlciBpbnB1dHMgYW5kIHRoZSBmaW5hbCByZXN1bHQuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1Jlc291cmNlRmlsdGVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VGaWx0 ZXIuY3BwCmluZGV4IDM1ODI2YTBlNzE1ZjY4ODlhZWIyYmU4YWZlZGYxNTNhYTVlODBiZjMuLmRl YTI4MmMwY2Y4YmZlNmExM2ViNzJlZjc3YWE5MDFlNDU3YzgxZTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VGaWx0ZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VGaWx0ZXIuY3Bw CkBAIC0yNjgsNyArMjY4LDcgQEAgdm9pZCBSZW5kZXJTVkdSZXNvdXJjZUZpbHRlcjo6cG9zdEFw cGx5UmVzb3VyY2UoUmVuZGVyRWxlbWVudCYgcmVuZGVyZXIsIEdyYXBoaWMKICAgICAgICAgLy8g QWx3YXlzIHRydWUgaWYgZmlsdGVyRGF0YSBpcyBqdXN0IGJ1aWx0IChmaWx0ZXJEYXRhLT5zdGF0 ZSA9PSBGaWx0ZXJEYXRhOjpCdWlsdCkuCiAgICAgICAgIGlmICghbGFzdEVmZmVjdC0+aGFzUmVz dWx0KCkpIHsKICAgICAgICAgICAgIGZpbHRlckRhdGEuc3RhdGUgPSBGaWx0ZXJEYXRhOjpBcHBs eWluZzsKLSAgICAgICAgICAgIGxhc3RFZmZlY3QtPmFwcGx5QWxsKCk7CisgICAgICAgICAgICBs YXN0RWZmZWN0LT5hcHBseSgpOwogICAgICAgICAgICAgbGFzdEVmZmVjdC0+Y29ycmVjdEZpbHRl clJlc3VsdElmTmVlZGVkKCk7CiAgICAgICAgICAgICBsYXN0RWZmZWN0LT50cmFuc2Zvcm1SZXN1 bHRDb2xvclNwYWNlKENvbG9yU3BhY2VTUkdCKTsKICAgICAgICAgfQo=