19115 2008-05-18 15:30:09 -0700 No completion for local variables when script paused 2008-08-17 20:33:46 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 rik timothy aroben timothy oldest_to_newest 80862 0 rik 2008-05-18 15:30:09 -0700 Now that we have access to variables in the local scope (see https://bugs.webkit.org/show_bug.cgi?id=19052), it would great to have the same completion as global variables. It means the automatic gray "hint" and the completion when pressing the tabulation key. 88615 1 22829 timothy 2008-08-15 17:26:47 -0700 Created attachment 22829 Proposed patch 88653 2 22829 ggaren 2008-08-16 22:00:49 -0700 Comment on attachment 22829 Proposed patch r=me 88695 3 timothy 2008-08-17 20:33:46 -0700 Landed in r35814. 22829 2008-08-15 17:26:47 -0700 2008-08-16 22:00:49 -0700 Proposed patch 0001--Complete-in-scope-variables-in-the-Console-w.patch text/plain 4528 timothy RnJvbSBlMDJlM2EyNDBhY2I5MjMxOTU3ZmU4NWU0ODg3ODQyYjA0OTM0MDlhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBGcmksIDE1IEF1ZyAyMDA4IDE3OjI0OjIxIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gICAg ICAgICBDb21wbGV0ZSBpbiBzY29wZSB2YXJpYWJsZXMgaW4gdGhlIENvbnNvbGUgd2hlbiBwYXVz ZWQuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEx NQoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgKiBwYWdlL2lu c3BlY3Rvci9Db25zb2xlLmpzOgogICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZS5wcm90b3R5 cGUuY29tcGxldGlvbnMpOiBJZiB0aGUgZXhwcmVzc2lvblN0cmluZwogICAgICAgIGlzIG51bGwg b3IgZW1wdHkgYW5kIHRoZSBkZWJ1Z2dlciBpcyBwYXVzZWQsIGNhbGwgdmFyaWFibGVzSW5TY29w ZUZvclNlbGVjdGVkQ2FsbEZyYW1lCiAgICAgICAgdG8gZ2V0IGFuIG9iamVjdCB0aGF0IGRlY2xh cmVzIGFsbCB0aGUgaW4gc2NvcGUgdmFyaWFibGVzLiBUaGF0IHdheQogICAgICAgICJ0b3AgbGV2 ZWwiIGV4cHJlc3Npb25zIGFyZSBjb21wbGV0ZWQuCiAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9T Y3JpcHRzUGFuZWwuanM6CiAgICAgICAgKFdlYkluc3BlY3Rvci5TY3JpcHRzUGFuZWwucHJvdG90 eXBlLnZhcmlhYmxlc0luU2NvcGVGb3JTZWxlY3RlZENhbGxGcmFtZSk6CiAgICAgICAgUmV0dXJu IGFuIG9iamVjdCB0aGF0IGhhcyBhbGwgdGhlIHZhcmlhYmxlcyB0aGF0IGFyZSBpbiBzY29wZSBm b3IgdGhlCiAgICAgICAgc2VsZWN0ZWQgY2FsbCBmcmFtZS4gVGhlIHZhbHVlIG9mIGVhY2ggcHJv cGVydHkgaXMganVzdCB0cnVlLgogICAgICAgIFRoZSByZXR1cm4gb2JqZWN0IGlzIHVzZWZ1bCBm b3IgcXVpY2sgbG9va3VwcyBvciBhdXRvIGNvbXBsZXRpb24uCi0tLQogV2ViQ29yZS9DaGFuZ2VM b2cgICAgICAgICAgICAgICAgICAgICAgfCAgIDE5ICsrKysrKysrKysrKysrKysrKysKIFdlYkNv cmUvcGFnZS9pbnNwZWN0b3IvQ29uc29sZS5qcyAgICAgIHwgICAgOSArKysrKysrKy0KIFdlYkNv cmUvcGFnZS9pbnNwZWN0b3IvU2NyaXB0c1BhbmVsLmpzIHwgICAxNyArKysrKysrKysrKysrKysr KwogMyBmaWxlcyBjaGFuZ2VkLCA0NCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODI0 YjdlNy4uMDY5NDVhZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOC0wOC0xNSAgVGltb3RoeSBIYXRjaGVy ICA8dGltb3RoeUBhcHBsZS5jb20+CisKKyAgICAgICAgQ29tcGxldGUgaW4gc2NvcGUgdmFyaWFi bGVzIGluIHRoZSBDb25zb2xlIHdoZW4gcGF1c2VkLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTExNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9pbnNwZWN0b3IvQ29uc29sZS5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlLnByb3RvdHlwZS5jb21wbGV0aW9ucyk6IElmIHRo ZSBleHByZXNzaW9uU3RyaW5nCisgICAgICAgIGlzIG51bGwgb3IgZW1wdHkgYW5kIHRoZSBkZWJ1 Z2dlciBpcyBwYXVzZWQsIGNhbGwgdmFyaWFibGVzSW5TY29wZUZvclNlbGVjdGVkQ2FsbEZyYW1l CisgICAgICAgIHRvIGdldCBhbiBvYmplY3QgdGhhdCBkZWNsYXJlcyBhbGwgdGhlIGluIHNjb3Bl IHZhcmlhYmxlcy4gVGhhdCB3YXkKKyAgICAgICAgInRvcCBsZXZlbCIgZXhwcmVzc2lvbnMgYXJl IGNvbXBsZXRlZC4KKyAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9TY3JpcHRzUGFuZWwuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZS52YXJpYWJsZXNJblNj b3BlRm9yU2VsZWN0ZWRDYWxsRnJhbWUpOgorICAgICAgICBSZXR1cm4gYW4gb2JqZWN0IHRoYXQg aGFzIGFsbCB0aGUgdmFyaWFibGVzIHRoYXQgYXJlIGluIHNjb3BlIGZvciB0aGUKKyAgICAgICAg c2VsZWN0ZWQgY2FsbCBmcmFtZS4gVGhlIHZhbHVlIG9mIGVhY2ggcHJvcGVydHkgaXMganVzdCB0 cnVlLgorICAgICAgICBUaGUgcmV0dXJuIG9iamVjdCBpcyB1c2VmdWwgZm9yIHF1aWNrIGxvb2t1 cHMgb3IgYXV0byBjb21wbGV0aW9uLgorCiAyMDA4LTA4LTE1ICBBZGEgQ2hhbiAgPGFkYWNoYW5A YXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBpdGVtJ3MgY29tcHV0ZWQgc3R5bGUgaWYgdGhlIHJl bmRlciBzdHlsZSBpcyAwIGJlZm9yZSBmYWxsaW5nIGJhY2sgdG8gdGhlIDxzZWxlY3Q+J3Mgc3R5 bGUuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL0NvbnNvbGUuanMgYi9XZWJD b3JlL3BhZ2UvaW5zcGVjdG9yL0NvbnNvbGUuanMKaW5kZXggNjNmNzljNS4uMzlkYWFjYSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9Db25zb2xlLmpzCisrKyBiL1dlYkNvcmUv cGFnZS9pbnNwZWN0b3IvQ29uc29sZS5qcwpAQCAtMjAwLDEzICsyMDAsMjAgQEAgV2ViSW5zcGVj dG9yLkNvbnNvbGUucHJvdG90eXBlID0gewogICAgICAgICBpZiAoIWV4cHJlc3Npb25TdHJpbmcg JiYgIXByZWZpeCkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICB2YXIgcmVzdWx0ID0g SW5zcGVjdG9yQ29udHJvbGxlci5pbnNwZWN0ZWRXaW5kb3coKTsKKyAgICAgICAgdmFyIHJlc3Vs dDsKICAgICAgICAgaWYgKGV4cHJlc3Npb25TdHJpbmcpIHsKICAgICAgICAgICAgIHRyeSB7CiAg ICAgICAgICAgICAgICAgcmVzdWx0ID0gdGhpcy5fZXZhbEluSW5zcGVjdGVkV2luZG93KGV4cHJl c3Npb25TdHJpbmcpOwogICAgICAgICAgICAgfSBjYXRjaChlKSB7CiAgICAgICAgICAgICAgICAg Ly8gRG8gbm90aGluZywgdGhlIHByZWZpeCB3aWxsIGJlIGNvbnNpZGVyZWQgYSB3aW5kb3cgcHJv cGVydHkuCiAgICAgICAgICAgICB9CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAvLyBU aGVyZSBpcyBubyBleHByZXNzaW9uU3RyaW5nLCBzbyB0aGUgY29tcGxldGlvbiBzaG91bGQgaGFw cGVuIGFnYWluc3QgZ2xvYmFsIHByb3BlcnRpZXMuCisgICAgICAgICAgICAvLyBPciBpZiB0aGUg ZGVidWdnZXIgaXMgcGF1c2VkLCBhZ2FpbnN0IHByb3BlcnRpZXMgaW4gc2NvcGUgb2YgdGhlIHNl bGVjdGVkIGNhbGwgZnJhbWUuCisgICAgICAgICAgICBpZiAoV2ViSW5zcGVjdG9yLnBhbmVscy5z Y3JpcHRzLnBhdXNlZCkKKyAgICAgICAgICAgICAgICByZXN1bHQgPSBXZWJJbnNwZWN0b3IucGFu ZWxzLnNjcmlwdHMudmFyaWFibGVzSW5TY29wZUZvclNlbGVjdGVkQ2FsbEZyYW1lKCk7CisgICAg ICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgcmVzdWx0ID0gSW5zcGVjdG9yQ29udHJvbGxl ci5pbnNwZWN0ZWRXaW5kb3coKTsKICAgICAgICAgfQogCiAgICAgICAgIGlmIChicmFja2V0Tm90 YXRpb24pIHsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvU2NyaXB0c1BhbmVs LmpzIGIvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9TY3JpcHRzUGFuZWwuanMKaW5kZXggMzlmOTA2 Yi4uNTIyN2RjYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9TY3JpcHRzUGFu ZWwuanMKKysrIGIvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9TY3JpcHRzUGFuZWwuanMKQEAgLTI5 Myw2ICsyOTMsMjMgQEAgV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5cGUgPSB7CiAg ICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfSwKIAorICAgIHZhcmlhYmxlc0luU2NvcGVGb3JT ZWxlY3RlZENhbGxGcmFtZTogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgdmFyIHNlbGVjdGVk Q2FsbEZyYW1lID0gdGhpcy5zaWRlYmFyUGFuZXMuY2FsbHN0YWNrLnNlbGVjdGVkQ2FsbEZyYW1l OworICAgICAgICBpZiAoIXRoaXMuX3BhdXNlZCB8fCAhc2VsZWN0ZWRDYWxsRnJhbWUpCisgICAg ICAgICAgICByZXR1cm4ge307CisKKyAgICAgICAgdmFyIHJlc3VsdCA9IHt9OworICAgICAgICB2 YXIgc2NvcGVDaGFpbiA9IHNlbGVjdGVkQ2FsbEZyYW1lLnNjb3BlQ2hhaW47CisgICAgICAgIGZv ciAodmFyIGkgPSAwOyBpIDwgc2NvcGVDaGFpbi5sZW5ndGg7ICsraSkgeworICAgICAgICAgICAg dmFyIHNjb3BlT2JqZWN0ID0gc2NvcGVDaGFpbltpXTsKKyAgICAgICAgICAgIGZvciAodmFyIHBy b3BlcnR5IGluIHNjb3BlT2JqZWN0KQorICAgICAgICAgICAgICAgIHJlc3VsdFtwcm9wZXJ0eV0g PSB0cnVlOworICAgICAgICB9CisKKyAgICAgICAgcmV0dXJuIHJlc3VsdDsKKyAgICB9LAorCiAg ICAgZGVidWdnZXJQYXVzZWQ6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIHRoaXMuX3BhdXNl ZCA9IHRydWU7Ci0tIAoxLjYuMC5yYzMKCg==