191142 2018-10-31 20:42:39 -0700 Add Justin Michaud to the list of WebKit Committers 2018-10-31 21:09:40 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 justin_michaud justin_michaud ews-watchlist glenn jonlee justin_fan lforschler mark.lam saam oldest_to_newest 1474006 0 justin_michaud 2018-10-31 20:42:39 -0700 🎉 1474007 1 353578 justin_michaud 2018-10-31 20:46:41 -0700 Created attachment 353578 Patch 1474009 2 justin_michaud 2018-10-31 20:47:47 -0700 The style check bugged me to run `validate-committer-lists --canonicalize` which seems to have caught a few other nits in the file. 1474011 3 ews-watchlist 2018-10-31 20:48:51 -0700 Attachment 353578 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1474013 4 353578 saam 2018-10-31 21:02:38 -0700 Comment on attachment 353578 Patch Heads up: You don’t need a reviewer for this type of change now that you’re a committer 1474015 5 justin_michaud 2018-10-31 21:09:28 -0700 Landed manually (thanks to Wenson): <https://trac.webkit.org/changeset/237668> 353578 2018-10-31 20:46:41 -0700 2018-10-31 21:02:38 -0700 Patch bug-191142-20181031204632.patch text/plain 1747 justin_michaud U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NjY3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTRkYjIzOTM1MTI2ZmNiMWZmNWRlMTRkNGRmNWMxMGE4 NzJlODJjMi4uMmY5YzNjNThjYjg4ZWI5NDE1MTY0ZWQ1MTJjMmNiODJiYzM5MTQ1NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE4LTEwLTMxICBKdXN0aW4gTWljaGF1ZCAgPGp1c3Rpbl9taWNoYXVkQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgSnVzdGluIE1pY2hhdWQgdG8gdGhlIGxpc3Qgb2YgV2ViS2l0IENv bW1pdHRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5MTE0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbnRyaWJ1dG9ycy5qc29uOgorCiAy MDE4LTEwLTMxICBHdWlsbGF1bWUgRW1vbnQgIDxndWlqZW1vbnRAaWdhbGlhLmNvbT4KIAogICAg ICAgICBEb24ndCBydW4gSklUIHRlc3RzIG9uIDMyLWJpdCBwbGF0Zm9ybXMKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbiBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbgpp bmRleCA0ZGI1OGZiNGJkYmI5N2JhMDQwYTM3MzFhMDU1YWNjNGYxNTU5N2FlLi4yY2E0OTAwMDBi ZTg4OGY2ZjU4NTA2YjZlMDY1ZjQ5M2E0YmRmMDc1IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29udHJpYnV0b3JzLmpzb24KKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbnRyaWJ1dG9ycy5qc29uCkBAIC0xNTM1LDkg KzE1MzUsOSBAQAogICAgICAgInN0YXR1cyIgOiAiY29tbWl0dGVyIgogICAgfSwKICAgICJEYXZp ZCBGZW50b24iIDogewotICAgICJhbGlhc2VzIiA6IFsKLSAgICAgICAgIkRhd2VpIEZlbnRvbiIK LSAgICAgXSwKKyAgICAgICJhbGlhc2VzIiA6IFsKKyAgICAgICAgICJEYXdlaSBGZW50b24iCisg ICAgICBdLAogICAgICAgImVtYWlscyIgOiBbCiAgICAgICAgICAiZGF2aWRfZmVudG9uQGFwcGxl LmNvbSIsCiAgICAgICAgICAicmVhbGRhd2VpQGFwcGxlLmNvbSIKQEAgLTMzMTMsNyArMzMxMyw4 IEBACiAgICAiSnVzdGluIE1pY2hhdWQiIDogewogICAgICAgImVtYWlscyIgOiBbCiAgICAgICAg ICAianVzdGluX21pY2hhdWRAYXBwbGUuY29tIgotICAgICAgXQorICAgICAgXSwKKyAgICAgICJz dGF0dXMiIDogImNvbW1pdHRlciIKICAgIH0sCiAgICAiSnVzdGluIE5vdm9zYWQiIDogewogICAg ICAgImVtYWlscyIgOiBbCkBAIC00NTUzLDcgKzQ1NTQsNyBAQAogICAgICAgXSwKICAgICAgICJz dGF0dXMiIDogImNvbW1pdHRlciIKICAgIH0sCi0gICAiUGFibG8gU2FhdmVkcmEgUm9kaVx1MDBG MW8iIDogeworICAgIlBhYmxvIFNhYXZlZHJhIFJvZGlcdTAwZjFvIiA6IHsKICAgICAgICJlbWFp bHMiIDogWwogICAgICAgICAgInBzYWF2ZWRyYUBpZ2FsaWEuY29tIgogICAgICAgXQpAQCAtNjE2 MSw0ICs2MTYyLDQgQEAKICAgICAgIF0sCiAgICAgICAic3RhdHVzIiA6ICJyZXZpZXdlciIKICAg IH0KLX0KK30KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==