191134 2018-10-31 14:54:29 -0700 [iOS] Do not paint tap highlight unless it is above a certain threshold 2018-10-31 23:38:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue simon.fraser thorton webkit-bug-importer zalan oldest_to_newest 1473887 0 zalan 2018-10-31 14:54:29 -0700 <rdar://problem/43615142> 1473890 1 353535 zalan 2018-10-31 15:02:27 -0700 Created attachment 353535 Patch 1473906 2 353535 commit-queue 2018-10-31 15:44:34 -0700 Comment on attachment 353535 Patch Clearing flags on attachment: 353535 Committed r237658: <https://trac.webkit.org/changeset/237658> 1473907 3 commit-queue 2018-10-31 15:44:36 -0700 All reviewed patches have been landed. Closing bug. 1473908 4 webkit-bug-importer 2018-10-31 15:45:26 -0700 <rdar://problem/45714814> 1474031 5 simon.fraser 2018-10-31 23:38:23 -0700 We have code that specializes iOS touch handling because we didn't want to show a tap highlight on the body. We should remove that now. See rdar://problem/5844416. 353535 2018-10-31 15:02:27 -0700 2018-10-31 15:44:34 -0700 Patch bug-191134-20181031150226.patch text/plain 3100 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDliNDAzZjIyYTNhMWM4MmQ5 MDUyZjRjMGFhZjg1OGM2NzE5ZTEzZWYuLjU1YzczZTMyYzM5ZjE3NmYyZDFkMWJlZmVjN2ZmZTdm Zjk5YWViNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMTAtMzEgIFphbGFuIEJ1 anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBEbyBub3QgcGFpbnQgdGFw IGhpZ2hsaWdodCB1bmxlc3MgaXQgaXMgYWJvdmUgYSBjZXJ0YWluIHRocmVzaG9sZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxMTM0CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS80MzYxNTE0Mj4KKworICAgICAgICBGbGFzaGluZyBhIGxhcmdlIHBv cnRpb24gb2YgdGhlIHNjcmVlbiBvbiBldmVyeSB0YXAgbG9va3MgdW5wbGVhc2FudC4KKyAgICAg ICAgVGhpcyBwYXRjaCBpbXBvdmVzIHRoZSBleGlzdGluZyBoZXVyaXN0aWMgYnkgYWRkaW5nIGFy ZWEgY2hlY2sgYW5kIGEgJSB0aHJlc2hvbGQuICAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVy YWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9zaG93VGFwSGlnaGxpZ2h0XSk6 CisgICAgICAgIChoaWdobGlnaHRlZFF1YWRzQXJlU21hbGxlclRoYW5SZWN0KTogRGVsZXRlZC4K KwogMjAxOC0xMC0zMSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAg ICAgU3RvcCB1c2luZyBMYXllckZsdXNoU2NoZWR1bGVyIGluIFdLMgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5k ZXggNGI4Njg2ZGNjMmQ5YWY4MzVjZTQ4YTkwNTVkZmU0YzQwZmI4Yzg2OS4uZTZlODYzMmRmYTU5 YzU0NGU4ODBmNzMzZWQzODM1N2RjZjdjNTNhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0xMTUxLDE2 ICsxMTUxLDYgQEAgLSAodm9pZClfd2ViVG91Y2hFdmVudDooY29uc3QgV2ViS2l0OjpOYXRpdmVX ZWJUb3VjaEV2ZW50Jil0b3VjaEV2ZW50IHByZXZlbnRzTmEKIH0KICNlbmRpZgogCi1zdGF0aWMg aW5saW5lIGJvb2wgaGlnaGxpZ2h0ZWRRdWFkc0FyZVNtYWxsZXJUaGFuUmVjdChjb25zdCBWZWN0 b3I8RmxvYXRRdWFkPiYgcXVhZHMsIGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkKLXsKLSAgICBmb3Ig KHNpemVfdCBpID0gMDsgaSA8IHF1YWRzLnNpemUoKTsgKytpKSB7Ci0gICAgICAgIEZsb2F0UmVj dCBib3VuZGluZ0JveCA9IHF1YWRzW2ldLmJvdW5kaW5nQm94KCk7Ci0gICAgICAgIGlmIChib3Vu ZGluZ0JveC53aWR0aCgpID4gcmVjdC53aWR0aCgpIHx8IGJvdW5kaW5nQm94LmhlaWdodCgpID4g cmVjdC5oZWlnaHQoKSkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9Ci0gICAgcmV0 dXJuIHRydWU7Ci19Ci0KIHN0YXRpYyBOU1ZhbHVlICpuc1NpemVGb3JUYXBIaWdobGlnaHRCb3Jk ZXJSYWRpdXMoV2ViQ29yZTo6SW50U2l6ZSBib3JkZXJSYWRpdXMsIENHRmxvYXQgYm9yZGVyUmFk aXVzU2NhbGUpCiB7CiAgICAgcmV0dXJuIFtOU1ZhbHVlIHZhbHVlV2l0aENHU2l6ZTpDR1NpemVN YWtlKChib3JkZXJSYWRpdXMud2lkdGgoKSAqIGJvcmRlclJhZGl1c1NjYWxlKSArIG1pbmltdW1U YXBIaWdobGlnaHRSYWRpdXMsIChib3JkZXJSYWRpdXMuaGVpZ2h0KCkgKiBib3JkZXJSYWRpdXNT Y2FsZSkgKyBtaW5pbXVtVGFwSGlnaGxpZ2h0UmFkaXVzKV07CkBAIC0xMjIzLDcgKzEyMTMsMTkg QEAgLSAodm9pZClfdXBkYXRlVGFwSGlnaGxpZ2h0CiAKIC0gKHZvaWQpX3Nob3dUYXBIaWdobGln aHQKIHsKLSAgICBpZiAoIWhpZ2hsaWdodGVkUXVhZHNBcmVTbWFsbGVyVGhhblJlY3QoX3RhcEhp Z2hsaWdodEluZm9ybWF0aW9uLnF1YWRzLCBfcGFnZS0+dW5vYnNjdXJlZENvbnRlbnRSZWN0KCkp ICYmICFfc2hvd0RlYnVnVGFwSGlnaGxpZ2h0c0ZvckZhc3RDbGlja2luZykKKyAgICBhdXRvIHNo b3VsZFBhaW50VGFwSGlnaGxpZ2h0ID0gWyZdKGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkgeworICAg ICAgICBzdGF0aWMgY29uc3QgZmxvYXQgaGlnaGxpZ2h0UGFpbnRUaHJlc2hvbGQgPSAwLjM7IC8v IDMwJQorICAgICAgICBmbG9hdCBoaWdobGlnaHRBcmVhID0gMDsKKyAgICAgICAgZm9yIChhdXRv IGhpZ2hsaWdodFF1YWQgOiBfdGFwSGlnaGxpZ2h0SW5mb3JtYXRpb24ucXVhZHMpIHsKKyAgICAg ICAgICAgIGF1dG8gYm91bmRpbmdCb3ggPSBoaWdobGlnaHRRdWFkLmJvdW5kaW5nQm94KCk7Cisg ICAgICAgICAgICBoaWdobGlnaHRBcmVhICs9IGJvdW5kaW5nQm94LmFyZWEoKTsgCisgICAgICAg ICAgICBpZiAoYm91bmRpbmdCb3gud2lkdGgoKSA+IChyZWN0LndpZHRoKCkgKiBoaWdobGlnaHRQ YWludFRocmVzaG9sZCkgfHwgYm91bmRpbmdCb3guaGVpZ2h0KCkgPiAocmVjdC5oZWlnaHQoKSAq IGhpZ2hsaWdodFBhaW50VGhyZXNob2xkKSkKKyAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgICAgIH0KKyAgICAgICAgcmV0dXJuIGhpZ2hsaWdodEFyZWEgPCByZWN0LmFyZWEoKSAq IGhpZ2hsaWdodFBhaW50VGhyZXNob2xkOworICAgIH07CisKKyAgICBpZiAoIXNob3VsZFBhaW50 VGFwSGlnaGxpZ2h0KF9wYWdlLT51bm9ic2N1cmVkQ29udGVudFJlY3QoKSkgJiYgIV9zaG93RGVi dWdUYXBIaWdobGlnaHRzRm9yRmFzdENsaWNraW5nKQogICAgICAgICByZXR1cm47CiAKICAgICBp ZiAoIV9oaWdobGlnaHRWaWV3KSB7Cg==