191124 2018-10-31 11:30:07 -0700 Cleanup: Extraneous platform guarding of -_setUpSQLiteDatabaseTrackerClient 2018-11-01 16:23:22 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aestes thorton webkit-bug-importer oldest_to_newest 1473793 0 dbates 2018-10-31 11:30:07 -0700 Currently we have a PLATFORM(IOS_FAMILY) guard around the call to -_setUpSQLiteDatabaseTrackerClient and we have PLATFORM(IOS_FAMILY) guards in the implementation of that message. It seems unnecessary to have both. 1473798 1 353512 dbates 2018-10-31 11:35:31 -0700 Created attachment 353512 Patch Let me know if it is preferred to keep the guards around the function call and move the guards in the implementation to be surrounding the implementation. With the guards removed from the call site, I would hope that the compiler is smart enough to realize that the called function is empty and just elide the function call. Maybe this is not true (I haven't looked at the binary) or maybe we have compiler warnings enabled to catch empty functions (I also haven't looked)? 1474315 2 353512 dbates 2018-11-01 16:22:28 -0700 Comment on attachment 353512 Patch Clearing flags on attachment: 353512 Committed r237704: <https://trac.webkit.org/changeset/237704> 1474316 3 dbates 2018-11-01 16:22:29 -0700 All reviewed patches have been landed. Closing bug. 1474317 4 webkit-bug-importer 2018-11-01 16:23:22 -0700 <rdar://problem/45746625> 353512 2018-10-31 11:35:31 -0700 2018-11-01 16:22:28 -0700 Patch bug-191124-20181031113530.patch text/plain 1702 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDExMTBiMTgxMjZlMzY1MTY1 MjhjNGFiYTI0MjhiOTM0ZWFkNTdkYmUuLmQyYzNhOTZjZDMyZmZhOWJkZTEwMTI3NmJjYjEyYmU4 N2YxZGYyZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMTAtMzEgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIENsZWFudXA6IEV4dHJhbmVvdXMg cGxhdGZvcm0gZ3VhcmRpbmcgb2YgLV9zZXRVcFNRTGl0ZURhdGFiYXNlVHJhY2tlckNsaWVudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxMTI0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRo ZSBwbGF0Zm9ybSBndWFyZCBhcm91bmQgdGhlIGNhbGwgdG8gLV9zZXRVcFNRTGl0ZURhdGFiYXNl VHJhY2tlckNsaWVudCBhcyB0aGUKKyAgICAgICAgaW1wbGVtZW50YXRpb24gb2YgdGhhdCBtZXNz YWdlIGlzIGFscmVhZHkgZ3VhcmRlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcgX2luaXRpYWxpemVXaXRoQ29uZmln dXJhdGlvbjpdKToKKwogMjAxOC0xMC0zMSAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBs ZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIzMDUyMyk6IENhcHMgbG9jayBpbmRpY2F0 b3Igbm90IHNob3duIGluIHBhc3N3b3JkIGZpZWxkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQppbmRleCAyNjUyMWJkNjUzYjM3MWYyNzRiZTNhOGE0 NjljNWM3YzNkM2MwMmY0Li45YzY4ZThmNmZhODUxZjljODUyMzBiMWM3YTI0ZGNkNDk3MTcwYjdl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3 Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0K QEAgLTczMSw5ICs3MzEsNyBAQCAtICh2b2lkKV9pbml0aWFsaXplV2l0aENvbmZpZ3VyYXRpb246 KFdLV2ViVmlld0NvbmZpZ3VyYXRpb24gKiljb25maWd1cmF0aW9uCiAKICAgICBfaWNvbkxvYWRp bmdEZWxlZ2F0ZSA9IHN0ZDo6bWFrZV91bmlxdWU8V2ViS2l0OjpJY29uTG9hZGluZ0RlbGVnYXRl PihzZWxmKTsKIAotI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCiAgICAgW3NlbGYgX3NldFVwU1FM aXRlRGF0YWJhc2VUcmFja2VyQ2xpZW50XTsKLSNlbmRpZgogCiAgICAgZm9yIChhdXRvJiBwYWly IDogcGFnZUNvbmZpZ3VyYXRpb24tPnVybFNjaGVtZUhhbmRsZXJzKCkpCiAgICAgICAgIF9wYWdl LT5zZXRVUkxTY2hlbWVIYW5kbGVyRm9yU2NoZW1lKFdlYktpdDo6V2ViVVJMU2NoZW1lSGFuZGxl ckNvY29hOjpjcmVhdGUoc3RhdGljX2Nhc3Q8V2ViS2l0OjpXZWJVUkxTY2hlbWVIYW5kbGVyQ29j b2EmPihwYWlyLnZhbHVlLmdldCgpKS5hcGlIYW5kbGVyKCkpLCBwYWlyLmtleSk7Cg==