191115 2018-10-31 08:27:58 -0700 Adjust inlining threshold for new bytecode format 2018-10-31 11:45:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1473715 0 tzagallo 2018-10-31 08:27:58 -0700 The new format changed the number of operands for many opcodes, which changed inlining decisions and impacted performance negatively. 1473717 1 353494 tzagallo 2018-10-31 08:29:53 -0700 Created attachment 353494 Patch 1473783 2 353494 saam 2018-10-31 11:00:02 -0700 Comment on attachment 353494 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353494&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + The new format changed the number of operands for many opcodes, which I think it's worth noting that you often made it so we had fewer operands, not more. > Source/JavaScriptCore/runtime/Options.h:306 > + v(unsigned, maximumFunctionForCallInlineCandidateInstructionCount, 120, Normal, nullptr) \ I wonder if this obviates that test you just added. 1473785 3 353507 tzagallo 2018-10-31 11:07:10 -0700 Created attachment 353507 Patch for landing 1473801 4 353507 commit-queue 2018-10-31 11:44:20 -0700 Comment on attachment 353507 Patch for landing Clearing flags on attachment: 353507 Committed r237645: <https://trac.webkit.org/changeset/237645> 1473802 5 commit-queue 2018-10-31 11:44:22 -0700 All reviewed patches have been landed. Closing bug. 1473803 6 webkit-bug-importer 2018-10-31 11:45:28 -0700 <rdar://problem/45707063> 353494 2018-10-31 08:29:53 -0700 2018-10-31 11:07:06 -0700 Patch bug-191115-20181031162944.patch text/plain 1697 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MmE4YWJhODM3ZWQwNGM5MDY1NmJmYmRmMGU0ZDZlZTg3ZDY2ZDg1Li5mOTNiZTMzNTc2ZWRjYTg1 MjZlMWQxMmQxMzkxMTU2NGRkYTNmZTk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0xMC0zMSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBBZGp1c3QgaW5saW5pbmcgdGhyZXNob2xkIGZvciBuZXcgYnl0ZWNvZGUg Zm9ybWF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTExMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgbmV3IGZvcm1hdCBjaGFuZ2VkIHRoZSBudW1iZXIgb2Ygb3BlcmFuZHMgZm9yIG1hbnkgb3Bj b2Rlcywgd2hpY2gKKyAgICAgICAgY2hhbmdlZCBpbmxpbmluZyBkZWNpc2lvbnMgYW5kIGltcGFj dGVkIHBlcmZvcm1hbmNlIG5lZ2F0aXZlbHkuCisKKyAgICAgICAgKiBydW50aW1lL09wdGlvbnMu aDoKKwogMjAxOC0xMC0zMSAgSmltIE1hc29uICA8am1hc29uQGliaW54LmNvbT4KIAogICAgICAg ICBTdGF0aWMgZ2xvYmFsICdmYXN0SGFuZGxlckluc3RhbGxlZCcgY29uZGl0aW9uYWxseSBkZWNs YXJlZCBpbiBXYXNtRmF1bHRTaWduYWxIYW5kbGVyLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvT3B0aW9ucy5oCmluZGV4IDA0NmJjOTJhOTIyNzUzMWM4YzA2ZWJlNjg5ZGY3ZmFmZjc0 MDA5MTIuLjMyMjNhOTJmNzlkYmZjYzY2OWY4NjRiMjhhNzBmNDhhMWZjZjQzZjcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmgKQEAgLTMwMyw3ICszMDMsNyBAQCBjb25z dGV4cHIgYm9vbCBlbmFibGVXZWJBc3NlbWJseVN0cmVhbWluZ0FwaSA9IGZhbHNlOwogICAgIFwK ICAgICB2KHVuc2lnbmVkLCBtYXhpbXVtT3B0aW1pemF0aW9uQ2FuZGlkYXRlSW5zdHJ1Y3Rpb25D b3VudCwgMTAwMDAwLCBOb3JtYWwsIG51bGxwdHIpIFwKICAgICBcCi0gICAgdih1bnNpZ25lZCwg bWF4aW11bUZ1bmN0aW9uRm9yQ2FsbElubGluZUNhbmRpZGF0ZUluc3RydWN0aW9uQ291bnQsIDE5 MCwgTm9ybWFsLCBudWxscHRyKSBcCisgICAgdih1bnNpZ25lZCwgbWF4aW11bUZ1bmN0aW9uRm9y Q2FsbElubGluZUNhbmRpZGF0ZUluc3RydWN0aW9uQ291bnQsIDEyMCwgTm9ybWFsLCBudWxscHRy KSBcCiAgICAgdih1bnNpZ25lZCwgbWF4aW11bUZ1bmN0aW9uRm9yQ2xvc3VyZUNhbGxJbmxpbmVD YW5kaWRhdGVJbnN0cnVjdGlvbkNvdW50LCAxMDAsIE5vcm1hbCwgbnVsbHB0cikgXAogICAgIHYo dW5zaWduZWQsIG1heGltdW1GdW5jdGlvbkZvckNvbnN0cnVjdElubGluZUNhbmRpZGF0ZUluc3Ry dWN0aW9uQ291bnQsIDEwMCwgTm9ybWFsLCBudWxscHRyKSBcCiAgICAgXAo= 353507 2018-10-31 11:07:10 -0700 2018-10-31 11:44:20 -0700 Patch for landing bug-191115-20181031190700.patch text/plain 1694 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MmE4YWJhODM3ZWQwNGM5MDY1NmJmYmRmMGU0ZDZlZTg3ZDY2ZDg1Li42YmZhMGQ0OTZjZmFiZDI1 ZWZhNGI5Y2ViMTRmNzEwYmJhZWRhNjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0xMC0zMSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBBZGp1c3QgaW5saW5pbmcgdGhyZXNob2xkIGZvciBuZXcgYnl0ZWNvZGUg Zm9ybWF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTExMTUKKworICAgICAgICBSZXZpZXdlZCBieSBTYWFtIEJhcmF0aS4KKworICAgICAgICBUaGUg bmV3IGZvcm1hdCByZWR1Y2VkIHRoZSBudW1iZXIgb2Ygb3BlcmFuZHMgZm9yIG1hbnkgb3Bjb2Rl cywgd2hpY2gKKyAgICAgICAgY2hhbmdlZCBpbmxpbmluZyBkZWNpc2lvbnMgYW5kIGltcGFjdGVk IHBlcmZvcm1hbmNlIG5lZ2F0aXZlbHkuCisKKyAgICAgICAgKiBydW50aW1lL09wdGlvbnMuaDoK KwogMjAxOC0xMC0zMSAgSmltIE1hc29uICA8am1hc29uQGliaW54LmNvbT4KIAogICAgICAgICBT dGF0aWMgZ2xvYmFsICdmYXN0SGFuZGxlckluc3RhbGxlZCcgY29uZGl0aW9uYWxseSBkZWNsYXJl ZCBpbiBXYXNtRmF1bHRTaWduYWxIYW5kbGVyLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvT3B0aW9ucy5oCmluZGV4IDA0NmJjOTJhOTIyNzUzMWM4YzA2ZWJlNjg5ZGY3ZmFmZjc0MDA5 MTIuLjMyMjNhOTJmNzlkYmZjYzY2OWY4NjRiMjhhNzBmNDhhMWZjZjQzZjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmgKQEAgLTMwMyw3ICszMDMsNyBAQCBjb25zdGV4 cHIgYm9vbCBlbmFibGVXZWJBc3NlbWJseVN0cmVhbWluZ0FwaSA9IGZhbHNlOwogICAgIFwKICAg ICB2KHVuc2lnbmVkLCBtYXhpbXVtT3B0aW1pemF0aW9uQ2FuZGlkYXRlSW5zdHJ1Y3Rpb25Db3Vu dCwgMTAwMDAwLCBOb3JtYWwsIG51bGxwdHIpIFwKICAgICBcCi0gICAgdih1bnNpZ25lZCwgbWF4 aW11bUZ1bmN0aW9uRm9yQ2FsbElubGluZUNhbmRpZGF0ZUluc3RydWN0aW9uQ291bnQsIDE5MCwg Tm9ybWFsLCBudWxscHRyKSBcCisgICAgdih1bnNpZ25lZCwgbWF4aW11bUZ1bmN0aW9uRm9yQ2Fs bElubGluZUNhbmRpZGF0ZUluc3RydWN0aW9uQ291bnQsIDEyMCwgTm9ybWFsLCBudWxscHRyKSBc CiAgICAgdih1bnNpZ25lZCwgbWF4aW11bUZ1bmN0aW9uRm9yQ2xvc3VyZUNhbGxJbmxpbmVDYW5k aWRhdGVJbnN0cnVjdGlvbkNvdW50LCAxMDAsIE5vcm1hbCwgbnVsbHB0cikgXAogICAgIHYodW5z aWduZWQsIG1heGltdW1GdW5jdGlvbkZvckNvbnN0cnVjdElubGluZUNhbmRpZGF0ZUluc3RydWN0 aW9uQ291bnQsIDEwMCwgTm9ybWFsLCBudWxscHRyKSBcCiAgICAgXAo=