191110 2018-10-31 04:15:23 -0700 [GTK][WPE] Remaining topPrivatelyControlledDomain() fixes 2018-10-31 08:19:34 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 csaavedra csaavedra bugs-noreply commit-queue mcatanzaro oldest_to_newest 1473672 0 csaavedra 2018-10-31 04:15:23 -0700 [GTK][WPE] Remaining topPrivatelyControlledDomain() fixes 1473673 1 353485 csaavedra 2018-10-31 04:15:46 -0700 Created attachment 353485 Patch 1473704 2 353485 mcatanzaro 2018-10-31 07:52:01 -0700 Comment on attachment 353485 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353485&action=review Specifically, what tests is it fixing? > Source/WebCore/platform/soup/PublicSuffixSoup.cpp:49 > + if (!domain.isAllASCII()) > + return domain; Syncing with the Mac implementation seems most important, but now can't the function return a domain that is not the top privately-controlled domain? 1473705 3 csaavedra 2018-10-31 07:58:03 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 353485 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353485&action=review > > Specifically, what tests is it fixing? > > > Source/WebCore/platform/soup/PublicSuffixSoup.cpp:49 > > + if (!domain.isAllASCII()) > > + return domain; > > Syncing with the Mac implementation seems most important, but now can't the > function return a domain that is not the top privately-controlled domain? I went back to the origin of that code, and it's here: https://bugs.webkit.org/show_bug.cgi?id=170798 There isn't much of an explanation but I'm guessing that this is not expected to be called with non-ASCII. And all tests pass with this. 1473713 4 353485 commit-queue 2018-10-31 08:19:33 -0700 Comment on attachment 353485 Patch Clearing flags on attachment: 353485 Committed r237637: <https://trac.webkit.org/changeset/237637> 1473714 5 commit-queue 2018-10-31 08:19:34 -0700 All reviewed patches have been landed. Closing bug. 353485 2018-10-31 04:15:46 -0700 2018-10-31 08:19:33 -0700 Patch bug-191110-20181031131545.patch text/plain 2608 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWNhNGRmMjYyOGUwYjUw MmJhYWNiYmVjODQ5OTk0YjEyY2ZhZDBlMi4uNzM0ODA5ZWRhZTcyNzNlMzA1ODZjMWZhMTdmMWZj OTU1MGYxMTQwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTEwLTMxICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BF XSBSZW1haW5pbmcgdG9wUHJpdmF0ZWx5Q29udHJvbGxlZERvbWFpbigpIGZpeGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTExMTAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0 aW5nIHRlc3RzLgorCisgICAgICAgIFR1cm5zIG91dCB0aGF0IHRoaXMgbWV0aG9kIGlzIGV4cGVj dGVkIHRvIHJlamVjdCBkb21haW5zIHRoYXQKKyAgICAgICAgYXJlIG5vdCByZWdpc3RyYWJsZS4g QWxzbyBzeW5jIHdpdGggdGhlIE1hYyBpbXBsZW1lbnRhdGlvbiBpbgorICAgICAgICB0aGF0IGdp dmVuIGRvbWFpbnMgdGhhdCBhcmUgbm90IGFsbCBBU0NJSSBzaG91bGQgYmUgcmV0dXJuZWQKKyAg ICAgICAgYmFjayBhcyBpcy4gVGhpcyBmaXhlcyB0aGUgcmVtYWluaW5nIFB1YmxpYyBTdWZmaXgg QVBJIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vc291cC9QdWJsaWNTdWZmaXhTb3VwLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OnRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW4pOgorCiAy MDE4LTEwLTMwICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAg ICAgIFtDb2NvYV0gQXR0YWNobWVudCBkcm9wcGVkIGZyb20gb25lIHdlYiB2aWV3IHRvIGFub3Ro ZXIgaXMgbWlzc2luZyBpdHMgZmlsZSB3cmFwcGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9zb3VwL1B1YmxpY1N1ZmZpeFNvdXAuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vc291cC9QdWJsaWNTdWZmaXhTb3VwLmNwcAppbmRleCA2YTc0ZDJlY2EzYmI0ZjEzZjFi Y2VmMjUwNmZiNmI5MWY3MjVmNDE5Li5mOTIwOTcxNzg5NjJjZDk2ZGNlNGFjODE4OWU4ZjFjZGMy YmY5ZWJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zb3VwL1B1YmxpY1N1 ZmZpeFNvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NvdXAvUHVibGljU3Vm Zml4U291cC5jcHAKQEAgLTQ1LDYgKzQ1LDggQEAgU3RyaW5nIHRvcFByaXZhdGVseUNvbnRyb2xs ZWREb21haW4oY29uc3QgU3RyaW5nJiBkb21haW4pCiB7CiAgICAgaWYgKGRvbWFpbi5pc0VtcHR5 KCkpCiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsKKyAgICBpZiAoIWRvbWFpbi5pc0FsbEFTQ0lJ KCkpCisgICAgICAgIHJldHVybiBkb21haW47CiAKICAgICBTdHJpbmcgbG93ZXJjYXNlRG9tYWlu ID0gZG9tYWluLmNvbnZlcnRUb0FTQ0lJTG93ZXJjYXNlKCk7CiAKQEAgLTU3LDEwICs1OSwxMCBA QCBTdHJpbmcgdG9wUHJpdmF0ZWx5Q29udHJvbGxlZERvbWFpbihjb25zdCBTdHJpbmcmIGRvbWFp bikKICAgICBpZiAoY29uc3QgY2hhciogYmFzZURvbWFpbiA9IHNvdXBfdGxkX2dldF9iYXNlX2Rv bWFpbihkb21haW5VVEY4LmRhdGEoKSwgJmVycm9yLm91dFB0cigpKSkKICAgICAgICAgcmV0dXJu IFN0cmluZzo6ZnJvbVVURjgoYmFzZURvbWFpbik7CiAKLSAgICBpZiAoZ19lcnJvcl9tYXRjaGVz KGVycm9yLmdldCgpLCBTT1VQX1RMRF9FUlJPUiwgU09VUF9UTERfRVJST1JfSU5WQUxJRF9IT1NU TkFNRSkgfHwgZ19lcnJvcl9tYXRjaGVzKGVycm9yLmdldCgpLCBTT1VQX1RMRF9FUlJPUiwgU09V UF9UTERfRVJST1JfTk9UX0VOT1VHSF9ET01BSU5TKSkKKyAgICBpZiAoZ19lcnJvcl9tYXRjaGVz KGVycm9yLmdldCgpLCBTT1VQX1RMRF9FUlJPUiwgU09VUF9UTERfRVJST1JfSU5WQUxJRF9IT1NU TkFNRSkgfHwgZ19lcnJvcl9tYXRjaGVzKGVycm9yLmdldCgpLCBTT1VQX1RMRF9FUlJPUiwgU09V UF9UTERfRVJST1JfTk9UX0VOT1VHSF9ET01BSU5TKSB8fCBnX2Vycm9yX21hdGNoZXMoZXJyb3Iu Z2V0KCksIFNPVVBfVExEX0VSUk9SLCBTT1VQX1RMRF9FUlJPUl9OT19CQVNFX0RPTUFJTikpCiAg ICAgICAgIHJldHVybiBTdHJpbmcoKTsKIAotICAgIGlmIChnX2Vycm9yX21hdGNoZXMoZXJyb3Iu Z2V0KCksIFNPVVBfVExEX0VSUk9SLCBTT1VQX1RMRF9FUlJPUl9JU19JUF9BRERSRVNTKSB8fCBn X2Vycm9yX21hdGNoZXMoZXJyb3IuZ2V0KCksIFNPVVBfVExEX0VSUk9SLCBTT1VQX1RMRF9FUlJP Ul9OT19CQVNFX0RPTUFJTikpCisgICAgaWYgKGdfZXJyb3JfbWF0Y2hlcyhlcnJvci5nZXQoKSwg U09VUF9UTERfRVJST1IsIFNPVVBfVExEX0VSUk9SX0lTX0lQX0FERFJFU1MpKQogICAgICAgICBy ZXR1cm4gZG9tYWluOwogCiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Cg==