191107 2018-10-31 03:24:40 -0700 Some minor X-Content-Type-Options parsing issues 2018-11-06 01:45:23 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 annevk rbuis cdumez commit-queue darin fred.wang rbuis webkit-bug-importer oldest_to_newest 1473662 0 annevk 2018-10-31 03:24:40 -0700 See https://github.com/web-platform-tests/wpt/pull/13559 for tests and https://github.com/whatwg/fetch/pull/818 for the new parser definition. In particular treating 0x0B and 0x0C as whitespace (bug 191102), but also not always dealing will with picking the first value when multiple are supplied. 1474791 1 353774 rbuis 2018-11-03 09:13:26 -0700 Created attachment 353774 Patch 1475037 2 353774 fred.wang 2018-11-05 05:05:41 -0800 Comment on attachment 353774 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353774&action=review > Source/WebCore/ChangeLog:10 > + Can we please also mention https://fetch.spec.whatwg.org/#x-content-type-options-header for easier review? > Source/WebCore/platform/network/HTTPParsers.cpp:487 > + options.truncate(commaPos); I wonder if there is a way to do that without passing by a non-const copy. Can we use String::split to get a StringView or something similar? 1475038 3 fred.wang 2018-11-05 05:06:10 -0800 cc'ing Darin for suggestions on String handling. 1475106 4 353774 cdumez 2018-11-05 09:15:25 -0800 Comment on attachment 353774 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353774&action=review > Source/WebCore/platform/network/HTTPParsers.cpp:482 > ContentTypeOptionsDisposition parseContentTypeOptionsHeader(const String& header) This should probably be: ContentTypeOptionsDisposition parseContentTypeOptionsHeader(StringView header) > Source/WebCore/platform/network/HTTPParsers.cpp:484 > + String options = header; Not needed >> Source/WebCore/platform/network/HTTPParsers.cpp:487 >> + options.truncate(commaPos); > > I wonder if there is a way to do that without passing by a non-const copy. Can we use String::split to get a StringView or something similar? use StringView::substring() 1475109 5 353774 darin 2018-11-05 09:23:32 -0800 Comment on attachment 353774 Patch Big picture: Best idiom for efficiency in a case like is to make the function take a StringView instead of "const String&". Then in the implementation don’t allocate any memory. And if StringView doesn’t have the functions we need, then add them. StringView does have everything needed here I think, although the names aren’t exactly the same as String: - StringView::find(UChar) - StringView::left - StringView::stripLeadingAndTrailingMatchedCharacters - equalLettersIgnoringASCIICase(StringView, <literal>) You can even leave out the "notFound" check because StringView::left does the right thing (nothing, returns the passed in string) when we pass notFound to it. That’s intentional to make cases like this work. So while it would not be elegant you could write this all on one line: equalLettersIgnoringASCIICase(header.left(header.find(',')).stripLeadingAndTrailingMatchedCharacters(predicate), "nosniff") But local variables might be needed to make it less chaotic/confusing. 1475111 6 darin 2018-11-05 09:24:33 -0800 I’m saying the same thing Chris is, just with more detailed suggestions. 1475228 7 353898 rbuis 2018-11-05 12:07:04 -0800 Created attachment 353898 Patch 1475241 8 353898 darin 2018-11-05 12:55:34 -0800 Comment on attachment 353898 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353898&action=review > Source/WebCore/platform/network/HTTPParsers.cpp:477 > +inline bool isHTTPTabOrSpace(UChar character) I’m not sure this helper function needs the word "HTTP" in it since it’s just tab and space. Also seems like this function could be in the ASCIICType.h header if it’s likely to come up often. The "whitespace" functions elsewhere sometimes say HTML or HTTP because whitespace has different meanings in different contexts so we are trying to clarify which one. But "tab" and "space" aren’t so situational as far as I know. I suspect this could also just use the isHTTPSpace function (not sure I have the name right) because the newline-related can’t possibly exist in the header since it’s already been broken into lines, but not really sure. Anyway, fine as is but would be nice to delete the "HTTP" and even nicer to not have to define a function here because another happens to be available, either in ASCIICType.h or in the header for other uses. 1475433 9 353946 rbuis 2018-11-05 23:58:05 -0800 Created attachment 353946 Patch 1475441 10 rbuis 2018-11-06 00:54:39 -0800 (In reply to Darin Adler from comment #8) > Comment on attachment 353898 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353898&action=review > > > Source/WebCore/platform/network/HTTPParsers.cpp:477 > > +inline bool isHTTPTabOrSpace(UChar character) > > I’m not sure this helper function needs the word "HTTP" in it since it’s > just tab and space. Also seems like this function could be in the > ASCIICType.h header if it’s likely to come up often. > > The "whitespace" functions elsewhere sometimes say HTML or HTTP because > whitespace has different meanings in different contexts so we are trying to > clarify which one. But "tab" and "space" aren’t so situational as far as I > know. > > I suspect this could also just use the isHTTPSpace function (not sure I have > the name right) because the newline-related can’t possibly exist in the > header since it’s already been broken into lines, but not really sure. > > Anyway, fine as is but would be nice to delete the "HTTP" and even nicer to > not have to define a function here because another happens to be available, > either in ASCIICType.h or in the header for other uses. Thanks for all the feedback! I overlooked it, but it turns out stripLeadingAndTrailingHTTPSpaces does exactly what we want and so we do not even need to add something like isHTTPTabOrSpace. 1475443 11 353946 commit-queue 2018-11-06 00:55:57 -0800 Comment on attachment 353946 Patch Rejecting attachment 353946 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 353946, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/imported/w3c/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/9875814 1475444 12 annevk 2018-11-06 01:00:35 -0800 (The reason the specification uses "HTTP tab or space" and not "HTTP whitespace" is mostly to be explicit about LF and CR not being able to be present. Using "HTTP whitespace" here created some confusion. I prefixed it with HTTP mostly because I don't think we group those two code points for any other reason, but maybe I'm wrong there at which point it'll be "tab or space" and moved to the Infra Standard I suppose.) 1475445 13 353948 rbuis 2018-11-06 01:04:01 -0800 Created attachment 353948 Patch 1475451 14 rbuis 2018-11-06 01:18:36 -0800 (In reply to Anne van Kesteren from comment #12) > (The reason the specification uses "HTTP tab or space" and not "HTTP > whitespace" is mostly to be explicit about LF and CR not being able to be > present. Using "HTTP whitespace" here created some confusion. I prefixed it > with HTTP mostly because I don't think we group those two code points for > any other reason, but maybe I'm wrong there at which point it'll be "tab or > space" and moved to the Infra Standard I suppose.) Thanks for the clarification. In WebKit case, as Darin pointed out, LF and CR will not be in the header value so we can reuse the existing stripLeadingAndTrailingHTTPSpaces. 1475454 15 353948 commit-queue 2018-11-06 01:44:23 -0800 Comment on attachment 353948 Patch Clearing flags on attachment: 353948 Committed r237850: <https://trac.webkit.org/changeset/237850> 1475455 16 commit-queue 2018-11-06 01:44:25 -0800 All reviewed patches have been landed. Closing bug. 1475456 17 webkit-bug-importer 2018-11-06 01:45:23 -0800 <rdar://problem/45837237> 353774 2018-11-03 09:13:26 -0700 2018-11-05 12:06:58 -0800 Patch bug-191107-20181103171325.patch text/plain 3331 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTU5NGIyOWVlMzU0Nzcz Nzk3YzMyMWQ3M2ExZDRjYThlYTBmYjZjNS4uMWRmOTk0ZmZmMTkxN2VkZTg4YWJiNTc2ZjY4MGY0 N2NkNjY3NmFhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTExLTAzICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgU29tZSBtaW5vciBYLUNvbnRlbnQt VHlwZS1PcHRpb25zIHBhcnNpbmcgaXNzdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTExMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgbmV3IHBhcnNpbmcgcnVsZXMgZm9yIFgtQ29u dGVudC1UeXBlLU9wdGlvbnM6CisgICAgICAgIGh0dHBzOi8vZ2l0aHViLmNvbS93aGF0d2cvZmV0 Y2gvcHVsbC84MTgKKworICAgICAgICBUZXN0OiB3ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvbm9z bmlmZi9wYXJzaW5nLW5vc25pZmYuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9I VFRQUGFyc2Vycy5jcHA6CisgICAgICAgIChXZWJDb3JlOjppc0hUVFBUYWJPclNwYWNlKToKKyAg ICAgICAgKFdlYkNvcmU6OnBhcnNlQ29udGVudFR5cGVPcHRpb25zSGVhZGVyKToKKwogMjAxOC0x MS0wMiAgSnVzdGluIE1pY2hhdWQgIDxqdXN0aW5fbWljaGF1ZEBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIG5ldyBnbG9iYWwgb2JqZWN0IGFuZCBwcmVsaW1pbmFyeSBXb3JrbGV0cyBzdXBwb3J0 IGZvciBDU1MgcGFpbnRpbmcgYXBpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL0hUVFBQYXJzZXJzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvSFRUUFBhcnNlcnMuY3BwCmluZGV4IGQ4MTEzZDU1MTdmZmVlODczYmNjNzJkMmEyZWZmYmFm MDQ5MGViZjAuLjI4ZGM1YzZjZWM2ZjI0ZWY5MTkwZTgyNjFlYTUyY2RhYjM1NWYzY2EgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUFBhcnNlcnMuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUFBhcnNlcnMuY3BwCkBAIC00 NzQsOSArNDc0LDE4IEBAIFhTU1Byb3RlY3Rpb25EaXNwb3NpdGlvbiBwYXJzZVhTU1Byb3RlY3Rp b25IZWFkZXIoY29uc3QgU3RyaW5nJiBoZWFkZXIsIFN0cmluZyYKICAgICB9CiB9CiAKK2lubGlu ZSBib29sIGlzSFRUUFRhYk9yU3BhY2UoVUNoYXIgY2hhcmFjdGVyKQoreworICAgIHJldHVybiBj aGFyYWN0ZXIgPT0gJyAnIHx8IGNoYXJhY3RlciA9PSAnXHQnOworfQorCiBDb250ZW50VHlwZU9w dGlvbnNEaXNwb3NpdGlvbiBwYXJzZUNvbnRlbnRUeXBlT3B0aW9uc0hlYWRlcihjb25zdCBTdHJp bmcmIGhlYWRlcikKIHsKLSAgICBpZiAoZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoaGVh ZGVyLnN0cmlwV2hpdGVTcGFjZSgpLCAibm9zbmlmZiIpKQorICAgIFN0cmluZyBvcHRpb25zID0g aGVhZGVyOworICAgIHNpemVfdCBjb21tYVBvcyA9IG9wdGlvbnMuZmluZCgnLCcpOworICAgIGlm IChjb21tYVBvcyAhPSBub3RGb3VuZCkKKyAgICAgICAgb3B0aW9ucy50cnVuY2F0ZShjb21tYVBv cyk7CisgICAgaWYgKGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKG9wdGlvbnMuc3RyaXBM ZWFkaW5nQW5kVHJhaWxpbmdDaGFyYWN0ZXJzKGlzSFRUUFRhYk9yU3BhY2UpLCAibm9zbmlmZiIp KQogICAgICAgICByZXR1cm4gQ29udGVudFR5cGVPcHRpb25zTm9zbmlmZjsKICAgICByZXR1cm4g Q29udGVudFR5cGVPcHRpb25zTm9uZTsKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9y dGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmlu ZGV4IDIzYzdiNzc3NTg0Y2NlOTgwMzM2YjFkOGNkNzQ3MjlmM2M4ZGRmNzUuLjgwZDZiYTI0MzJk MzJhMjM2ODcyMTI0MTgyZjkxNzA1MzhjMDAxODggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTExLTAzICBSb2IgQnVpcyAgPHJidWlzQGlnYWxp YS5jb20+CisKKyAgICAgICAgU29tZSBtaW5vciBYLUNvbnRlbnQtVHlwZS1PcHRpb25zIHBhcnNp bmcgaXNzdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTExMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVcGRhdGUgaW1wcm92ZWQgcmVzdWx0LgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3Rz L2ZldGNoL25vc25pZmYvcGFyc2luZy1ub3NuaWZmLWV4cGVjdGVkLnR4dDoKKwogMjAxOC0xMS0w MiAgQWxpIEp1bWEgIDxhanVtYUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWxsb3cgY3Jvc3Mt ZG9jdW1lbnQgaW50ZXJzZWN0aW9uIG9ic2VydmluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9ub3NuaWZmL3BhcnNpbmctbm9z bmlmZi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2ZldGNoL25vc25pZmYvcGFyc2luZy1ub3NuaWZmLWV4cGVjdGVkLnR4dAppbmRleCA0 NzQyOTYyNjRiNzFmZjRhZjk0MzRlMTY5NTkxYThjMWE4ODQ4ZDZjLi42YTAwOGM3YTllYjIxY2Zl MTBmYjBlZGZjODAwMjZjY2E0MzNhOTQ4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL25vc25pZmYvcGFyc2luZy1ub3NuaWZmLWV4 cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2ZldGNoL25vc25pZmYvcGFyc2luZy1ub3NuaWZmLWV4cGVjdGVkLnR4dApAQCAtMSw1ICsx LDUgQEAKIAotRkFJTCBVUkwgcXVlcnk6IGZpcnN0IGFzc2VydF91bnJlYWNoZWQ6IFVuZXhwZWN0 ZWQgbG9hZCBldmVudCBSZWFjaGVkIHVucmVhY2hhYmxlIGNvZGUKK1BBU1MgVVJMIHF1ZXJ5OiBm aXJzdCAKIFBBU1MgVVJMIHF1ZXJ5OiB1cHBlcmNhc2UgCiBQQVNTIFVSTCBxdWVyeTogbGFzdCAK IFBBU1MgVVJMIHF1ZXJ5OiBxdW90ZWQgCg== 353898 2018-11-05 12:07:04 -0800 2018-11-05 23:58:00 -0800 Patch bug-191107-20181105210703.patch text/plain 4420 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3ODE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM1YzYxNGU5MmRhM2U0 NTU1YjMxYjg4M2JjMzdiYzMyODc2OWJlNi4uYTllMGMyNTI5NjlmOGYzMDNkZmZjMzQ2Nzg3YWQy OGE3ZjAzNTllMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTExLTA1ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgU29tZSBtaW5vciBYLUNvbnRlbnQt VHlwZS1PcHRpb25zIHBhcnNpbmcgaXNzdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTExMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgbmV3IHBhcnNpbmcgcnVsZXMgZm9yIFgtQ29u dGVudC1UeXBlLU9wdGlvbnMgWzFdOgorICAgICAgICBodHRwczovL2dpdGh1Yi5jb20vd2hhdHdn L2ZldGNoL3B1bGwvODE4CisKKyAgICAgICAgWzFdIGh0dHBzOi8vZmV0Y2guc3BlYy53aGF0d2cu b3JnLyN4LWNvbnRlbnQtdHlwZS1vcHRpb25zLWhlYWRlcgorCisgICAgICAgIFRlc3Q6IHdlYi1w bGF0Zm9ybS10ZXN0cy9mZXRjaC9ub3NuaWZmL3BhcnNpbmctbm9zbmlmZi5odG1sCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmlzSFRUUFRhYk9yU3BhY2UpOgorICAgICAgICAoV2ViQ29yZTo6cGFyc2VDb250ZW50VHlwZU9w dGlvbnNIZWFkZXIpOgorCiAyMDE4LTExLTA1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhA YXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIENoYW5naW5nIHZpZXcgc2NhbGUgc29tZXRpbWVz IGRvZXMgbm90IHpvb20gdGhlIHBhZ2UgdG8gdGhlIG5ldyBpbml0aWFsIHNjYWxlIHdoZW4gdGhl IHBhZ2UgaXMgem9vbWVkIGluIHdoZW4gaWdub3JpbmcgbWV0YSB2aWV3cG9ydApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmNwcAppbmRleCBkODExM2Q1 NTE3ZmZlZTg3M2JjYzcyZDJhMmVmZmJhZjA0OTBlYmYwLi42ZTBjMjViY2JkZjhlMWJlM2UyMTRk MjY1NWU2YTg1N2E0N2EwNTgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL0hUVFBQYXJzZXJzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL0hUVFBQYXJzZXJzLmNwcApAQCAtNDc0LDkgKzQ3NCwxNSBAQCBYU1NQcm90ZWN0aW9uRGlz cG9zaXRpb24gcGFyc2VYU1NQcm90ZWN0aW9uSGVhZGVyKGNvbnN0IFN0cmluZyYgaGVhZGVyLCBT dHJpbmcmCiAgICAgfQogfQogCi1Db250ZW50VHlwZU9wdGlvbnNEaXNwb3NpdGlvbiBwYXJzZUNv bnRlbnRUeXBlT3B0aW9uc0hlYWRlcihjb25zdCBTdHJpbmcmIGhlYWRlcikKK2lubGluZSBib29s IGlzSFRUUFRhYk9yU3BhY2UoVUNoYXIgY2hhcmFjdGVyKQogewotICAgIGlmIChlcXVhbExldHRl cnNJZ25vcmluZ0FTQ0lJQ2FzZShoZWFkZXIuc3RyaXBXaGl0ZVNwYWNlKCksICJub3NuaWZmIikp CisgICAgcmV0dXJuIGNoYXJhY3RlciA9PSAnICcgfHwgY2hhcmFjdGVyID09ICdcdCc7Cit9CisK K0NvbnRlbnRUeXBlT3B0aW9uc0Rpc3Bvc2l0aW9uIHBhcnNlQ29udGVudFR5cGVPcHRpb25zSGVh ZGVyKFN0cmluZ1ZpZXcgaGVhZGVyKQoreworICAgIFN0cmluZ1ZpZXcgbGVmdFRva2VuID0gaGVh ZGVyLmxlZnQoaGVhZGVyLmZpbmQoJywnKSk7CisgICAgaWYgKGVxdWFsTGV0dGVyc0lnbm9yaW5n QVNDSUlDYXNlKGxlZnRUb2tlbi5zdHJpcExlYWRpbmdBbmRUcmFpbGluZ01hdGNoZWRDaGFyYWN0 ZXJzKGlzSFRUUFRhYk9yU3BhY2UpLCAibm9zbmlmZiIpKQogICAgICAgICByZXR1cm4gQ29udGVu dFR5cGVPcHRpb25zTm9zbmlmZjsKICAgICByZXR1cm4gQ29udGVudFR5cGVPcHRpb25zTm9uZTsK IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUFBhcnNl cnMuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUFBhcnNlcnMuaAppbmRl eCBhNjU5MmYyYTdiYzk0MmRmODYwMGFiNGI1YjA2ZTQyYjgxNjU5ZmE4Li5hYmU3MzlkOGU3MjI3 MzNjMDM4YWVmYmNlZmU0ZTcwMmQ0MjJkNjZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9IVFRQUGFyc2Vycy5oCkBAIC04OSw3ICs4OSw3IEBAIFdFQkNPUkVfRVhQT1JU IFhGcmFtZU9wdGlvbnNEaXNwb3NpdGlvbiBwYXJzZVhGcmFtZU9wdGlvbnNIZWFkZXIoY29uc3Qg U3RyaW5nJik7CiAvLyAtMSBjb3VsZCBiZSBzZXQgdG8gb25lIG9mIHRoZSByZXR1cm4gcGFyYW1l dGVycyB0byBpbmRpY2F0ZSB0aGUgdmFsdWUgaXMgbm90IHNwZWNpZmllZC4KIFdFQkNPUkVfRVhQ T1JUIGJvb2wgcGFyc2VSYW5nZShjb25zdCBTdHJpbmcmLCBsb25nIGxvbmcmIHJhbmdlT2Zmc2V0 LCBsb25nIGxvbmcmIHJhbmdlRW5kLCBsb25nIGxvbmcmIHJhbmdlU3VmZml4TGVuZ3RoKTsKIAot Q29udGVudFR5cGVPcHRpb25zRGlzcG9zaXRpb24gcGFyc2VDb250ZW50VHlwZU9wdGlvbnNIZWFk ZXIoY29uc3QgU3RyaW5nJiBoZWFkZXIpOworQ29udGVudFR5cGVPcHRpb25zRGlzcG9zaXRpb24g cGFyc2VDb250ZW50VHlwZU9wdGlvbnNIZWFkZXIoU3RyaW5nVmlldyBoZWFkZXIpOwogCiAvLyBQ YXJzaW5nIENvbXBsZXRlIEhUVFAgTWVzc2FnZXMuCiBlbnVtIEhUVFBWZXJzaW9uIHsgVW5rbm93 biwgSFRUUF8xXzAsIEhUVFBfMV8xIH07CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRl eCBmYzM3ZmRhNjIxZmRlZGYxOWQwZDdmN2Q5NjdkYjg5OTA1M2RlNzc2Li4wNjk3MjRlNjBlOTZm NTMxY2FiMTdiZDA3MGFlZjY5ZjMyMWE1YTdjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0xMS0wNSAgUm9iIEJ1aXMgIDxyYnVpc0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFNvbWUgbWlub3IgWC1Db250ZW50LVR5cGUtT3B0aW9ucyBwYXJzaW5n IGlzc3VlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTkxMTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VXBkYXRlIGltcHJvdmVkIHJlc3VsdC4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9m ZXRjaC9ub3NuaWZmL3BhcnNpbmctbm9zbmlmZi1leHBlY3RlZC50eHQ6CisKIDIwMTgtMTEtMDUg IENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXN5bmMgaHRtbC9i cm93c2Vycy90aGUtd2luZG93LW9iamVjdC9hcGlzLWZvci1jcmVhdGluZy1hbmQtbmF2aWdhdGlu Zy1icm93c2luZy1jb250ZXh0cy1ieS1uYW1lIFdQVCB0ZXN0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9ub3NuaWZmL3BhcnNp bmctbm9zbmlmZi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBs YXRmb3JtLXRlc3RzL2ZldGNoL25vc25pZmYvcGFyc2luZy1ub3NuaWZmLWV4cGVjdGVkLnR4dApp bmRleCA0NzQyOTYyNjRiNzFmZjRhZjk0MzRlMTY5NTkxYThjMWE4ODQ4ZDZjLi42YTAwOGM3YTll YjIxY2ZlMTBmYjBlZGZjODAwMjZjY2E0MzNhOTQ4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL25vc25pZmYvcGFyc2luZy1ub3Nu aWZmLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL2ZldGNoL25vc25pZmYvcGFyc2luZy1ub3NuaWZmLWV4cGVjdGVkLnR4dApAQCAt MSw1ICsxLDUgQEAKIAotRkFJTCBVUkwgcXVlcnk6IGZpcnN0IGFzc2VydF91bnJlYWNoZWQ6IFVu ZXhwZWN0ZWQgbG9hZCBldmVudCBSZWFjaGVkIHVucmVhY2hhYmxlIGNvZGUKK1BBU1MgVVJMIHF1 ZXJ5OiBmaXJzdCAKIFBBU1MgVVJMIHF1ZXJ5OiB1cHBlcmNhc2UgCiBQQVNTIFVSTCBxdWVyeTog bGFzdCAKIFBBU1MgVVJMIHF1ZXJ5OiBxdW90ZWQgCg== 353946 2018-11-05 23:58:05 -0800 2018-11-06 01:03:57 -0800 Patch bug-191107-20181106085803.patch text/plain 4290 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3ODE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM1YzYxNGU5MmRhM2U0 NTU1YjMxYjg4M2JjMzdiYzMyODc2OWJlNi4uYTllMGMyNTI5NjlmOGYzMDNkZmZjMzQ2Nzg3YWQy OGE3ZjAzNTllMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTExLTA1ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgU29tZSBtaW5vciBYLUNvbnRlbnQt VHlwZS1PcHRpb25zIHBhcnNpbmcgaXNzdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTExMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgbmV3IHBhcnNpbmcgcnVsZXMgZm9yIFgtQ29u dGVudC1UeXBlLU9wdGlvbnMgWzFdOgorICAgICAgICBodHRwczovL2dpdGh1Yi5jb20vd2hhdHdn L2ZldGNoL3B1bGwvODE4CisKKyAgICAgICAgWzFdIGh0dHBzOi8vZmV0Y2guc3BlYy53aGF0d2cu b3JnLyN4LWNvbnRlbnQtdHlwZS1vcHRpb25zLWhlYWRlcgorCisgICAgICAgIFRlc3Q6IHdlYi1w bGF0Zm9ybS10ZXN0cy9mZXRjaC9ub3NuaWZmL3BhcnNpbmctbm9zbmlmZi5odG1sCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmlzSFRUUFRhYk9yU3BhY2UpOgorICAgICAgICAoV2ViQ29yZTo6cGFyc2VDb250ZW50VHlwZU9w dGlvbnNIZWFkZXIpOgorCiAyMDE4LTExLTA1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhA YXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIENoYW5naW5nIHZpZXcgc2NhbGUgc29tZXRpbWVz IGRvZXMgbm90IHpvb20gdGhlIHBhZ2UgdG8gdGhlIG5ldyBpbml0aWFsIHNjYWxlIHdoZW4gdGhl IHBhZ2UgaXMgem9vbWVkIGluIHdoZW4gaWdub3JpbmcgbWV0YSB2aWV3cG9ydApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmNwcAppbmRleCBkODExM2Q1 NTE3ZmZlZTg3M2JjYzcyZDJhMmVmZmJhZjA0OTBlYmYwLi45NDJjNzAxN2Y0ZDEwMGQyYWM3NGUw NGE3MzM2ZGU1OWExY2FiZTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL0hUVFBQYXJzZXJzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL0hUVFBQYXJzZXJzLmNwcApAQCAtNDc0LDkgKzQ3NCwxMCBAQCBYU1NQcm90ZWN0aW9uRGlz cG9zaXRpb24gcGFyc2VYU1NQcm90ZWN0aW9uSGVhZGVyKGNvbnN0IFN0cmluZyYgaGVhZGVyLCBT dHJpbmcmCiAgICAgfQogfQogCi1Db250ZW50VHlwZU9wdGlvbnNEaXNwb3NpdGlvbiBwYXJzZUNv bnRlbnRUeXBlT3B0aW9uc0hlYWRlcihjb25zdCBTdHJpbmcmIGhlYWRlcikKK0NvbnRlbnRUeXBl T3B0aW9uc0Rpc3Bvc2l0aW9uIHBhcnNlQ29udGVudFR5cGVPcHRpb25zSGVhZGVyKFN0cmluZ1Zp ZXcgaGVhZGVyKQogewotICAgIGlmIChlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShoZWFk ZXIuc3RyaXBXaGl0ZVNwYWNlKCksICJub3NuaWZmIikpCisgICAgU3RyaW5nVmlldyBsZWZ0VG9r ZW4gPSBoZWFkZXIubGVmdChoZWFkZXIuZmluZCgnLCcpKTsKKyAgICBpZiAoZXF1YWxMZXR0ZXJz SWdub3JpbmdBU0NJSUNhc2Uoc3RyaXBMZWFkaW5nQW5kVHJhaWxpbmdIVFRQU3BhY2VzKGxlZnRU b2tlbiksICJub3NuaWZmIikpCiAgICAgICAgIHJldHVybiBDb250ZW50VHlwZU9wdGlvbnNOb3Nu aWZmOwogICAgIHJldHVybiBDb250ZW50VHlwZU9wdGlvbnNOb25lOwogfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5oIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5oCmluZGV4IGE2NTkyZjJhN2JjOTQy ZGY4NjAwYWI0YjViMDZlNDJiODE2NTlmYTguLmFiZTczOWQ4ZTcyMjczM2MwMzhhZWZiY2VmZTRl NzAyZDQyMmQ2NmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv SFRUUFBhcnNlcnMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBQ YXJzZXJzLmgKQEAgLTg5LDcgKzg5LDcgQEAgV0VCQ09SRV9FWFBPUlQgWEZyYW1lT3B0aW9uc0Rp c3Bvc2l0aW9uIHBhcnNlWEZyYW1lT3B0aW9uc0hlYWRlcihjb25zdCBTdHJpbmcmKTsKIC8vIC0x IGNvdWxkIGJlIHNldCB0byBvbmUgb2YgdGhlIHJldHVybiBwYXJhbWV0ZXJzIHRvIGluZGljYXRl IHRoZSB2YWx1ZSBpcyBub3Qgc3BlY2lmaWVkLgogV0VCQ09SRV9FWFBPUlQgYm9vbCBwYXJzZVJh bmdlKGNvbnN0IFN0cmluZyYsIGxvbmcgbG9uZyYgcmFuZ2VPZmZzZXQsIGxvbmcgbG9uZyYgcmFu Z2VFbmQsIGxvbmcgbG9uZyYgcmFuZ2VTdWZmaXhMZW5ndGgpOwogCi1Db250ZW50VHlwZU9wdGlv bnNEaXNwb3NpdGlvbiBwYXJzZUNvbnRlbnRUeXBlT3B0aW9uc0hlYWRlcihjb25zdCBTdHJpbmcm IGhlYWRlcik7CitDb250ZW50VHlwZU9wdGlvbnNEaXNwb3NpdGlvbiBwYXJzZUNvbnRlbnRUeXBl T3B0aW9uc0hlYWRlcihTdHJpbmdWaWV3IGhlYWRlcik7CiAKIC8vIFBhcnNpbmcgQ29tcGxldGUg SFRUUCBNZXNzYWdlcy4KIGVudW0gSFRUUFZlcnNpb24geyBVbmtub3duLCBIVFRQXzFfMCwgSFRU UF8xXzEgfTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IGZjMzdmZGE2MjFmZGVk ZjE5ZDBkN2Y3ZDk2N2RiODk5MDUzZGU3NzYuLjA2OTcyNGU2MGU5NmY1MzFjYWIxN2JkMDcwYWVm NjlmMzIxYTVhN2MgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE4LTExLTA1ICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAg U29tZSBtaW5vciBYLUNvbnRlbnQtVHlwZS1PcHRpb25zIHBhcnNpbmcgaXNzdWVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTExMDcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgaW1wcm92ZWQg cmVzdWx0LgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL25vc25pZmYvcGFy c2luZy1ub3NuaWZmLWV4cGVjdGVkLnR4dDoKKwogMjAxOC0xMS0wNSAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJlc3luYyBodG1sL2Jyb3dzZXJzL3RoZS13aW5k b3ctb2JqZWN0L2FwaXMtZm9yLWNyZWF0aW5nLWFuZC1uYXZpZ2F0aW5nLWJyb3dzaW5nLWNvbnRl eHRzLWJ5LW5hbWUgV1BUIHRlc3RzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL25vc25pZmYvcGFyc2luZy1ub3NuaWZmLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0 Y2gvbm9zbmlmZi9wYXJzaW5nLW5vc25pZmYtZXhwZWN0ZWQudHh0CmluZGV4IDQ3NDI5NjI2NGI3 MWZmNGFmOTQzNGUxNjk1OTFhOGMxYTg4NDhkNmMuLjZhMDA4YzdhOWViMjFjZmUxMGZiMGVkZmM4 MDAyNmNjYTQzM2E5NDggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvZmV0Y2gvbm9zbmlmZi9wYXJzaW5nLW5vc25pZmYtZXhwZWN0ZWQudHh0 CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gv bm9zbmlmZi9wYXJzaW5nLW5vc25pZmYtZXhwZWN0ZWQudHh0CkBAIC0xLDUgKzEsNSBAQAogCi1G QUlMIFVSTCBxdWVyeTogZmlyc3QgYXNzZXJ0X3VucmVhY2hlZDogVW5leHBlY3RlZCBsb2FkIGV2 ZW50IFJlYWNoZWQgdW5yZWFjaGFibGUgY29kZQorUEFTUyBVUkwgcXVlcnk6IGZpcnN0IAogUEFT UyBVUkwgcXVlcnk6IHVwcGVyY2FzZSAKIFBBU1MgVVJMIHF1ZXJ5OiBsYXN0IAogUEFTUyBVUkwg cXVlcnk6IHF1b3RlZCAK 353948 2018-11-06 01:04:01 -0800 2018-11-06 01:44:23 -0800 Patch bug-191107-20181106100400.patch text/plain 4284 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3ODE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM1YzYxNGU5MmRhM2U0 NTU1YjMxYjg4M2JjMzdiYzMyODc2OWJlNi4uOTIxN2E1OTkwZDg3MjBkOTQ5OGI4OTYwYTIyOTNj NTFkNjgyM2VkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTExLTA1ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgU29tZSBtaW5vciBYLUNvbnRlbnQt VHlwZS1PcHRpb25zIHBhcnNpbmcgaXNzdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTExMDcKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBB ZGxlci4KKworICAgICAgICBJbXBsZW1lbnQgbmV3IHBhcnNpbmcgcnVsZXMgZm9yIFgtQ29udGVu dC1UeXBlLU9wdGlvbnMgWzFdOgorICAgICAgICBodHRwczovL2dpdGh1Yi5jb20vd2hhdHdnL2Zl dGNoL3B1bGwvODE4CisKKyAgICAgICAgWzFdIGh0dHBzOi8vZmV0Y2guc3BlYy53aGF0d2cub3Jn LyN4LWNvbnRlbnQtdHlwZS1vcHRpb25zLWhlYWRlcgorCisgICAgICAgIFRlc3Q6IHdlYi1wbGF0 Zm9ybS10ZXN0cy9mZXRjaC9ub3NuaWZmL3BhcnNpbmctbm9zbmlmZi5odG1sCisKKyAgICAgICAg KiBwbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omlz SFRUUFRhYk9yU3BhY2UpOgorICAgICAgICAoV2ViQ29yZTo6cGFyc2VDb250ZW50VHlwZU9wdGlv bnNIZWFkZXIpOgorCiAyMDE4LTExLTA1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBw bGUuY29tPgogCiAgICAgICAgIFtpT1NdIENoYW5naW5nIHZpZXcgc2NhbGUgc29tZXRpbWVzIGRv ZXMgbm90IHpvb20gdGhlIHBhZ2UgdG8gdGhlIG5ldyBpbml0aWFsIHNjYWxlIHdoZW4gdGhlIHBh Z2UgaXMgem9vbWVkIGluIHdoZW4gaWdub3JpbmcgbWV0YSB2aWV3cG9ydApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmNwcAppbmRleCBkODExM2Q1NTE3 ZmZlZTg3M2JjYzcyZDJhMmVmZmJhZjA0OTBlYmYwLi45NDJjNzAxN2Y0ZDEwMGQyYWM3NGUwNGE3 MzM2ZGU1OWExY2FiZTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL0hUVFBQYXJzZXJzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L0hUVFBQYXJzZXJzLmNwcApAQCAtNDc0LDkgKzQ3NCwxMCBAQCBYU1NQcm90ZWN0aW9uRGlzcG9z aXRpb24gcGFyc2VYU1NQcm90ZWN0aW9uSGVhZGVyKGNvbnN0IFN0cmluZyYgaGVhZGVyLCBTdHJp bmcmCiAgICAgfQogfQogCi1Db250ZW50VHlwZU9wdGlvbnNEaXNwb3NpdGlvbiBwYXJzZUNvbnRl bnRUeXBlT3B0aW9uc0hlYWRlcihjb25zdCBTdHJpbmcmIGhlYWRlcikKK0NvbnRlbnRUeXBlT3B0 aW9uc0Rpc3Bvc2l0aW9uIHBhcnNlQ29udGVudFR5cGVPcHRpb25zSGVhZGVyKFN0cmluZ1ZpZXcg aGVhZGVyKQogewotICAgIGlmIChlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShoZWFkZXIu c3RyaXBXaGl0ZVNwYWNlKCksICJub3NuaWZmIikpCisgICAgU3RyaW5nVmlldyBsZWZ0VG9rZW4g PSBoZWFkZXIubGVmdChoZWFkZXIuZmluZCgnLCcpKTsKKyAgICBpZiAoZXF1YWxMZXR0ZXJzSWdu b3JpbmdBU0NJSUNhc2Uoc3RyaXBMZWFkaW5nQW5kVHJhaWxpbmdIVFRQU3BhY2VzKGxlZnRUb2tl biksICJub3NuaWZmIikpCiAgICAgICAgIHJldHVybiBDb250ZW50VHlwZU9wdGlvbnNOb3NuaWZm OwogICAgIHJldHVybiBDb250ZW50VHlwZU9wdGlvbnNOb25lOwogfQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5oIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5oCmluZGV4IGE2NTkyZjJhN2JjOTQyZGY4 NjAwYWI0YjViMDZlNDJiODE2NTlmYTguLmFiZTczOWQ4ZTcyMjczM2MwMzhhZWZiY2VmZTRlNzAy ZDQyMmQ2NmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRU UFBhcnNlcnMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJz ZXJzLmgKQEAgLTg5LDcgKzg5LDcgQEAgV0VCQ09SRV9FWFBPUlQgWEZyYW1lT3B0aW9uc0Rpc3Bv c2l0aW9uIHBhcnNlWEZyYW1lT3B0aW9uc0hlYWRlcihjb25zdCBTdHJpbmcmKTsKIC8vIC0xIGNv dWxkIGJlIHNldCB0byBvbmUgb2YgdGhlIHJldHVybiBwYXJhbWV0ZXJzIHRvIGluZGljYXRlIHRo ZSB2YWx1ZSBpcyBub3Qgc3BlY2lmaWVkLgogV0VCQ09SRV9FWFBPUlQgYm9vbCBwYXJzZVJhbmdl KGNvbnN0IFN0cmluZyYsIGxvbmcgbG9uZyYgcmFuZ2VPZmZzZXQsIGxvbmcgbG9uZyYgcmFuZ2VF bmQsIGxvbmcgbG9uZyYgcmFuZ2VTdWZmaXhMZW5ndGgpOwogCi1Db250ZW50VHlwZU9wdGlvbnNE aXNwb3NpdGlvbiBwYXJzZUNvbnRlbnRUeXBlT3B0aW9uc0hlYWRlcihjb25zdCBTdHJpbmcmIGhl YWRlcik7CitDb250ZW50VHlwZU9wdGlvbnNEaXNwb3NpdGlvbiBwYXJzZUNvbnRlbnRUeXBlT3B0 aW9uc0hlYWRlcihTdHJpbmdWaWV3IGhlYWRlcik7CiAKIC8vIFBhcnNpbmcgQ29tcGxldGUgSFRU UCBNZXNzYWdlcy4KIGVudW0gSFRUUFZlcnNpb24geyBVbmtub3duLCBIVFRQXzFfMCwgSFRUUF8x XzEgfTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9M YXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IGZjMzdmZGE2MjFmZGVkZjE5 ZDBkN2Y3ZDk2N2RiODk5MDUzZGU3NzYuLjRkZjMwZmY5OGM4ZGY1MTQwN2ZkODZiOGQxYTllMmYw MTUyYTNjNzYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDE4LTExLTA1ICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgU29t ZSBtaW5vciBYLUNvbnRlbnQtVHlwZS1PcHRpb25zIHBhcnNpbmcgaXNzdWVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTExMDcKKworICAgICAgICBS ZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBVcGRhdGUgaW1wcm92ZWQgcmVzdWx0 LgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL25vc25pZmYvcGFyc2luZy1u b3NuaWZmLWV4cGVjdGVkLnR4dDoKKwogMjAxOC0xMS0wNSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIFJlc3luYyBodG1sL2Jyb3dzZXJzL3RoZS13aW5kb3ctb2Jq ZWN0L2FwaXMtZm9yLWNyZWF0aW5nLWFuZC1uYXZpZ2F0aW5nLWJyb3dzaW5nLWNvbnRleHRzLWJ5 LW5hbWUgV1BUIHRlc3RzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2ZldGNoL25vc25pZmYvcGFyc2luZy1ub3NuaWZmLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvbm9z bmlmZi9wYXJzaW5nLW5vc25pZmYtZXhwZWN0ZWQudHh0CmluZGV4IDQ3NDI5NjI2NGI3MWZmNGFm OTQzNGUxNjk1OTFhOGMxYTg4NDhkNmMuLjZhMDA4YzdhOWViMjFjZmUxMGZiMGVkZmM4MDAyNmNj YTQzM2E5NDggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvZmV0Y2gvbm9zbmlmZi9wYXJzaW5nLW5vc25pZmYtZXhwZWN0ZWQudHh0CisrKyBi L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvbm9zbmlm Zi9wYXJzaW5nLW5vc25pZmYtZXhwZWN0ZWQudHh0CkBAIC0xLDUgKzEsNSBAQAogCi1GQUlMIFVS TCBxdWVyeTogZmlyc3QgYXNzZXJ0X3VucmVhY2hlZDogVW5leHBlY3RlZCBsb2FkIGV2ZW50IFJl YWNoZWQgdW5yZWFjaGFibGUgY29kZQorUEFTUyBVUkwgcXVlcnk6IGZpcnN0IAogUEFTUyBVUkwg cXVlcnk6IHVwcGVyY2FzZSAKIFBBU1MgVVJMIHF1ZXJ5OiBsYXN0IAogUEFTUyBVUkwgcXVlcnk6 IHF1b3RlZCAK