191105 2018-10-31 03:09:06 -0700 [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion 2018-10-31 18:22:49 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham pvollan ross.kirsling webkit-bug-importer oldest_to_newest 1473649 0 fujii 2018-10-31 03:09:06 -0700 [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion clang-cl detects an infinite recursion of DOMHTMLDocument::setNodeValue. > In file included from ..\..\Source\WebKitLegacy\win\DOMHTMLClasses.cpp:27: > ..\..\Source\WebKitLegacy\win/DOMHTMLClasses.h(229,5): warning: all paths through this function will call itself [-Winfinite-recursion] > { > ^ 1473650 1 fujii 2018-10-31 03:09:34 -0700 This code has introduced in https://github.com/WebKit/webkit/commit/fee2e824695f7bfa0f9062b36322874cfbd3733c 1473667 2 353482 fujii 2018-10-31 03:50:50 -0700 Created attachment 353482 Patch 1473795 3 353482 ross.kirsling 2018-10-31 11:32:45 -0700 Comment on attachment 353482 Patch Informal r+. That's a strange mistake, but I'm glad clang is finding things that MSVC didn't! 1473807 4 353482 bfulgham 2018-10-31 11:59:16 -0700 Comment on attachment 353482 Patch Wow! How did that ever work? 1473978 5 fujii 2018-10-31 18:03:52 -0700 Thank you for the review. (In reply to Brent Fulgham from comment #4) > Wow! How did that ever work? I guess this is a unused API. 1473986 6 353482 fujii 2018-10-31 18:21:00 -0700 Comment on attachment 353482 Patch Clearing flags on attachment: 353482 Committed r237666: <https://trac.webkit.org/changeset/237666> 1473987 7 fujii 2018-10-31 18:21:03 -0700 All reviewed patches have been landed. Closing bug. 1473988 8 webkit-bug-importer 2018-10-31 18:22:49 -0700 <rdar://problem/45718605> 353482 2018-10-31 03:50:50 -0700 2018-10-31 18:21:00 -0700 Patch bug-191105-20181031195048.patch text/plain 1376 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L3dpbi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DaGFuZ2VMb2cKaW5k ZXggNmQzNjk1MDM0ZWViNTAwYWEyZTE5NmUyZmJiOTMxZTI4MzZlYjk1Yy4uMjljNWNhYzJlOWYz ZTM1MmQxOWNkODQ0MGEyNzk5NGJhYjBkMDgwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS93aW4vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTEwLTMxICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3Jp LkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dW1dLTF0gRE9NSFRNTERvY3VtZW50Ojpz ZXROb2RlVmFsdWUgZG9lcyBpbmZpbml0ZSByZWN1cnNpb24KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTEwNQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRE9NSFRNTENsYXNzZXMuaDoKKyAgICAgICAg KERPTUhUTUxEb2N1bWVudDo6c2V0Tm9kZVZhbHVlKTogQ2FsbCBET01Eb2N1bWVudDo6c2V0Tm9k ZVZhbHVlCisgICAgICAgIGluc3RlYWQgb2Ygb3duIHNldE5vZGVWYWx1ZS4KKwogMjAxOC0xMC0y NSAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWIgQW5p bWF0aW9uc10gVHVybiBXZWIgQW5pbWF0aW9ucyBDU1MgSW50ZWdyYXRpb24gb2ZmIGJ5IGRlZmF1 bHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0RPTUhUTUxDbGFzc2VzLmgg Yi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9ET01IVE1MQ2xhc3Nlcy5oCmluZGV4IGIxM2RiOWVh YWYyZGEwN2QxMjAyYjZhOTA4NTI1YmU5MDBlNDQyM2MuLjI4MWZjZWU0YTQwMmQ2OTNmMjc3OTM4 ZDBmMjdhNTA0MWMxZTQ5NmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0RP TUhUTUxDbGFzc2VzLmgKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS93aW4vRE9NSFRNTENsYXNz ZXMuaApAQCAtMjI3LDcgKzIyNyw3IEBAIHB1YmxpYzoKICAgICAKICAgICB2aXJ0dWFsIEhSRVNV TFQgU1RETUVUSE9EQ0FMTFRZUEUgc2V0Tm9kZVZhbHVlKF9Jbl8gQlNUUiB2YWx1ZSkKICAgICB7 Ci0gICAgICAgIHJldHVybiBzZXROb2RlVmFsdWUodmFsdWUpOworICAgICAgICByZXR1cm4gRE9N RG9jdW1lbnQ6OnNldE5vZGVWYWx1ZSh2YWx1ZSk7CiAgICAgfQogICAgIAogICAgIHZpcnR1YWwg SFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBub2RlVHlwZShfT3V0XyB1bnNpZ25lZCBzaG9ydCog cmVzdWx0KQo=