191101 2018-10-30 22:42:51 -0700 [Win] Use C++14, not C++17 2018-11-04 20:40:19 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=185232 InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham pvollan ross.kirsling webkit-bug-importer ysuzuki oldest_to_newest 1473611 0 fujii 2018-10-30 22:42:51 -0700 [Win] Use C++14, not C++17 Based on the webkit-dev discussion, I'd like to switch Windows port from C++17 to C++14. [webkit-dev] MSVC and the state of C++17 https://lists.webkit.org/pipermail/webkit-dev/2018-September/030186.html See also: Bug 185232 – [Win] Use C++17 in MSVC 1473613 1 353465 fujii 2018-10-30 22:54:59 -0700 Created attachment 353465 Patch 1473614 2 353465 ross.kirsling 2018-10-30 23:00:01 -0700 Comment on attachment 353465 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353465&action=review > Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:41 > + std::vector<WKChar> wkCharBuffer(maxSize); Should this be a WTF::Vector instead? 1473615 3 353465 fujii 2018-10-30 23:06:33 -0700 Comment on attachment 353465 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353465&action=review >> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:41 >> + std::vector<WKChar> wkCharBuffer(maxSize); > > Should this be a WTF::Vector instead? The reason why I don't want to use WTF in MiniBrowser is that I want to use only public API (WK1 and WK2) in MiniBrowser as much as possible. But, this is just my opinion, MiniBrowser is including some WebCore headers. See also Bug 190791. 1474943 4 353465 fujii 2018-11-04 20:39:28 -0800 Comment on attachment 353465 Patch Clearing flags on attachment: 353465 Committed r237789: <https://trac.webkit.org/changeset/237789> 1474944 5 fujii 2018-11-04 20:39:31 -0800 All reviewed patches have been landed. Closing bug. 1474945 6 webkit-bug-importer 2018-11-04 20:40:19 -0800 <rdar://problem/45797939> 353465 2018-10-30 22:54:59 -0700 2018-11-04 20:39:28 -0800 Patch bug-191101-20181031145457.patch text/plain 5394 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDg4MWI1MWVkYTc5MTUwMTNmNjIwNWFl NDQ2NGYxNDdjZTdkM2NjMDAuLjExOWJiZTk4NWJjOGUzMzI5ZTJhNDU1NDQ2YTIxOTY3ZTM0OTkz MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMTAtMzAgIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gVXNlIEMrKzE0LCBub3QgQysr MTcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTEw MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3Rm L1N0ZExpYkV4dHJhcy5oOiBVc2UgX01TVkNfTEFORyB0byBjaGVjayBDKysgbGFuZ3VhZ2UgdmVy c2lvbgorICAgICAgICBpbnN0ZWFkIG9mIF9NU0NfRlVMTF9WRVIuCisKIDIwMTgtMTAtMzAgIERv biBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAgICBbUGxheVN0YXRp b25dIEVuYWJsZSBKYXZhU2NyaXB0Q29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvU3Rk TGliRXh0cmFzLmggYi9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaAppbmRleCA3ZTg4MTQ0 NjFlNzQwOGEzYmM0NjQyM2Q4ODU1MDVkODZlYmM2OGUxLi4zOWI2N2UzM2I4ZjgwZWVkZDU2MGE4 MmVhMjg0MDYwNWM0NjhmNjVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRy YXMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaApAQCAtNTI3LDcgKzUyNyw3 IEBAIHRlbXBsYXRlPGNsYXNzLi4uIF9BcmdzPiBzdHJ1Y3QgY29uanVuY3Rpb24gOiB3dGZfY29u anVuY3Rpb25faW1wbDxfQXJncy4uLj4geyB9CiAKIC8vIFByb3ZpZGUgaW5fcGxhY2VfdCB3aGVu IG5vdCBidWlsZGluZyB3aXRoIC1zdGQ9YysrMTcsIG9yIHdoZW4gYnVpbGRpbmcgd2l0aCBsaWJz dGRjKysgNgogLy8gKHdoaWNoIGRvZXNuJ3QgZGVmaW5lIHRoZSBfR0xJQkNYWF9SRUxFQVNFIG1h Y3JvIHRoYXQncyBiZWVuIGludHJvZHVjZWQgaW4gbGlic3RkYysrIDcpLgotI2lmIChfX2NwbHVz cGx1cyA8IDIwMTcwM0wgfHwgKGRlZmluZWQoX19HTElCQ1hYX18pICYmICFkZWZpbmVkKF9HTElC Q1hYX1JFTEVBU0UpKSkgJiYgKCFkZWZpbmVkKF9NU0NfRlVMTF9WRVIpIHx8IF9NU0NfRlVMTF9W RVIgPCAxOTAwMjM5MTgpCisjaWYgKF9fY3BsdXNwbHVzIDwgMjAxNzAzTCB8fCAoZGVmaW5lZChf X0dMSUJDWFhfXykgJiYgIWRlZmluZWQoX0dMSUJDWFhfUkVMRUFTRSkpKSAmJiAoIWRlZmluZWQo X01TVkNfTEFORykgfHwgX01TVkNfTEFORyA8IDIwMTcwM0wpCiAKIC8vIFRoZXNlIGFyZSBpbmxp bmUgdmFyaWFibGUgZm9yIEMrKzE3IGFuZCBsYXRlci4KICNkZWZpbmUgX19JTl9QTEFDRV9JTkxJ TkVfVkFSSUFCTEUgc3RhdGljIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9u c01TVkMuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc01TVkMuY21ha2UKaW5kZXggYzZhYWQ1 MGYzMWUwNzMxNTZmZTZjMmVkNmFiODc0ODY4YzQ5ZDdlMy4uODNkMWUyMmI0YjQ4YzhjM2MxZTc1 NjIyZjM0MWE3Y2I0ZjE2YmZkMCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNNU1ZD LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zTVNWQy5jbWFrZQpAQCAtMjYsOSArMjYs OSBAQCBpZiAoTk9UIENPTVBJTEVSX0lTX0NMQU5HX0NMKQogICAgIGFkZF9kZWZpbml0aW9ucygt RF9DUlRfU0VDVVJFX0NQUF9PVkVSTE9BRF9TVEFOREFSRF9OQU1FUz0xKQogZW5kaWYgKCkKIAot IyBFbmFibGUgQysrMTcKKyMgRW5hYmxlIEMrKzE0CiAjIGh0dHBzOi8vZG9jcy5taWNyb3NvZnQu Y29tL2VuLXVzL2NwcC9idWlsZC9yZWZlcmVuY2Uvc3RkLXNwZWNpZnktbGFuZ3VhZ2Utc3RhbmRh cmQtdmVyc2lvbgotYWRkX2NvbXBpbGVfb3B0aW9ucygvc3RkOmMrKzE3KQorYWRkX2NvbXBpbGVf b3B0aW9ucygvc3RkOmMrKzE0KQogCiAjIFNwZWNpZnkgdGhlIHNvdXJjZSBjb2RlIGVuY29kaW5n CiBhZGRfY29tcGlsZV9vcHRpb25zKC91dGYtOCAvdmFsaWRhdGUtY2hhcnNldCkKZGlmZiAtLWdp dCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMjQyY2YzYzUwOWZj NGNiMGM3YzJlMmU3MDBmYzI3OGVlMTI3NjMxLi5jODBlZDY1Zjc3Nzc0OWFhOWZjNTZjMjcxMjYw NGEzZjVmMTJlNmYxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTAtMzAgIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gVXNlIEMrKzE0LCBub3QgQysr MTcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTEw MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHN0ZDo6 YmFzaWNfc3RyaW5nOjpkYXRhKCkgcmV0dXJucyBhIHJlYWQtb25seSBjb25zdCBidWZmZXIgaW4K KyAgICAgICAgQysrMTQuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci93aW4vV2ViS2l0QnJvd3Nl cldpbmRvdy5jcHA6CisgICAgICAgIChjcmVhdGVTdHJpbmcpOiBVc2Ugc3RkOjp2ZWN0b3IgaW5z dGVhZCBvZiBzdGQ6OndzdHJpbmcuCisgICAgICAgIChjcmVhdGVVVEY4U3RyaW5nKTogVXNlIHN0 ZDo6dmVjdG9yIGluc3RlYWQgb2Ygc3RkOjpzdHJpbmcuCisKIDIwMTgtMTAtMzAgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW1dpbl0gUmVtb3Zl IG9ic29sZXRlIGNvZGUgZm9yIFZpc3VhbCBTdHVkaW8gRXhwcmVzcyBpbiB3ZWJraXRkaXJzLnBt CmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci93aW4vV2ViS2l0QnJvd3NlcldpbmRvdy5j cHAgYi9Ub29scy9NaW5pQnJvd3Nlci93aW4vV2ViS2l0QnJvd3NlcldpbmRvdy5jcHAKaW5kZXgg NDgxNjdkN2FhYzEyMTZlODBmNGFmODMwMzcxMjAxY2ZmMmE2NjkzYy4uYmY5M2NiNjkwNTIzOGM0 MjFhMDkzN2U3YmY0ZTZjOGU3OTNmOGI3NyAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIv d2luL1dlYktpdEJyb3dzZXJXaW5kb3cuY3BwCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9X ZWJLaXRCcm93c2VyV2luZG93LmNwcApAQCAtMzcsMTEgKzM3LDEwIEBACiBzdGQ6OndzdHJpbmcg Y3JlYXRlU3RyaW5nKFdLU3RyaW5nUmVmIHdrU3RyaW5nKQogewogICAgIHNpemVfdCBtYXhTaXpl ID0gV0tTdHJpbmdHZXRMZW5ndGgod2tTdHJpbmcpOwotICAgIHN0ZDo6d3N0cmluZyBzdHIobWF4 U2l6ZSwgJ1wwJyk7Ci0gICAgc2l6ZV90IGFjdHVhbExlbmd0aCA9IFdLU3RyaW5nR2V0Q2hhcmFj dGVycyh3a1N0cmluZywgc3RyLmRhdGEoKSwgbWF4U2l6ZSk7Ci0gICAgaWYgKG1heFNpemUgIT0g YWN0dWFsTGVuZ3RoKQotICAgICAgICBzdHIucmVzaXplKGFjdHVhbExlbmd0aCk7Ci0gICAgcmV0 dXJuIHN0ZDo6d3N0cmluZyhzdHIuZGF0YSgpKTsKKworICAgIHN0ZDo6dmVjdG9yPFdLQ2hhcj4g d2tDaGFyQnVmZmVyKG1heFNpemUpOworICAgIHNpemVfdCBhY3R1YWxMZW5ndGggPSBXS1N0cmlu Z0dldENoYXJhY3RlcnMod2tTdHJpbmcsIHdrQ2hhckJ1ZmZlci5kYXRhKCksIG1heFNpemUpOwor ICAgIHJldHVybiBzdGQ6OndzdHJpbmcod2tDaGFyQnVmZmVyLmRhdGEoKSwgYWN0dWFsTGVuZ3Ro KTsKIH0KIAogc3RkOjp3c3RyaW5nIGNyZWF0ZVN0cmluZyhXS1VSTFJlZiB3a1VSTCkKQEAgLTUz LDExICs1Miw5IEBAIHN0ZDo6d3N0cmluZyBjcmVhdGVTdHJpbmcoV0tVUkxSZWYgd2tVUkwpCiBz dGQ6OnN0cmluZyBjcmVhdGVVVEY4U3RyaW5nKGNvbnN0IHdjaGFyX3QqIHNyYywgc2l6ZV90IHNy Y0xlbmd0aCkKIHsKICAgICBpbnQgbGVuZ3RoID0gV2lkZUNoYXJUb011bHRpQnl0ZShDUF9VVEY4 LCAwLCBzcmMsIHNyY0xlbmd0aCwgMCwgMCwgbnVsbHB0ciwgbnVsbHB0cik7Ci0gICAgc3RkOjpz dHJpbmcgc3RyKGxlbmd0aCwgJ1wwJyk7Ci0gICAgaW50IGFjdHVhbExlbmd0aCA9IFdpZGVDaGFy VG9NdWx0aUJ5dGUoQ1BfVVRGOCwgMCwgc3JjLCBzcmNMZW5ndGgsIHN0ci5kYXRhKCksIGxlbmd0 aCwgbnVsbHB0ciwgbnVsbHB0cik7Ci0gICAgaWYgKGxlbmd0aCAhPSBhY3R1YWxMZW5ndGgpCi0g ICAgICAgIHN0ci5yZXNpemUoYWN0dWFsTGVuZ3RoKTsKLSAgICByZXR1cm4gc3RyOworICAgIHN0 ZDo6dmVjdG9yPGNoYXI+IGJ1ZmZlcihsZW5ndGgpOworICAgIHNpemVfdCBhY3R1YWxMZW5ndGgg PSBXaWRlQ2hhclRvTXVsdGlCeXRlKENQX1VURjgsIDAsIHNyYywgc3JjTGVuZ3RoLCBidWZmZXIu ZGF0YSgpLCBsZW5ndGgsIG51bGxwdHIsIG51bGxwdHIpOworICAgIHJldHVybiB7IGJ1ZmZlci5k YXRhKCksIGFjdHVhbExlbmd0aCB9OwogfQogCiBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gY3Jl YXRlV0tTdHJpbmcoX2JzdHJfdCBzdHIpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VM b2cKaW5kZXggZmQyMTFjNzUxNjZmNWQ2NGM3YTZiYWEwMTEzMmVhNmMzNWU1Y2FjMC4uN2Q0OWNj NDAzYzQ3YjUxZjQ2NmM5ZmM5YmE1YzEwNjJhYWVjNDg3MiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9n CisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTEwLTMwICBGdWppaSBIaXJv bm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIFVzZSBDKysx NCwgbm90IEMrKzE3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTExMDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBCYXNlZCBvbiB0aGUgd2Via2l0LWRldiBkaXNjdXNzaW9uLCB0aGlzIGNoYW5nZSBzd2l0 Y2hlcyBXaW5kb3dzCisgICAgICAgIHBvcnQgZnJvbSBDKysxNyB0byBDKysxNC4KKyAgICAgICAg PGh0dHBzOi8vbGlzdHMud2Via2l0Lm9yZy9waXBlcm1haWwvd2Via2l0LWRldi8yMDE4LVNlcHRl bWJlci8wMzAxODYuaHRtbD4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zTVNWQy5j bWFrZTogUmVwbGFjZWQgL3N0ZDpjKysxNyB3aXRoIC9zdGQ6YysrMTQgc3dpdGNoLgorCiAyMDE4 LTEwLTMwICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAg W1BsYXlTdGF0aW9uXSBFbmFibGUgSmF2YVNjcmlwdENvcmUK