191094 2018-10-30 17:04:48 -0700 [lldb-webkit] Fix formatting nits in Document and Frame summary strings 2018-11-05 11:36:24 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aestes lforschler webkit-bug-importer oldest_to_newest 1473516 0 dbates 2018-10-30 17:04:48 -0700 Format boolean as 1/0 when printing Frame summary and substitute "inMainFrame" for "isMainFrame" in Document summary. 1473517 1 353440 dbates 2018-10-30 17:05:26 -0700 Created attachment 353440 Patch 1473601 2 353440 dbates 2018-10-30 21:27:47 -0700 Comment on attachment 353440 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353440&action=review > Tools/lldb/lldb_webkit.py:212 > + return '{ origin = %s, url = %s, isMainFrame = %d, pageCacheState = %s' % (origin, url, provider.is_main_frame(), pageCacheState) Oops! I also forgot the closing '}'. So this line should read: return '{ origin = %s, url = %s, isMainFrame = %d, pageCacheState = %s }' % (origin, url, provider.is_main_frame(), pageCacheState) > Tools/lldb/lldb_webkit.py:219 > + return '{ origin = %s, url = %s, inMainFrame = %s, pageCacheState = %s' % (provider.origin(), provider.url(), in_main_frame, provider.page_cache_state()) Oops! I also forgot the closing '}'. So this line should read: return '{ origin = %s, url = %s, inMainFrame = %s, pageCacheState = %s }' % (provider.origin(), provider.url(), in_main_frame, provider.page_cache_state()) 1473789 3 353510 dbates 2018-10-31 11:21:35 -0700 Created attachment 353510 Patch 1475202 4 353510 dbates 2018-11-05 11:35:50 -0800 Comment on attachment 353510 Patch Clearing flags on attachment: 353510 Committed r237822: <https://trac.webkit.org/changeset/237822> 1475203 5 dbates 2018-11-05 11:35:52 -0800 All reviewed patches have been landed. Closing bug. 1475206 6 webkit-bug-importer 2018-11-05 11:36:24 -0800 <rdar://problem/45814199> 353440 2018-10-30 17:05:26 -0700 2018-10-31 11:21:34 -0700 Patch bug-191094-20181030170526.patch text/plain 2146 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NjA5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzlkOTlmM2U0ZTA4Mjk4ZWRjYzU5OTEzM2ZmMjdmMTE4 YjBkZGRjMi4uOWZhMDNkODVjNjg0Nzg2YzNhNzRlMjNkYWYzM2JjY2IwNGJkM2FhMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE4LTEwLTMwICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbbGxkYi13ZWJraXRdIEZvcm1hdCBib29sZWFuIGFzIDEvMCB3aGVuIHByaW50aW5nIEZy YW1lIHN1bW1hcnkgYW5kIHN1YnN0aXR1dGUgImluTWFpbkZyYW1lIgorICAgICAgICBmb3IgImlz TWFpbkZyYW1lIiBpbiBEb2N1bWVudCBzdW1tYXJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEwOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZm9ybWVyIG1hdGNoZXMgdGhlIGZvcm1hdHRpbmcg d2UgdXNlIGZvciBib29sZWFuIHZhbHVlcyBpbiBvdGhlciBzdW1tYXJpZXMgYW5kIHRoZSBsYXR0 ZXIKKyAgICAgICAgZml4ZXMgYSB0eXBvOiBhIGRvY3VtZW50IGlzIGluIGEgZnJhbWU7IGl0IGlz IG5vdCBhIGZyYW1lLgorCisgICAgICAgICogbGxkYi9sbGRiX3dlYmtpdC5weToKKyAgICAgICAg KFdlYkNvcmVGcmFtZV9TdW1tYXJ5UHJvdmlkZXIpOgorICAgICAgICAoV2ViQ29yZURvY3VtZW50 X1N1bW1hcnlQcm92aWRlcik6CisKIDIwMTgtMTAtMzAgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxh cEBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgc29tZSBvYnNvbGV0ZSBNQVhfQUxMT1dF RCBtYWNyb3MKZGlmZiAtLWdpdCBhL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQucHkgYi9Ub29scy9s bGRiL2xsZGJfd2Via2l0LnB5CmluZGV4IGRkZTFhYTdhY2I3NWIzNzE2OWQ5NzY3YzkxMjViZTM5 MTVhYzY2NDguLjAxODgzMTQ3YjFjNGQ5MjI0NzM4NGIwNTU3NzQ5MmZiZGU0ZDk4YjkgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQucHkKKysrIGIvVG9vbHMvbGxkYi9sbGRiX3dl YmtpdC5weQpAQCAtMjA5LDE0ICsyMDksMTQgQEAgZGVmIFdlYkNvcmVGcmFtZV9TdW1tYXJ5UHJv dmlkZXIodmFsb2JqLCBkaWN0KToKICAgICAgICAgb3JpZ2luID0gJycKICAgICAgICAgdXJsID0g JycKICAgICAgICAgcGFnZUNhY2hlU3RhdGUgPSAnJwotICAgIHJldHVybiAneyBvcmlnaW4gPSAl cywgdXJsID0gJXMsIGlzTWFpbkZyYW1lID0gJXMsIHBhZ2VDYWNoZVN0YXRlID0gJXMnICUgKG9y aWdpbiwgdXJsLCBwcm92aWRlci5pc19tYWluX2ZyYW1lKCksIHBhZ2VDYWNoZVN0YXRlKQorICAg IHJldHVybiAneyBvcmlnaW4gPSAlcywgdXJsID0gJXMsIGlzTWFpbkZyYW1lID0gJWQsIHBhZ2VD YWNoZVN0YXRlID0gJXMnICUgKG9yaWdpbiwgdXJsLCBwcm92aWRlci5pc19tYWluX2ZyYW1lKCks IHBhZ2VDYWNoZVN0YXRlKQogCiAKIGRlZiBXZWJDb3JlRG9jdW1lbnRfU3VtbWFyeVByb3ZpZGVy KHZhbG9iaiwgZGljdCk6CiAgICAgcHJvdmlkZXIgPSBXZWJDb3JlRG9jdW1lbnRQcm92aWRlcih2 YWxvYmosIGRpY3QpCiAgICAgZnJhbWUgPSBwcm92aWRlci5mcmFtZSgpCiAgICAgaW5fbWFpbl9m cmFtZSA9ICclZCcgJSBmcmFtZS5pc19tYWluX2ZyYW1lKCkgaWYgZnJhbWUgZWxzZSAnRGV0YWNo ZWQnCi0gICAgcmV0dXJuICd7IG9yaWdpbiA9ICVzLCB1cmwgPSAlcywgaXNNYWluRnJhbWUgPSAl cywgcGFnZUNhY2hlU3RhdGUgPSAlcycgJSAocHJvdmlkZXIub3JpZ2luKCksIHByb3ZpZGVyLnVy bCgpLCBpbl9tYWluX2ZyYW1lLCBwcm92aWRlci5wYWdlX2NhY2hlX3N0YXRlKCkpCisgICAgcmV0 dXJuICd7IG9yaWdpbiA9ICVzLCB1cmwgPSAlcywgaW5NYWluRnJhbWUgPSAlcywgcGFnZUNhY2hl U3RhdGUgPSAlcycgJSAocHJvdmlkZXIub3JpZ2luKCksIHByb3ZpZGVyLnVybCgpLCBpbl9tYWlu X2ZyYW1lLCBwcm92aWRlci5wYWdlX2NhY2hlX3N0YXRlKCkpCiAKIAogZGVmIGJ0anMoZGVidWdn ZXIsIGNvbW1hbmQsIHJlc3VsdCwgaW50ZXJuYWxfZGljdCk6Cg== 353510 2018-10-31 11:21:35 -0700 2018-11-05 11:35:50 -0800 Patch bug-191094-20181031112134.patch text/plain 2244 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NjQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTRkYjIzOTM1MTI2ZmNiMWZmNWRlMTRkNGRmNWMxMGE4 NzJlODJjMi4uYTM1NmEzNTI1MDRjNjBhNTUxMDA2ZDQ4YzNjN2NhMmJkODk0OWQ3OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE4LTEwLTMxICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbbGxkYi13ZWJraXRdIEZpeCBmb3JtYXR0aW5nIG5pdHMgaW4gRG9jdW1lbnQgYW5kIEZy YW1lIHN1bW1hcnkgc3RyaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTkxMDk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRm9ybWF0IGJvb2xlYW4gYXMgMS8wIHdoZW4gcHJpbnRpbmcgRnJhbWUgc3Vt bWFyeSB0byBiZSBjb25zaXN0ZW50IHdpdGggdGhlIGZvcm1hdHRpbmcgb2YKKyAgICAgICAgYm9v bGVhbnMgaW4gb3RoZXIgc3VtbWFyeSBzdHJpbmdzLCBzdWJzdGl0dXRlICJpbk1haW5GcmFtZSIg Zm9yICJpc01haW5GcmFtZSIgaW4gdGhlIHByaW50ZWQKKyAgICAgICAgRG9jdW1lbnQgc3VtbWFy eSBhbmQgYWRkIGNsb3NpbmcgYnJhY2UgJ30nIHRvIGJvdGggRnJhbWUgYW5kIERvY3VtZW50IHN1 bW1hcnkgc3RyaW5ncyB0byBtYWtlCisgICAgICAgIHRoZW0gbG9vayBwcmV0dHkuCisKKyAgICAg ICAgKiBsbGRiL2xsZGJfd2Via2l0LnB5OgorICAgICAgICAoV2ViQ29yZUZyYW1lX1N1bW1hcnlQ cm92aWRlcik6CisgICAgICAgIChXZWJDb3JlRG9jdW1lbnRfU3VtbWFyeVByb3ZpZGVyKToKKwog MjAxOC0xMC0zMSAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxpYS5jb20+CiAKICAg ICAgICAgRG9uJ3QgcnVuIEpJVCB0ZXN0cyBvbiAzMi1iaXQgcGxhdGZvcm1zCmRpZmYgLS1naXQg YS9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5IGIvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5weQpp bmRleCBkZGUxYWE3YWNiNzViMzcxNjlkOTc2N2M5MTI1YmUzOTE1YWM2NjQ4Li5mNWJiYzIxNzFj NGU2YjczOTgwNWQ5NTQ2OGM3MzNiYzY1YjRkNDVmIDEwMDY0NAotLS0gYS9Ub29scy9sbGRiL2xs ZGJfd2Via2l0LnB5CisrKyBiL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQucHkKQEAgLTIwOSwxNCAr MjA5LDE0IEBAIGRlZiBXZWJDb3JlRnJhbWVfU3VtbWFyeVByb3ZpZGVyKHZhbG9iaiwgZGljdCk6 CiAgICAgICAgIG9yaWdpbiA9ICcnCiAgICAgICAgIHVybCA9ICcnCiAgICAgICAgIHBhZ2VDYWNo ZVN0YXRlID0gJycKLSAgICByZXR1cm4gJ3sgb3JpZ2luID0gJXMsIHVybCA9ICVzLCBpc01haW5G cmFtZSA9ICVzLCBwYWdlQ2FjaGVTdGF0ZSA9ICVzJyAlIChvcmlnaW4sIHVybCwgcHJvdmlkZXIu aXNfbWFpbl9mcmFtZSgpLCBwYWdlQ2FjaGVTdGF0ZSkKKyAgICByZXR1cm4gJ3sgb3JpZ2luID0g JXMsIHVybCA9ICVzLCBpc01haW5GcmFtZSA9ICVkLCBwYWdlQ2FjaGVTdGF0ZSA9ICVzIH0nICUg KG9yaWdpbiwgdXJsLCBwcm92aWRlci5pc19tYWluX2ZyYW1lKCksIHBhZ2VDYWNoZVN0YXRlKQog CiAKIGRlZiBXZWJDb3JlRG9jdW1lbnRfU3VtbWFyeVByb3ZpZGVyKHZhbG9iaiwgZGljdCk6CiAg ICAgcHJvdmlkZXIgPSBXZWJDb3JlRG9jdW1lbnRQcm92aWRlcih2YWxvYmosIGRpY3QpCiAgICAg ZnJhbWUgPSBwcm92aWRlci5mcmFtZSgpCiAgICAgaW5fbWFpbl9mcmFtZSA9ICclZCcgJSBmcmFt ZS5pc19tYWluX2ZyYW1lKCkgaWYgZnJhbWUgZWxzZSAnRGV0YWNoZWQnCi0gICAgcmV0dXJuICd7 IG9yaWdpbiA9ICVzLCB1cmwgPSAlcywgaXNNYWluRnJhbWUgPSAlcywgcGFnZUNhY2hlU3RhdGUg PSAlcycgJSAocHJvdmlkZXIub3JpZ2luKCksIHByb3ZpZGVyLnVybCgpLCBpbl9tYWluX2ZyYW1l LCBwcm92aWRlci5wYWdlX2NhY2hlX3N0YXRlKCkpCisgICAgcmV0dXJuICd7IG9yaWdpbiA9ICVz LCB1cmwgPSAlcywgaW5NYWluRnJhbWUgPSAlcywgcGFnZUNhY2hlU3RhdGUgPSAlcyB9JyAlIChw cm92aWRlci5vcmlnaW4oKSwgcHJvdmlkZXIudXJsKCksIGluX21haW5fZnJhbWUsIHByb3ZpZGVy LnBhZ2VfY2FjaGVfc3RhdGUoKSkKIAogCiBkZWYgYnRqcyhkZWJ1Z2dlciwgY29tbWFuZCwgcmVz dWx0LCBpbnRlcm5hbF9kaWN0KToK