191070 2018-10-30 10:46:06 -0700 [iOS] Use the mainframe view size to compute window.outerWidth/height. 2018-10-30 13:17:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan webkit-unassigned bfulgham commit-queue simon.fraser thorton zalan oldest_to_newest 1473306 0 zalan 2018-10-30 10:46:06 -0700 WKWebView's frame rect -> drawing area sizing -> WebPage's view size -> FrameView size 1473312 1 zalan 2018-10-30 10:49:37 -0700 rdar://problem/42368377 1473314 2 353385 zalan 2018-10-30 10:50:07 -0700 Created attachment 353385 Patch 1473339 3 353385 commit-queue 2018-10-30 11:33:09 -0700 Comment on attachment 353385 Patch Clearing flags on attachment: 353385 Committed r237596: <https://trac.webkit.org/changeset/237596> 1473340 4 commit-queue 2018-10-30 11:33:10 -0700 All reviewed patches have been landed. Closing bug. 1473380 5 353385 simon.fraser 2018-10-30 13:17:18 -0700 Comment on attachment 353385 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353385&action=review > Source/WebCore/page/DOMWindow.cpp:1183 > + auto* view = frame()->isMainFrame() ? frame()->view() : frame()->mainFrame().view(); Is frame()->mainFrame().view() == frame()->view() for the main frame (i.e. do you need this ternary at all?). 353385 2018-10-30 10:50:07 -0700 2018-10-30 11:33:09 -0700 Patch bug-191070-20181030105006.patch text/plain 2016 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2M0MWViNmI1ZGI4MzRm MTBjNDQ5NmZmZTFhNWEzOTEzZWY0ODRmNC4uZTZlMDFiZmJiZDJiOTRmNmRiMWNmMTE5YzE1MDRk ZTc5MzMzNDRhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTEwLTMwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gVXNlIHRoZSBtYWlu ZnJhbWUgdmlldyBzaXplIHRvIGNvbXB1dGUgd2luZG93Lm91dGVyV2lkdGgvaGVpZ2h0LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxMDcwCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS80MjM2ODM3Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgYSBtb3JlIHJlYXNvbmFibGUgdmFsdWUgZm9yIHdp bmRvdy5vdXRlcldpZHRoIGFuZCBoZWlnaHQuCisgICAgICAgIChXS1dlYlZpZXcncyBmcmFtZSBy ZWN0IC0+IGRyYXdpbmcgYXJlYSBzaXppbmcgLT4gV2ViUGFnZSdzIHZpZXcgc2l6ZSAtPiBGcmFt ZVZpZXcgc2l6ZSkKKworICAgICAgICAqIHBhZ2UvRE9NV2luZG93LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkRPTVdpbmRvdzo6b3V0ZXJIZWlnaHQgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6 RE9NV2luZG93OjpvdXRlcldpZHRoIGNvbnN0KToKKwogMjAxOC0xMC0yOSAgWmFsYW4gQnVqdGFz ICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gSW50cm9kdWNlIElubGlu ZUZvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkgY2xhc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRE9NV2luZG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNw cAppbmRleCAyNmUxNjNkMmZmNjRiNjFiZmRkZTk4NGJiOTJlZTQ3Yjg3ZGEwMDc5Li41MDkwMzQw ZDRkNTg4NWUyZWMwZTRiMjZkNmU3NmZiMmUwOWRjYTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5k b3cuY3BwCkBAIC0xMTc3LDcgKzExNzcsMTQgQEAgYm9vbCBET01XaW5kb3c6Om9mZnNjcmVlbkJ1 ZmZlcmluZygpIGNvbnN0CiBpbnQgRE9NV2luZG93OjpvdXRlckhlaWdodCgpIGNvbnN0CiB7CiAj aWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKLSAgICByZXR1cm4gMDsKKyAgICBpZiAoIWZyYW1lKCkp CisgICAgICAgIHJldHVybiAwOworCisgICAgYXV0byogdmlldyA9IGZyYW1lKCktPmlzTWFpbkZy YW1lKCkgPyBmcmFtZSgpLT52aWV3KCkgOiBmcmFtZSgpLT5tYWluRnJhbWUoKS52aWV3KCk7Cisg ICAgaWYgKCF2aWV3KQorICAgICAgICByZXR1cm4gMDsKKworICAgIHJldHVybiB2aWV3LT5mcmFt ZVJlY3QoKS5oZWlnaHQoKTsKICNlbHNlCiAgICAgYXV0byogZnJhbWUgPSB0aGlzLT5mcmFtZSgp OwogICAgIGlmICghZnJhbWUpCkBAIC0xMTk0LDcgKzEyMDEsMTQgQEAgaW50IERPTVdpbmRvdzo6 b3V0ZXJIZWlnaHQoKSBjb25zdAogaW50IERPTVdpbmRvdzo6b3V0ZXJXaWR0aCgpIGNvbnN0CiB7 CiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKLSAgICByZXR1cm4gMDsKKyAgICBpZiAoIWZyYW1l KCkpCisgICAgICAgIHJldHVybiAwOworCisgICAgYXV0byogdmlldyA9IGZyYW1lKCktPmlzTWFp bkZyYW1lKCkgPyBmcmFtZSgpLT52aWV3KCkgOiBmcmFtZSgpLT5tYWluRnJhbWUoKS52aWV3KCk7 CisgICAgaWYgKCF2aWV3KQorICAgICAgICByZXR1cm4gMDsKKworICAgIHJldHVybiB2aWV3LT5m cmFtZVJlY3QoKS53aWR0aCgpOwogI2Vsc2UKICAgICBhdXRvKiBmcmFtZSA9IHRoaXMtPmZyYW1l KCk7CiAgICAgaWYgKCFmcmFtZSkK