191068 2018-10-30 08:17:10 -0700 PNGImageDecoder: report no repetition for non-animated images 2018-11-02 00:16:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zan zan magomez mcatanzaro webkit-bug-importer oldest_to_newest 1473260 0 zan 2018-10-30 08:17:10 -0700 PNGImageDecoder: report no repetition for non-animated images 1473261 1 353370 zan 2018-10-30 08:20:02 -0700 Created attachment 353370 Patch 1473262 2 353370 mcatanzaro 2018-10-30 08:22:44 -0700 Comment on attachment 353370 Patch Does this fix something? Is it testable? 1473264 3 zan 2018-10-30 08:40:45 -0700 This avoids querying the PNG decoder for duration information on non-animated images. As it stands, that query goes on and needlessly decodes all the PNG data. Combined with other issues in ScalableImageDecoder, size of all that decoded data goes unreported to the MemoryCache, which means that MemoryCache ends up handling more data than it knows about. So currently, there's no simple way to test it yet. 1473271 4 magomez 2018-10-30 08:55:09 -0700 Yeah, makes sense. 1474415 5 353370 zan 2018-11-02 00:15:16 -0700 Comment on attachment 353370 Patch Clearing flags on attachment: 353370 Committed r237725: <https://trac.webkit.org/changeset/237725> 1474416 6 zan 2018-11-02 00:15:19 -0700 All reviewed patches have been landed. Closing bug. 1474417 7 webkit-bug-importer 2018-11-02 00:16:21 -0700 <rdar://problem/45755638> 353370 2018-10-30 08:20:02 -0700 2018-11-02 00:15:16 -0700 Patch bug-191068-20181030162001.patch text/plain 1894 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2M0MWViNmI1ZGI4MzRm MTBjNDQ5NmZmZTFhNWEzOTEzZWY0ODRmNC4uNzEwMTBlNjA3M2VkNjRhYjRjYTQyNGNlZWFlYTE5 N2VkZGVlYzRjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTMwICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBQTkdJbWFnZURlY29k ZXI6IHJlcG9ydCBubyByZXBldGl0aW9uIGZvciBub24tYW5pbWF0ZWQgaW1hZ2VzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEwNjgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGJ1aWxkaW5nIHdp dGggQVBORyBzdXBwb3J0IGVuYWJsZWQsIHRoZQorICAgICAgICBQTkdJbWFnZURlY29kZXI6OnJl cGV0aXRpb25Db3VudCgpIG1ldGhvZCB1bnRpbCBub3cgcmVwb3J0ZWQgIGluZmluaXRlCisgICAg ICAgIHJlcGV0aXRpb24gY291bnQgZm9yIGFsbCBQTkcgaW1hZ2VzLCBldmVuIHRoZSBvbmVzIHRo YXQgd2VyZSBub3QKKyAgICAgICAgYW5pbWF0ZWQuIFRoaXMgaXMgbm93IGNoYW5nZWQgc28gdGhh dCBubyByZXBldGl0aW9uIGlzIHJlcG9ydGVkIGZvcgorICAgICAgICBub24tYW5pbWF0ZWQgaW1h Z2VzLgorCisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvcG5nL1BOR0ltYWdlRGVj b2Rlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQTkdJbWFnZURlY29kZXI6OnJlcGV0aXRpb25D b3VudCBjb25zdCk6CisKIDIwMTgtMTAtMjkgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNv bT4KIAogICAgICAgICBbTEZDXVtJRkNdIEludHJvZHVjZSBJbmxpbmVGb3JtYXR0aW5nQ29udGV4 dEdlb21ldHJ5IGNsYXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFn ZS1kZWNvZGVycy9wbmcvUE5HSW1hZ2VEZWNvZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2ltYWdlLWRlY29kZXJzL3BuZy9QTkdJbWFnZURlY29kZXIuY3BwCmluZGV4IGZkODZmMmIw NGZiMzljNGZlOWUxM2NhYTI3ZjZiMWZiN2M3YzgxMGEuLmMxOGEzOWI1OTEzM2EzMThmMTUxMDU4 MWU4ZjkxZWJkZDc2ODc5YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lt YWdlLWRlY29kZXJzL3BuZy9QTkdJbWFnZURlY29kZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3BuZy9QTkdJbWFnZURlY29kZXIuY3BwCkBAIC0yMzUs NiArMjM1LDEwIEBAIFBOR0ltYWdlRGVjb2Rlcjo6flBOR0ltYWdlRGVjb2RlcigpID0gZGVmYXVs dDsKICNpZiBFTkFCTEUoQVBORykKIFJlcGV0aXRpb25Db3VudCBQTkdJbWFnZURlY29kZXI6OnJl cGV0aXRpb25Db3VudCgpIGNvbnN0CiB7CisgICAgLy8gU2lnbmFsIG5vIHJlcGV0aXRpb24gaWYg dGhlIFBORyBpbWFnZSBpcyBub3QgYW5pbWF0ZWQuCisgICAgaWYgKCFtX2lzQW5pbWF0ZWQpCisg ICAgICAgIHJldHVybiBSZXBldGl0aW9uQ291bnROb25lOworCiAgICAgLy8gQVBORyBmb3JtYXQg dXNlcyAwIHRvIGluZGljYXRlIHRoYXQgYW4gYW5pbWF0aW9uIG11c3QgcGxheSBpbmRlZmluaXRl bHkuIEJ1dAogICAgIC8vIHRoZSBSZXBldGl0aW9uQ291bnQgZW51bWVyYXRpb24gdXNlcyBSZXBl dGl0aW9uQ291bnRJbmZpbml0ZSwgc28gd2UgbmVlZCB0byBhZGFwdCB0aGlzLgogICAgIGlmICgh bV9wbGF5Q291bnQpCg==