191067 2018-10-30 07:47:25 -0700 [GTK] Scrollbars not following gtk-primary-button-warps-slider setting 2018-11-23 11:46:01 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jmason webkit-unassigned bugs-noreply cgarcia commit-queue ews-watchlist mcatanzaro oldest_to_newest 1473245 0 jmason 2018-10-30 07:47:25 -0700 When you click in the scrollbar trough, WebKit GTK will always warp the slider to the clicked position, regardless of the setting 'gtk-primary-button-warps-slider'. Expected behaviour: If 'gtk-primary-button-warps-slider' is false, then a click in the trough should page forward or backward; if true, then it should warp. Holding down the shift key or clicking the middle button reverses the sense of the setting. Reference: https://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-primary-button-warps-slider 1473246 1 353366 jmason 2018-10-30 07:51:59 -0700 Created attachment 353366 Patch 1473251 2 ews-watchlist 2018-10-30 07:56:24 -0700 Attachment 353366 did not pass style-queue: ERROR: Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:780: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:781: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:781: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:783: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:784: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1473253 3 353367 jmason 2018-10-30 08:03:16 -0700 Created attachment 353367 Patch 1473254 4 ews-watchlist 2018-10-30 08:06:09 -0700 Attachment 353367 did not pass style-queue: ERROR: Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:780: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:784: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1473259 5 353369 jmason 2018-10-30 08:15:01 -0700 Created attachment 353369 Patch 1473305 6 mcatanzaro 2018-10-30 10:42:48 -0700 Did you close this accidentally? 1473308 7 353369 mcatanzaro 2018-10-30 10:47:17 -0700 Comment on attachment 353369 Patch Oooh, cool! Nice, especially if this is your first contribution. I have two suggestions: (1) WebKit style is that the comment should be a complete sentence that starts with a capital and ends with a period. (2) The ^ is too clever for my taste; can you write it out with conditionals so that it's easier to read? Thanks! 1473320 8 353387 jmason 2018-10-30 11:11:29 -0700 Created attachment 353387 Patch 1473325 9 jmason 2018-10-30 11:13:31 -0700 (In reply to Michael Catanzaro from comment #7) > Comment on attachment 353369 [details] > Patch > > Oooh, cool! Nice, especially if this is your first contribution. > > I have two suggestions: > > (1) WebKit style is that the comment should be a complete sentence that > starts with a capital and ends with a period. > > (2) The ^ is too clever for my taste; can you write it out with > conditionals so that it's easier to read? > > Thanks! Good feedback, thanks! The changes have been applied. 1473327 10 353387 mcatanzaro 2018-10-30 11:16:04 -0700 Comment on attachment 353387 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353387&action=review > Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:785 > + return warp_slider? OK one last change: leave one space before the ? warp_slider ? Sorry. :P 1473328 11 353389 jmason 2018-10-30 11:17:30 -0700 Created attachment 353389 Patch 1473330 12 jmason 2018-10-30 11:20:33 -0700 (In reply to Michael Catanzaro from comment #10) > Comment on attachment 353387 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353387&action=review > > > Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:785 > > + return warp_slider? > > OK one last change: leave one space before the ? > > warp_slider ? > > Sorry. :P No prob, 'tis done. 1473578 13 353389 commit-queue 2018-10-30 19:30:00 -0700 Comment on attachment 353389 Patch Clearing flags on attachment: 353389 Committed r237617: <https://trac.webkit.org/changeset/237617> 1473579 14 commit-queue 2018-10-30 19:30:02 -0700 All reviewed patches have been landed. Closing bug. 1480922 15 cgarcia 2018-11-22 00:42:20 -0800 (In reply to Michael Catanzaro from comment #10) > Comment on attachment 353387 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353387&action=review > > > Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:785 > > + return warp_slider? > > OK one last change: leave one space before the ? > > warp_slider ? > > Sorry. :P warpSlider... 1481133 16 mcatanzaro 2018-11-23 08:59:18 -0800 Sorry, I missed that. Will you rename it, or do you want me to? 1481142 17 jmason 2018-11-23 09:10:22 -0800 Reopening to attach new patch. 1481143 18 355518 jmason 2018-11-23 09:10:24 -0800 Created attachment 355518 Patch 1481144 19 ews-watchlist 2018-11-23 09:12:18 -0800 Attachment 355518 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:10: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1481145 20 355519 jmason 2018-11-23 09:14:45 -0800 Created attachment 355519 Patch 1481166 21 355519 mcatanzaro 2018-11-23 11:20:16 -0800 Comment on attachment 355519 Patch OK, thanks. 1481170 22 355519 commit-queue 2018-11-23 11:45:59 -0800 Comment on attachment 355519 Patch Clearing flags on attachment: 355519 Committed r238462: <https://trac.webkit.org/changeset/238462> 1481171 23 commit-queue 2018-11-23 11:46:01 -0800 All reviewed patches have been landed. Closing bug. 353366 2018-10-30 07:51:59 -0700 2018-10-30 08:03:11 -0700 Patch bug-191067-20181030145158.patch text/plain 1943 jmason SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNzU4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE4LTEwLTMwICBKaW0gTWFz b24gIDxqbWFzb25AaWJpbnguY29tPgorCisgICAgICAgIFtHVEtdIFNjcm9sbGJhcnMgbm90IGZv bGxvd2luZyBndGstcHJpbWFyeS1idXR0b24td2FycHMtc2xpZGVyIHNldHRpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTA2NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Nj cm9sbGJhclRoZW1lR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lR3Rr OjpoYW5kbGVNb3VzZVByZXNzRXZlbnQpOgorCiAyMDE4LTEwLTI5ICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWlzc2luZyBmcm9tIHIyMzc1NDkKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0ay5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmNwcAko cmV2aXNpb24gMjM3NTgzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJh clRoZW1lR3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzcyLDEzICs3NzIsMTggQEAgYm9vbCBT Y3JvbGxiYXJUaGVtZUd0azo6cGFpbnQoU2Nyb2xsYmFyJgogCiBTY3JvbGxiYXJCdXR0b25QcmVz c0FjdGlvbiBTY3JvbGxiYXJUaGVtZUd0azo6aGFuZGxlTW91c2VQcmVzc0V2ZW50KFNjcm9sbGJh ciYsIGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYgZXZlbnQsIFNjcm9sbGJhclBhcnQgcHJlc3Nl ZFBhcnQpCiB7CisgICAgZ2Jvb2xlYW4gd2FycF9zbGlkZXIgPSBGQUxTRTsKICAgICBzd2l0Y2gg KHByZXNzZWRQYXJ0KSB7CiAgICAgY2FzZSBCYWNrVHJhY2tQYXJ0OgogICAgIGNhc2UgRm9yd2Fy ZFRyYWNrUGFydDoKLSAgICAgICAgaWYgKGV2ZW50LmJ1dHRvbigpID09IExlZnRCdXR0b24pCi0g ICAgICAgICAgICByZXR1cm4gU2Nyb2xsYmFyQnV0dG9uUHJlc3NBY3Rpb246OkNlbnRlck9uVGh1 bWI7Ci0gICAgICAgIGlmIChldmVudC5idXR0b24oKSA9PSBSaWdodEJ1dHRvbikKLSAgICAgICAg ICAgIHJldHVybiBTY3JvbGxiYXJCdXR0b25QcmVzc0FjdGlvbjo6U2Nyb2xsOworICAgICAgICBn X29iamVjdF9nZXQoZ3RrX3NldHRpbmdzX2dldF9kZWZhdWx0KCksCisgICAgICAgICAgICAgICAg ICAgICAiZ3RrLXByaW1hcnktYnV0dG9uLXdhcnBzLXNsaWRlciIsCisgICAgICAgICAgICAgICAg ICAgICAmd2FycF9zbGlkZXIsIE5VTEwpOworICAgICAgICAvLyBzaGlmdCBrZXkgb3IgbWlkZGxl L3JpZ2h0IGJ1dHRvbiByZXZlcnNlcyBzZW5zZSBvZiBzZXR0aW5nCisgICAgICAgIHJldHVybiB3 YXJwX3NsaWRlciBeIChldmVudC5zaGlmdEtleSgpIHx8CisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBldmVudC5idXR0b24oKSAhPSBMZWZ0QnV0dG9uKT8KKyAgICAgICAgICAgICAgICBT Y3JvbGxiYXJCdXR0b25QcmVzc0FjdGlvbjo6Q2VudGVyT25UaHVtYjoKKyAgICAgICAgICAgICAg ICBTY3JvbGxiYXJCdXR0b25QcmVzc0FjdGlvbjo6U2Nyb2xsOwogICAgICAgICBicmVhazsKICAg ICBjYXNlIFRodW1iUGFydDoKICAgICAgICAgaWYgKGV2ZW50LmJ1dHRvbigpICE9IFJpZ2h0QnV0 dG9uKQo= 353367 2018-10-30 08:03:16 -0700 2018-10-30 08:14:55 -0700 Patch bug-191067-20181030150315.patch text/plain 1946 jmason SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNzU4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE4LTEwLTMwICBKaW0gTWFz b24gIDxqbWFzb25AaWJpbnguY29tPgorCisgICAgICAgIFtHVEtdIFNjcm9sbGJhcnMgbm90IGZv bGxvd2luZyBndGstcHJpbWFyeS1idXR0b24td2FycHMtc2xpZGVyIHNldHRpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTA2NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Nj cm9sbGJhclRoZW1lR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lR3Rr OjpoYW5kbGVNb3VzZVByZXNzRXZlbnQpOgorCiAyMDE4LTEwLTI5ICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWlzc2luZyBmcm9tIHIyMzc1NDkKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0ay5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmNwcAko cmV2aXNpb24gMjM3NTgzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJh clRoZW1lR3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzcyLDEzICs3NzIsMTggQEAgYm9vbCBT Y3JvbGxiYXJUaGVtZUd0azo6cGFpbnQoU2Nyb2xsYmFyJgogCiBTY3JvbGxiYXJCdXR0b25QcmVz c0FjdGlvbiBTY3JvbGxiYXJUaGVtZUd0azo6aGFuZGxlTW91c2VQcmVzc0V2ZW50KFNjcm9sbGJh ciYsIGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYgZXZlbnQsIFNjcm9sbGJhclBhcnQgcHJlc3Nl ZFBhcnQpCiB7CisgICAgZ2Jvb2xlYW4gd2FycF9zbGlkZXIgPSBGQUxTRTsKICAgICBzd2l0Y2gg KHByZXNzZWRQYXJ0KSB7CiAgICAgY2FzZSBCYWNrVHJhY2tQYXJ0OgogICAgIGNhc2UgRm9yd2Fy ZFRyYWNrUGFydDoKLSAgICAgICAgaWYgKGV2ZW50LmJ1dHRvbigpID09IExlZnRCdXR0b24pCi0g ICAgICAgICAgICByZXR1cm4gU2Nyb2xsYmFyQnV0dG9uUHJlc3NBY3Rpb246OkNlbnRlck9uVGh1 bWI7Ci0gICAgICAgIGlmIChldmVudC5idXR0b24oKSA9PSBSaWdodEJ1dHRvbikKLSAgICAgICAg ICAgIHJldHVybiBTY3JvbGxiYXJCdXR0b25QcmVzc0FjdGlvbjo6U2Nyb2xsOworICAgICAgICBn X29iamVjdF9nZXQoZ3RrX3NldHRpbmdzX2dldF9kZWZhdWx0KCksCisgICAgICAgICAgICAgICAg ICAgICJndGstcHJpbWFyeS1idXR0b24td2FycHMtc2xpZGVyIiwKKyAgICAgICAgICAgICAgICAg ICAgJndhcnBfc2xpZGVyLCBudWxscHRyKTsKKyAgICAgICAgLy8gc2hpZnQga2V5IG9yIG1pZGRs ZS9yaWdodCBidXR0b24gcmV2ZXJzZXMgc2Vuc2Ugb2Ygc2V0dGluZworICAgICAgICByZXR1cm4g d2FycF9zbGlkZXIgXiAoZXZlbnQuc2hpZnRLZXkoKQorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8fCBldmVudC5idXR0b24oKSAhPSBMZWZ0QnV0dG9uKT8KKyAgICAgICAgICAgICAg ICBTY3JvbGxiYXJCdXR0b25QcmVzc0FjdGlvbjo6Q2VudGVyT25UaHVtYjoKKyAgICAgICAgICAg ICAgICBTY3JvbGxiYXJCdXR0b25QcmVzc0FjdGlvbjo6U2Nyb2xsOwogICAgICAgICBicmVhazsK ICAgICBjYXNlIFRodW1iUGFydDoKICAgICAgICAgaWYgKGV2ZW50LmJ1dHRvbigpICE9IFJpZ2h0 QnV0dG9uKQo= 353369 2018-10-30 08:15:01 -0700 2018-10-30 11:11:24 -0700 Patch bug-191067-20181030151459.patch text/plain 1902 jmason SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNzU4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE4LTEwLTMwICBKaW0gTWFz b24gIDxqbWFzb25AaWJpbnguY29tPgorCisgICAgICAgIFtHVEtdIFNjcm9sbGJhcnMgbm90IGZv bGxvd2luZyBndGstcHJpbWFyeS1idXR0b24td2FycHMtc2xpZGVyIHNldHRpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTA2NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Nj cm9sbGJhclRoZW1lR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lR3Rr OjpoYW5kbGVNb3VzZVByZXNzRXZlbnQpOgorCiAyMDE4LTEwLTI5ICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWlzc2luZyBmcm9tIHIyMzc1NDkKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0ay5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmNwcAko cmV2aXNpb24gMjM3NTgzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJh clRoZW1lR3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzcyLDEzICs3NzIsMTggQEAgYm9vbCBT Y3JvbGxiYXJUaGVtZUd0azo6cGFpbnQoU2Nyb2xsYmFyJgogCiBTY3JvbGxiYXJCdXR0b25QcmVz c0FjdGlvbiBTY3JvbGxiYXJUaGVtZUd0azo6aGFuZGxlTW91c2VQcmVzc0V2ZW50KFNjcm9sbGJh ciYsIGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYgZXZlbnQsIFNjcm9sbGJhclBhcnQgcHJlc3Nl ZFBhcnQpCiB7CisgICAgZ2Jvb2xlYW4gd2FycF9zbGlkZXIgPSBGQUxTRTsKICAgICBzd2l0Y2gg KHByZXNzZWRQYXJ0KSB7CiAgICAgY2FzZSBCYWNrVHJhY2tQYXJ0OgogICAgIGNhc2UgRm9yd2Fy ZFRyYWNrUGFydDoKLSAgICAgICAgaWYgKGV2ZW50LmJ1dHRvbigpID09IExlZnRCdXR0b24pCi0g ICAgICAgICAgICByZXR1cm4gU2Nyb2xsYmFyQnV0dG9uUHJlc3NBY3Rpb246OkNlbnRlck9uVGh1 bWI7Ci0gICAgICAgIGlmIChldmVudC5idXR0b24oKSA9PSBSaWdodEJ1dHRvbikKLSAgICAgICAg ICAgIHJldHVybiBTY3JvbGxiYXJCdXR0b25QcmVzc0FjdGlvbjo6U2Nyb2xsOworICAgICAgICBn X29iamVjdF9nZXQoZ3RrX3NldHRpbmdzX2dldF9kZWZhdWx0KCksCisgICAgICAgICAgICAiZ3Rr LXByaW1hcnktYnV0dG9uLXdhcnBzLXNsaWRlciIsCisgICAgICAgICAgICAmd2FycF9zbGlkZXIs IG51bGxwdHIpOworICAgICAgICAvLyBzaGlmdCBrZXkgb3IgbWlkZGxlL3JpZ2h0IGJ1dHRvbiBy ZXZlcnNlcyBzZW5zZSBvZiBzZXR0aW5nCisgICAgICAgIHJldHVybiB3YXJwX3NsaWRlciBeIChl dmVudC5zaGlmdEtleSgpCisgICAgICAgICAgICB8fCBldmVudC5idXR0b24oKSAhPSBMZWZ0QnV0 dG9uKT8KKyAgICAgICAgICAgIFNjcm9sbGJhckJ1dHRvblByZXNzQWN0aW9uOjpDZW50ZXJPblRo dW1iOgorICAgICAgICAgICAgU2Nyb2xsYmFyQnV0dG9uUHJlc3NBY3Rpb246OlNjcm9sbDsKICAg ICAgICAgYnJlYWs7CiAgICAgY2FzZSBUaHVtYlBhcnQ6CiAgICAgICAgIGlmIChldmVudC5idXR0 b24oKSAhPSBSaWdodEJ1dHRvbikK 353387 2018-10-30 11:11:29 -0700 2018-10-30 11:17:25 -0700 Patch bug-191067-20181030181128.patch text/plain 1938 jmason SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNzU4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE4LTEwLTMwICBKaW0gTWFz b24gIDxqbWFzb25AaWJpbnguY29tPgorCisgICAgICAgIFtHVEtdIFNjcm9sbGJhcnMgbm90IGZv bGxvd2luZyBndGstcHJpbWFyeS1idXR0b24td2FycHMtc2xpZGVyIHNldHRpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTA2NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Nj cm9sbGJhclRoZW1lR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lR3Rr OjpoYW5kbGVNb3VzZVByZXNzRXZlbnQpOgorCiAyMDE4LTEwLTI5ICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWlzc2luZyBmcm9tIHIyMzc1NDkKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0ay5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmNwcAko cmV2aXNpb24gMjM3NTgzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJh clRoZW1lR3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzcyLDEzICs3NzIsMTkgQEAgYm9vbCBT Y3JvbGxiYXJUaGVtZUd0azo6cGFpbnQoU2Nyb2xsYmFyJgogCiBTY3JvbGxiYXJCdXR0b25QcmVz c0FjdGlvbiBTY3JvbGxiYXJUaGVtZUd0azo6aGFuZGxlTW91c2VQcmVzc0V2ZW50KFNjcm9sbGJh ciYsIGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYgZXZlbnQsIFNjcm9sbGJhclBhcnQgcHJlc3Nl ZFBhcnQpCiB7CisgICAgZ2Jvb2xlYW4gd2FycF9zbGlkZXIgPSBGQUxTRTsKICAgICBzd2l0Y2gg KHByZXNzZWRQYXJ0KSB7CiAgICAgY2FzZSBCYWNrVHJhY2tQYXJ0OgogICAgIGNhc2UgRm9yd2Fy ZFRyYWNrUGFydDoKLSAgICAgICAgaWYgKGV2ZW50LmJ1dHRvbigpID09IExlZnRCdXR0b24pCi0g ICAgICAgICAgICByZXR1cm4gU2Nyb2xsYmFyQnV0dG9uUHJlc3NBY3Rpb246OkNlbnRlck9uVGh1 bWI7Ci0gICAgICAgIGlmIChldmVudC5idXR0b24oKSA9PSBSaWdodEJ1dHRvbikKLSAgICAgICAg ICAgIHJldHVybiBTY3JvbGxiYXJCdXR0b25QcmVzc0FjdGlvbjo6U2Nyb2xsOworICAgICAgICBn X29iamVjdF9nZXQoZ3RrX3NldHRpbmdzX2dldF9kZWZhdWx0KCksCisgICAgICAgICAgICAiZ3Rr LXByaW1hcnktYnV0dG9uLXdhcnBzLXNsaWRlciIsCisgICAgICAgICAgICAmd2FycF9zbGlkZXIs IG51bGxwdHIpOworICAgICAgICAvLyBUaGUgc2hpZnQga2V5IG9yIG1pZGRsZS9yaWdodCBidXR0 b24gcmV2ZXJzZXMgdGhlIHNlbnNlLgorICAgICAgICBpZiAoZXZlbnQuc2hpZnRLZXkoKSB8fCBl dmVudC5idXR0b24oKSAhPSBMZWZ0QnV0dG9uKQorICAgICAgICAgICAgd2FycF9zbGlkZXIgPSAh d2FycF9zbGlkZXI7CisgICAgICAgIHJldHVybiB3YXJwX3NsaWRlcj8KKyAgICAgICAgICAgIFNj cm9sbGJhckJ1dHRvblByZXNzQWN0aW9uOjpDZW50ZXJPblRodW1iOgorICAgICAgICAgICAgU2Ny b2xsYmFyQnV0dG9uUHJlc3NBY3Rpb246OlNjcm9sbDsKICAgICAgICAgYnJlYWs7CiAgICAgY2Fz ZSBUaHVtYlBhcnQ6CiAgICAgICAgIGlmIChldmVudC5idXR0b24oKSAhPSBSaWdodEJ1dHRvbikK 353389 2018-10-30 11:17:30 -0700 2018-11-23 09:10:16 -0800 Patch bug-191067-20181030181729.patch text/plain 1939 jmason SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNzU4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE4LTEwLTMwICBKaW0gTWFz b24gIDxqbWFzb25AaWJpbnguY29tPgorCisgICAgICAgIFtHVEtdIFNjcm9sbGJhcnMgbm90IGZv bGxvd2luZyBndGstcHJpbWFyeS1idXR0b24td2FycHMtc2xpZGVyIHNldHRpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTA2NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Nj cm9sbGJhclRoZW1lR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lR3Rr OjpoYW5kbGVNb3VzZVByZXNzRXZlbnQpOgorCiAyMDE4LTEwLTI5ICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWlzc2luZyBmcm9tIHIyMzc1NDkKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0ay5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmNwcAko cmV2aXNpb24gMjM3NTgzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJh clRoZW1lR3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzcyLDEzICs3NzIsMTkgQEAgYm9vbCBT Y3JvbGxiYXJUaGVtZUd0azo6cGFpbnQoU2Nyb2xsYmFyJgogCiBTY3JvbGxiYXJCdXR0b25QcmVz c0FjdGlvbiBTY3JvbGxiYXJUaGVtZUd0azo6aGFuZGxlTW91c2VQcmVzc0V2ZW50KFNjcm9sbGJh ciYsIGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYgZXZlbnQsIFNjcm9sbGJhclBhcnQgcHJlc3Nl ZFBhcnQpCiB7CisgICAgZ2Jvb2xlYW4gd2FycF9zbGlkZXIgPSBGQUxTRTsKICAgICBzd2l0Y2gg KHByZXNzZWRQYXJ0KSB7CiAgICAgY2FzZSBCYWNrVHJhY2tQYXJ0OgogICAgIGNhc2UgRm9yd2Fy ZFRyYWNrUGFydDoKLSAgICAgICAgaWYgKGV2ZW50LmJ1dHRvbigpID09IExlZnRCdXR0b24pCi0g ICAgICAgICAgICByZXR1cm4gU2Nyb2xsYmFyQnV0dG9uUHJlc3NBY3Rpb246OkNlbnRlck9uVGh1 bWI7Ci0gICAgICAgIGlmIChldmVudC5idXR0b24oKSA9PSBSaWdodEJ1dHRvbikKLSAgICAgICAg ICAgIHJldHVybiBTY3JvbGxiYXJCdXR0b25QcmVzc0FjdGlvbjo6U2Nyb2xsOworICAgICAgICBn X29iamVjdF9nZXQoZ3RrX3NldHRpbmdzX2dldF9kZWZhdWx0KCksCisgICAgICAgICAgICAiZ3Rr LXByaW1hcnktYnV0dG9uLXdhcnBzLXNsaWRlciIsCisgICAgICAgICAgICAmd2FycF9zbGlkZXIs IG51bGxwdHIpOworICAgICAgICAvLyBUaGUgc2hpZnQga2V5IG9yIG1pZGRsZS9yaWdodCBidXR0 b24gcmV2ZXJzZXMgdGhlIHNlbnNlLgorICAgICAgICBpZiAoZXZlbnQuc2hpZnRLZXkoKSB8fCBl dmVudC5idXR0b24oKSAhPSBMZWZ0QnV0dG9uKQorICAgICAgICAgICAgd2FycF9zbGlkZXIgPSAh d2FycF9zbGlkZXI7CisgICAgICAgIHJldHVybiB3YXJwX3NsaWRlciA/CisgICAgICAgICAgICBT Y3JvbGxiYXJCdXR0b25QcmVzc0FjdGlvbjo6Q2VudGVyT25UaHVtYjoKKyAgICAgICAgICAgIFNj cm9sbGJhckJ1dHRvblByZXNzQWN0aW9uOjpTY3JvbGw7CiAgICAgICAgIGJyZWFrOwogICAgIGNh c2UgVGh1bWJQYXJ0OgogICAgICAgICBpZiAoZXZlbnQuYnV0dG9uKCkgIT0gUmlnaHRCdXR0b24p Cg== 355518 2018-11-23 09:10:24 -0800 2018-11-23 09:14:39 -0800 Patch bug-191067-20181123171023.patch text/plain 2078 jmason SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzODQ1OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTExLTIzICBKaW0gTWFz b24gIDxqbWFzb25AaWJpbnguY29tPgorCisgICAgICAgIFtHVEtdIFNjcm9sbGJhcnMgbm90IGZv bGxvd2luZyBndGstcHJpbWFyeS1idXR0b24td2FycHMtc2xpZGVyIHNldHRpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTA2NworCisgICAgICAg IFVwZGF0ZWQgY29kZSBwZXIgdGhlIHN0eWxlIGd1aWRlLCByZW1vdmVkIHVucmVhY2hhYmxlIGJy ZWFrIChub24tc2VtYW50aWMgY2hhbmdlKQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoT09QUyEpLgorCisgICAgICAgICogcGxh dGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9s bGJhclRoZW1lR3RrOjpoYW5kbGVNb3VzZVByZXNzRXZlbnQpOgorCiAyMDE4LTExLTIzICBBbnR0 aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBVSSBzaWRlIGNvbXBvc2l0 aW5nIGRvZXNuJ3QgcGFpbnQgb24gTWFjCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvU2Nyb2xsYmFyVGhlbWVHdGsuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0ay5jcHAJKHJldmlzaW9uIDIzODQ1NikKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0ay5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTc3MiwyMCArNzcyLDE5IEBAIGJvb2wgU2Nyb2xsYmFyVGhlbWVHdGs6OnBhaW50 KFNjcm9sbGJhciYKIAogU2Nyb2xsYmFyQnV0dG9uUHJlc3NBY3Rpb24gU2Nyb2xsYmFyVGhlbWVH dGs6OmhhbmRsZU1vdXNlUHJlc3NFdmVudChTY3JvbGxiYXImLCBjb25zdCBQbGF0Zm9ybU1vdXNl RXZlbnQmIGV2ZW50LCBTY3JvbGxiYXJQYXJ0IHByZXNzZWRQYXJ0KQogewotICAgIGdib29sZWFu IHdhcnBfc2xpZGVyID0gRkFMU0U7CisgICAgZ2Jvb2xlYW4gd2FycFNsaWRlciA9IEZBTFNFOwog ICAgIHN3aXRjaCAocHJlc3NlZFBhcnQpIHsKICAgICBjYXNlIEJhY2tUcmFja1BhcnQ6CiAgICAg Y2FzZSBGb3J3YXJkVHJhY2tQYXJ0OgogICAgICAgICBnX29iamVjdF9nZXQoZ3RrX3NldHRpbmdz X2dldF9kZWZhdWx0KCksCiAgICAgICAgICAgICAiZ3RrLXByaW1hcnktYnV0dG9uLXdhcnBzLXNs aWRlciIsCi0gICAgICAgICAgICAmd2FycF9zbGlkZXIsIG51bGxwdHIpOworICAgICAgICAgICAg JndhcnBTbGlkZXIsIG51bGxwdHIpOwogICAgICAgICAvLyBUaGUgc2hpZnQga2V5IG9yIG1pZGRs ZS9yaWdodCBidXR0b24gcmV2ZXJzZXMgdGhlIHNlbnNlLgogICAgICAgICBpZiAoZXZlbnQuc2hp ZnRLZXkoKSB8fCBldmVudC5idXR0b24oKSAhPSBMZWZ0QnV0dG9uKQotICAgICAgICAgICAgd2Fy cF9zbGlkZXIgPSAhd2FycF9zbGlkZXI7Ci0gICAgICAgIHJldHVybiB3YXJwX3NsaWRlciA/Cisg ICAgICAgICAgICB3YXJwU2xpZGVyID0gIXdhcnBTbGlkZXI7CisgICAgICAgIHJldHVybiB3YXJw U2xpZGVyID8KICAgICAgICAgICAgIFNjcm9sbGJhckJ1dHRvblByZXNzQWN0aW9uOjpDZW50ZXJP blRodW1iOgogICAgICAgICAgICAgU2Nyb2xsYmFyQnV0dG9uUHJlc3NBY3Rpb246OlNjcm9sbDsK LSAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBUaHVtYlBhcnQ6CiAgICAgICAgIGlmIChldmVudC5i dXR0b24oKSAhPSBSaWdodEJ1dHRvbikKICAgICAgICAgICAgIHJldHVybiBTY3JvbGxiYXJCdXR0 b25QcmVzc0FjdGlvbjo6U3RhcnREcmFnOwo= 355519 2018-11-23 09:14:45 -0800 2018-11-23 11:45:59 -0800 Patch bug-191067-20181123171443.patch text/plain 2045 jmason SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzODQ1OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTExLTIzICBKaW0gTWFz b24gIDxqbWFzb25AaWJpbnguY29tPgorCisgICAgICAgIFtHVEtdIFNjcm9sbGJhcnMgbm90IGZv bGxvd2luZyBndGstcHJpbWFyeS1idXR0b24td2FycHMtc2xpZGVyIHNldHRpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTA2NworCisgICAgICAg IFVwZGF0ZWQgY29kZSBwZXIgdGhlIHN0eWxlIGd1aWRlLCByZW1vdmVkIHVucmVhY2hhYmxlIGJy ZWFrIChub24tc2VtYW50aWMgY2hhbmdlKQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lR3RrOjpoYW5kbGVNb3VzZVByZXNzRXZl bnQpOgorCiAyMDE4LTExLTIzICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAog ICAgICAgICBVSSBzaWRlIGNvbXBvc2l0aW5nIGRvZXNuJ3QgcGFpbnQgb24gTWFjCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsYmFyVGhlbWVHdGsuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVtZUd0ay5jcHAJ KHJldmlzaW9uIDIzODQ1NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxi YXJUaGVtZUd0ay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc3MiwyMCArNzcyLDE5IEBAIGJvb2wg U2Nyb2xsYmFyVGhlbWVHdGs6OnBhaW50KFNjcm9sbGJhciYKIAogU2Nyb2xsYmFyQnV0dG9uUHJl c3NBY3Rpb24gU2Nyb2xsYmFyVGhlbWVHdGs6OmhhbmRsZU1vdXNlUHJlc3NFdmVudChTY3JvbGxi YXImLCBjb25zdCBQbGF0Zm9ybU1vdXNlRXZlbnQmIGV2ZW50LCBTY3JvbGxiYXJQYXJ0IHByZXNz ZWRQYXJ0KQogewotICAgIGdib29sZWFuIHdhcnBfc2xpZGVyID0gRkFMU0U7CisgICAgZ2Jvb2xl YW4gd2FycFNsaWRlciA9IEZBTFNFOwogICAgIHN3aXRjaCAocHJlc3NlZFBhcnQpIHsKICAgICBj YXNlIEJhY2tUcmFja1BhcnQ6CiAgICAgY2FzZSBGb3J3YXJkVHJhY2tQYXJ0OgogICAgICAgICBn X29iamVjdF9nZXQoZ3RrX3NldHRpbmdzX2dldF9kZWZhdWx0KCksCiAgICAgICAgICAgICAiZ3Rr LXByaW1hcnktYnV0dG9uLXdhcnBzLXNsaWRlciIsCi0gICAgICAgICAgICAmd2FycF9zbGlkZXIs IG51bGxwdHIpOworICAgICAgICAgICAgJndhcnBTbGlkZXIsIG51bGxwdHIpOwogICAgICAgICAv LyBUaGUgc2hpZnQga2V5IG9yIG1pZGRsZS9yaWdodCBidXR0b24gcmV2ZXJzZXMgdGhlIHNlbnNl LgogICAgICAgICBpZiAoZXZlbnQuc2hpZnRLZXkoKSB8fCBldmVudC5idXR0b24oKSAhPSBMZWZ0 QnV0dG9uKQotICAgICAgICAgICAgd2FycF9zbGlkZXIgPSAhd2FycF9zbGlkZXI7Ci0gICAgICAg IHJldHVybiB3YXJwX3NsaWRlciA/CisgICAgICAgICAgICB3YXJwU2xpZGVyID0gIXdhcnBTbGlk ZXI7CisgICAgICAgIHJldHVybiB3YXJwU2xpZGVyID8KICAgICAgICAgICAgIFNjcm9sbGJhckJ1 dHRvblByZXNzQWN0aW9uOjpDZW50ZXJPblRodW1iOgogICAgICAgICAgICAgU2Nyb2xsYmFyQnV0 dG9uUHJlc3NBY3Rpb246OlNjcm9sbDsKLSAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBUaHVtYlBh cnQ6CiAgICAgICAgIGlmIChldmVudC5idXR0b24oKSAhPSBSaWdodEJ1dHRvbikKICAgICAgICAg ICAgIHJldHVybiBTY3JvbGxiYXJCdXR0b25QcmVzc0FjdGlvbjo6U3RhcnREcmFnOwo=