191063 2018-10-30 05:10:17 -0700 Static global 'fastHandlerInstalled' conditionally declared in WasmFaultSignalHandler.cpp 2018-10-31 03:12:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jmason webkit-unassigned commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1473227 0 jmason 2018-10-30 05:10:17 -0700 The static global variable 'fastHandlerInstalled' is declared inside an #if block in WasmFaultSignalHandler.cpp, but referenced later outside it. This results in a compilation error when the #if condition is not met. In this specific case, the combination of conditions which result in the error are ENABLE(WEBASSEMBLY) and !ENABLE(WEBASSEMBLY_FAST_MEMORY). Rescoping the declaration outside the #if block resolves the problem. 1473233 1 353362 jmason 2018-10-30 05:22:42 -0700 Created attachment 353362 Patch 1473234 2 353362 ysuzuki 2018-10-30 05:30:51 -0700 Comment on attachment 353362 Patch r=me 1473637 3 jmason 2018-10-31 02:22:11 -0700 Closed by mistake. Reopening for commit bot. 1473654 4 commit-queue 2018-10-31 03:10:04 -0700 The commit-queue encountered the following flaky tests while processing attachment 353362: http/wpt/css/css-animations/start-animation-001.html bug 190903 (authors: dino@apple.com, fred.wang@free.fr, and graouts@apple.com) The commit-queue is continuing to process your patch. 1473655 5 353362 commit-queue 2018-10-31 03:10:53 -0700 Comment on attachment 353362 Patch Clearing flags on attachment: 353362 Committed r237630: <https://trac.webkit.org/changeset/237630> 1473656 6 commit-queue 2018-10-31 03:10:55 -0700 All reviewed patches have been landed. Closing bug. 1473657 7 webkit-bug-importer 2018-10-31 03:12:38 -0700 <rdar://problem/45696235> 353362 2018-10-30 05:22:42 -0700 2018-10-31 03:10:53 -0700 Patch bug-191063-20181030122241.patch text/plain 1394 jmason SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM3NTgzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDE4LTEwLTMwICBKaW0gTWFzb24gIDxqbWFzb25AaWJpbnguY29tPgorCisgICAgICAgIFN0 YXRpYyBnbG9iYWwgJ2Zhc3RIYW5kbGVySW5zdGFsbGVkJyBjb25kaXRpb25hbGx5IGRlY2xhcmVk IGluIFdhc21GYXVsdFNpZ25hbEhhbmRsZXIuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEwNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHdhc20vV2FzbUZhdWx0U2lnbmFsSGFuZGxlci5jcHA6 CisKIDIwMTgtMTAtMjkgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAg IENvcnJlY3RseSBkZXRlY3Qgc3RyaW5nIG92ZXJmbG93IHdoZW4gdXNpbmcgdGhlICdGdW5jdGlv bicgY29uc3RydWN0b3IuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtRmF1 bHRTaWduYWxIYW5kbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv d2FzbS9XYXNtRmF1bHRTaWduYWxIYW5kbGVyLmNwcAkocmV2aXNpb24gMjM3NTgzKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUZhdWx0U2lnbmFsSGFuZGxlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTUwLDEwICs1MCwxMCBAQCBzdGF0aWMgY29uc3QgYm9vbCB2ZXJib3NlID0g ZmFsc2U7CiBzdGF0aWMgTG9jayBjb2RlTG9jYXRpb25zTG9jazsKIHN0YXRpYyBMYXp5TmV2ZXJE ZXN0cm95ZWQ8SGFzaFNldDxzdGQ6OnR1cGxlPHZvaWQqLCB2b2lkKj4+PiBjb2RlTG9jYXRpb25z OyAvLyAoc3RhcnQsIGVuZCkKIAotI2lmIEVOQUJMRShXRUJBU1NFTUJMWV9GQVNUX01FTU9SWSkK LQogc3RhdGljIGJvb2wgZmFzdEhhbmRsZXJJbnN0YWxsZWQgeyBmYWxzZSB9OwogCisjaWYgRU5B QkxFKFdFQkFTU0VNQkxZX0ZBU1RfTUVNT1JZKQorCiBzdGF0aWMgU2lnbmFsQWN0aW9uIHRyYXBI YW5kbGVyKFNpZ25hbCwgU2lnSW5mbyYgc2lnSW5mbywgUGxhdGZvcm1SZWdpc3RlcnMmIGNvbnRl eHQpCiB7CiAgICAgYXV0byBpbnN0cnVjdGlvblBvaW50ZXIgPSBNYWNoaW5lQ29udGV4dDo6aW5z dHJ1Y3Rpb25Qb2ludGVyKGNvbnRleHQpOwo=