191049 2018-10-29 16:44:45 -0700 Move 'ProcessSwapOnCrossSiteNavigationEnabled' to 'experimental' category. 2018-10-30 17:38:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dewei_zhu webkit-unassigned cdumez commit-queue dewei_zhu dino simon.fraser webkit-bug-importer oldest_to_newest 1473115 0 dewei_zhu 2018-10-29 16:44:45 -0700 Move 'ProcessSwapOnCrossSiteNavigationEnabled' to 'experimental' category. 1473116 1 353333 dewei_zhu 2018-10-29 16:45:51 -0700 Created attachment 353333 Patch 1473118 2 353333 cdumez 2018-10-29 16:48:07 -0700 Comment on attachment 353333 Patch r=me 1473119 3 353333 cdumez 2018-10-29 16:49:29 -0700 Comment on attachment 353333 Patch Clearing flags on attachment: 353333 Committed r237573: <https://trac.webkit.org/changeset/237573> 1473120 4 cdumez 2018-10-29 16:49:30 -0700 All reviewed patches have been landed. Closing bug. 1473121 5 dewei_zhu 2018-10-29 16:50:08 -0700 Reopening to attach new patch. 1473122 6 353334 dewei_zhu 2018-10-29 16:50:09 -0700 Created attachment 353334 Patch for landing 1473123 7 webkit-bug-importer 2018-10-29 16:50:32 -0700 <rdar://problem/45654625> 1473124 8 353334 commit-queue 2018-10-29 16:51:39 -0700 Comment on attachment 353334 Patch for landing Rejecting attachment 353334 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 353334, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=353334&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=191049&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 353334 from bug 191049. Fetching: https://bugs.webkit.org/attachment.cgi?id=353334 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/Shared/WebPreferences.yaml Hunk #1 FAILED at 1350. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Shared/WebPreferences.yaml.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/9773376 1473126 9 cdumez 2018-10-29 16:53:26 -0700 I already landed it in https://trac.webkit.org/changeset/237573 1473292 10 353334 dino 2018-10-30 10:22:28 -0700 Comment on attachment 353334 Patch for landing Could you also move the entire feature into the section with other experimental features? (A few lines above this) 1473334 11 dewei_zhu 2018-10-30 11:28:13 -0700 Will do in a followup fix. 1473524 12 dewei_zhu 2018-10-30 17:17:49 -0700 Reopening to attach new patch. 1473525 13 353445 dewei_zhu 2018-10-30 17:17:50 -0700 Created attachment 353445 Patch 1473530 14 353445 dino 2018-10-30 17:31:23 -0700 Comment on attachment 353445 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353445&action=review > Source/WebKit/Shared/WebPreferences.yaml:1340 > +type: bool > +defaultValue: false > +humanReadableName: "Swap Processes on Cross-Site Navigation" > +humanReadableDescription: "Swap WebContent processes on cross-site navigations" > +category: experimental > +webcoreBinding: none Nit: indentation. 1473531 15 353445 dewei_zhu 2018-10-30 17:34:19 -0700 Comment on attachment 353445 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353445&action=review >> Source/WebKit/Shared/WebPreferences.yaml:1340 >> +webcoreBinding: none > > Nit: indentation. Nice catch. Tricked by Xcode. 1473534 16 dewei_zhu 2018-10-30 17:38:19 -0700 Landed in r237611. 353333 2018-10-29 16:45:51 -0700 2018-10-29 16:50:06 -0700 Patch bug-191049-20181029164550.patch text/plain 1386 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJjOGYyNGI2MzBlMmRkOTlm NzlhMTFiMTk1YTEwMWQzODBmMGRmY2UuLjAxNjQzZjU4NDZiYmFjODQ1ZGQ0ZmRlODIxZTgyYWYy NDczNWU0YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTAtMjkgIERld2VpIFpo dSAgPGRld2VpX3podUBhcHBsZS5jb20+CisKKyAgICAgICAgTW92ZSAnUHJvY2Vzc1N3YXBPbkNy b3NzU2l0ZU5hdmlnYXRpb25FbmFibGVkJyB0byAnZXhwZXJpbWVudGFsJyBjYXRlZ29yeS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTA0OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgJ1Byb2Nl c3NTd2FwT25Dcm9zc1NpdGVOYXZpZ2F0aW9uRW5hYmxlZCcgZnJvbSAnaW50ZXJuYWwnIHRvICdl eHBlcmltZW50YWwnIGNhdGVnb3J5LgorCisgICAgICAgICogU2hhcmVkL1dlYlByZWZlcmVuY2Vz LnlhbWw6CisKIDIwMTgtMTAtMjkgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgog CiAgICAgICAgIEhhbmRsZSBNRE5TIHJlc29sdXRpb24gb2YgY2FuZGlkYXRlcyB0aHJvdWdoIGxp YndlYnJ0YyBkaXJlY3RseQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJl ZmVyZW5jZXMueWFtbCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwK aW5kZXggZDBlMjAxMGU4YWVkM2IwZDY1YzRkYjU2ZjZiMmNhNTZmYzViYTAyZC4uZjFkNDAxMzEy YmRjMmZjOTdiODFmNGVjMGNkNmY0ODE2NmZhMDA5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9X ZWJQcmVmZXJlbmNlcy55YW1sCkBAIC0xMzUwLDcgKzEzNTAsNyBAQCBQcm9jZXNzU3dhcE9uQ3Jv c3NTaXRlTmF2aWdhdGlvbkVuYWJsZWQ6CiAgIGRlZmF1bHRWYWx1ZTogZmFsc2UKICAgaHVtYW5S ZWFkYWJsZU5hbWU6ICJTd2FwIFByb2Nlc3NlcyBvbiBDcm9zcy1TaXRlIE5hdmlnYXRpb24iCiAg IGh1bWFuUmVhZGFibGVEZXNjcmlwdGlvbjogIlN3YXAgV2ViQ29udGVudCBwcm9jZXNzZXMgb24g Y3Jvc3Mtc2l0ZSBuYXZpZ2F0aW9ucyIKLSAgY2F0ZWdvcnk6IGludGVybmFsCisgIGNhdGVnb3J5 OiBleHBlcmltZW50YWwKICAgd2ViY29yZUJpbmRpbmc6IG5vbmUKIAogUmVzb3VyY2VMb2FkU3Rh dGlzdGljc0RlYnVnTW9kZToK 353334 2018-10-29 16:50:09 -0700 2018-10-30 17:17:47 -0700 Patch for landing bug-191049-20181029165009.patch text/plain 1386 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJjOGYyNGI2MzBlMmRkOTlm NzlhMTFiMTk1YTEwMWQzODBmMGRmY2UuLjAxNjQzZjU4NDZiYmFjODQ1ZGQ0ZmRlODIxZTgyYWYy NDczNWU0YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTAtMjkgIERld2VpIFpo dSAgPGRld2VpX3podUBhcHBsZS5jb20+CisKKyAgICAgICAgTW92ZSAnUHJvY2Vzc1N3YXBPbkNy b3NzU2l0ZU5hdmlnYXRpb25FbmFibGVkJyB0byAnZXhwZXJpbWVudGFsJyBjYXRlZ29yeS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTA0OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgJ1Byb2Nl c3NTd2FwT25Dcm9zc1NpdGVOYXZpZ2F0aW9uRW5hYmxlZCcgZnJvbSAnaW50ZXJuYWwnIHRvICdl eHBlcmltZW50YWwnIGNhdGVnb3J5LgorCisgICAgICAgICogU2hhcmVkL1dlYlByZWZlcmVuY2Vz LnlhbWw6CisKIDIwMTgtMTAtMjkgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgog CiAgICAgICAgIEhhbmRsZSBNRE5TIHJlc29sdXRpb24gb2YgY2FuZGlkYXRlcyB0aHJvdWdoIGxp YndlYnJ0YyBkaXJlY3RseQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJl ZmVyZW5jZXMueWFtbCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwK aW5kZXggZDBlMjAxMGU4YWVkM2IwZDY1YzRkYjU2ZjZiMmNhNTZmYzViYTAyZC4uZjFkNDAxMzEy YmRjMmZjOTdiODFmNGVjMGNkNmY0ODE2NmZhMDA5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9X ZWJQcmVmZXJlbmNlcy55YW1sCkBAIC0xMzUwLDcgKzEzNTAsNyBAQCBQcm9jZXNzU3dhcE9uQ3Jv c3NTaXRlTmF2aWdhdGlvbkVuYWJsZWQ6CiAgIGRlZmF1bHRWYWx1ZTogZmFsc2UKICAgaHVtYW5S ZWFkYWJsZU5hbWU6ICJTd2FwIFByb2Nlc3NlcyBvbiBDcm9zcy1TaXRlIE5hdmlnYXRpb24iCiAg IGh1bWFuUmVhZGFibGVEZXNjcmlwdGlvbjogIlN3YXAgV2ViQ29udGVudCBwcm9jZXNzZXMgb24g Y3Jvc3Mtc2l0ZSBuYXZpZ2F0aW9ucyIKLSAgY2F0ZWdvcnk6IGludGVybmFsCisgIGNhdGVnb3J5 OiBleHBlcmltZW50YWwKICAgd2ViY29yZUJpbmRpbmc6IG5vbmUKIAogUmVzb3VyY2VMb2FkU3Rh dGlzdGljc0RlYnVnTW9kZToK 353445 2018-10-30 17:17:50 -0700 2018-10-30 17:31:23 -0700 Patch bug-191049-20181030171749.patch text/plain 2034 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NjA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVlNTg5MDFkZDNiNGRiZDEy YjYwNjk4MzVjYWZjZDkwYWFhMWVlYzQuLjEzMjE1YzhjNmE3YzE5NGY0ODE1ODNlZTQ3Yjc3NjQ0 ZDU0NWMxNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTAtMzAgIERld2VpIFpo dSAgPGRld2VpX3podUBhcHBsZS5jb20+CisKKyAgICAgICAgTW92ZSAnUHJvY2Vzc1N3YXBPbkNy b3NzU2l0ZU5hdmlnYXRpb25FbmFibGVkJyB0byAnZXhwZXJpbWVudGFsJyBjYXRlZ29yeS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MTA0OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgdGhlIGZl YXR1cmUgZmxhZyB0byBleHBlcmltZW50YWwgZmVhdHVyZSBzZWN0aW9uLgorCisgICAgICAgICog U2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWw6CisKIDIwMTgtMTAtMzAgIEFsZXhleSBQcm9za3Vy eWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgc29tZSBvYnNvbGV0ZSBN QVhfQUxMT1dFRCBtYWNyb3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlBy ZWZlcmVuY2VzLnlhbWwgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1s CmluZGV4IGYxZDQwMTMxMmJkYzJmYzk3YjgxZjRlYzBjZDZmNDgxNjZmYTAwOTMuLjBkNTIyZjZj ZWM0NTEwNWVjOTcwNzA1YTVhMmJiNTBjMWY0NTg1ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQv V2ViUHJlZmVyZW5jZXMueWFtbApAQCAtMTMzMSw2ICsxMzMxLDE0IEBAIFdlYlNRTERpc2FibGVk OgogICB3ZWJjb3JlQmluZGluZzogUnVudGltZUVuYWJsZWRGZWF0dXJlcwogICBjYXRlZ29yeTog ZXhwZXJpbWVudGFsCiAKK1Byb2Nlc3NTd2FwT25Dcm9zc1NpdGVOYXZpZ2F0aW9uRW5hYmxlZDoK K3R5cGU6IGJvb2wKK2RlZmF1bHRWYWx1ZTogZmFsc2UKK2h1bWFuUmVhZGFibGVOYW1lOiAiU3dh cCBQcm9jZXNzZXMgb24gQ3Jvc3MtU2l0ZSBOYXZpZ2F0aW9uIgoraHVtYW5SZWFkYWJsZURlc2Ny aXB0aW9uOiAiU3dhcCBXZWJDb250ZW50IHByb2Nlc3NlcyBvbiBjcm9zcy1zaXRlIG5hdmlnYXRp b25zIgorY2F0ZWdvcnk6IGV4cGVyaW1lbnRhbAord2ViY29yZUJpbmRpbmc6IG5vbmUKKwogIyBG b3IgaW50ZXJuYWwgZmVhdHVyZXM6CiAjIFRoZSB0eXBlIHNob3VsZCBiZSBib29sZWFuLgogIyBZ b3UgbXVzdCBwcm92aWRlIGEgaHVtYW5SZWFkYWJsZU5hbWUgYW5kIGh1bWFuUmVhZGFibGVEZXNj cmlwdGlvbiBmb3IgYWxsIGRlYnVnIGZlYXR1cmVzLiBUaGV5CkBAIC0xMzQ1LDE0ICsxMzUzLDYg QEAgRXhwZXJpbWVudGFsUGx1Z0luU2FuZGJveFByb2ZpbGVzRW5hYmxlZDoKICAgd2ViY29yZUJp bmRpbmc6IFJ1bnRpbWVFbmFibGVkRmVhdHVyZXMKICAgd2ViY29yZU5hbWU6IGV4cGVyaW1lbnRh bFBsdWdJblNhbmRib3hQcm9maWxlc0VuYWJsZWQKIAotUHJvY2Vzc1N3YXBPbkNyb3NzU2l0ZU5h dmlnYXRpb25FbmFibGVkOgotICB0eXBlOiBib29sCi0gIGRlZmF1bHRWYWx1ZTogZmFsc2UKLSAg aHVtYW5SZWFkYWJsZU5hbWU6ICJTd2FwIFByb2Nlc3NlcyBvbiBDcm9zcy1TaXRlIE5hdmlnYXRp b24iCi0gIGh1bWFuUmVhZGFibGVEZXNjcmlwdGlvbjogIlN3YXAgV2ViQ29udGVudCBwcm9jZXNz ZXMgb24gY3Jvc3Mtc2l0ZSBuYXZpZ2F0aW9ucyIKLSAgY2F0ZWdvcnk6IGV4cGVyaW1lbnRhbAot ICB3ZWJjb3JlQmluZGluZzogbm9uZQotCiBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGVidWdNb2Rl OgogICB0eXBlOiBib29sCiAgIGRlZmF1bHRWYWx1ZTogZmFsc2UK