191048 2018-10-29 16:32:43 -0700 Web Inspector: Flash views with red outline on initial layout 2018-10-29 20:28:58 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1473109 0 nvasilyev 2018-10-29 16:32:43 -0700 We already have a debug setting to flash views with the orange outline on layout (when View.prototype.layout is called, to be exact): Bug 176389 - Web Inspector: Layout flashing for internal View.prototype.layout. While debugging the style editor, I find it useful to have a different outline color for the initial layout. 1473110 1 353331 nvasilyev 2018-10-29 16:33:59 -0700 Created attachment 353331 Patch 1473168 2 353331 hi 2018-10-29 20:00:41 -0700 Comment on attachment 353331 Patch r=me 1473171 3 353331 commit-queue 2018-10-29 20:27:06 -0700 Comment on attachment 353331 Patch Clearing flags on attachment: 353331 Committed r237578: <https://trac.webkit.org/changeset/237578> 1473172 4 commit-queue 2018-10-29 20:27:08 -0700 All reviewed patches have been landed. Closing bug. 1473173 5 webkit-bug-importer 2018-10-29 20:28:58 -0700 <rdar://problem/45659166> 353331 2018-10-29 16:33:59 -0700 2018-10-29 20:27:06 -0700 Patch patch.txt text/plain 2307 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY5NTMxYWRhY2QzLi5iZGFiYTg4NGMyZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTAtMjkgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogRmxhc2ggdmlld3Mgd2l0aCByZWQgb3V0bGluZSBvbiBpbml0aWFsIGxheW91dAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxMDQ4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL1ZpZXcuanM6CisgICAgICAgIChXSS5WaWV3LnByb3RvdHlwZS5fbGF5b3V0U3VidHJl ZSk6CisgICAgICAgIChXSS5WaWV3LnByb3RvdHlwZS5fZHJhd0xheW91dEZsYXNoaW5nT3V0bGlu ZSk6CisKIDIwMTgtMTAtMjkgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgTW9kZXJuaXplIFdlYktpdCBuaWJzIGFuZCBscHJvanMgZm9yIGxvY2FsaXph dGlvbidzIHNha2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1ZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9WaWV3LmpzCmluZGV4IDk2YjNjM2Y3NTk3Li5jZTY0ZDAxYTgyNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmlldy5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaWV3LmpzCkBAIC0yNjYs NiArMjY2LDcgQEAgV0kuVmlldyA9IGNsYXNzIFZpZXcgZXh0ZW5kcyBXSS5PYmplY3QKICAgICB7 CiAgICAgICAgIHRoaXMuX2RpcnR5ID0gZmFsc2U7CiAgICAgICAgIHRoaXMuX2RpcnR5RGVzY2Vu ZGFudHNDb3VudCA9IDA7CisgICAgICAgIGxldCBpc0luaXRpYWxMYXlvdXQgPSAhdGhpcy5fZGlk SW5pdGlhbExheW91dDsKIAogICAgICAgICBpZiAoIXRoaXMuX2RpZEluaXRpYWxMYXlvdXQpIHsK ICAgICAgICAgICAgIHRoaXMuaW5pdGlhbExheW91dCgpOwpAQCAtMjc4LDcgKzI3OSw3IEBAIFdJ LlZpZXcgPSBjbGFzcyBWaWV3IGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgIHRoaXMubGF5b3V0 KCk7CiAKICAgICAgICAgaWYgKFdJLnNldHRpbmdzLmVuYWJsZUxheW91dEZsYXNoaW5nLnZhbHVl KQotICAgICAgICAgICAgdGhpcy5fZHJhd0xheW91dEZsYXNoaW5nT3V0bGluZSgpOworICAgICAg ICAgICAgdGhpcy5fZHJhd0xheW91dEZsYXNoaW5nT3V0bGluZShpc0luaXRpYWxMYXlvdXQpOwog CiAgICAgICAgIGZvciAobGV0IHZpZXcgb2YgdGhpcy5fc3Vidmlld3MpIHsKICAgICAgICAgICAg IHZpZXcuX3NldExheW91dFJlYXNvbih0aGlzLl9sYXlvdXRSZWFzb24pOwpAQCAtMjk2LDE0ICsy OTcsMTUgQEAgV0kuVmlldyA9IGNsYXNzIFZpZXcgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAg dGhpcy5fbGF5b3V0UmVhc29uID0gbGF5b3V0UmVhc29uIHx8IFdJLlZpZXcuTGF5b3V0UmVhc29u LkRpcnR5OwogICAgIH0KIAotICAgIF9kcmF3TGF5b3V0Rmxhc2hpbmdPdXRsaW5lKCkKKyAgICBf ZHJhd0xheW91dEZsYXNoaW5nT3V0bGluZShpc0luaXRpYWxMYXlvdXQpCiAgICAgewogICAgICAg ICBpZiAodGhpcy5fbGF5b3V0Rmxhc2hpbmdUaW1lb3V0KQogICAgICAgICAgICAgY2xlYXJUaW1l b3V0KHRoaXMuX2xheW91dEZsYXNoaW5nVGltZW91dCk7CiAgICAgICAgIGVsc2UKICAgICAgICAg ICAgIHRoaXMuX2xheW91dEZsYXNoaW5nUHJldmlvdXNPdXRsaW5lID0gdGhpcy5fZWxlbWVudC5z dHlsZS5vdXRsaW5lOwogCi0gICAgICAgIHRoaXMuX2VsZW1lbnQuc3R5bGUub3V0bGluZSA9ICIx cHggc29saWQgaHNsYSgzOSwgMTAwJSwgNTElLCAwLjgpIjsKKyAgICAgICAgbGV0IGh1ZSA9IGlz SW5pdGlhbExheW91dCA/IDIwIDogNDA7CisgICAgICAgIHRoaXMuX2VsZW1lbnQuc3R5bGUub3V0 bGluZSA9IGAxcHggc29saWQgaHNsYSgke2h1ZX0sIDEwMCUsIDUxJSwgMC44KWA7CiAKICAgICAg ICAgdGhpcy5fbGF5b3V0Rmxhc2hpbmdUaW1lb3V0ID0gc2V0VGltZW91dCgoKSA9PiB7CiAgICAg ICAgICAgICBpZiAodGhpcy5fZWxlbWVudCkK