191036 2018-10-29 11:40:47 -0700 [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator 2023-05-08 01:49:01 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aestes kkinnunen lforschler simon.fraser webkit-bug-importer oldest_to_newest 1472976 0 dbates 2018-10-29 11:40:47 -0700 Consider the following enum: enum Flag { A = 1 << 0, AAlias = A, } Pretty-printing OptionSet<Flag>(Flag::A) prints the last-most enumerator with value 2, AAlias. But I propose that it print the first enumerator with value 2, A, because aliased enumerators tend to be used in bounds check as opposed to actual set members. 1472978 1 353304 dbates 2018-10-29 11:44:54 -0700 Created attachment 353304 Patch and unit test 1473044 2 353304 dbates 2018-10-29 13:57:19 -0700 Comment on attachment 353304 Patch and unit test Clearing flags on attachment: 353304 Committed r237564: <https://trac.webkit.org/changeset/237564> 1473045 3 dbates 2018-10-29 13:57:20 -0700 All reviewed patches have been landed. Closing bug. 1473046 4 webkit-bug-importer 2018-10-29 13:58:29 -0700 <rdar://problem/45648188> 353304 2018-10-29 11:44:54 -0700 2018-10-29 13:57:19 -0700 Patch and unit test bug-191036-20181029114453.patch text/plain 4575 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NTU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmM5NGUzZmQyNGNiMDcwZTNlODNkYzFiNGIyZWRhNWRh NGViMjk0ZS4uMjA1Mjk5NThkMmVkYmQ3ZjBmZWJkYTJlMGUyMDk5ZmQzODcxNDRlYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMz IEBACisyMDE4LTEwLTI5ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbbGxkYi13ZWJraXRdIExhc3QgYWxpYXNlZCBlbnVtZXJhdG9yIGluIE9wdGlvblNldCBp cyBwcmludGVkOyBzaG91bGQgcHJpbnQgZmlyc3QgZW51bWVyYXRvcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkxMDM2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJlZmVyIHRoZSBmaXJzdCBlbnVtZXJh dG9yIChpbiBwYXJzZSBvcmRlcikgd2hlbiBwcmV0dHktcHJpbnRpbmcgYW4gT3B0aW9uU2V0IHRo YXQgaXMgcGFyYW1ldGVyaXplZAorICAgICAgICBieSBhbiBlbnVtIHRoYXQgY29udGFpbnMgdHdv IG9yIG1vcmUgZW51bWVyYXRvcnMgd2l0aCB0aGUgc2FtZSB2YWx1ZS4gRm9yIGV4YW1wbGUsIHN1 cHBvc2UKKyAgICAgICAgeW91IGhhdmUgdGhlIGZvbGxvd2luZyBlbnVtOgorCisgICAgICAgIGVu dW0gRmxhZyB7CisgICAgICAgICAgICBBID0gMSA8PCAwLAorICAgICAgICAgICAgQUFsaWFzID0g QSwKKyAgICAgICAgfTsKKworICAgICAgICBUaGVuIHByZXR0eS1wcmludGluZyBPcHRpb25TZXQ8 RmxhZz4oRmxhZzo6QSkgc2hvdWxkIHByaW50IEEgaW5zdGVhZCBvZiBBQWxpYXMuIEEgc2lkZSBl ZmZlY3Qgb2YKKyAgICAgICAgdGhpcyBjaGFuZ2UgaXMgdGhhdCBPcHRpb25TZXQ8RmxhZz4oRmxh Zzo6QUFsaWFzKSB3aWxsIGFsc28gcHJpbnQgQSBhcyBpdHMgb25seSBtZW1iZXIgYXMgd2UgY2Fu bm90CisgICAgICAgIGRpZmZlcmVudGlhdGUgYmV0d2VlbiBBIGFuZCBBbGlhcy4gVGhpcyBzaG91 bGQgYmUgYWNjZXB0YWJsZSBpbiBwcmFjdGljZSBhcyBhbGlhc2VkIGVudW1lcmF0b3JzCisgICAg ICAgIHRlbmQgdG8gYmUgdXNlZCBpbiBib3VuZHMgY2hlY2tzIGFzIG9wcG9zZWQgdG8gY29kZSB0 aGF0IGFkZHMgdG8gYSBzZXQuCisKKyAgICAgICAgKiBsbGRiL2xsZGJXZWJLaXRUZXN0ZXIvbWFp bi5jcHA6CisgICAgICAgICh0ZXN0U3VtbWFyeVByb3ZpZGVycyk6CisgICAgICAgICogbGxkYi9s bGRiX3dlYmtpdC5weToKKyAgICAgICAgKFdURk9wdGlvblNldFByb3ZpZGVyLnVwZGF0ZSk6Cisg ICAgICAgICogbGxkYi9sbGRiX3dlYmtpdF91bml0dGVzdC5weToKKyAgICAgICAgKFRlc3RTdW1t YXJ5UHJvdmlkZXJzLnNlcmlhbF90ZXN0X1dURk9wdGlvblNldFByb3ZpZGVyX3NpbXBsZSk6Cisg ICAgICAgIChUZXN0U3VtbWFyeVByb3ZpZGVycyk6CisgICAgICAgIChUZXN0U3VtbWFyeVByb3Zp ZGVycy5zZXJpYWxfdGVzdF9XVEZPcHRpb25TZXRQcm92aWRlcl9hbGlhc2VkX2ZsYWcpOgorCiAy MDE4LTEwLTI5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1BT T05dIFdoZW4gU2FmYXJpIHJlc3RvcmVzIHNlc3Npb24gc3RhdGUgYWZ0ZXIgbGF1bmNoaW5nLCBn b2luZyBiYWNrIGFuZCBmb3J3YXJkIGRvZXMgbm90IHN3YXAgcHJvY2Vzc2VzCmRpZmYgLS1naXQg YS9Ub29scy9sbGRiL2xsZGJXZWJLaXRUZXN0ZXIvbWFpbi5jcHAgYi9Ub29scy9sbGRiL2xsZGJX ZWJLaXRUZXN0ZXIvbWFpbi5jcHAKaW5kZXggOWY4YWY1MjQzZDYzMWU4M2ZjODBhMjBhYTJhMTVj MDEwYmZmMGE2Zi4uNjk0MGM1OWY5MzY3NjFmN2JiY2QwZWE1N2IyYjI1NWVmYzg2MWI4YyAxMDA2 NDQKLS0tIGEvVG9vbHMvbGxkYi9sbGRiV2ViS2l0VGVzdGVyL21haW4uY3BwCisrKyBiL1Rvb2xz L2xsZGIvbGxkYldlYktpdFRlc3Rlci9tYWluLmNwcApAQCAtNTAsNiArNTAsNyBAQCBlbnVtIGNs YXNzIEV4YW1wbGVGbGFncyB7CiAgICAgQiA9IDEgPDwgMSwKICAgICBDID0gMSA8PCAyLAogICAg IEQgPSAxIDw8IDMsCisgICAgQUFsaWFzID0gQSwKIH07CiAKIHN0YXRpYyB2b2lkIHRlc3RTdW1t YXJ5UHJvdmlkZXJzKCkKQEAgLTgzLDYgKzg0LDcgQEAgc3RhdGljIHZvaWQgdGVzdFN1bW1hcnlQ cm92aWRlcnMoKQogCiAgICAgT3B0aW9uU2V0PEV4YW1wbGVGbGFncz4gZXhhbXBsZUZsYWdzRW1w dHk7CiAgICAgT3B0aW9uU2V0PEV4YW1wbGVGbGFncz4gZXhhbXBsZUZsYWdzU2ltcGxlIHsgRXhh bXBsZUZsYWdzOjpBLCBFeGFtcGxlRmxhZ3M6OkQsIEV4YW1wbGVGbGFnczo6QyB9OworICAgIE9w dGlvblNldDxFeGFtcGxlRmxhZ3M+IGV4YW1wbGVGbGFnc0FsaWFzZWRGbGFnIHsgRXhhbXBsZUZs YWdzOjpBQWxpYXMsIEV4YW1wbGVGbGFnczo6RCB9OwogCiAgICAgYnJlYWtGb3JUZXN0aW5nU3Vt bWFyeVByb3ZpZGVycygpOwogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5w eSBiL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQucHkKaW5kZXggMzA4YWNkZWM5ZDM2ODMyYTgxYTRm MzI1MmQyZTQ0ZWZiZDIxOGZhNS4uOGVlMzJhZTM5ZTkwMzczZDYzZmNmMGVhNjY3ZDYwYmU3MTUx MGU5ZCAxMDA2NDQKLS0tIGEvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5weQorKysgYi9Ub29scy9s bGRiL2xsZGJfd2Via2l0LnB5CkBAIC02MTcsNyArNjE3LDExIEBAIGNsYXNzIFdURk9wdGlvblNl dFByb3ZpZGVyOgogICAgICAgICBzZWxmLnNpemUgPSAwCiAKICAgICAgICAgdGVtcGxhdGVfYXJn dW1lbnRfc2JUeXBlID0gc2VsZi52YWxvYmouR2V0VHlwZSgpLkdldFRlbXBsYXRlQXJndW1lbnRU eXBlKDApCi0gICAgICAgIGVudW1lcmF0b3JfdmFsdWVfdG9fbmFtZV9tYXAgPSB7c2JUeXBlRW51 bU1lbWJlci5HZXRWYWx1ZUFzVW5zaWduZWQoKTogc2JUeXBlRW51bU1lbWJlci5HZXROYW1lKCkg Zm9yIHNiVHlwZUVudW1NZW1iZXIgaW4gdGVtcGxhdGVfYXJndW1lbnRfc2JUeXBlLmdldF9lbnVt X21lbWJlcnNfYXJyYXkoKX0KKyAgICAgICAgZW51bWVyYXRvcl92YWx1ZV90b19uYW1lX21hcCA9 IHt9CisgICAgICAgIGZvciBzYlR5cGVFbnVtTWVtYmVyIGluIHRlbXBsYXRlX2FyZ3VtZW50X3Ni VHlwZS5nZXRfZW51bV9tZW1iZXJzX2FycmF5KCk6CisgICAgICAgICAgICBlbnVtZXJhdG9yX3Zh bHVlID0gc2JUeXBlRW51bU1lbWJlci5HZXRWYWx1ZUFzVW5zaWduZWQoKQorICAgICAgICAgICAg aWYgZW51bWVyYXRvcl92YWx1ZSBub3QgaW4gZW51bWVyYXRvcl92YWx1ZV90b19uYW1lX21hcDoK KyAgICAgICAgICAgICAgICBlbnVtZXJhdG9yX3ZhbHVlX3RvX25hbWVfbWFwW2VudW1lcmF0b3Jf dmFsdWVdID0gc2JUeXBlRW51bU1lbWJlci5HZXROYW1lKCkKICAgICAgICAgaWYgbm90IGVudW1l cmF0b3JfdmFsdWVfdG9fbmFtZV9tYXA6CiAgICAgICAgICAgICByZXR1cm4KIApkaWZmIC0tZ2l0 IGEvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdF91bml0dGVzdC5weSBiL1Rvb2xzL2xsZGIvbGxkYl93 ZWJraXRfdW5pdHRlc3QucHkKaW5kZXggMzRiNTU1NTYyNTU5MGVkYTc2MDk1MTQ2NGYwZGU2ZDY2 YmZjZTViNC4uZWM4MjRlNzc1ODQ3YjBiOWVmOTNiOWExNTEyOGZkOGE2NjU5NzZiNyAxMDA3NTUK LS0tIGEvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdF91bml0dGVzdC5weQorKysgYi9Ub29scy9sbGRi L2xsZGJfd2Via2l0X3VuaXR0ZXN0LnB5CkBAIC0xOTYsMyArMTk2LDExIEBAIGNsYXNzIFRlc3RT dW1tYXJ5UHJvdmlkZXJzKHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRF cXVhbChwcm92aWRlci5nZXRfY2hpbGRfYXRfaW5kZXgoMSkuR2V0VmFsdWUoKSwgJzQnKQogICAg ICAgICBzZWxmLmFzc2VydEVxdWFsKHByb3ZpZGVyLmdldF9jaGlsZF9hdF9pbmRleCgyKS5HZXRO YW1lKCksICdEJykKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChwcm92aWRlci5nZXRfY2hpbGRf YXRfaW5kZXgoMikuR2V0VmFsdWUoKSwgJzgnKQorCisgICAgZGVmIHNlcmlhbF90ZXN0X1dURk9w dGlvblNldFByb3ZpZGVyX2FsaWFzZWRfZmxhZyhzZWxmKToKKyAgICAgICAgdmFyaWFibGUgPSBz ZWxmLl9zYkZyYW1lLkZpbmRWYXJpYWJsZSgnZXhhbXBsZUZsYWdzQWxpYXNlZEZsYWcnKQorICAg ICAgICBwcm92aWRlciA9IGxsZGJfd2Via2l0LldURk9wdGlvblNldFByb3ZpZGVyKHZhcmlhYmxl LCB7fSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChwcm92aWRlci5nZXRfY2hpbGRfYXRfaW5k ZXgoMCkuR2V0TmFtZSgpLCAnQScpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocHJvdmlkZXIu Z2V0X2NoaWxkX2F0X2luZGV4KDApLkdldFZhbHVlKCksICcxJykKKyAgICAgICAgc2VsZi5hc3Nl cnRFcXVhbChwcm92aWRlci5nZXRfY2hpbGRfYXRfaW5kZXgoMSkuR2V0TmFtZSgpLCAnRCcpCisg ICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocHJvdmlkZXIuZ2V0X2NoaWxkX2F0X2luZGV4KDEpLkdl dFZhbHVlKCksICc4JykK