191031 2018-10-29 09:08:52 -0700 [GTK][WPE] Fixes to the PublicSuffix implementation 2018-10-30 01:27:06 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 csaavedra csaavedra achristensen bugs-noreply chris.reid commit-queue mcatanzaro oldest_to_newest 1472924 0 csaavedra 2018-10-29 09:08:52 -0700 [GTK][WPE] Fixes to the PublicSuffix implementation 1472926 1 353291 csaavedra 2018-10-29 09:11:55 -0700 Created attachment 353291 Patch 1472928 2 csaavedra 2018-10-29 09:14:48 -0700 With this patch there are these two failures. I am not familiar with the r4--- prefix, is that something we should be able to decode or just noise? ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:170 Expected equality of these values: String() Which is: topPrivatelyControlledDomain("1") Which is: 1 ../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:174 Expected equality of these values: String() Which is: topPrivatelyControlledDomain("r4---asdf") Which is: r4---asdf 1472929 3 csaavedra 2018-10-29 09:15:51 -0700 NB: I am removing the test for 栃木.jp as it's a public-suffix and I don't think it should be tested where it currently is. 1472973 4 mcatanzaro 2018-10-29 11:38:55 -0700 (In reply to Claudio Saavedra from comment #2) > With this patch there are these two failures. I am not familiar with the > r4--- prefix, is that something we should be able to decode or just noise? I don't know IDN. No clue. 1473202 5 353291 commit-queue 2018-10-30 01:27:04 -0700 Comment on attachment 353291 Patch Clearing flags on attachment: 353291 Committed r237584: <https://trac.webkit.org/changeset/237584> 1473203 6 commit-queue 2018-10-30 01:27:06 -0700 All reviewed patches have been landed. Closing bug. 353291 2018-10-29 09:11:55 -0700 2018-10-30 01:27:04 -0700 Patch bug-191031-20181029181154.patch text/plain 4473 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjIzNGYxYjliNDU2MDg2 N2Q4OWEzYjdkNzhhYzZiYmZmZWVmZGI3ZC4uNmE0Y2M0MWNmM2Y2MzJlODEzNDg5ZmFhMjgyZTI4 ZDE0NmQxYjNmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTEwLTI5ICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BF XSBGaXhlcyB0byB0aGUgUHVibGljU3VmZml4IGltcGxlbWVudGF0aW9uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEwMzEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRl c3RzLgorCisgICAgICAgIERvd25jYXNlIGhvc3RuYW1lcyBiZWZvcmUgcGFzc2luZyBpdCBvbiB0 byB0aGUgdW5kZXJseWluZworICAgICAgICBsaWJzb3VwIEFQSS4gU3BlY2lhbCBjYXNlIGxvY2Fs aG9zdCBhbmQgZml4IGEgbWl4ZWQtdXAKKyAgICAgICAgbGlic291cCBHRXJyb3IgY2hlY2tzLiBU aGlzIGZpeGVzIG1vc3Qgb2YgdGhlIGZhaWx1cmVzLgorCisgICAgICAgICogcGxhdGZvcm0vc291 cC9QdWJsaWNTdWZmaXhTb3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzUHVibGljU3VmZml4 KToKKyAgICAgICAgKFdlYkNvcmU6OnRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW4pOgorCiAy MDE4LTEwLTI4ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbUGF5 bWVudCBSZXF1ZXN0XSBJbXBsZW1lbnQgTWVyY2hhbnRWYWxpZGF0aW9uRXZlbnQubWV0aG9kTmFt ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc291cC9QdWJsaWNTdWZmaXhT b3VwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NvdXAvUHVibGljU3VmZml4U291cC5j cHAKaW5kZXggMjM5YzA4MTk0NGY0MWIxNDQ3YjFkODNhNjY4YTM5NjFlNmUwMGE5ZC4uNmE3NGQy ZWNhM2JiNGYxM2YxYmNlZjI1MDZmYjZiOTFmNzI1ZjQxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vc291cC9QdWJsaWNTdWZmaXhTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9zb3VwL1B1YmxpY1N1ZmZpeFNvdXAuY3BwCkBAIC0zOCw3ICszOCw3IEBA IGJvb2wgaXNQdWJsaWNTdWZmaXgoY29uc3QgU3RyaW5nJiBkb21haW4pCiAgICAgaWYgKGRvbWFp bi5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIHJldHVybiBzb3VwX3Rs ZF9kb21haW5faXNfcHVibGljX3N1ZmZpeChkb21haW4udXRmOCgpLmRhdGEoKSk7CisgICAgcmV0 dXJuIHNvdXBfdGxkX2RvbWFpbl9pc19wdWJsaWNfc3VmZml4KGRvbWFpbi5jb252ZXJ0VG9BU0NJ SUxvd2VyY2FzZSgpLnV0ZjgoKS5kYXRhKCkpOwogfQogCiBTdHJpbmcgdG9wUHJpdmF0ZWx5Q29u dHJvbGxlZERvbWFpbihjb25zdCBTdHJpbmcmIGRvbWFpbikKQEAgLTQ2LDE1ICs0NiwyMSBAQCBT dHJpbmcgdG9wUHJpdmF0ZWx5Q29udHJvbGxlZERvbWFpbihjb25zdCBTdHJpbmcmIGRvbWFpbikK ICAgICBpZiAoZG9tYWluLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIFN0cmluZygpOwogCisg ICAgU3RyaW5nIGxvd2VyY2FzZURvbWFpbiA9IGRvbWFpbi5jb252ZXJ0VG9BU0NJSUxvd2VyY2Fz ZSgpOworCisgICAgaWYgKGxvd2VyY2FzZURvbWFpbiA9PSAibG9jYWxob3N0IikKKyAgICAgICAg cmV0dXJuIGxvd2VyY2FzZURvbWFpbjsKKwogICAgIEdVbmlxdWVPdXRQdHI8R0Vycm9yPiBlcnJv cjsKLSAgICBDU3RyaW5nIGRvbWFpblVURjggPSBkb21haW4udXRmOCgpOworICAgIENTdHJpbmcg ZG9tYWluVVRGOCA9IGxvd2VyY2FzZURvbWFpbi51dGY4KCk7CisKICAgICBpZiAoY29uc3QgY2hh ciogYmFzZURvbWFpbiA9IHNvdXBfdGxkX2dldF9iYXNlX2RvbWFpbihkb21haW5VVEY4LmRhdGEo KSwgJmVycm9yLm91dFB0cigpKSkKICAgICAgICAgcmV0dXJuIFN0cmluZzo6ZnJvbVVURjgoYmFz ZURvbWFpbik7CiAKLSAgICBpZiAoZ19lcnJvcl9tYXRjaGVzKGVycm9yLmdldCgpLCBTT1VQX1RM RF9FUlJPUiwgU09VUF9UTERfRVJST1JfTk9fQkFTRV9ET01BSU4pIHx8IGdfZXJyb3JfbWF0Y2hl cyhlcnJvci5nZXQoKSwgU09VUF9UTERfRVJST1IsIFNPVVBfVExEX0VSUk9SX05PVF9FTk9VR0hf RE9NQUlOUykpCisgICAgaWYgKGdfZXJyb3JfbWF0Y2hlcyhlcnJvci5nZXQoKSwgU09VUF9UTERf RVJST1IsIFNPVVBfVExEX0VSUk9SX0lOVkFMSURfSE9TVE5BTUUpIHx8IGdfZXJyb3JfbWF0Y2hl cyhlcnJvci5nZXQoKSwgU09VUF9UTERfRVJST1IsIFNPVVBfVExEX0VSUk9SX05PVF9FTk9VR0hf RE9NQUlOUykpCiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsKIAotICAgIGlmIChnX2Vycm9yX21h dGNoZXMoZXJyb3IuZ2V0KCksIFNPVVBfVExEX0VSUk9SLCBTT1VQX1RMRF9FUlJPUl9JU19JUF9B RERSRVNTKSB8fCBnX2Vycm9yX21hdGNoZXMoZXJyb3IuZ2V0KCksIFNPVVBfVExEX0VSUk9SLCBT T1VQX1RMRF9FUlJPUl9JTlZBTElEX0hPU1ROQU1FKSkKKyAgICBpZiAoZ19lcnJvcl9tYXRjaGVz KGVycm9yLmdldCgpLCBTT1VQX1RMRF9FUlJPUiwgU09VUF9UTERfRVJST1JfSVNfSVBfQUREUkVT UykgfHwgZ19lcnJvcl9tYXRjaGVzKGVycm9yLmdldCgpLCBTT1VQX1RMRF9FUlJPUiwgU09VUF9U TERfRVJST1JfTk9fQkFTRV9ET01BSU4pKQogICAgICAgICByZXR1cm4gZG9tYWluOwogCiAgICAg QVNTRVJUX05PVF9SRUFDSEVEKCk7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29s cy9DaGFuZ2VMb2cKaW5kZXggMDI3NjA4MGRhMTJhYjIyODA0YjU2MGY3NDU4YjlmMjkyNWNiMzE5 Ny4uNDBlNmFlMWVmODY2NTE3OWFiYjM5MDhkY2UxOTE4YzIwMzE2MWViOSAxMDA2NDQKLS0tIGEv VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisy MDE4LTEwLTI5ICBDbGF1ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAg ICAgICAgW0dUS11bV1BFXSBGaXhlcyB0byB0aGUgUHVibGljU3VmZml4IGltcGxlbWVudGF0aW9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTEwMzEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9QdWJsaWNTdWZmaXguY3BwOgorICAgICAgICAoVGVzdFdl YktpdEFQSTo6VEVTVF9GKTogUmVtb3ZlIGEgdGVzdCBmb3IgYSBkb21haW4KKyAgICAgICAgdGhh dCBpcyBub3QgcmVnaXN0cmFibGUgYW5kIHNob3VsZG4ndCBiZSB0ZXN0ZWQgdGhlcmUuCisKIDIw MTgtMTAtMjkgIENsYXVkaW8gU2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXSBUcnkgdG8gZml4IHRoZSB4c2VydmVyLXhvcmcgYnVpbGQgaW4gdGhlIFVidW50 dSBMVFMgYm90CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUv UHVibGljU3VmZml4LmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9QdWJs aWNTdWZmaXguY3BwCmluZGV4IDYwNjkzMDFiNTk3YmU1ZTBiNTRhYjMwYjZkMTFjYzViMDdjOTY5 MzMuLjk0MTFjNWNjMjliNGViMGYzMGRjODg3MTI4YjFlNTdhMDg5ZTYwNWUgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9QdWJsaWNTdWZmaXguY3BwCisrKyBi L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9QdWJsaWNTdWZmaXguY3BwCkBAIC0x NTMsNyArMTUzLDYgQEAgVEVTVF9GKFB1YmxpY1N1ZmZpeCwgSXNQdWJsaWNTdWZmaXgpCiAKIFRF U1RfRihQdWJsaWNTdWZmaXgsIFRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW4pCiB7Ci0gICAg RVhQRUNUX0VRKHV0ZjE2U3RyaW5nKHUiXHU2ODAzXHU2NzI4LmpwIiksIHRvcFByaXZhdGVseUNv bnRyb2xsZWREb21haW4odXRmMTZTdHJpbmcodSJcdTY4MDNcdTY3MjguanAiKSkpOwogICAgIEVY UEVDVF9FUShTdHJpbmcodXRmMTZTdHJpbmcodSJleGFtcGxlLlx1NjgwM1x1NjcyOC5qcCIpKSwg dG9wUHJpdmF0ZWx5Q29udHJvbGxlZERvbWFpbih1dGYxNlN0cmluZyh1ImV4YW1wbGUuXHU2ODAz XHU2NzI4LmpwIikpKTsKICAgICBFWFBFQ1RfRVEoU3RyaW5nKCksIHRvcFByaXZhdGVseUNvbnRy b2xsZWREb21haW4oU3RyaW5nKCkpKTsKICAgICBFWFBFQ1RfRVEoU3RyaW5nKCksIHRvcFByaXZh dGVseUNvbnRyb2xsZWREb21haW4oIiIpKTsK