190988 2018-10-27 11:00:10 -0700 Web Inspector: prevent Canvas tab from listening for "space" when not visibile 2018-10-29 13:31:45 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 190754 1 hi hi commit-queue ews-watchlist hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1472718 0 hi 2018-10-27 11:00:10 -0700 . 1472720 1 353236 hi 2018-10-27 11:02:36 -0700 Created attachment 353236 Patch 1472722 2 ews-watchlist 2018-10-27 11:04:45 -0700 Attachment 353236 did not pass style-queue: ERROR: Source/WebInspectorUI/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1472728 3 353240 hi 2018-10-27 11:09:55 -0700 Created attachment 353240 Patch Whoops. Forgot bug number. 1472987 4 353240 commit-queue 2018-10-29 12:13:08 -0700 Comment on attachment 353240 Patch Clearing flags on attachment: 353240 Committed r237560: <https://trac.webkit.org/changeset/237560> 1472988 5 commit-queue 2018-10-29 12:13:09 -0700 All reviewed patches have been landed. Closing bug. 1473018 6 webkit-bug-importer 2018-10-29 13:31:40 -0700 <rdar://problem/45647159> 1473019 7 webkit-bug-importer 2018-10-29 13:31:45 -0700 <rdar://problem/45647158> 353236 2018-10-27 11:02:36 -0700 2018-10-27 11:09:55 -0700 Patch canvasShortcut.diff text/plain 2445 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQyZWUzNTcyZjRkLi5mMjE3NmQxNGRiNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMTAtMjYgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHBy ZXZlbnQgQ2FudmFzIHRhYiBmcm9tIGxpc3RlbmluZyBmb3IgInNwYWNlIiB3aGVuIG5vdCB2aXNp YmlsZQorICAgICAgICBOZWVkIHRoZSBidWcgVVJMIChPT1BTISkuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0Nh bnZhc1RhYkNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuQ2FudmFzVGFiQ29udGVudFZpZXcp OgorICAgICAgICAoV0kuQ2FudmFzVGFiQ29udGVudFZpZXcucHJvdG90eXBlLnNob3duKToKKyAg ICAgICAgKFdJLkNhbnZhc1RhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5oaWRkZW4pOiBBZGRlZC4K KwogMjAxOC0xMC0yNSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogQ2FudmFzIFJlY29yZGluZyBsb2FkaW5nIGdvZXMgc2lnbmlmaWNh bnRseSBzbG93ZXIgd2hlbiAiRnJhbWUiIHRyZWUgZWxlbWVudCBpcyBleHBhbmRlZApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzVGFi Q29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9DYW52YXNUYWJDb250ZW50Vmlldy5qcwppbmRleCA5MzMyMTFjNDA4OC4uMzQ3YzUyNDNjN2Ig MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Nh bnZhc1RhYkNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0NhbnZhc1RhYkNvbnRlbnRWaWV3LmpzCkBAIC01MCw5ICs1MCwxMSBAQCBX SS5DYW52YXNUYWJDb250ZW50VmlldyA9IGNsYXNzIENhbnZhc1RhYkNvbnRlbnRWaWV3IGV4dGVu ZHMgV0kuQ29udGVudEJyb3dzZXJUYQogCiAgICAgICAgIHRoaXMuX3JlY29yZFNob3J0Y3V0ID0g bmV3IFdJLktleWJvYXJkU2hvcnRjdXQobnVsbCwgV0kuS2V5Ym9hcmRTaG9ydGN1dC5LZXkuU3Bh Y2UsIHRoaXMuX2hhbmRsZVNwYWNlLmJpbmQodGhpcykpOwogICAgICAgICB0aGlzLl9yZWNvcmRT aG9ydGN1dC5pbXBsaWNpdGx5UHJldmVudHNEZWZhdWx0ID0gZmFsc2U7CisgICAgICAgIHRoaXMu X3JlY29yZFNob3J0Y3V0LmRpc2FibGVkID0gdHJ1ZTsKIAogICAgICAgICB0aGlzLl9yZWNvcmRT aW5nbGVGcmFtZVNob3J0Y3V0ID0gbmV3IFdJLktleWJvYXJkU2hvcnRjdXQoV0kuS2V5Ym9hcmRT aG9ydGN1dC5Nb2RpZmllci5TaGlmdCwgV0kuS2V5Ym9hcmRTaG9ydGN1dC5LZXkuU3BhY2UsIHRo aXMuX2hhbmRsZVNwYWNlLmJpbmQodGhpcykpOwogICAgICAgICB0aGlzLl9yZWNvcmRTaW5nbGVG cmFtZVNob3J0Y3V0LmltcGxpY2l0bHlQcmV2ZW50c0RlZmF1bHQgPSBmYWxzZTsKKyAgICAgICAg dGhpcy5fcmVjb3JkU2luZ2xlRnJhbWVTaG9ydGN1dC5kaXNhYmxlZCA9IHRydWU7CiAgICAgfQog CiAgICAgc3RhdGljIHRhYkluZm8oKQpAQCAtMTAyLDEwICsxMDQsMjEgQEAgV0kuQ2FudmFzVGFi Q29udGVudFZpZXcgPSBjbGFzcyBDYW52YXNUYWJDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRl bnRCcm93c2VyVGEKICAgICB7CiAgICAgICAgIHN1cGVyLnNob3duKCk7CiAKKyAgICAgICAgdGhp cy5fcmVjb3JkU2hvcnRjdXQuZGlzYWJsZWQgPSBmYWxzZTsKKyAgICAgICAgdGhpcy5fcmVjb3Jk U2luZ2xlRnJhbWVTaG9ydGN1dC5kaXNhYmxlZCA9IGZhbHNlOworCiAgICAgICAgIGlmICghdGhp cy5jb250ZW50QnJvd3Nlci5jdXJyZW50Q29udGVudFZpZXcpCiAgICAgICAgICAgICB0aGlzLnNo b3dSZXByZXNlbnRlZE9iamVjdCh0aGlzLl9jYW52YXNDb2xsZWN0aW9uKTsKICAgICB9CiAKKyAg ICBoaWRkZW4oKQorICAgIHsKKyAgICAgICAgdGhpcy5fcmVjb3JkU2hvcnRjdXQuZGlzYWJsZWQg PSB0cnVlOworICAgICAgICB0aGlzLl9yZWNvcmRTaW5nbGVGcmFtZVNob3J0Y3V0LmRpc2FibGVk ID0gdHJ1ZTsKKworICAgICAgICBzdXBlci5oaWRkZW4oKTsKKyAgICB9CisKICAgICByZXN0b3Jl U3RhdGVGcm9tQ29va2llKGNvb2tpZSkKICAgICB7CiAgICAgICAgIC8vIEZJWE1FOiBpbXBsZW1l bnQgb25jZSA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTc3NjA2PiBpcyBjb21wbGV0ZS4K 353240 2018-10-27 11:09:55 -0700 2018-10-29 12:13:08 -0700 Patch canvasShortcut.diff text/plain 2466 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQyZWUzNTcyZjRkLi5mMjE3NmQxNGRiNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMTAtMjcgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHBy ZXZlbnQgQ2FudmFzIHRhYiBmcm9tIGxpc3RlbmluZyBmb3IgInNwYWNlIiB3aGVuIG5vdCB2aXNp YmlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkw OTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1RhYkNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0ku Q2FudmFzVGFiQ29udGVudFZpZXcpOgorICAgICAgICAoV0kuQ2FudmFzVGFiQ29udGVudFZpZXcu cHJvdG90eXBlLnNob3duKToKKyAgICAgICAgKFdJLkNhbnZhc1RhYkNvbnRlbnRWaWV3LnByb3Rv dHlwZS5oaWRkZW4pOiBBZGRlZC4KKwogMjAxOC0xMC0yNSAgRGV2aW4gUm91c3NvICA8ZHJvdXNz b0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FudmFzIFJlY29yZGluZyBs b2FkaW5nIGdvZXMgc2lnbmlmaWNhbnRseSBzbG93ZXIgd2hlbiAiRnJhbWUiIHRyZWUgZWxlbWVu dCBpcyBleHBhbmRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvQ2FudmFzVGFiQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNUYWJDb250ZW50Vmlldy5qcwppbmRleCA5MzMy MTFjNDA4OC4uMzQ3YzUyNDNjN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1RhYkNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1RhYkNvbnRlbnRWaWV3Lmpz CkBAIC01MCw5ICs1MCwxMSBAQCBXSS5DYW52YXNUYWJDb250ZW50VmlldyA9IGNsYXNzIENhbnZh c1RhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudEJyb3dzZXJUYQogCiAgICAgICAgIHRo aXMuX3JlY29yZFNob3J0Y3V0ID0gbmV3IFdJLktleWJvYXJkU2hvcnRjdXQobnVsbCwgV0kuS2V5 Ym9hcmRTaG9ydGN1dC5LZXkuU3BhY2UsIHRoaXMuX2hhbmRsZVNwYWNlLmJpbmQodGhpcykpOwog ICAgICAgICB0aGlzLl9yZWNvcmRTaG9ydGN1dC5pbXBsaWNpdGx5UHJldmVudHNEZWZhdWx0ID0g ZmFsc2U7CisgICAgICAgIHRoaXMuX3JlY29yZFNob3J0Y3V0LmRpc2FibGVkID0gdHJ1ZTsKIAog ICAgICAgICB0aGlzLl9yZWNvcmRTaW5nbGVGcmFtZVNob3J0Y3V0ID0gbmV3IFdJLktleWJvYXJk U2hvcnRjdXQoV0kuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5TaGlmdCwgV0kuS2V5Ym9hcmRT aG9ydGN1dC5LZXkuU3BhY2UsIHRoaXMuX2hhbmRsZVNwYWNlLmJpbmQodGhpcykpOwogICAgICAg ICB0aGlzLl9yZWNvcmRTaW5nbGVGcmFtZVNob3J0Y3V0LmltcGxpY2l0bHlQcmV2ZW50c0RlZmF1 bHQgPSBmYWxzZTsKKyAgICAgICAgdGhpcy5fcmVjb3JkU2luZ2xlRnJhbWVTaG9ydGN1dC5kaXNh YmxlZCA9IHRydWU7CiAgICAgfQogCiAgICAgc3RhdGljIHRhYkluZm8oKQpAQCAtMTAyLDEwICsx MDQsMjEgQEAgV0kuQ2FudmFzVGFiQ29udGVudFZpZXcgPSBjbGFzcyBDYW52YXNUYWJDb250ZW50 VmlldyBleHRlbmRzIFdJLkNvbnRlbnRCcm93c2VyVGEKICAgICB7CiAgICAgICAgIHN1cGVyLnNo b3duKCk7CiAKKyAgICAgICAgdGhpcy5fcmVjb3JkU2hvcnRjdXQuZGlzYWJsZWQgPSBmYWxzZTsK KyAgICAgICAgdGhpcy5fcmVjb3JkU2luZ2xlRnJhbWVTaG9ydGN1dC5kaXNhYmxlZCA9IGZhbHNl OworCiAgICAgICAgIGlmICghdGhpcy5jb250ZW50QnJvd3Nlci5jdXJyZW50Q29udGVudFZpZXcp CiAgICAgICAgICAgICB0aGlzLnNob3dSZXByZXNlbnRlZE9iamVjdCh0aGlzLl9jYW52YXNDb2xs ZWN0aW9uKTsKICAgICB9CiAKKyAgICBoaWRkZW4oKQorICAgIHsKKyAgICAgICAgdGhpcy5fcmVj b3JkU2hvcnRjdXQuZGlzYWJsZWQgPSB0cnVlOworICAgICAgICB0aGlzLl9yZWNvcmRTaW5nbGVG cmFtZVNob3J0Y3V0LmRpc2FibGVkID0gdHJ1ZTsKKworICAgICAgICBzdXBlci5oaWRkZW4oKTsK KyAgICB9CisKICAgICByZXN0b3JlU3RhdGVGcm9tQ29va2llKGNvb2tpZSkKICAgICB7CiAgICAg ICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQgb25jZSA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTc3NjA2 PiBpcyBjb21wbGV0ZS4K