190955 2018-10-26 05:22:25 -0700 Crash in http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html 2018-10-26 11:33:47 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=190901 InRadar P2 Normal --- 1 graouts graouts commit-queue dino inspector-bugzilla-changes ryanhaddad webkit-bug-importer oldest_to_newest 1472395 0 graouts 2018-10-26 05:22:25 -0700 This is fallout from https://bugs.webkit.org/show_bug.cgi?id=190901. If you run this command: run-webkit-tests -1 --debug --child-processes=1 http/tests/inspector/network/resource-initiatorNode.html http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html … you'll hit a crash when this assertion is hit: ASSERTION FAILED: !frame().animation().hasAnimations() ./page/FrameView.cpp(607) : void WebCore::FrameView::didDestroyRenderTree() When DRT loads http/tests/inspector/network/resource-initiatorNode.html, it eventually calls RuntimeEnabledFeatures::sharedFeatures().setWebAnimationsCSSIntegrationEnabled() with a true value with this code invocation: #0 0x112b4faed in WebCore::RuntimeEnabledFeatures::setWebAnimationsCSSIntegrationEnabled(bool) at ~/Builds/Debug/WebCore.framework/PrivateHeaders/RuntimeEnabledFeatures.h:115 #1 0x112b4d5a1 in ::-[WebView(WebPrivate) _preferencesChanged:](WebPreferences *) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebView/WebView.mm:3099 #2 0x112b4b104 in ::-[WebView(WebPrivate) _preferencesChangedNotification:](NSNotification *) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebView/WebView.mm:2786 #3 0x7fff45e903f2 in __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ () #4 0x7fff45e9036c in ___CFXRegistrationPost_block_invoke () #5 0x7fff45e9028d in _CFXRegistrationPost () #6 0x7fff45e986d9 in ___CFXNotificationPost_block_invoke () #7 0x7fff45dffe8a in -[_CFXNotificationRegistrar find:object:observer:enumerator:] () #8 0x7fff45dff24d in _CFXNotificationPost () #9 0x7fff4824d98b in -[NSNotificationCenter postNotificationName:object:userInfo:] () #10 0x112b0e2af in ::-[WebPreferences(WebPrivate) _postPreferencesChangedNotification]() at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebView/WebPreferences.mm:1841 #11 0x112b0b366 in ::-[WebPreferences _setBoolValue:forKey:](BOOL, NSString *) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebView/WebPreferences.mm:846 #12 0x112b1257e in ::-[WebPreferences(WebPrivate) setWebAnimationsCSSIntegrationEnabled:](BOOL) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebView/WebPreferences.mm:3147 #13 0x1068e427c in setWebPreferencesForTestOptions(TestOptions const&) at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:1011 #14 0x1068e21d0 in resetWebViewToConsistentStateBeforeTesting(TestOptions const&) at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:1850 #15 0x1068d8aa8 in runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:1983 #16 0x1068d801f in runTestingServerLoop() at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:1195 #17 0x1068d7467 in dumpRenderTree(int, char const**) at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:1296 #18 0x1068da860 in DumpRenderTreeMain(int, char const**) at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:1409 From that point on the Web Animations CSS Integration feature should be on, which is what is expected for DRT and WKTR. But, then we have this call sequence that sets the flag back to false when the test shows the Web Inspector and preferences are re-set to what Web Inspector expects to be sane defaults: #0 0x112b4fb00 in WebCore::RuntimeEnabledFeatures::setWebAnimationsCSSIntegrationEnabled(bool) at ~/Builds/Debug/WebCore.framework/PrivateHeaders/RuntimeEnabledFeatures.h:117 #1 0x112b4d5a1 in ::-[WebView(WebPrivate) _preferencesChanged:](WebPreferences *) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebView/WebView.mm:3099 #2 0x112b5d78a in ::-[WebView setPreferences:](WebPreferences *) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebView/WebView.mm:6233 #3 0x112aad1d1 in ::-[WebInspectorWindowController init]() at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:395 #4 0x112aad2cd in ::-[WebInspectorWindowController initWithInspectedWebView:isUnderTest:](WebView *, BOOL) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:408 #5 0x112aa9c9f in WebInspectorClient::openLocalFrontend(WebCore::InspectorController*) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:108 #6 0x118b29fef in WebCore::InspectorController::show() at ~/Code/safari/OpenSource/Source/WebCore/inspector/InspectorController.cpp:361 #7 0x112aa92b4 in ::-[WebInspector showWindow]() at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebInspector/WebInspector.mm:70 #8 0x112aa9318 in ::-[WebInspector show:](id) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebInspector/WebInspector.mm:75 #9 0x106951fea in TestRunner::showWebInspector() at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/TestRunnerMac.mm:802 #10 0x10693a3a6 in showWebInspectorCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) at ~/Code/safari/OpenSource/Tools/DumpRenderTree/TestRunner.cpp:1498 #11 0x107811631 in long long JSC::APICallbackFunction::call<JSC::JSCallbackFunction>(JSC::ExecState*) at ~/Code/safari/OpenSource/Source/JavaScriptCore/API/APICallbackFunction.h:63 #12 0x33138780102d in 0x33138780102d () #13 0x10778d8c8 in llint_entry at ~/Code/safari/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:830 #14 0x10778d8c8 in llint_entry at ~/Code/safari/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:830 #15 0x1077851e2 in vmEntryToJavaScript at ~/Code/safari/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:256 #16 0x10833d31e in JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) at ~/Code/safari/OpenSource/Source/JavaScriptCore/jit/JITCodeInlines.h:38 #17 0x10833d9b9 in JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) at ~/Code/safari/OpenSource/Source/JavaScriptCore/interpreter/Interpreter.cpp:891 #18 0x1085f003c in JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) at ~/Code/safari/OpenSource/Source/JavaScriptCore/runtime/CallData.cpp:41 #19 0x1085f012a in JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) at ~/Code/safari/OpenSource/Source/JavaScriptCore/runtime/CallData.cpp:48 #20 0x1085f041e in JSC::profiledCall(JSC::ExecState*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) at ~/Code/safari/OpenSource/Source/JavaScriptCore/runtime/CallData.cpp:69 #21 0x117f756db in WebCore::JSExecState::profiledCall(JSC::ExecState*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) at ~/Code/safari/OpenSource/Source/WebCore/bindings/js/JSExecState.h:74 #22 0x117fbec54 in WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext&, WebCore::Event&) at ~/Code/safari/OpenSource/Source/WebCore/bindings/js/JSEventListener.cpp:175 #23 0x118586eec in WebCore::EventTarget::innerInvokeEventListeners(WebCore::Event&, WTF::Vector<WTF::RefPtr<WebCore::RegisteredEventListener, WTF::DumbPtrTraits<WebCore::RegisteredEventListener> >, 1ul, WTF::CrashOnOverflow, 16ul>, WebCore::EventTarget::EventInvokePhase) at ~/Code/safari/OpenSource/Source/WebCore/dom/EventTarget.cpp:301 #24 0x1185828c2 in WebCore::EventTarget::fireEventListeners(WebCore::Event&, WebCore::EventTarget::EventInvokePhase) at ~/Code/safari/OpenSource/Source/WebCore/dom/EventTarget.cpp:242 #25 0x118e67481 in WebCore::DOMWindow::dispatchEvent(WebCore::Event&, WebCore::EventTarget*) at ~/Code/safari/OpenSource/Source/WebCore/page/DOMWindow.cpp:2013 #26 0x118e716a5 in WebCore::DOMWindow::dispatchLoadEvent() at ~/Code/safari/OpenSource/Source/WebCore/page/DOMWindow.cpp:1962 #27 0x1184a46f8 in WebCore::Document::dispatchWindowLoadEvent() at ~/Code/safari/OpenSource/Source/WebCore/dom/Document.cpp:4487 #28 0x11849ccb3 in WebCore::Document::implicitClose() at ~/Code/safari/OpenSource/Source/WebCore/dom/Document.cpp:2945 #29 0x118d032fb in WebCore::FrameLoader::checkCallImplicitClose() at ~/Code/safari/OpenSource/Source/WebCore/loader/FrameLoader.cpp:951 #30 0x118d02d94 in WebCore::FrameLoader::checkCompleted() at ~/Code/safari/OpenSource/Source/WebCore/loader/FrameLoader.cpp:892 #31 0x118d02e0d in WebCore::FrameLoader::loadDone(WebCore::LoadCompletionType) at ~/Code/safari/OpenSource/Source/WebCore/loader/FrameLoader.cpp:794 #32 0x118dfe896 in WebCore::CachedResourceLoader::loadDone(WebCore::LoadCompletionType, bool) at ~/Code/safari/OpenSource/Source/WebCore/loader/cache/CachedResourceLoader.cpp:1317 #33 0x118d77a0d in WebCore::SubresourceLoader::notifyDone(WebCore::LoadCompletionType) at ~/Code/safari/OpenSource/Source/WebCore/loader/SubresourceLoader.cpp:742 #34 0x118d75778 in WebCore::SubresourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&) at ~/Code/safari/OpenSource/Source/WebCore/loader/SubresourceLoader.cpp:642 #35 0x118d5b775 in WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*) at ~/Code/safari/OpenSource/Source/WebCore/loader/ResourceLoader.cpp:682 #36 0x116f1e6d4 in -[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]::$_7::operator()() at ~/Code/safari/OpenSource/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:314 #37 0x116f1e5b9 in WTF::Function<void ()>::CallableWrapper<-[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]::$_7>::call() at ~/Builds/Debug/usr/local/include/wtf/Function.h:101 #38 0x1073076dd in WTF::Function<void ()>::operator()() const at ~/Builds/Debug/usr/local/include/wtf/Function.h:56 #39 0x1073364dd in WTF::dispatchFunctionsFromMainThread() at ~/Code/safari/OpenSource/Source/WTF/wtf/MainThread.cpp:115 #40 0x107339245 in ::-[JSWTFMainThreadCaller call]() at ~/Code/safari/OpenSource/Source/WTF/wtf/cocoa/MainThreadCocoa.mm:54 #41 0x7fff482edabb in __NSThreadPerformPerform () #42 0x7fff45e49155 in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ () #43 0x7fff45e490fb in __CFRunLoopDoSource0 () #44 0x7fff45e2cb95 in __CFRunLoopDoSources0 () #45 0x7fff45e2c13e in __CFRunLoopRun () #46 0x7fff45e2ba28 in CFRunLoopRunSpecific () #47 0x1068d9dbb in runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:2052 #48 0x1068d801f in runTestingServerLoop() at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:1195 #49 0x1068d7467 in dumpRenderTree(int, char const**) at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:1296 #50 0x1068da860 in DumpRenderTreeMain(int, char const**) at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:1409 After this happens the media controls code that is loaded as a result of media controls being created for the .vtt file loaded in the test creates some CSS Transitions and CSS Animations that are evaluated using the legacy animation engine (CSSAnimationController). Then after that the flag is set back to true! #0 0x112b4faed in WebCore::RuntimeEnabledFeatures::setWebAnimationsCSSIntegrationEnabled(bool) at ~/Builds/Debug/WebCore.framework/PrivateHeaders/RuntimeEnabledFeatures.h:115 #1 0x112b4d5a1 in ::-[WebView(WebPrivate) _preferencesChanged:](WebPreferences *) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebView/WebView.mm:3099 #2 0x112b4b104 in ::-[WebView(WebPrivate) _preferencesChangedNotification:](NSNotification *) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebView/WebView.mm:2786 #3 0x7fff45e903f2 in __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ () #4 0x7fff45e9036c in ___CFXRegistrationPost_block_invoke () #5 0x7fff45e9028d in _CFXRegistrationPost () #6 0x7fff45e986d9 in ___CFXNotificationPost_block_invoke () #7 0x7fff45dffe8a in -[_CFXNotificationRegistrar find:object:observer:enumerator:] () #8 0x7fff45dff24d in _CFXNotificationPost () #9 0x7fff4824d98b in -[NSNotificationCenter postNotificationName:object:userInfo:] () #10 0x112b0e2af in ::-[WebPreferences(WebPrivate) _postPreferencesChangedNotification]() at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebView/WebPreferences.mm:1841 #11 0x112b0b366 in ::-[WebPreferences _setBoolValue:forKey:](BOOL, NSString *) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebView/WebPreferences.mm:846 #12 0x112b0cc4e in ::-[WebPreferences(WebPrivate) setDeveloperExtrasEnabled:](BOOL) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebView/WebPreferences.mm:1317 #13 0x106951f97 in TestRunner::setDeveloperExtrasEnabled(bool) at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/TestRunnerMac.mm:797 #14 0x1068d9f98 in runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:2071 #15 0x1068d801f in runTestingServerLoop() at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:1195 #16 0x1068d7467 in dumpRenderTree(int, char const**) at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:1296 #17 0x1068da860 in DumpRenderTreeMain(int, char const**) at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/DumpRenderTree.mm:1409 Then the inspector is shown again and the flag is back to being false: #0 0x112b4fb00 in WebCore::RuntimeEnabledFeatures::setWebAnimationsCSSIntegrationEnabled(bool) at ~/Builds/Debug/WebCore.framework/PrivateHeaders/RuntimeEnabledFeatures.h:117 #1 0x112b4d5a1 in ::-[WebView(WebPrivate) _preferencesChanged:](WebPreferences *) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebView/WebView.mm:3099 #2 0x112b5d78a in ::-[WebView setPreferences:](WebPreferences *) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebView/WebView.mm:6233 #3 0x112aad1d1 in ::-[WebInspectorWindowController init]() at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:395 #4 0x112aad2cd in ::-[WebInspectorWindowController initWithInspectedWebView:isUnderTest:](WebView *, BOOL) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:408 #5 0x112aa9c9f in WebInspectorClient::openLocalFrontend(WebCore::InspectorController*) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:108 #6 0x118b29fef in WebCore::InspectorController::show() at ~/Code/safari/OpenSource/Source/WebCore/inspector/InspectorController.cpp:361 #7 0x112aa92b4 in ::-[WebInspector showWindow]() at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebInspector/WebInspector.mm:70 #8 0x112aa9318 in ::-[WebInspector show:](id) at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebInspector/WebInspector.mm:75 #9 0x106951fea in TestRunner::showWebInspector() at ~/Code/safari/OpenSource/Tools/DumpRenderTree/mac/TestRunnerMac.mm:802 #10 0x10693a3a6 in showWebInspectorCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) at ~/Code/safari/OpenSource/Tools/DumpRenderTree/TestRunner.cpp:1498 #11 0x107811631 in long long JSC::APICallbackFunction::call<JSC::JSCallbackFunction>(JSC::ExecState*) at ~/Code/safari/OpenSource/Source/JavaScriptCore/API/APICallbackFunction.h:63 #12 0x33138780102d in 0x33138780102d () #13 0x10778d8c8 in llint_entry at ~/Code/safari/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:830 #14 0x10778d8c8 in llint_entry at ~/Code/safari/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:830 #15 0x1077851e2 in vmEntryToJavaScript at ~/Code/safari/OpenSource/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:256 #16 0x10833d31e in JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) at ~/Code/safari/OpenSource/Source/JavaScriptCore/jit/JITCodeInlines.h:38 #17 0x10833d9b9 in JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) at ~/Code/safari/OpenSource/Source/JavaScriptCore/interpreter/Interpreter.cpp:891 #18 0x1085f003c in JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) at ~/Code/safari/OpenSource/Source/JavaScriptCore/runtime/CallData.cpp:41 #19 0x1085f012a in JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) at ~/Code/safari/OpenSource/Source/JavaScriptCore/runtime/CallData.cpp:48 #20 0x1085f041e in JSC::profiledCall(JSC::ExecState*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) at ~/Code/safari/OpenSource/Source/JavaScriptCore/runtime/CallData.cpp:69 #21 0x117f756db in WebCore::JSExecState::profiledCall(JSC::ExecState*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) at ~/Code/safari/OpenSource/Source/WebCore/bindings/js/JSExecState.h:74 #22 0x117fbec54 in WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext&, WebCore::Event&) at ~/Code/safari/OpenSource/Source/WebCore/bindings/js/JSEventListener.cpp:175 #23 0x118586eec in WebCore::EventTarget::innerInvokeEventListeners(WebCore::Event&, WTF::Vector<WTF::RefPtr<WebCore::RegisteredEventListener, WTF::DumbPtrTraits<WebCore::RegisteredEventListener> >, 1ul, WTF::CrashOnOverflow, 16ul>, WebCore::EventTarget::EventInvokePhase) at ~/Code/safari/OpenSource/Source/WebCore/dom/EventTarget.cpp:301 #24 0x1185828c2 in WebCore::EventTarget::fireEventListeners(WebCore::Event&, WebCore::EventTarget::EventInvokePhase) at ~/Code/safari/OpenSource/Source/WebCore/dom/EventTarget.cpp:242 #25 0x118e67481 in WebCore::DOMWindow::dispatchEvent(WebCore::Event&, WebCore::EventTarget*) at ~/Code/safari/OpenSource/Source/WebCore/page/DOMWindow.cpp:2013 #26 0x118e716a5 in WebCore::DOMWindow::dispatchLoadEvent() at ~/Code/safari/OpenSource/Source/WebCore/page/DOMWindow.cpp:1962 #27 0x1184a46f8 in WebCore::Document::dispatchWindowLoadEvent() at ~/Code/safari/OpenSource/Source/WebCore/dom/Document.cpp:4487 #28 0x11849ccb3 in WebCore::Document::implicitClose() at ~/Code/safari/OpenSource/Source/WebCore/dom/Document.cpp:2945 #29 0x118d032fb in WebCore::FrameLoader::checkCallImplicitClose() at ~/Code/safari/OpenSource/Source/WebCore/loader/FrameLoader.cpp:951 #30 0x118d02d94 in WebCore::FrameLoader::checkCompleted() at ~/Code/safari/OpenSource/Source/WebCore/loader/FrameLoader.cpp:892 #31 0x118d02e0d in WebCore::FrameLoader::loadDone(WebCore::LoadCompletionType) at ~/Code/safari/OpenSource/Source/WebCore/loader/FrameLoader.cpp:794 #32 0x118dfe896 in WebCore::CachedResourceLoader::loadDone(WebCore::LoadCompletionType, bool) at ~/Code/safari/OpenSource/Source/WebCore/loader/cache/CachedResourceLoader.cpp:1317 #33 0x118d77a0d in WebCore::SubresourceLoader::notifyDone(WebCore::LoadCompletionType) at ~/Code/safari/OpenSource/Source/WebCore/loader/SubresourceLoader.cpp:742 #34 0x118d75778 in WebCore::SubresourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&) at ~/Code/safari/OpenSource/Source/WebCore/loader/SubresourceLoader.cpp:642 #35 0x118d5b775 in WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*) at ~/Code/safari/OpenSource/Source/WebCore/loader/ResourceLoader.cpp:682 #36 0x116f1e6d4 in -[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]::$_7::operator()() at ~/Code/safari/OpenSource/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:314 #37 0x116f1e5b9 in WTF::Function<void ()>::CallableWrapper<-[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]::$_7>::call() at ~/Builds/Debug/usr/local/include/wtf/Function.h:101 #38 0x1073076dd in WTF::Function<void ()>::operator()() const at ~/Builds/Debug/usr/local/include/wtf/Function.h:56 #39 0x1073364dd in WTF::dispatchFunctionsFromMainThread() at ~/Code/safari/OpenSource/Source/WTF/wtf/MainThread.cpp:115 #40 0x107339245 in ::-[JSWTFMainThreadCaller call]() at ~/Code/safari/OpenSource/Source/WTF/wtf/cocoa/MainThreadCocoa.mm:54 … and eventually we hit the ASSERT(): #2 0x118ed4d38 in WebCore::FrameView::didDestroyRenderTree() at ~/Code/safari/OpenSource/Source/WebCore/page/FrameView.cpp:607 #3 0x1184a1616 in WebCore::Document::destroyRenderTree() at ~/Code/safari/OpenSource/Source/WebCore/dom/Document.cpp:2418 #4 0x1184a18f0 in WebCore::Document::prepareForDestruction() at ~/Code/safari/OpenSource/Source/WebCore/dom/Document.cpp:2465 #5 0x118ec82a0 in WebCore::Frame::setView(WTF::RefPtr<WebCore::FrameView, WTF::DumbPtrTraits<WebCore::FrameView> >&&) at ~/Code/safari/OpenSource/Source/WebCore/page/Frame.cpp:240 #6 0x112a3ac5d in WebFrameLoaderClient::transitionToCommittedForNewPage() at ~/Code/safari/OpenSource/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:1466 #7 0x118d0d669 in WebCore::FrameLoader::transitionToCommitted(WebCore::CachedPage*) at ~/Code/safari/OpenSource/Source/WebCore/loader/FrameLoader.cpp:2149 #8 0x118d0c700 in WebCore::FrameLoader::commitProvisionalLoad() at ~/Code/safari/OpenSource/Source/WebCore/loader/FrameLoader.cpp:1976 #9 0x118ca4e2c in WebCore::DocumentLoader::commitIfReady() at ~/Code/safari/OpenSource/Source/WebCore/loader/DocumentLoader.cpp:357 #10 0x118cab27c in WebCore::DocumentLoader::commitLoad(char const*, int) at ~/Code/safari/OpenSource/Source/WebCore/loader/DocumentLoader.cpp:964 #11 0x118cab225 in WebCore::DocumentLoader::dataReceived(char const*, int) at ~/Code/safari/OpenSource/Source/WebCore/loader/DocumentLoader.cpp:1113 #12 0x118caba96 in WebCore::DocumentLoader::dataReceived(WebCore::CachedResource&, char const*, int) at ~/Code/safari/OpenSource/Source/WebCore/loader/DocumentLoader.cpp:1086 #13 0x118dec46b in WebCore::CachedRawResource::notifyClientsDataWasReceived(char const*, unsigned int) at ~/Code/safari/OpenSource/Source/WebCore/loader/cache/CachedRawResource.cpp:136 #14 0x118dec249 in WebCore::CachedRawResource::updateBuffer(WebCore::SharedBuffer&) at ~/Code/safari/OpenSource/Source/WebCore/loader/cache/CachedRawResource.cpp:73 #15 0x118d76f62 in WebCore::SubresourceLoader::didReceiveDataOrBuffer(char const*, int, WTF::RefPtr<WebCore::SharedBuffer, WTF::DumbPtrTraits<WebCore::SharedBuffer> >&&, long long, WebCore::DataPayloadType) at ~/Code/safari/OpenSource/Source/WebCore/loader/SubresourceLoader.cpp:455 #16 0x118d77092 in WebCore::SubresourceLoader::didReceiveBuffer(WTF::Ref<WebCore::SharedBuffer, WTF::DumbPtrTraits<WebCore::SharedBuffer> >&&, long long, WebCore::DataPayloadType) at ~/Code/safari/OpenSource/Source/WebCore/loader/SubresourceLoader.cpp:435 #17 0x118d5b70c in WebCore::ResourceLoader::didReceiveBuffer(WebCore::ResourceHandle*, WTF::Ref<WebCore::SharedBuffer, WTF::DumbPtrTraits<WebCore::SharedBuffer> >&&, int) at ~/Code/safari/OpenSource/Source/WebCore/loader/ResourceLoader.cpp:676 #18 0x116f1d9a1 in -[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveData:lengthReceived:]::$_5::operator()() at ~/Code/safari/OpenSource/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:280 #19 0x116f1d809 in WTF::Function<void ()>::CallableWrapper<-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveData:lengthReceived:]::$_5>::call() at ~/Builds/Debug/usr/local/include/wtf/Function.h:101 #20 0x1073076dd in WTF::Function<void ()>::operator()() const at ~/Builds/Debug/usr/local/include/wtf/Function.h:56 #21 0x1073364dd in WTF::dispatchFunctionsFromMainThread() at ~/Code/safari/OpenSource/Source/WTF/wtf/MainThread.cpp:115 #22 0x107339245 in ::-[JSWTFMainThreadCaller call]() at ~/Code/safari/OpenSource/Source/WTF/wtf/cocoa/MainThreadCocoa.mm:54 The reason things are bad is that the flag was off when the animations were created, but it was on when the code that tears down animations runs and so we don't have a chance to remove the animations from CSSAnimationController as we should have. And so when this ASSERT() checks that there are no animations left on the animation controller upon destroying the page, the state is bad. 1472404 1 353178 graouts 2018-10-26 06:07:44 -0700 Created attachment 353178 Patch 1472507 2 353178 commit-queue 2018-10-26 11:17:02 -0700 Comment on attachment 353178 Patch Clearing flags on attachment: 353178 Committed r237468: <https://trac.webkit.org/changeset/237468> 1472508 3 commit-queue 2018-10-26 11:17:04 -0700 All reviewed patches have been landed. Closing bug. 1472515 4 webkit-bug-importer 2018-10-26 11:33:47 -0700 <rdar://problem/45594319> 353178 2018-10-26 06:07:44 -0700 2018-10-26 11:17:02 -0700 Patch bug-190955-20181026150742.patch text/plain 5898 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NDQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWU1ZGEwN2U2YWMxZDcw Yzg2Y2RmODZjNTlkYjVjMDQ5Mjk3MWU4ZS4uYmI1ZTEwZTJmNDUzMzI2NjYyZmJlOTk4NjY4M2Ix NmJiNDVhYzk3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE4LTEwLTI2ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog Q3Jhc2ggaW4gaHR0cC90ZXN0cy9pbnNwZWN0b3IvbmV0d29yay9yZXNvdXJjZS1yZXNwb25zZS1z b3VyY2UtbWVtb3J5LWNhY2hlLXJldmFsaWRhdGUtZXhwaXJlZC1vbmx5Lmh0bWwKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDk1NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGNhbiBnZXQgaW4gc2l0 dWF0aW9ucyB3aGVuIHJ1bm5pbmcgdGVzdHMgd2hlcmUgcnVudGltZSBmbGFncyBhcmUgbm90IGNv bnNpc3RlbnQgdGhyb3VnaG91dCB0aGUgdGltZSBhIHRlc3QgaXMgcnVuIHNpbmNlCisgICAgICAg IHNob3dpbmcgdGhlIFdlYiBJbnNwZWN0b3IgY2FuIGNhdXNlIGZsYWdzIHRvIGJlIHJlLXNldCBh ZnRlciB0aGUgaW5pdGlhbCB0ZXN0IHdhcyBsb2FkZWQuIEFzIHN1Y2gsIHRvIGF2b2lkIGNyYXNo ZXMgZHVlIHRvCisgICAgICAgIHRoZSBBU1NFUlQoIWZyYW1lKCkuYW5pbWF0aW9uKCkuaGFzQW5p bWF0aW9ucygpKSBpbiBGcmFtZVZpZXc6OmRpZERlc3Ryb3lSZW5kZXJUcmVlKCksIHdlIG5vdyBj YW5jZWwgYW5pbWF0aW9ucyB1cG9uIHRlYXJkb3duCisgICAgICAgIG5vIG1hdHRlciB3aGF0IHRo ZSB2YWx1ZSBvZiB0aGUgcnVudGltZSBmbGFnIGZvciB0aGUgV2ViIEFuaW1hdGlvbnMgQ1NTIElu dGVncmF0aW9uIG9uIGJvdGggdGhlIERvY3VtZW50VGltZWxpbmUgKGlmIGl0IGV4aXN0cykKKyAg ICAgICAgYW5kIHRoZSBDU1NBbmltYXRpb25Db250cm9sbGVyLgorCisgICAgICAgICogZG9tL0Vs ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6cmVtb3ZlZEZyb21BbmNlc3Rv cik6CisgICAgICAgICogZG9tL1BzZXVkb0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UHNldWRvRWxlbWVudDo6Y2xlYXJIb3N0RWxlbWVudCk6CisgICAgICAgICogcGFnZS9GcmFtZVZp ZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpkaWREZXN0cm95UmVuZGVyVHJl ZSk6CisgICAgICAgICogcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVVcGRhdGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRyZWVVcGRhdGVyOjp0ZWFyRG93blJlbmRlcmVycyk6 CisKIDIwMTgtMTAtMjUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAg ICBbUFNPTl0gTmF2aWdhdGluZyBjcm9zcy1zaXRlIHdpdGggbG9ja2VkIGhpc3RvcnkgYnV0IHVu bG9ja2VkIGJhY2svZm9yd2FyZCBsaXN0IGZhaWxzIHRvIGNyZWF0ZSBhIG5ldyBCYWNrRm9yd2Fy ZExpc3RJdGVtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKaW5kZXggOWQ0NzMzOTM1ZDZhOWIzYTFkYmQ0 NzBjM2E1MGUyMTFhYTViZjM3Mi4uZDJkNTgzNjU1NDZkNGNhZWFhZTk1YWNjOWYxNjdiZmVlYjM0 ZmVlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApAQCAtMTk2MiwxMCArMTk2Miw5IEBAIHZvaWQg RWxlbWVudDo6cmVtb3ZlZEZyb21BbmNlc3RvcihSZW1vdmFsVHlwZSByZW1vdmFsVHlwZSwgQ29u dGFpbmVyTm9kZSYgb2xkUGFyCiAgICAgICAgIGRvY3VtZW50KCkuYWNjZXNzU1ZHRXh0ZW5zaW9u cygpLnJlbW92ZUVsZW1lbnRGcm9tUGVuZGluZ1Jlc291cmNlcyh0aGlzKTsKIAogICAgIFJlZlB0 cjxGcmFtZT4gZnJhbWUgPSBkb2N1bWVudCgpLmZyYW1lKCk7Ci0gICAgaWYgKFJ1bnRpbWVFbmFi bGVkRmVhdHVyZXM6OnNoYXJlZEZlYXR1cmVzKCkud2ViQW5pbWF0aW9uc0NTU0ludGVncmF0aW9u RW5hYmxlZCgpKSB7Ci0gICAgICAgIGlmIChhdXRvKiB0aW1lbGluZSA9IGRvY3VtZW50KCkuZXhp c3RpbmdUaW1lbGluZSgpKQotICAgICAgICAgICAgdGltZWxpbmUtPmVsZW1lbnRXYXNSZW1vdmVk KCp0aGlzKTsKLSAgICB9IGVsc2UgaWYgKGZyYW1lKQorICAgIGlmIChhdXRvKiB0aW1lbGluZSA9 IGRvY3VtZW50KCkuZXhpc3RpbmdUaW1lbGluZSgpKQorICAgICAgICB0aW1lbGluZS0+ZWxlbWVu dFdhc1JlbW92ZWQoKnRoaXMpOworICAgIGlmIChmcmFtZSkKICAgICAgICAgZnJhbWUtPmFuaW1h dGlvbigpLmNhbmNlbEFuaW1hdGlvbnMoKnRoaXMpOwogCiAjaWYgUExBVEZPUk0oTUFDKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1BzZXVkb0VsZW1lbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvZG9tL1BzZXVkb0VsZW1lbnQuY3BwCmluZGV4IGYzOWI0ZTlhMDE3OGY3MDNjNGIzNzE4 Njk3OTM5NWY3M2Y1ZTNjZGEuLjE1MTk3NzhjMzk1NWJiMTQ2YmNhMWY3MzE1MzRlNjEyZGFhYjQ0 YjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Qc2V1ZG9FbGVtZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vUHNldWRvRWxlbWVudC5jcHAKQEAgLTkwLDEwICs5MCw5IEBA IHZvaWQgUHNldWRvRWxlbWVudDo6Y2xlYXJIb3N0RWxlbWVudCgpCiB7CiAgICAgSW5zcGVjdG9y SW5zdHJ1bWVudGF0aW9uOjpwc2V1ZG9FbGVtZW50RGVzdHJveWVkKGRvY3VtZW50KCkucGFnZSgp LCAqdGhpcyk7CiAKLSAgICBpZiAoUnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVy ZXMoKS53ZWJBbmltYXRpb25zQ1NTSW50ZWdyYXRpb25FbmFibGVkKCkpIHsKLSAgICAgICAgaWYg KGF1dG8qIHRpbWVsaW5lID0gZG9jdW1lbnQoKS5leGlzdGluZ1RpbWVsaW5lKCkpCi0gICAgICAg ICAgICB0aW1lbGluZS0+cmVtb3ZlQW5pbWF0aW9uc0ZvckVsZW1lbnQoKnRoaXMpOwotICAgIH0g ZWxzZSBpZiAoYXV0byogZnJhbWUgPSBkb2N1bWVudCgpLmZyYW1lKCkpCisgICAgaWYgKGF1dG8q IHRpbWVsaW5lID0gZG9jdW1lbnQoKS5leGlzdGluZ1RpbWVsaW5lKCkpCisgICAgICAgIHRpbWVs aW5lLT5yZW1vdmVBbmltYXRpb25zRm9yRWxlbWVudCgqdGhpcyk7CisgICAgaWYgKGF1dG8qIGZy YW1lID0gZG9jdW1lbnQoKS5mcmFtZSgpKQogICAgICAgICBmcmFtZS0+YW5pbWF0aW9uKCkuY2Fu Y2VsQW5pbWF0aW9ucygqdGhpcyk7CiAKICAgICBtX2hvc3RFbGVtZW50ID0gbnVsbHB0cjsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCBmZGU2ZDc1OTI3MDI0MmYzZmNlZjRjMmVhYjI4 MWY4MDBmMmNlOWYyLi45ZjY5MjRkN2Q4YTNiYWNkNzg3MDE5YTNiOWY5OGVmNTUzOWUzZjk5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC02MDMsOCArNjAzLDcgQEAgdm9pZCBGcmFt ZVZpZXc6OmRpZERlc3Ryb3lSZW5kZXJUcmVlKCkKICAgICBBU1NFUlQoIW1fdmlld3BvcnRDb25z dHJhaW5lZE9iamVjdHMgfHwgbV92aWV3cG9ydENvbnN0cmFpbmVkT2JqZWN0cy0+aXNFbXB0eSgp KTsKICAgICBBU1NFUlQoIW1fc2xvd1JlcGFpbnRPYmplY3RzIHx8IG1fc2xvd1JlcGFpbnRPYmpl Y3RzLT5pc0VtcHR5KCkpOwogCi0gICAgaWYgKCFSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFy ZWRGZWF0dXJlcygpLndlYkFuaW1hdGlvbnNDU1NJbnRlZ3JhdGlvbkVuYWJsZWQoKSkKLSAgICAg ICAgQVNTRVJUKCFmcmFtZSgpLmFuaW1hdGlvbigpLmhhc0FuaW1hdGlvbnMoKSk7CisgICAgQVNT RVJUKCFmcmFtZSgpLmFuaW1hdGlvbigpLmhhc0FuaW1hdGlvbnMoKSk7CiB9CiAKIHZvaWQgRnJh bWVWaWV3OjpzZXRDb250ZW50c1NpemUoY29uc3QgSW50U2l6ZSYgc2l6ZSkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlVXBkYXRlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZVVwZGF0ZXIuY3Bw CmluZGV4IDRlNGU1ZDM5YzU0YjIyODgwNzNjMzU1N2ExZGQwMjIyZTdhODliNTguLjZkZDBiODc3 YjU5OWE1MGE2NGU4MWIzNWU0YWY5Y2IwM2Y4ZGY1MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlVXBkYXRlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVVcGRhdGVyLmNwcApAQCAtNTU1 LDE1ICs1NTUsMTMgQEAgdm9pZCBSZW5kZXJUcmVlVXBkYXRlcjo6dGVhckRvd25SZW5kZXJlcnMo RWxlbWVudCYgcm9vdCwgVGVhcmRvd25UeXBlIHRlYXJkb3duVHkKICAgICAgICAgICAgIGF1dG8m IGVsZW1lbnQgPSAqdGVhcmRvd25TdGFjay50YWtlTGFzdCgpOwogCiAgICAgICAgICAgICBpZiAo dGVhcmRvd25UeXBlID09IFRlYXJkb3duVHlwZTo6RnVsbCB8fCB0ZWFyZG93blR5cGUgPT0gVGVh cmRvd25UeXBlOjpSZW5kZXJlclVwZGF0ZUNhbmNlbGluZ0FuaW1hdGlvbnMpIHsKLSAgICAgICAg ICAgICAgICBpZiAoUnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKS53ZWJB bmltYXRpb25zQ1NTSW50ZWdyYXRpb25FbmFibGVkKCkpIHsKLSAgICAgICAgICAgICAgICAgICAg aWYgKHRpbWVsaW5lKSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICBpZiAoZG9jdW1lbnQucmVu ZGVyVHJlZUJlaW5nRGVzdHJveWVkKCkpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgdGlt ZWxpbmUtPmVsZW1lbnRXYXNSZW1vdmVkKGVsZW1lbnQpOwotICAgICAgICAgICAgICAgICAgICAg ICAgZWxzZSBpZiAodGVhcmRvd25UeXBlID09IFRlYXJkb3duVHlwZTo6UmVuZGVyZXJVcGRhdGVD YW5jZWxpbmdBbmltYXRpb25zKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRpbWVsaW5l LT5jYW5jZWxEZWNsYXJhdGl2ZUFuaW1hdGlvbnNGb3JFbGVtZW50KGVsZW1lbnQpOwotICAgICAg ICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICAgICAg ICAgIGFuaW1hdGlvbkNvbnRyb2xsZXIuY2FuY2VsQW5pbWF0aW9ucyhlbGVtZW50KTsKKyAgICAg ICAgICAgICAgICBpZiAodGltZWxpbmUpIHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKGRvY3Vt ZW50LnJlbmRlclRyZWVCZWluZ0Rlc3Ryb3llZCgpKQorICAgICAgICAgICAgICAgICAgICAgICAg dGltZWxpbmUtPmVsZW1lbnRXYXNSZW1vdmVkKGVsZW1lbnQpOworICAgICAgICAgICAgICAgICAg ICBlbHNlIGlmICh0ZWFyZG93blR5cGUgPT0gVGVhcmRvd25UeXBlOjpSZW5kZXJlclVwZGF0ZUNh bmNlbGluZ0FuaW1hdGlvbnMpCisgICAgICAgICAgICAgICAgICAgICAgICB0aW1lbGluZS0+Y2Fu Y2VsRGVjbGFyYXRpdmVBbmltYXRpb25zRm9yRWxlbWVudChlbGVtZW50KTsKKyAgICAgICAgICAg ICAgICB9CisgICAgICAgICAgICAgICAgYW5pbWF0aW9uQ29udHJvbGxlci5jYW5jZWxBbmltYXRp b25zKGVsZW1lbnQpOwogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBpZiAodGVhcmRvd25U eXBlID09IFRlYXJkb3duVHlwZTo6RnVsbCkK