190953 2018-10-26 05:09:27 -0700 hashSet.remove(hashSet.random()) doesn't build 2018-10-26 09:28:28 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=190814 InRadar P2 Normal --- 190957 1 koivisto webkit-unassigned benjamin cdumez cmarcelo commit-queue dbates ews-watchlist ggaren webkit-bug-importer oldest_to_newest 1472391 0 koivisto 2018-10-26 05:09:27 -0700 Const version of random() is wrong. 1472393 1 353176 koivisto 2018-10-26 05:15:54 -0700 Created attachment 353176 patch 1472467 2 353176 cdumez 2018-10-26 08:42:09 -0700 Comment on attachment 353176 patch r=me 1472476 3 353176 commit-queue 2018-10-26 09:27:34 -0700 Comment on attachment 353176 patch Clearing flags on attachment: 353176 Committed r237461: <https://trac.webkit.org/changeset/237461> 1472477 4 commit-queue 2018-10-26 09:27:36 -0700 All reviewed patches have been landed. Closing bug. 1472478 5 webkit-bug-importer 2018-10-26 09:28:28 -0700 <rdar://problem/45589738> 353176 2018-10-26 05:15:54 -0700 2018-10-26 09:27:34 -0700 patch hashset-random-const.patch text/plain 3192 koivisto SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzc0NDgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTI2ICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KKworICAgICAgICBoYXNoU2V0LnJlbW92ZShoYXNoU2V0LnJhbmRvbSgp KSBkb2Vzbid0IGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTA5NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHd0Zi9IYXNoU2V0Lmg6CisKKyAgICAgICAgUmVtb3ZlIG5vbi1jb25zdCByYW5k b20oKS4gSGFzaFNldCBvbmx5IHJldHVybnMgY29uc3QgaXRlcmF0b3JzIChpdCBpcyBpbW11dGFi bGUgdmlhIGl0ZXJhdG9yKS4KKworICAgICAgICAqIHd0Zi9IYXNoVGFibGUuaDoKKyAgICAgICAg KFdURjo6SGFzaFRhYmxlOjpyYW5kb20gY29uc3QpOgorCisgICAgICAgIEludm9rZSBjb25zdF9p dGVyYXRvcigpIGJ5IHVzaW5nIHN0YXRpY19jYXN0PD4gaW5zdGVhZCBvZiB0cnlpbmcgdG8gZG8g aXQgZGlyZWN0bHkuCisKIDIwMTgtMTAtMjYgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBh cHBsZS5jb20+CiAKICAgICAgICAgU29tZSBpbnRlcm5hbCBwcm9qZWN0cyBpbmNsdWRlIHd0ZiBo ZWFkZXJzIGFuZCBidWlsZCB3aXRoIEMrKzExCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9IYXNoU2V0 LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvSGFzaFNldC5oCShyZXZpc2lvbiAyMzc0 NDgpCisrKyBTb3VyY2UvV1RGL3d0Zi9IYXNoU2V0LmgJKHdvcmtpbmcgY29weSkKQEAgLTY4LDgg KzY4LDcgQEAgcHVibGljOgogICAgIGl0ZXJhdG9yIGJlZ2luKCkgY29uc3Q7CiAgICAgaXRlcmF0 b3IgZW5kKCkgY29uc3Q7CiAKLSAgICBpdGVyYXRvciByYW5kb20oKSB7IHJldHVybiBtX2ltcGwu cmFuZG9tKCk7IH0KLSAgICBjb25zdF9pdGVyYXRvciByYW5kb20oKSBjb25zdCB7IHJldHVybiBt X2ltcGwucmFuZG9tKCk7IH0KKyAgICBpdGVyYXRvciByYW5kb20oKSBjb25zdCB7IHJldHVybiBt X2ltcGwucmFuZG9tKCk7IH0KIAogICAgIGl0ZXJhdG9yIGZpbmQoY29uc3QgVmFsdWVUeXBlJikg Y29uc3Q7CiAgICAgYm9vbCBjb250YWlucyhjb25zdCBWYWx1ZVR5cGUmKSBjb25zdDsKSW5kZXg6 IFNvdXJjZS9XVEYvd3RmL0hhc2hUYWJsZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3Rm L0hhc2hUYWJsZS5oCShyZXZpc2lvbiAyMzc0NDgpCisrKyBTb3VyY2UvV1RGL3d0Zi9IYXNoVGFi bGUuaAkod29ya2luZyBjb3B5KQpAQCAtMzkwLDcgKzM5MCw3IEBAIG5hbWVzcGFjZSBXVEYgewog ICAgICAgICAgICAgcmV0dXJuIGl0OwogICAgICAgICB9CiAKLSAgICAgICAgY29uc3RfaXRlcmF0 b3IgcmFuZG9tKCkgY29uc3QgeyByZXR1cm4gY29uc3RfY2FzdDxIYXNoVGFibGUqPih0aGlzKS0+ cmFuZG9tKCkuY29uc3RfaXRlcmF0b3IoKTsgfQorICAgICAgICBjb25zdF9pdGVyYXRvciByYW5k b20oKSBjb25zdCB7IHJldHVybiBzdGF0aWNfY2FzdDxjb25zdF9pdGVyYXRvcj4oY29uc3RfY2Fz dDxIYXNoVGFibGUqPih0aGlzKS0+cmFuZG9tKCkpOyB9CiAKICAgICAgICAgdW5zaWduZWQgc2l6 ZSgpIGNvbnN0IHsgcmV0dXJuIG1fa2V5Q291bnQ7IH0KICAgICAgICAgdW5zaWduZWQgY2FwYWNp dHkoKSBjb25zdCB7IHJldHVybiBtX3RhYmxlU2l6ZTsgfQpJbmRleDogVG9vbHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMjM3NDQ4KQorKysgVG9v bHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMTAtMjYg IEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIGhhc2hTZXQucmVt b3ZlKGhhc2hTZXQucmFuZG9tKCkpIGRvZXNuJ3QgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDk1MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvSGFz aFNldC5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxOC0xMC0yNSAg Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtQU09OXSBOYXZpZ2F0 aW5nIGNyb3NzLXNpdGUgd2l0aCBsb2NrZWQgaGlzdG9yeSBidXQgdW5sb2NrZWQgYmFjay9mb3J3 YXJkIGxpc3QgZmFpbHMgdG8gY3JlYXRlIGEgbmV3IEJhY2tGb3J3YXJkTGlzdEl0ZW0KSW5kZXg6 IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0hhc2hTZXQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0hhc2hTZXQuY3BwCShyZXZpc2lvbiAyMzc0 NDgpCisrKyBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9IYXNoU2V0LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDU3LDQgKzQ1NywxMyBAQCBURVNUKFdURl9IYXNoU2V0LCBEZWxldGVkQWRk cmVzc09mT3BlcmF0CiAgICAgc2V0MS5yZW1vdmUoMTApOwogfQogCitURVNUKFdURl9IYXNoU2V0 LCBSZW1vdmVSYW5kb20pCit7CisgICAgSGFzaFNldDx1bnNpZ25lZD4gc2V0MSB7IDEsIDIsIDMg fTsKKyAgICBzZXQxLnJlbW92ZShzZXQxLnJhbmRvbSgpKTsKKyAgICBzZXQxLnJlbW92ZShzZXQx LnJhbmRvbSgpKTsKKyAgICBzZXQxLnJlbW92ZShzZXQxLnJhbmRvbSgpKTsKKyAgICBBU1NFUlRf VFJVRShzZXQxLmlzRW1wdHkoKSk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkK