<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>190952</bug_id>
          
          <creation_ts>2018-10-26 05:01:38 -0700</creation_ts>
          <short_desc>JSC xcconfig should set DEFINES_MODULE</short_desc>
          <delta_ts>2018-10-26 09:48:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Keith Miller">keith_miller</reporter>
          <assigned_to name="Keith Miller">keith_miller</assigned_to>
          <cc>aestes</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>mark.lam</cc>
    
    <cc>mitz</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1472390</commentid>
    <comment_count>0</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-10-26 05:01:38 -0700</bug_when>
    <thetext>JSC xcconfig should set DEFINES_MODULE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472392</commentid>
    <comment_count>1</comment_count>
      <attachid>353175</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-10-26 05:10:31 -0700</bug_when>
    <thetext>Created attachment 353175
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472479</commentid>
    <comment_count>2</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-10-26 09:41:09 -0700</bug_when>
    <thetext>rdar://problem/45169447</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472480</commentid>
    <comment_count>3</comment_count>
      <attachid>353175</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-10-26 09:41:57 -0700</bug_when>
    <thetext>Comment on attachment 353175
Patch

rs=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472482</commentid>
    <comment_count>4</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-10-26 09:48:11 -0700</bug_when>
    <thetext>Committed r237462: &lt;https://trac.webkit.org/changeset/237462&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>353175</attachid>
            <date>2018-10-26 05:10:31 -0700</date>
            <delta_ts>2018-10-26 09:41:57 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190952-20181026141030.patch</filename>
            <type>text/plain</type>
            <size>2265</size>
            <attacher name="Keith Miller">keith_miller</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NDQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi
NGNiZDYwODYyMDI5YjdiMzBiZGI0ZTMzMzBkMjg1ZDNhYjMzMGJjLi40ODEwMzQ3ZTY4NjhmNTJh
MDdmYTc3ODU1NGM1NWJiMjI5OTA0NDdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxOC0xMC0yNiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl
LmNvbT4KKworICAgICAgICBKU0MgeGNjb25maWcgc2hvdWxkIHNldCBERUZJTkVTX01PRFVMRQor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwOTUyCisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBzaG91
bGQgbWVhbiB0aGF0IHRoZSBKYXZhU2NyaXB0Q29yZS5mcmFtZXdvcmsgd2lsbCBoYXZlIGEgbW9k
dWxlIG1hcC4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL0phdmFTY3JpcHRDb3JlLnhjY29u
ZmlnOgorCiAyMDE4LTEwLTI1ICBZdXN1a2UgU3V6dWtpICA8eXVzdWtlc3V6dWtpQHNsb3dzdGFy
dC5vcmc+CiAKICAgICAgICAgW0pTQ10gaGF2aW5nQUJhZFRpbWVXYXRjaHBvaW50IGlzIG5vdCBy
ZXF1aXJlZCBpbiBBcnJheSNpbmRleE9mIG9wdGltaXphdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNl
L0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL0phdmFTY3JpcHRDb3JlLnhjY29uZmlnIGIv
U291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL0phdmFTY3JpcHRDb3JlLnhjY29u
ZmlnCmluZGV4IDg4OTQ5ZDEyNTBjZjQ2ODQ2NWZiOGUyZTA5NTQxMDVhZmM4OWQyZTQuLmU4Mjhh
NzVlZjkwZGM2NWNiNzljZmMzNWUzNzllMjBkMDVmZWM0ZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K
YXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9KYXZhU2NyaXB0Q29yZS54Y2NvbmZpZworKysg
Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvSmF2YVNjcmlwdENvcmUueGNj
b25maWcKQEAgLTI0LDYgKzI0LDggQEAKICNpbmNsdWRlICJGZWF0dXJlRGVmaW5lcy54Y2NvbmZp
ZyIKICNpbmNsdWRlICJWZXJzaW9uLnhjY29uZmlnIgogCitERUZJTkVTX01PRFVMRSA9IFlFUzsK
KwogLy8gUHJldmVudCBDKysgc3RhbmRhcmQgbGlicmFyeSBvcGVyYXRvciBuZXcsIGRlbGV0ZSBh
bmQgdGhlaXIgcmVsYXRlZCBleGNlcHRpb24gdHlwZXMgZnJvbSBiZWluZyBleHBvcnRlZCBhcyB3
ZWFrIHN5bWJvbHMuCiBPVEhFUl9MREZMQUdTX0hJREVfU1lNQk9MUyA9IC1XbCwtdW5leHBvcnRl
ZF9zeW1ib2wsX19aVElTdDliYWRfYWxsb2MgLVdsLC11bmV4cG9ydGVkX3N5bWJvbCxfX1pUSVN0
OWV4Y2VwdGlvbiAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sLF9fWlRTU3Q5YmFkX2FsbG9jIC1XbCwt
dW5leHBvcnRlZF9zeW1ib2wsX19aVFNTdDlleGNlcHRpb24gLVdsLC11bmV4cG9ydGVkX3N5bWJv
bCxfX1pkbFB2U18gLVdsLC11bmV4cG9ydGVkX3N5bWJvbCxfX1pud21QdiAtV2wsLXVuZXhwb3J0
ZWRfc3ltYm9sLF9fWk5LU3QzX18xOGZ1bmN0aW9uSUZ2dkVFY2xFdiAtV2wsLXVuZXhwb3J0ZWRf
c3ltYm9sLF9fWk5TdDNfXzE4ZnVuY3Rpb25JRnZ2RUVDMUVPUzJfIC1XbCwtdW5leHBvcnRlZF9z
eW1ib2wsX19aTlN0M19fMThmdW5jdGlvbklGdnZFRUMyRU9TMl8gLVdsLC11bmV4cG9ydGVkX3N5
bWJvbCxfX1pOS1N0M19fMThmdW5jdGlvbklGdlJOM0pTQzE3Qnl0ZWNvZGVHZW5lcmF0b3JFUE5T
MV8xMFJlZ2lzdGVySURFRUVjbEVTM19TNV8gLVdsLC11bmV4cG9ydGVkX3N5bWJvbCxfX1pOU3Qz
X18xOGZ1bmN0aW9uSUZ2Uk4zSlNDMTdCeXRlY29kZUdlbmVyYXRvckVQTlMxXzEwUmVnaXN0ZXJJ
REVFRUQxRXYgLVdsLC11bmV4cG9ydGVkX3N5bWJvbCxfX1pOU3QzX18xOGZ1bmN0aW9uSUZ2Uk4z
SlNDMTdCeXRlY29kZUdlbmVyYXRvckVQTlMxXzEwUmVnaXN0ZXJJREVFRUQyRXYgLVdsLC11bmV4
cG9ydGVkX3N5bWJvbCxfX1pOU3QzX18xOGZ1bmN0aW9uSUZ2dkVFRDFFdiAtV2wsLXVuZXhwb3J0
ZWRfc3ltYm9sLF9fWk5TdDNfXzE4ZnVuY3Rpb25JRnZ2RUVEMkV2IC1XbCwtdW5leHBvcnRlZF9z
eW1ib2wsX19aVFZOU3QzX18xMTdiYWRfZnVuY3Rpb25fY2FsbEU7CiAK
</data>
<flag name="review"
          id="370386"
          type_id="1"
          status="+"
          setter="mark.lam"
    />
          </attachment>
      

    </bug>

</bugzilla>