190945 2018-10-25 21:28:32 -0700 [LFC][IFC] Add more inline information to outputLayoutTree 2018-10-26 07:46:25 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham ews-watchlist koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1472323 0 zalan 2018-10-25 21:28:32 -0700 ssia. 1472324 1 353156 zalan 2018-10-25 21:29:44 -0700 Created attachment 353156 Patch 1472421 2 ews-watchlist 2018-10-26 07:22:34 -0700 Attachment 353156 did not pass style-queue: ERROR: Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:152: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1472444 3 zalan 2018-10-26 07:45:58 -0700 Committed r237457: <https://trac.webkit.org/changeset/237457> 1472445 4 webkit-bug-importer 2018-10-26 07:46:25 -0700 <rdar://problem/45587217> 353156 2018-10-25 21:29:44 -0700 2018-10-26 07:25:17 -0700 Patch Patch.txt text/plain 3258 zalan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NjE3MDFjNjg0ZS4uMmQxMjA5Y2EwYmYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOC0xMC0yNSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgor CisgICAgICAgIFtMRkNdW0lGQ10gQWRkIG1vcmUgaW5saW5lIGluZm9ybWF0aW9uIHRvIG91dHB1 dExheW91dFRyZWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MDk0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0VHJlZUJ1aWxkZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TGF5b3V0OjpvdXRwdXRJbmxpbmVSdW5zKToKKyAgICAgICAgKFdlYkNvcmU6Okxh eW91dDo6b3V0cHV0TGF5b3V0Qm94KToKKwogMjAxOC0xMC0yNSAgWmFsYW4gQnVqdGFzICA8emFs YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gTGF5b3V0IGZsb2F0cyBhcyBwYXJ0 IG9mIHRoZSBpbmxpbmUgY29udGVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2xheW91dHRyZWUvTGF5b3V0VHJlZUJ1aWxkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2xheW91dHRyZWUvTGF5b3V0VHJlZUJ1aWxkZXIuY3BwCmluZGV4IDk0NDk1NDdjZjJkLi4xZjky ZDBhNjc5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5 b3V0VHJlZUJ1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVl L0xheW91dFRyZWVCdWlsZGVyLmNwcApAQCAtMTQ4LDYgKzE0OCw4IEBAIHN0YXRpYyB2b2lkIG91 dHB1dElubGluZVJ1bnMoVGV4dFN0cmVhbSYgc3RyZWFtLCBjb25zdCBMYXlvdXRDb250ZXh0JiBs YXlvdXRDb250CiAgICAgICAgIHN0cmVhbSA8PCAicnVuIjsKICAgICAgICAgaWYgKGlubGluZVJ1 bi50ZXh0Q29udGV4dCgpKQogICAgICAgICAgICAgc3RyZWFtIDw8ICIoIiA8PCBpbmxpbmVSdW4u dGV4dENvbnRleHQoKS0+c3RhcnQoKSA8PCAiLCAiIDw8IGlubGluZVJ1bi50ZXh0Q29udGV4dCgp LT5zdGFydCgpICsgaW5saW5lUnVuLnRleHRDb250ZXh0KCktPmxlbmd0aCgpIDw8ICIpICI7Cisg ICAgICAgIGVsc2UKKyAgICAgICAgICAgIHN0cmVhbSA8PCAiKHgsIHgpICI7OwogICAgICAgICBz dHJlYW0gPDwgIigiIDw8IGlubGluZVJ1bi5sb2dpY2FsTGVmdCgpIDw8ICIsICIgPDwgaW5saW5l UnVuLmxvZ2ljYWxSaWdodCgpIDw8ICIpIjsKICAgICAgICAgc3RyZWFtLm5leHRMaW5lKCk7CiAg ICAgfQpAQCAtMTYxLDkgKzE2MywxNSBAQCBzdGF0aWMgdm9pZCBvdXRwdXRMYXlvdXRCb3goVGV4 dFN0cmVhbSYgc3RyZWFtLCBjb25zdCBCb3gmIGxheW91dEJveCwgY29uc3QgRGlzcAogCiAgICAg aWYgKGlzPElubGluZUNvbnRhaW5lcj4obGF5b3V0Qm94KSkKICAgICAgICAgc3RyZWFtIDw8ICJp bmxpbmUgY29udGFpbmVyIjsKLSAgICBlbHNlIGlmIChpczxJbmxpbmVCb3g+KGxheW91dEJveCkp Ci0gICAgICAgIHN0cmVhbSA8PCAiaW5saW5lIGJveCI7Ci0gICAgZWxzZSBpZiAoaXM8QmxvY2tD b250YWluZXI+KGxheW91dEJveCkpIHsKKyAgICBlbHNlIGlmIChpczxJbmxpbmVCb3g+KGxheW91 dEJveCkpIHsKKyAgICAgICAgaWYgKGxheW91dEJveC5yZXBsYWNlZCgpKQorICAgICAgICAgICAg c3RyZWFtIDw8ICJpbmxpbmUgcmVwbGFjZWQgYm94IjsKKyAgICAgICAgZWxzZSBpZiAoZG93bmNh c3Q8SW5saW5lQm94PihsYXlvdXRCb3gpLmhhc1RleHRDb250ZW50KCkpIHsKKyAgICAgICAgICAg IGF1dG8gdGV4dENvbnRlbnQgPSBkb3duY2FzdDxJbmxpbmVCb3g+KGxheW91dEJveCkudGV4dENv bnRlbnQoKTsKKyAgICAgICAgICAgIHN0cmVhbSA8PCAiaW5saW5lIHRleHQgW1wiIiA8PCB0ZXh0 Q29udGVudC51dGY4KCkuZGF0YSgpIDw8ICJcIl0iOworICAgICAgICB9IGVsc2UKKyAgICAgICAg ICAgIHN0cmVhbSA8PCAiaW5saW5lIGJveCI7CisgICAgfSBlbHNlIGlmIChpczxCbG9ja0NvbnRh aW5lcj4obGF5b3V0Qm94KSkgewogICAgICAgICBpZiAoIWxheW91dEJveC5wYXJlbnQoKSkKICAg ICAgICAgICAgIHN0cmVhbSA8PCAiaW5pdGlhbCAiOwogICAgICAgICBzdHJlYW0gPDwgImJsb2Nr IGNvbnRhaW5lciI7CkBAIC0xNzEsMTMgKzE3OSwxMyBAQCBzdGF0aWMgdm9pZCBvdXRwdXRMYXlv dXRCb3goVGV4dFN0cmVhbSYgc3RyZWFtLCBjb25zdCBCb3gmIGxheW91dEJveCwgY29uc3QgRGlz cAogICAgICAgICBzdHJlYW0gPDwgImJveCI7CiAgICAgLy8gRklYTUU6IElubGluZSB0ZXh0IHJ1 bnMgZG9uJ3QgY3JlYXRlIGRpc3BsYXkgYm94ZXMgeWV0LgogICAgIGlmIChkaXNwbGF5Qm94KSB7 Ci0gICAgICAgIGlmIChpczxJbmxpbmVCb3g+KGxheW91dEJveCkgfHwgaXM8SW5saW5lQ29udGFp bmVyPihsYXlvdXRCb3gpKSB7Ci0gICAgICAgICAgICAvLyBGSVhNRTogZGlzcGxheSBib3ggaXMg bm90IGNvbXBsZXRlbHkgc2V0IHlldC4KKyAgICAgICAgLy8gRklYTUU6IGRpc3BsYXkgYm94IGlz IG5vdCBjb21wbGV0ZWx5IHNldCB5ZXQuCisgICAgICAgIGlmICgoaXM8SW5saW5lQm94PihsYXlv dXRCb3gpIHx8IGlzPElubGluZUNvbnRhaW5lcj4obGF5b3V0Qm94KSkgJiYgIWxheW91dEJveC5p c0Zsb2F0aW5nUG9zaXRpb25lZCgpKQogICAgICAgICAgICAgc3RyZWFtIDw8ICIgYXQgWyIgPDwg Ii4iIDw8ICIgIiA8PCAiLiIgPDwgIl0gc2l6ZSBbIiA8PCBkaXNwbGF5Qm94LT53aWR0aCgpIDw8 ICIgIiA8PCBkaXNwbGF5Qm94LT5oZWlnaHQoKSA8PCAiXSI7Ci0gICAgICAgIH0gZWxzZQorICAg ICAgICBlbHNlCiAgICAgICAgICAgICBzdHJlYW0gPDwgIiBhdCBbIiA8PCBkaXNwbGF5Qm94LT5s ZWZ0KCkgPDwgIiAiIDw8IGRpc3BsYXlCb3gtPnRvcCgpIDw8ICJdIHNpemUgWyIgPDwgZGlzcGxh eUJveC0+d2lkdGgoKSA8PCAiICIgPDwgZGlzcGxheUJveC0+aGVpZ2h0KCkgPDwgIl0iOwogICAg IH0KLSAgICBzdHJlYW0gPDwgIiBvYmplY3QgWyIgPDwgJmxheW91dEJveCA8PCAiXSI7CisgICAg c3RyZWFtIDw8ICIgWyIgPDwgJmxheW91dEJveCA8PCAiXSI7CiAKICAgICBzdHJlYW0ubmV4dExp bmUoKTsKIH0K