<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>190937</bug_id>
          
          <creation_ts>2018-10-25 18:23:43 -0700</creation_ts>
          <short_desc>Use dark appearance scrollbar when page background is dark or document supports dark mode</short_desc>
          <delta_ts>2018-11-02 13:29:06 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>WebKit Local Build</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>macOS 10.14</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Timothy Hatcher">timothy</reporter>
          <assigned_to name="Timothy Hatcher">timothy</assigned_to>
          <cc>bdakin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>mehmet.sahin</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1472278</commentid>
    <comment_count>0</comment_count>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2018-10-25 18:23:43 -0700</bug_when>
    <thetext>Use new delegate for NSScrollerImp to give an NSAppearance to use for async scrollbars.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472279</commentid>
    <comment_count>1</comment_count>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2018-10-25 18:23:53 -0700</bug_when>
    <thetext>&lt;rdar://problem/41225839&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472282</commentid>
    <comment_count>2</comment_count>
      <attachid>353138</attachid>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2018-10-25 18:31:58 -0700</bug_when>
    <thetext>Created attachment 353138
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472311</commentid>
    <comment_count>3</comment_count>
      <attachid>353151</attachid>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2018-10-25 20:45:50 -0700</bug_when>
    <thetext>Created attachment 353151
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472497</commentid>
    <comment_count>4</comment_count>
      <attachid>353151</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-10-26 10:47:20 -0700</bug_when>
    <thetext>Comment on attachment 353151
Patch

Clearing flags on attachment: 353151

Committed r237466: &lt;https://trac.webkit.org/changeset/237466&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1472498</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-10-26 10:47:21 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1474607</commentid>
    <comment_count>6</comment_count>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2018-11-02 13:29:06 -0700</bug_when>
    <thetext>*** Bug 191140 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>353138</attachid>
            <date>2018-10-25 18:31:58 -0700</date>
            <delta_ts>2018-10-25 20:45:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190937-20181025183157.patch</filename>
            <type>text/plain</type>
            <size>6151</size>
            <attacher name="Timothy Hatcher">timothy</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE1YjY1ZjI2M2I2OGFk
NmUwNGM4OGE5MzZkNjQwMjRiNTk4NzZkMy4uYzg2OGI3ODM1OWZkMDI2OGJiMmZiYjQ1MDBlNGQ4
NGY2NmEyZGEwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTEwLTI1ICBUaW1v
dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgZGFyayBhcHBl
YXJhbmNlIHNjcm9sbGJhciB3aGVuIHBhZ2UgYmFja2dyb3VuZCBpcyBkYXJrIG9yIGRvY3VtZW50
IHN1cHBvcnRzIGRhcmsgbW9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE5MDkzNworICAgICAgICByZGFyOi8vcHJvYmxlbS80MTIyNTgzOQorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9GcmFt
ZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3Ojp1c2VEYXJrQXBwZWFyYW5j
ZSBjb25zdCk6IEFkZGVkLiBBc2sgdGhlIGRvY3VtZW50LgorICAgICAgICAqIHBhZ2UvRnJhbWVW
aWV3Lmg6CisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsYWJsZUFyZWEuaDoKKyAgICAgICAgKFdl
YkNvcmU6OlNjcm9sbGFibGVBcmVhOjp1c2VEYXJrQXBwZWFyYW5jZSBjb25zdCk6IEFkZGVkLiBE
ZWZhdWx0IHRvIGZhbHNlLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1h
Yy5tbToKKyAgICAgICAgKC1bV2ViU2Nyb2xsZXJJbXBEZWxlZ2F0ZSBlZmZlY3RpdmVBcHBlYXJh
bmNlRm9yU2Nyb2xsZXJJbXA6XSk6IEFkZGVkLgorICAgICAgICBBc2sgdGhlIFNjcm9sbGFibGVB
cmVhIGlmIGEgZGFyayBhcHBlYXJhbmNlIGlzIGRlc2lyZWQuCisKIDIwMTgtMTAtMjUgIEpvbiBE
YXZpcyAgPGpvbmRAYXBwbGUuY29tPgogCiAgICAgICAgIENoYW5nZWQgIlVuZGVyIERldmVsb3Bt
ZW50IiBzdGF0dXMgdG8gdXNlICJJbiBEZXZlbG9wbWVudCIgaW5zdGVhZApkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VM
b2cKaW5kZXggMzVhZGE3MjMxY2RmZGY1MWUxNjk2OGVkZjc1M2FlMjVkNDdlYjE0Yy4uNmVhYzM5
Zjg1ZjRmODViYTNjOTIwMGE5ZDM4MjA5NzVkNDYxYTFhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvUEFML0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMTgtMTAtMjUgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBw
bGUuY29tPgorCisgICAgICAgIFVzZSBkYXJrIGFwcGVhcmFuY2Ugc2Nyb2xsYmFyIHdoZW4gcGFn
ZSBiYWNrZ3JvdW5kIGlzIGRhcmsgb3IgZG9jdW1lbnQgc3VwcG9ydHMgZGFyayBtb2RlLgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwOTM3CisgICAg
ICAgIHJkYXI6Ly9wcm9ibGVtLzQxMjI1ODM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgKiBwYWwvc3BpL21hYy9OU1Njcm9sbGVySW1wU1BJLmg6IEFk
ZGVkIGVmZmVjdGl2ZUFwcGVhcmFuY2VGb3JTY3JvbGxlckltcDouCisKIDIwMTgtMTAtMjQgIEFs
ZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgc29t
ZSBvYnNvbGV0ZSBtYWNPUyB2ZXJzaW9uIGd1YXJkcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv
cmUvUEFML3BhbC9zcGkvbWFjL05TU2Nyb2xsZXJJbXBTUEkuaCBiL1NvdXJjZS9XZWJDb3JlL1BB
TC9wYWwvc3BpL21hYy9OU1Njcm9sbGVySW1wU1BJLmgKaW5kZXggYWRmMTEwYTk2ZjlhM2IzOTcy
ZWRkNGUzZWU2MjllZjA5NGE2ZWQ2MS4uOWQ2MzBkODI4ZDA5MmMxN2ZmMjkwMGYxNWZhY2ExMzJl
ZGY4NWZmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TU2Ny
b2xsZXJJbXBTUEkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNTY3Jv
bGxlckltcFNQSS5oCkBAIC0xMDYsNiArMTA2LDcgQEAgdHlwZWRlZiBOU1VJbnRlZ2VyIE5TT3Zl
cmxheVNjcm9sbGVyU3RhdGU7CiAtIChOU1BvaW50KW1vdXNlTG9jYXRpb25JblNjcm9sbGVyRm9y
U2Nyb2xsZXJJbXA6KE5TU2Nyb2xsZXJJbXAgKilzY3JvbGxlckltcDsKIC0gKE5TUmVjdCljb252
ZXJ0UmVjdFRvTGF5ZXI6KE5TUmVjdClhUmVjdDsKIC0gKEJPT0wpc2hvdWxkVXNlTGF5ZXJQZXJQ
YXJ0Rm9yU2Nyb2xsZXJJbXA6KE5TU2Nyb2xsZXJJbXAgKilzY3JvbGxlckltcDsKKy0gKE5TQXBw
ZWFyYW5jZSAqKWVmZmVjdGl2ZUFwcGVhcmFuY2VGb3JTY3JvbGxlckltcDooTlNTY3JvbGxlcklt
cCAqKXNjcm9sbGVySW1wOwogQGVuZAogCiBAcHJvdG9jb2wgTlNTY3JvbGxlckltcFBhaXJEZWxl
Z2F0ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1Nv
dXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCBmZGU2ZDc1OTI3MDI0MmYzZmNl
ZjRjMmVhYjI4MWY4MDBmMmNlOWYyLi44ODkyOWQ5NTIyYWZkM2Q0MThmY2NlMjczZTU0MzUyZjVk
MzEzZDI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysr
IGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0yMDM1LDYgKzIwMzUsMTMg
QEAgYm9vbCBGcmFtZVZpZXc6OnNob3VsZFNldEN1cnNvcigpIGNvbnN0CiAgICAgcmV0dXJuIHBh
Z2UgJiYgcGFnZS0+aXNWaXNpYmxlKCkgJiYgcGFnZS0+Zm9jdXNDb250cm9sbGVyKCkuaXNBY3Rp
dmUoKTsKIH0KIAorYm9vbCBGcmFtZVZpZXc6OnVzZURhcmtBcHBlYXJhbmNlKCkgY29uc3QKK3sK
KyAgICBBU1NFUlQoZnJhbWUoKS5kb2N1bWVudCgpKTsKKyAgICBhdXRvJiBkb2N1bWVudCA9ICpm
cmFtZSgpLmRvY3VtZW50KCk7CisgICAgcmV0dXJuIGRvY3VtZW50LnVzZURhcmtBcHBlYXJhbmNl
KCk7Cit9CisKIGJvb2wgRnJhbWVWaWV3OjpzY3JvbGxDb250ZW50c0Zhc3RQYXRoKGNvbnN0IElu
dFNpemUmIHNjcm9sbERlbHRhLCBjb25zdCBJbnRSZWN0JiByZWN0VG9TY3JvbGwsIGNvbnN0IElu
dFJlY3QmIGNsaXBSZWN0KQogewogICAgIGlmICghbV92aWV3cG9ydENvbnN0cmFpbmVkT2JqZWN0
cyB8fCBtX3ZpZXdwb3J0Q29uc3RyYWluZWRPYmplY3RzLT5pc0VtcHR5KCkpIHsKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdl
L0ZyYW1lVmlldy5oCmluZGV4IDNjMDVkMWYzM2VlMzUzYzQzNWQzM2NiNDM0ZGQ4ZGQyNWVlZmMx
NzMuLjI4NzBhMTNjYmY4ZThlMjU0ZTY0NWFjYTFhYjBhMzJiOTQ4ZmZkYWMgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn
ZS9GcmFtZVZpZXcuaApAQCAtNTA3LDYgKzUwNyw4IEBAIHB1YmxpYzoKICAgICBib29sIGlzSGFu
ZGxpbmdXaGVlbEV2ZW50KCkgY29uc3QgZmluYWw7CiAgICAgYm9vbCBzaG91bGRTZXRDdXJzb3Io
KSBjb25zdDsKIAorICAgIGJvb2wgdXNlRGFya0FwcGVhcmFuY2UoKSBjb25zdCBmaW5hbDsKKwog
ICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyBtZXRob2Qgb25jZSBwbHVnaW4gbG9hZGluZyBpcyBk
ZWNvdXBsZWQgZnJvbSBsYXlvdXQuCiAgICAgdm9pZCBmbHVzaEFueVBlbmRpbmdQb3N0TGF5b3V0
VGFza3MoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYWJs
ZUFyZWEuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGFibGVBcmVhLmgKaW5kZXgg
YTkyZDQ1Njg3OWMxMjY3ODI0YjdhM2VmYmViZDYzMDlkNWU3NTNmYi4uZTE1ZWMzZjEzNTlmMmE2
MDc4YjczODQzMGIyMmU2NGY0MTM3NzJhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vU2Nyb2xsYWJsZUFyZWEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3Jv
bGxhYmxlQXJlYS5oCkBAIC0yNTEsNiArMjUxLDggQEAgcHVibGljOgogICAgIC8vIFRoZSB0b3Rh
bENvbnRlbnRzU2l6ZSgpIGlzIGVxdWl2YWxlbnQgdG8gdGhlIGNvbnRlbnRzU2l6ZSgpIHBsdXMg
dGhlIGhlYWRlciBhbmQgZm9vdGVyIGhlaWdodHMuCiAgICAgV0VCQ09SRV9FWFBPUlQgSW50U2l6
ZSB0b3RhbENvbnRlbnRzU2l6ZSgpIGNvbnN0OwogCisgICAgdmlydHVhbCBib29sIHVzZURhcmtB
cHBlYXJhbmNlKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KKwogICAgIHZpcnR1YWwgYm9vbCBz
aG91bGRTdXNwZW5kU2Nyb2xsQW5pbWF0aW9ucygpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KICAg
ICBXRUJDT1JFX0VYUE9SVCB2aXJ0dWFsIHZvaWQgc2Nyb2xsYmFyU3R5bGVDaGFuZ2VkKFNjcm9s
bGJhclN0eWxlIC8qbmV3U3R5bGUqLywgYm9vbCAvKmZvcmNlVXBkYXRlKi8pOwogICAgIHZpcnR1
YWwgdm9pZCBzZXRWaXNpYmxlU2Nyb2xsZXJUaHVtYlJlY3QoY29uc3QgSW50UmVjdCYpIHsgfQpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFj
Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tCmlu
ZGV4IGUwODhlM2NkNTJlMGE1YjQ5ZGM1OTYxYzUzNTcwMzQwNGRjMjBiODcuLjljYjFlY2NkN2Q3
NmZlZjQxYjBhYTk1Y2NmNDU3ZTdiOTY4NWY0YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0KQEAgLTUyNyw2ICs1MjcsMjAgQEAgLSAo
Qk9PTClzaG91bGRVc2VMYXllclBlclBhcnRGb3JTY3JvbGxlckltcDooTlNTY3JvbGxlckltcCAq
KXNjcm9sbGVySW1wCiAgICAgcmV0dXJuIF9zY3JvbGxiYXItPnN1cHBvcnRzVXBkYXRlT25TZWNv
bmRhcnlUaHJlYWQoKTsKIH0KIAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQg
Pj0gMTAxNDAwCistIChOU0FwcGVhcmFuY2UgKillZmZlY3RpdmVBcHBlYXJhbmNlRm9yU2Nyb2xs
ZXJJbXA6KE5TU2Nyb2xsZXJJbXAgKilzY3JvbGxlckltcAoreworICAgIFVOVVNFRF9QQVJBTShz
Y3JvbGxlckltcCk7CisKKyAgICBpZiAoIV9zY3JvbGxiYXIpCisgICAgICAgIHJldHVybiBbTlNB
cHBlYXJhbmNlIGN1cnJlbnRBcHBlYXJhbmNlXTsKKworICAgIC8vIElmIGRhcmsgYXBwZWFyYW5j
ZSBpcyB1c2VkIG9yIHRoZSBvdmVybGF5IHN0eWxlIGlzIGxpZ2h0IChiZWNhdXNlIG9mIGEgZGFy
ayBwYWdlIGJhY2tncm91bmQpLCByZXR1cm4gdGhlIGRhcmsgYXBwcGVhcmFuY2UuCisgICAgYm9v
bCB1c2VEYXJrQXBwZWFyYW5jZSA9IF9zY3JvbGxiYXItPnNjcm9sbGFibGVBcmVhKCkudXNlRGFy
a0FwcGVhcmFuY2UoKSB8fCBfc2Nyb2xsYmFyLT5zY3JvbGxhYmxlQXJlYSgpLnNjcm9sbGJhck92
ZXJsYXlTdHlsZSgpID09IFdlYkNvcmU6OlNjcm9sbGJhck92ZXJsYXlTdHlsZUxpZ2h0OworICAg
IHJldHVybiBbTlNBcHBlYXJhbmNlIGFwcGVhcmFuY2VOYW1lZDp1c2VEYXJrQXBwZWFyYW5jZSA/
IE5TQXBwZWFyYW5jZU5hbWVEYXJrQXF1YSA6IE5TQXBwZWFyYW5jZU5hbWVBcXVhXTsKK30KKyNl
bmRpZgorCiAtICh2b2lkKXNldFVwQWxwaGFBbmltYXRpb246KFJldGFpblB0cjxXZWJTY3JvbGxi
YXJQYXJ0QW5pbWF0aW9uPiYpc2Nyb2xsYmFyUGFydEFuaW1hdGlvbiBzY3JvbGxlclBhaW50ZXI6
KE5TU2Nyb2xsZXJJbXAgKilzY3JvbGxlclBhaW50ZXIgcGFydDooV2ViQ29yZTo6U2Nyb2xsYmFy
UGFydClwYXJ0IGFuaW1hdGVBbHBoYVRvOihDR0Zsb2F0KW5ld0FscGhhIGR1cmF0aW9uOihOU1Rp
bWVJbnRlcnZhbClkdXJhdGlvbgogewogICAgIC8vIElmIHRoZSB1c2VyIGhhcyBzY3JvbGxlZCB0
aGUgcGFnZSwgdGhlbiB0aGUgc2Nyb2xsYmFycyBtdXN0IGJlIGFuaW1hdGVkIGhlcmUuCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>353151</attachid>
            <date>2018-10-25 20:45:50 -0700</date>
            <delta_ts>2018-10-26 10:47:20 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190937-20181025204550.patch</filename>
            <type>text/plain</type>
            <size>7363</size>
            <attacher name="Timothy Hatcher">timothy</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE1YjY1ZjI2M2I2OGFk
NmUwNGM4OGE5MzZkNjQwMjRiNTk4NzZkMy4uZTc3NDBmZTU5OWZmNTAyZDFjNmVhYjM2OWQwY2M3
MWE0YzRiNjAxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTEwLTI1ICBUaW1v
dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgZGFyayBhcHBl
YXJhbmNlIHNjcm9sbGJhciB3aGVuIHBhZ2UgYmFja2dyb3VuZCBpcyBkYXJrIG9yIGRvY3VtZW50
IHN1cHBvcnRzIGRhcmsgbW9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE5MDkzNworICAgICAgICByZGFyOi8vcHJvYmxlbS80MTIyNTgzOQorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9GcmFt
ZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3Ojp1c2VEYXJrQXBwZWFyYW5j
ZSBjb25zdCk6IEFkZGVkLiBBc2sgdGhlIGRvY3VtZW50LgorICAgICAgICAoV2ViQ29yZTo6RnJh
bWVWaWV3OjpwYWludFNjcm9sbENvcm5lcik6IFNldCBMb2NhbERlZmF1bHRTeXN0ZW1BcHBlYXJh
bmNlIGJhc2VkCisgICAgICAgIG9uIHRoZSBzY3JvbGxiYXIgb3ZlcmxheSBzdHlsZSB0b28uCisg
ICAgICAgICogcGFnZS9GcmFtZVZpZXcuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxhYmxl
QXJlYS5oOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYWJsZUFyZWE6OnVzZURhcmtBcHBlYXJh
bmNlIGNvbnN0KTogQWRkZWQuIERlZmF1bHQgdG8gZmFsc2UuCisgICAgICAgICogcGxhdGZvcm0v
bWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tOgorICAgICAgICAoLVtXZWJTY3JvbGxlckltcERlbGVn
YXRlIGVmZmVjdGl2ZUFwcGVhcmFuY2VGb3JTY3JvbGxlckltcDpdKTogQWRkZWQuCisgICAgICAg
IEFzayB0aGUgU2Nyb2xsYWJsZUFyZWEgaWYgYSBkYXJrIGFwcGVhcmFuY2UgaXMgZGVzaXJlZC4K
KwogMjAxOC0xMC0yNSAgSm9uIERhdmlzICA8am9uZEBhcHBsZS5jb20+CiAKICAgICAgICAgQ2hh
bmdlZCAiVW5kZXIgRGV2ZWxvcG1lbnQiIHN0YXR1cyB0byB1c2UgIkluIERldmVsb3BtZW50IiBp
bnN0ZWFkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nIGIvU291cmNl
L1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCAzNWFkYTcyMzFjZGZkZjUxZTE2OTY4ZWRmNzUz
YWUyNWQ0N2ViMTRjLi42ZWFjMzlmODVmNGY4NWJhM2M5MjAwYTlkMzgyMDk3NWQ0NjFhMWFlIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD
b3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOC0xMC0yNSAgVGltb3RoeSBI
YXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGRhcmsgYXBwZWFyYW5j
ZSBzY3JvbGxiYXIgd2hlbiBwYWdlIGJhY2tncm91bmQgaXMgZGFyayBvciBkb2N1bWVudCBzdXBw
b3J0cyBkYXJrIG1vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xOTA5MzcKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vNDEyMjU4MzkKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhbC9zcGkvbWFjL05T
U2Nyb2xsZXJJbXBTUEkuaDogQWRkZWQgZWZmZWN0aXZlQXBwZWFyYW5jZUZvclNjcm9sbGVySW1w
Oi4KKwogMjAxOC0xMC0yNCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAog
ICAgICAgICBDbGVhbiB1cCBzb21lIG9ic29sZXRlIG1hY09TIHZlcnNpb24gZ3VhcmRzCmRpZmYg
LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNTY3JvbGxlckltcFNQSS5o
IGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TU2Nyb2xsZXJJbXBTUEkuaAppbmRl
eCBhZGYxMTBhOTZmOWEzYjM5NzJlZGQ0ZTNlZTYyOWVmMDk0YTZlZDYxLi45ZDYzMGQ4MjhkMDky
YzE3ZmYyOTAwZjE1ZmFjYTEzMmVkZjg1ZmZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Q
QUwvcGFsL3NwaS9tYWMvTlNTY3JvbGxlckltcFNQSS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BB
TC9wYWwvc3BpL21hYy9OU1Njcm9sbGVySW1wU1BJLmgKQEAgLTEwNiw2ICsxMDYsNyBAQCB0eXBl
ZGVmIE5TVUludGVnZXIgTlNPdmVybGF5U2Nyb2xsZXJTdGF0ZTsKIC0gKE5TUG9pbnQpbW91c2VM
b2NhdGlvbkluU2Nyb2xsZXJGb3JTY3JvbGxlckltcDooTlNTY3JvbGxlckltcCAqKXNjcm9sbGVy
SW1wOwogLSAoTlNSZWN0KWNvbnZlcnRSZWN0VG9MYXllcjooTlNSZWN0KWFSZWN0OwogLSAoQk9P
TClzaG91bGRVc2VMYXllclBlclBhcnRGb3JTY3JvbGxlckltcDooTlNTY3JvbGxlckltcCAqKXNj
cm9sbGVySW1wOworLSAoTlNBcHBlYXJhbmNlICopZWZmZWN0aXZlQXBwZWFyYW5jZUZvclNjcm9s
bGVySW1wOihOU1Njcm9sbGVySW1wICopc2Nyb2xsZXJJbXA7CiBAZW5kCiAKIEBwcm90b2NvbCBO
U1Njcm9sbGVySW1wUGFpckRlbGVnYXRlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFn
ZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4
IGZkZTZkNzU5MjcwMjQyZjNmY2VmNGMyZWFiMjgxZjgwMGYyY2U5ZjIuLmUyYWU5NjZiMDdjYzIw
ZjZlMmM3YjA5ODdmZGU1NDI1NDU1YTIzN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh
Z2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAK
QEAgLTExOCw2ICsxMTgsMTAgQEAKICNpbmNsdWRlICJMZWdhY3lUaWxlQ2FjaGUuaCIKICNlbmRp
ZgogCisjaWYgUExBVEZPUk0oTUFDKQorI2luY2x1ZGUgIkxvY2FsRGVmYXVsdFN5c3RlbUFwcGVh
cmFuY2UuaCIKKyNlbmRpZgorCiAjZGVmaW5lIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoZm10LCAu
Li4pIFJFTEVBU0VfTE9HX0lGKGZyYW1lKCkucGFnZSgpICYmIGZyYW1lKCkucGFnZSgpLT5pc0Fs
d2F5c09uTG9nZ2luZ0FsbG93ZWQoKSwgTGF5b3V0LCAiJXAgLSBGcmFtZVZpZXc6OiIgZm10LCB0
aGlzLCAjI19fVkFfQVJHU19fKQogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0yMDM1LDYgKzIw
MzksMTMgQEAgYm9vbCBGcmFtZVZpZXc6OnNob3VsZFNldEN1cnNvcigpIGNvbnN0CiAgICAgcmV0
dXJuIHBhZ2UgJiYgcGFnZS0+aXNWaXNpYmxlKCkgJiYgcGFnZS0+Zm9jdXNDb250cm9sbGVyKCku
aXNBY3RpdmUoKTsKIH0KIAorYm9vbCBGcmFtZVZpZXc6OnVzZURhcmtBcHBlYXJhbmNlKCkgY29u
c3QKK3sKKyAgICBBU1NFUlQoZnJhbWUoKS5kb2N1bWVudCgpKTsKKyAgICBhdXRvJiBkb2N1bWVu
dCA9ICpmcmFtZSgpLmRvY3VtZW50KCk7CisgICAgcmV0dXJuIGRvY3VtZW50LnVzZURhcmtBcHBl
YXJhbmNlKCk7Cit9CisKIGJvb2wgRnJhbWVWaWV3OjpzY3JvbGxDb250ZW50c0Zhc3RQYXRoKGNv
bnN0IEludFNpemUmIHNjcm9sbERlbHRhLCBjb25zdCBJbnRSZWN0JiByZWN0VG9TY3JvbGwsIGNv
bnN0IEludFJlY3QmIGNsaXBSZWN0KQogewogICAgIGlmICghbV92aWV3cG9ydENvbnN0cmFpbmVk
T2JqZWN0cyB8fCBtX3ZpZXdwb3J0Q29uc3RyYWluZWRPYmplY3RzLT5pc0VtcHR5KCkpIHsKQEAg
LTM4OTIsNiArMzkwMywxNCBAQCB2b2lkIEZyYW1lVmlldzo6cGFpbnRTY3JvbGxDb3JuZXIoR3Jh
cGhpY3NDb250ZXh0JiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiBjb3JuZQogICAgICAgICByZXR1
cm47CiAgICAgfQogCisjaWYgUExBVEZPUk0oTUFDKQorICAgIC8vIElmIGRhcmsgYXBwZWFyYW5j
ZSBpcyB1c2VkIG9yIHRoZSBvdmVybGF5IHN0eWxlIGlzIGxpZ2h0IChiZWNhdXNlIG9mIGEgZGFy
ayBwYWdlIGJhY2tncm91bmQpLCBzZXQgdGhlIGRhcmsgYXBwcGVhcmFuY2UuCisgICAgLy8gS2Vl
cCB0aGlzIGluIHN5bmMgd2l0aCBTY3JvbGxBbmltYXRvck1hYydzIGVmZmVjdGl2ZUFwcGVhcmFu
Y2VGb3JTY3JvbGxlckltcDouCisgICAgYXV0byogZG9jdW1lbnQgPSBmcmFtZSgpLmRvY3VtZW50
KCk7CisgICAgYm9vbCB1c2VEYXJrQXBwZWFyYW5jZSA9IChkb2N1bWVudCAmJiBkb2N1bWVudC0+
dXNlRGFya0FwcGVhcmFuY2UoKSkgfHwgc2Nyb2xsYmFyT3ZlcmxheVN0eWxlKCkgPT0gV2ViQ29y
ZTo6U2Nyb2xsYmFyT3ZlcmxheVN0eWxlTGlnaHQ7CisgICAgTG9jYWxEZWZhdWx0U3lzdGVtQXBw
ZWFyYW5jZSBsb2NhbEFwcGVhcmFuY2UodXNlRGFya0FwcGVhcmFuY2UpOworI2VuZGlmCisKICAg
ICBTY3JvbGxWaWV3OjpwYWludFNjcm9sbENvcm5lcihjb250ZXh0LCBjb3JuZXJSZWN0KTsKIH0K
IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaCBiL1NvdXJjZS9X
ZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKaW5kZXggM2MwNWQxZjMzZWUzNTNjNDM1ZDMzY2I0MzRk
ZDhkZDI1ZWVmYzE3My4uMjg3MGExM2NiZjhlOGUyNTRlNjQ1YWNhMWFiMGEzMmI5NDhmZmRhYyAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCkBAIC01MDcsNiArNTA3LDggQEAgcHVibGljOgogICAg
IGJvb2wgaXNIYW5kbGluZ1doZWVsRXZlbnQoKSBjb25zdCBmaW5hbDsKICAgICBib29sIHNob3Vs
ZFNldEN1cnNvcigpIGNvbnN0OwogCisgICAgYm9vbCB1c2VEYXJrQXBwZWFyYW5jZSgpIGNvbnN0
IGZpbmFsOworCiAgICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIG1ldGhvZCBvbmNlIHBsdWdpbiBs
b2FkaW5nIGlzIGRlY291cGxlZCBmcm9tIGxheW91dC4KICAgICB2b2lkIGZsdXNoQW55UGVuZGlu
Z1Bvc3RMYXlvdXRUYXNrcygpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9TY3JvbGxhYmxlQXJlYS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYWJsZUFy
ZWEuaAppbmRleCBhOTJkNDU2ODc5YzEyNjc4MjRiN2EzZWZiZWJkNjMwOWQ1ZTc1M2ZiLi5lMTVl
YzNmMTM1OWYyYTYwNzhiNzM4NDMwYjIyZTY0ZjQxMzc3MmFlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL1Njcm9sbGFibGVBcmVhLmgKQEAgLTI1MSw2ICsyNTEsOCBAQCBwdWJsaWM6CiAgICAg
Ly8gVGhlIHRvdGFsQ29udGVudHNTaXplKCkgaXMgZXF1aXZhbGVudCB0byB0aGUgY29udGVudHNT
aXplKCkgcGx1cyB0aGUgaGVhZGVyIGFuZCBmb290ZXIgaGVpZ2h0cy4KICAgICBXRUJDT1JFX0VY
UE9SVCBJbnRTaXplIHRvdGFsQ29udGVudHNTaXplKCkgY29uc3Q7CiAKKyAgICB2aXJ0dWFsIGJv
b2wgdXNlRGFya0FwcGVhcmFuY2UoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQorCiAgICAgdmly
dHVhbCBib29sIHNob3VsZFN1c3BlbmRTY3JvbGxBbmltYXRpb25zKCkgY29uc3QgeyByZXR1cm4g
dHJ1ZTsgfQogICAgIFdFQkNPUkVfRVhQT1JUIHZpcnR1YWwgdm9pZCBzY3JvbGxiYXJTdHlsZUNo
YW5nZWQoU2Nyb2xsYmFyU3R5bGUgLypuZXdTdHlsZSovLCBib29sIC8qZm9yY2VVcGRhdGUqLyk7
CiAgICAgdmlydHVhbCB2b2lkIHNldFZpc2libGVTY3JvbGxlclRodW1iUmVjdChjb25zdCBJbnRS
ZWN0JikgeyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xs
QW5pbWF0b3JNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0
b3JNYWMubW0KaW5kZXggZTA4OGUzY2Q1MmUwYTViNDlkYzU5NjFjNTM1NzAzNDA0ZGMyMGI4Ny4u
ZDA4Y2M1OWZmZjE5YTliNjA4ZDNkYTc4Mjg3NjQ3ZDhlYzY5MjdmOSAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tCisrKyBiL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5tbQpAQCAtNTI3LDYgKzUy
NywyMSBAQCAtIChCT09MKXNob3VsZFVzZUxheWVyUGVyUGFydEZvclNjcm9sbGVySW1wOihOU1Nj
cm9sbGVySW1wICopc2Nyb2xsZXJJbXAKICAgICByZXR1cm4gX3Njcm9sbGJhci0+c3VwcG9ydHNV
cGRhdGVPblNlY29uZGFyeVRocmVhZCgpOwogfQogCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01J
Tl9SRVFVSVJFRCA+PSAxMDE0MDAKKy0gKE5TQXBwZWFyYW5jZSAqKWVmZmVjdGl2ZUFwcGVhcmFu
Y2VGb3JTY3JvbGxlckltcDooTlNTY3JvbGxlckltcCAqKXNjcm9sbGVySW1wCit7CisgICAgVU5V
U0VEX1BBUkFNKHNjcm9sbGVySW1wKTsKKworICAgIGlmICghX3Njcm9sbGJhcikKKyAgICAgICAg
cmV0dXJuIFtOU0FwcGVhcmFuY2UgY3VycmVudEFwcGVhcmFuY2VdOworCisgICAgLy8gSWYgZGFy
ayBhcHBlYXJhbmNlIGlzIHVzZWQgb3IgdGhlIG92ZXJsYXkgc3R5bGUgaXMgbGlnaHQgKGJlY2F1
c2Ugb2YgYSBkYXJrIHBhZ2UgYmFja2dyb3VuZCksIHJldHVybiB0aGUgZGFyayBhcHBwZWFyYW5j
ZS4KKyAgICAvLyBLZWVwIHRoaXMgaW4gc3luYyB3aXRoIEZyYW1lVmlldzo6cGFpbnRTY3JvbGxD
b3JuZXIuCisgICAgYm9vbCB1c2VEYXJrQXBwZWFyYW5jZSA9IF9zY3JvbGxiYXItPnNjcm9sbGFi
bGVBcmVhKCkudXNlRGFya0FwcGVhcmFuY2UoKSB8fCBfc2Nyb2xsYmFyLT5zY3JvbGxhYmxlQXJl
YSgpLnNjcm9sbGJhck92ZXJsYXlTdHlsZSgpID09IFdlYkNvcmU6OlNjcm9sbGJhck92ZXJsYXlT
dHlsZUxpZ2h0OworICAgIHJldHVybiBbTlNBcHBlYXJhbmNlIGFwcGVhcmFuY2VOYW1lZDp1c2VE
YXJrQXBwZWFyYW5jZSA/IE5TQXBwZWFyYW5jZU5hbWVEYXJrQXF1YSA6IE5TQXBwZWFyYW5jZU5h
bWVBcXVhXTsKK30KKyNlbmRpZgorCiAtICh2b2lkKXNldFVwQWxwaGFBbmltYXRpb246KFJldGFp
blB0cjxXZWJTY3JvbGxiYXJQYXJ0QW5pbWF0aW9uPiYpc2Nyb2xsYmFyUGFydEFuaW1hdGlvbiBz
Y3JvbGxlclBhaW50ZXI6KE5TU2Nyb2xsZXJJbXAgKilzY3JvbGxlclBhaW50ZXIgcGFydDooV2Vi
Q29yZTo6U2Nyb2xsYmFyUGFydClwYXJ0IGFuaW1hdGVBbHBoYVRvOihDR0Zsb2F0KW5ld0FscGhh
IGR1cmF0aW9uOihOU1RpbWVJbnRlcnZhbClkdXJhdGlvbgogewogICAgIC8vIElmIHRoZSB1c2Vy
IGhhcyBzY3JvbGxlZCB0aGUgcGFnZSwgdGhlbiB0aGUgc2Nyb2xsYmFycyBtdXN0IGJlIGFuaW1h
dGVkIGhlcmUuCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>