190932 2018-10-25 16:34:55 -0700 Consider removing double load for accessing the instructions from LLInt 2018-11-18 22:53:45 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo ysuzuki ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1472248 0 tzagallo 2018-10-25 16:34:55 -0700 https://bugs.webkit.org/show_bug.cgi?id=187373 changes CodeBlock::m_instructions from being an array of instructions to being a InstructionStream, which itself contains a Vector of instructions. Therefore, we need two loads to get to the actual Instruction*. The implementation was done this way to avoid copying the instructions once we finish writing to the stream after bytecode generation, but it might not be the best trade-off. 1477624 1 354567 ysuzuki 2018-11-12 10:27:35 -0800 Created attachment 354567 Patch 1477627 2 ews-watchlist 2018-11-12 10:30:13 -0800 Attachment 354567 did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:373: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 1479207 3 ysuzuki 2018-11-15 17:56:35 -0800 Ping? 1480134 4 ysuzuki 2018-11-18 22:09:04 -0800 Ping? 1480137 5 354567 mark.lam 2018-11-18 22:18:49 -0800 Comment on attachment 354567 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354567&action=review > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1818 > - muli sizeof SimpleJumpTable, t3 # FIXME: would be nice to peephole this! > + muli sizeof SimpleJumpTable, t3 What's the peephole opportunity the comment was talking about, and is it invalid / inappropriate? What is your reason for this change? 1480139 6 354567 ysuzuki 2018-11-18 22:21:10 -0800 Comment on attachment 354567 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354567&action=review >> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1818 >> + muli sizeof SimpleJumpTable, t3 > > What's the peephole opportunity the comment was talking about, and is it invalid / inappropriate? What is your reason for this change? This removal is because we already did this optimization in https://trac.webkit.org/changeset/237627/webkit. This comment means that we can perform strength reduction to convert `muli` to `lshifti` if `sizeof SimpleJumpTable` is a power of two. 1480141 7 354567 mark.lam 2018-11-18 22:28:09 -0800 Comment on attachment 354567 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354567&action=review r=me. >>> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1818 >>> + muli sizeof SimpleJumpTable, t3 >> >> What's the peephole opportunity the comment was talking about, and is it invalid / inappropriate? What is your reason for this change? > > This removal is because we already did this optimization in https://trac.webkit.org/changeset/237627/webkit. > This comment means that we can perform strength reduction to convert `muli` to `lshifti` if `sizeof SimpleJumpTable` is a power of two. OK, thanks. 1480144 8 ysuzuki 2018-11-18 22:51:59 -0800 Committed r238367: <https://trac.webkit.org/changeset/238367> 1480146 9 webkit-bug-importer 2018-11-18 22:53:45 -0800 <rdar://problem/46161984> 354567 2018-11-12 10:27:35 -0800 2018-11-18 22:28:09 -0800 Patch bug-190932-20181113032734.patch text/plain 8528 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MDkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NWMzYmVmZGY3Yzc1MWJhNjgwZWFhOTMyOWQ2MWEwM2U3NmJiNGM2Li44YjY4ZjFmODg3Y2FkOThl OGZlYjE0YjI3MTk3NmEwYjRkM2RmZDIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxOC0xMS0xMiAgWXVzdWtlIFN1enVraSAgPHl1c3VrZXN1enVraUBzbG93 c3RhcnQub3JnPgorCisgICAgICAgIENvbnNpZGVyIHJlbW92aW5nIGRvdWJsZSBsb2FkIGZvciBh Y2Nlc3NpbmcgdGhlIGluc3RydWN0aW9ucyBmcm9tIExMSW50CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA5MzIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2luZyBJbnN0cnVjdGlvblN0cmVhbSB0 byBSZWZDb3VudGVkQXJyYXkgbGlrZSBzdHJ1Y3R1cmUgaW52b2x2ZXMgc28gbXVjaCBjaGFuZ2Vz CisgICAgICAgIGluY2x1ZGluZyBCeXRlY29kZUdyYXBoLCBQcmVjaXNlSnVtcFRhcmdldHMgZXRj LiBJbnN0ZWFkLCBDb2RlQmxvY2sgc2ltcGx5IGhvbGQgYSByYXcKKyAgICAgICAgcG9pbnRlciB0 byB0aGUgSW5zdHJ1Y3Rpb25TdHJlYW0ncyBkYXRhLiBTaW5jZSBJbnN0cnVjdGlvblN0cmVhbSBp cyBub3QgY2hhbmdlZAorICAgICAgICBhbnltb3JlLCB0aGlzIHBvaW50ZXIgaXMgdmFsaWQgd2hp bGUgQ29kZUJsb2NrIGlzIGxpdmUuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3Bw OgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6OkNvZGVCbG9jayk6CisgICAgICAgICogYnl0ZWNv ZGUvQ29kZUJsb2NrLmg6CisgICAgICAgICogYnl0ZWNvZGUvSW5zdHJ1Y3Rpb25TdHJlYW0uaDoK KyAgICAgICAgKEpTQzo6SW5zdHJ1Y3Rpb25TdHJlYW06OnJhd1BvaW50ZXIgY29uc3QpOgorICAg ICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtOgorICAgICAgICAqIGxsaW50L0xv d0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc206CisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRl cnByZXRlcjY0LmFzbToKKwogMjAxOC0xMS0xMSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWlu QHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IGEgZml4bWU6IHJlbmFtZSB3dGZPYmpjTXNnU2Vu ZCB0byB3dGZPYmpDTXNnU2VuZApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb2RlL0NvZGVCbG9jay5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29k ZUJsb2NrLmNwcAppbmRleCA3Yjc2MjNmNTBhMjdiYjQ2MjYyN2UxNDQ3ODhmOGQ4NzRkZTk1YTUz Li5iNDRiODJiNTMxZTQyOTg2OGE1NWM3ZjcwNjIyMjJkOWMzMDQwYzhkIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcApAQCAtMzAzLDggKzMwMyw5IEBA IENvZGVCbG9jazo6Q29kZUJsb2NrKFZNKiB2bSwgU3RydWN0dXJlKiBzdHJ1Y3R1cmUsIENvcHlQ YXJzZWRCbG9ja1RhZywgQ29kZUJsb2NrCiAgICAgLCBtX3VubGlua2VkQ29kZSgqb3RoZXIudm0o KSwgdGhpcywgb3RoZXIubV91bmxpbmtlZENvZGUuZ2V0KCkpCiAgICAgLCBtX293bmVyRXhlY3V0 YWJsZSgqb3RoZXIudm0oKSwgdGhpcywgb3RoZXIubV9vd25lckV4ZWN1dGFibGUuZ2V0KCkpCiAg ICAgLCBtX3BvaXNvbmVkVk0ob3RoZXIubV9wb2lzb25lZFZNKQotICAgICwgbV9pbnN0cnVjdGlv bkNvdW50KG90aGVyLm1faW5zdHJ1Y3Rpb25Db3VudCkKICAgICAsIG1faW5zdHJ1Y3Rpb25zKG90 aGVyLm1faW5zdHJ1Y3Rpb25zKQorICAgICwgbV9pbnN0cnVjdGlvbnNSYXdQb2ludGVyKG90aGVy Lm1faW5zdHJ1Y3Rpb25zUmF3UG9pbnRlcikKKyAgICAsIG1faW5zdHJ1Y3Rpb25Db3VudChvdGhl ci5tX2luc3RydWN0aW9uQ291bnQpCiAgICAgLCBtX3RoaXNSZWdpc3RlcihvdGhlci5tX3RoaXNS ZWdpc3RlcikKICAgICAsIG1fc2NvcGVSZWdpc3RlcihvdGhlci5tX3Njb3BlUmVnaXN0ZXIpCiAg ICAgLCBtX2hhc2gob3RoZXIubV9oYXNoKQpAQCAtMzY5LDYgKzM3MCw3IEBAIENvZGVCbG9jazo6 Q29kZUJsb2NrKFZNKiB2bSwgU3RydWN0dXJlKiBzdHJ1Y3R1cmUsIFNjcmlwdEV4ZWN1dGFibGUq IG93bmVyRXhlY3V0CiAgICAgLCBtX293bmVyRXhlY3V0YWJsZSgqdm0sIHRoaXMsIG93bmVyRXhl Y3V0YWJsZSkKICAgICAsIG1fcG9pc29uZWRWTSh2bSkKICAgICAsIG1faW5zdHJ1Y3Rpb25zKCZ1 bmxpbmtlZENvZGVCbG9jay0+aW5zdHJ1Y3Rpb25zKCkpCisgICAgLCBtX2luc3RydWN0aW9uc1Jh d1BvaW50ZXIobV9pbnN0cnVjdGlvbnMtPnJhd1BvaW50ZXIoKSkKICAgICAsIG1fdGhpc1JlZ2lz dGVyKHVubGlua2VkQ29kZUJsb2NrLT50aGlzUmVnaXN0ZXIoKSkKICAgICAsIG1fc2NvcGVSZWdp c3Rlcih1bmxpbmtlZENvZGVCbG9jay0+c2NvcGVSZWdpc3RlcigpKQogICAgICwgbV9zb3VyY2Uo V1RGTW92ZShzb3VyY2VQcm92aWRlcikpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUv Q29kZUJsb2NrLmgKaW5kZXggM2M1YjU2N2EyODliMTBjYzEzZDNlOGViYzU3ZmYwY2Q0OWY0ZmQ2 Mi4uMjlhNjA1YjlmNjA2NzIzMzMyOTBhYjZmNDA3Nzc4YzQ4OGJjODVkZCAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaApAQCAtOTQ5LDggKzk0OSw5IEBAIGNs YXNzIENvZGVCbG9jayA6IHB1YmxpYyBKU0NlbGwgewogICAgIFdyaXRlQmFycmllcjxFeGVjdXRh YmxlVG9Db2RlQmxvY2tFZGdlPiBtX293bmVyRWRnZTsKICAgICBQb2lzb25lZDxDb2RlQmxvY2tQ b2lzb24sIFZNKj4gbV9wb2lzb25lZFZNOwogCi0gICAgdW5zaWduZWQgbV9pbnN0cnVjdGlvbkNv dW50IHsgMCB9OwogICAgIGNvbnN0IEluc3RydWN0aW9uU3RyZWFtKiBtX2luc3RydWN0aW9uczsK KyAgICBjb25zdCB2b2lkKiBtX2luc3RydWN0aW9uc1Jhd1BvaW50ZXIgeyBudWxscHRyIH07Cisg ICAgdW5zaWduZWQgbV9pbnN0cnVjdGlvbkNvdW50IHsgMCB9OwogICAgIFZpcnR1YWxSZWdpc3Rl ciBtX3RoaXNSZWdpc3RlcjsKICAgICBWaXJ0dWFsUmVnaXN0ZXIgbV9zY29wZVJlZ2lzdGVyOwog ICAgIG11dGFibGUgQ29kZUJsb2NrSGFzaCBtX2hhc2g7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnl0ZWNvZGUvSW5zdHJ1Y3Rpb25TdHJlYW0uaCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ieXRlY29kZS9JbnN0cnVjdGlvblN0cmVhbS5oCmluZGV4IDRiMzQzODYzNzA3MWNl NmY1ZTE3ODI4ODgxZTU2N2I0NGNhMzdiYmMuLjQ0YjRiZTc0Y2U4N2UyZTNlNjlmMzM3OTYyYzA1 MTFmNGMwNDViZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9J bnN0cnVjdGlvblN0cmVhbS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9J bnN0cnVjdGlvblN0cmVhbS5oCkBAIC0xNjIsNiArMTYyLDExIEBAIGNsYXNzIEluc3RydWN0aW9u U3RyZWFtIHsKICAgICAgICAgcmV0dXJuIG1faW5zdHJ1Y3Rpb25zLnNpemUoKTsKICAgICB9CiAK KyAgICBjb25zdCB2b2lkKiByYXdQb2ludGVyKCkgY29uc3QKKyAgICB7CisgICAgICAgIHJldHVy biBtX2luc3RydWN0aW9ucy5kYXRhKCk7CisgICAgfQorCiBwcm90ZWN0ZWQ6CiAgICAgZXhwbGlj aXQgSW5zdHJ1Y3Rpb25TdHJlYW0oSW5zdHJ1Y3Rpb25CdWZmZXImJik7CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbSBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQppbmRleCA0 MTZmM2JhNzNhOGU0YWY2MGNhZmUxMGYxMmNhZmUzZDZmMmYyMmUxLi4yZjlhZTg4ZGVhZDEzZjdj N2VkYzNmNWJhNTg5MGU0NjE2OGY5MWVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20KKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCkBAIC0xMTI3LDE3ICsxMTI3LDExIEBA IG1hY3JvIHByb2xvZ3VlKGNvZGVCbG9ja0dldHRlciwgY29kZUJsb2NrU2V0dGVyLCBvc3JTbG93 UGF0aCwgdHJhY2VTbG93UGF0aCkKIAogICAgICMgU2V0IHVwIHRoZSBQQy4KICAgICBpZiBKU1ZB TFVFNjQKLSAgICAgICAgIyBGSVhNRTogY2xlYW51cCBkb3VibGUgbG9hZAotICAgICAgICAjIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA5MzIKLSAgICAgICAgbG9h ZHAgQ29kZUJsb2NrOjptX2luc3RydWN0aW9uc1t0MV0sIFBCCi0gICAgICAgIGxvYWRwIFtQQl0s IFBCCisgICAgICAgIGxvYWRwIENvZGVCbG9jazo6bV9pbnN0cnVjdGlvbnNSYXdQb2ludGVyW3Qx XSwgUEIKICAgICAgICAgdW5wb2lzb24oX2dfQ29kZUJsb2NrUG9pc29uLCBQQiwgdDMpCiAgICAg ICAgIG1vdmUgMCwgUEMKICAgICBlbHNlCi0gICAgICAgICMgRklYTUU6IGNsZWFudXAgZG91Ymxl IGxvYWQKLSAgICAgICAgIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTkwOTMyCi0gICAgICAgIGxvYWRwIENvZGVCbG9jazo6bV9pbnN0cnVjdGlvbnNbdDFdLCBQQwot ICAgICAgICBsb2FkcCBbUENdLCBQQworICAgICAgICBsb2FkcCBDb2RlQmxvY2s6Om1faW5zdHJ1 Y3Rpb25zUmF3UG9pbnRlclt0MV0sIFBDCiAgICAgZW5kCiAKICAgICAjIEdldCBuZXcgc3AgaW4g dDAgYW5kIGNoZWNrIHN0YWNrIGhlaWdodC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KaW5kZXggODFlMjAzYjI2 OTQ1Y2MwNTlmMjRjYjQwMGE2NjUzZmY4MzMzNTgzNC4uZTc1YjY2ODIyZDI1ODQ1OGQ5MjBhZWE3 YTRkMzZjNWI3YmYzNjJjNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50 L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KQEAgLTY3OCwxMCArNjc4LDcgQEAg bWFjcm8gZnVuY3Rpb25Bcml0eUNoZWNrKGRvbmVMYWJlbCwgc2xvd1BhdGgpCiAuY29udGludWU6 CiAgICAgIyBSZWxvYWQgQ29kZUJsb2NrIGFuZCBQQywgc2luY2UgdGhlIHNsb3dfcGF0aCBjbG9i YmVyZWQgaXQuCiAgICAgbG9hZHAgQ29kZUJsb2NrW2Nmcl0sIHQxCi0gICAgIyBGSVhNRTogY2xl YW51cCBkb3VibGUgbG9hZAotICAgICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5MDkzMgotICAgIGxvYWRwIENvZGVCbG9jazo6bV9pbnN0cnVjdGlvbnNbdDFdLCBQ QwotICAgIGxvYWRwIFtQQ10sIFBDCisgICAgbG9hZHAgQ29kZUJsb2NrOjptX2luc3RydWN0aW9u c1Jhd1BvaW50ZXJbdDFdLCBQQwogICAgIGptcCBkb25lTGFiZWwKIGVuZAogCkBAIC0xODE4LDcg KzE4MTUsNyBAQCBsbGludE9wV2l0aEp1bXAob3Bfc3dpdGNoX2ltbSwgT3BTd2l0Y2hJbW0sIG1h Y3JvIChzaXplLCBnZXQsIGp1bXAsIGRpc3BhdGNoKQogICAgIGxvYWRDb25zdGFudE9yVmFyaWFi bGUoc2l6ZSwgdDIsIHQxLCB0MCkKICAgICBsb2FkcCBDb2RlQmxvY2tbY2ZyXSwgdDIKICAgICBs b2FkcCBDb2RlQmxvY2s6Om1fcmFyZURhdGFbdDJdLCB0MgotICAgIG11bGkgc2l6ZW9mIFNpbXBs ZUp1bXBUYWJsZSwgdDMgICAjIEZJWE1FOiB3b3VsZCBiZSBuaWNlIHRvIHBlZXBob2xlIHRoaXMh CisgICAgbXVsaSBzaXplb2YgU2ltcGxlSnVtcFRhYmxlLCB0MwogICAgIGxvYWRwIENvZGVCbG9j azo6UmFyZURhdGE6Om1fc3dpdGNoSnVtcFRhYmxlcyArIFZlY3RvckJ1ZmZlck9mZnNldFt0Ml0s IHQyCiAgICAgYWRkcCB0MywgdDIKICAgICBiaW5lcSB0MSwgSW50MzJUYWcsIC5vcFN3aXRjaElt bU5vdEludApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVs SW50ZXJwcmV0ZXI2NC5hc20gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJ bnRlcnByZXRlcjY0LmFzbQppbmRleCA1NmRlZDcxOWUyMmE2NzQ0NGE4MmU5MTMyNmNmMDJlZTMw NDhhYTA1Li44NmRkZDkyZjFiOTEwZjMzYjZmODZlYWMxYmE5YjljMGU2YzhjZjU5IDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFz bQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0 LmFzbQpAQCAtODAsMTAgKzgwLDcgQEAgZW5kCiBtYWNybyBkaXNwYXRjaEFmdGVyQ2FsbChzaXpl LCBvcCwgZGlzcGF0Y2gpCiAgICAgbG9hZGkgQXJndW1lbnRDb3VudCArIFRhZ09mZnNldFtjZnJd LCBQQwogICAgIGxvYWRwIENvZGVCbG9ja1tjZnJdLCBQQgotICAgICMgRklYTUU6IGNsZWFudXAg ZG91YmxlIGxvYWQKLSAgICAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTA5MzIKLSAgICBsb2FkcCBDb2RlQmxvY2s6Om1faW5zdHJ1Y3Rpb25zW1BCXSwgUEIKLSAg ICBsb2FkcCBbUEJdLCBQQgorICAgIGxvYWRwIENvZGVCbG9jazo6bV9pbnN0cnVjdGlvbnNSYXdQ b2ludGVyW1BCXSwgUEIKICAgICB1bnBvaXNvbihfZ19Db2RlQmxvY2tQb2lzb24sIFBCLCB0MSkK ICAgICBnZXQoc2l6ZSwgb3AsIGRzdCwgdDEpCiAgICAgc3RvcmVxIHIwLCBbY2ZyLCB0MSwgOF0K QEAgLTYzMiwxMCArNjI5LDcgQEAgbWFjcm8gZnVuY3Rpb25Bcml0eUNoZWNrKGRvbmVMYWJlbCwg c2xvd1BhdGgpCiAuY29udGludWU6CiAgICAgIyBSZWxvYWQgQ29kZUJsb2NrIGFuZCByZXNldCBQ Qywgc2luY2UgdGhlIHNsb3dfcGF0aCBjbG9iYmVyZWQgdGhlbS4KICAgICBsb2FkcCBDb2RlQmxv Y2tbY2ZyXSwgdDEKLSAgICAjIEZJWE1FOiBjbGVhbnVwIGRvdWJsZSBsb2FkCi0gICAgIyBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwOTMyCi0gICAgbG9hZHAgQ29k ZUJsb2NrOjptX2luc3RydWN0aW9uc1t0MV0sIFBCCi0gICAgbG9hZHAgW1BCXSwgUEIKKyAgICBs b2FkcCBDb2RlQmxvY2s6Om1faW5zdHJ1Y3Rpb25zUmF3UG9pbnRlclt0MV0sIFBCCiAgICAgdW5w b2lzb24oX2dfQ29kZUJsb2NrUG9pc29uLCBQQiwgdDIpCiAgICAgbW92ZSAwLCBQQwogICAgIGpt cCBkb25lTGFiZWwKQEAgLTE5MTMsNyArMTkwNyw3IEBAIGxsaW50T3BXaXRoSnVtcChvcF9zd2l0 Y2hfaW1tLCBPcFN3aXRjaEltbSwgbWFjcm8gKHNpemUsIGdldCwganVtcCwgZGlzcGF0Y2gpCiAg ICAgbG9hZENvbnN0YW50T3JWYXJpYWJsZShzaXplLCB0MiwgdDEpCiAgICAgbG9hZHAgQ29kZUJs b2NrW2Nmcl0sIHQyCiAgICAgbG9hZHAgQ29kZUJsb2NrOjptX3JhcmVEYXRhW3QyXSwgdDIKLSAg ICBtdWxpIHNpemVvZiBTaW1wbGVKdW1wVGFibGUsIHQzICAgICMgRklYTUU6IHdvdWxkIGJlIG5p Y2UgdG8gcGVlcGhvbGUgdGhpcyEKKyAgICBtdWxpIHNpemVvZiBTaW1wbGVKdW1wVGFibGUsIHQz CiAgICAgbG9hZHAgQ29kZUJsb2NrOjpSYXJlRGF0YTo6bV9zd2l0Y2hKdW1wVGFibGVzICsgVmVj dG9yQnVmZmVyT2Zmc2V0W3QyXSwgdDIKICAgICBhZGRwIHQzLCB0MgogICAgIGJxYiB0MSwgdGFn VHlwZU51bWJlciwgLm9wU3dpdGNoSW1tTm90SW50CkBAIC0yMDU2LDEwICsyMDUwLDcgQEAgY29t bW9uT3AobGxpbnRfb3BfY2F0Y2gsIG1hY3JvKCkgZW5kLCBtYWNybyAoc2l6ZSkKICAgICByZXN0 b3JlU3RhY2tQb2ludGVyQWZ0ZXJDYWxsKCkKIAogICAgIGxvYWRwIENvZGVCbG9ja1tjZnJdLCBQ QgotICAgICMgRklYTUU6IGNsZWFudXAgZG91YmxlIGxvYWQKLSAgICAjIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA5MzIKLSAgICBsb2FkcCBDb2RlQmxvY2s6Om1f aW5zdHJ1Y3Rpb25zW1BCXSwgUEIKLSAgICBsb2FkcCBbUEJdLCBQQgorICAgIGxvYWRwIENvZGVC bG9jazo6bV9pbnN0cnVjdGlvbnNSYXdQb2ludGVyW1BCXSwgUEIKICAgICB1bnBvaXNvbihfZ19D b2RlQmxvY2tQb2lzb24sIFBCLCB0MikKICAgICBsb2FkcCBWTTo6dGFyZ2V0SW50ZXJwcmV0ZXJQ Q0ZvclRocm93W3QzXSwgUEMKICAgICBzdWJwIFBCLCBQQwo=