190931 2018-10-25 16:34:07 -0700 Modernize / Simplify IPC::Connection::sendOutgoingMessage() 2018-10-26 08:35:36 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen commit-queue ews-watchlist ggaren koivisto webkit-bug-importer oldest_to_newest 1472247 0 cdumez 2018-10-25 16:34:07 -0700 Modernize / Simplify IPC::Connection::sendOutgoingMessage(). 1472249 1 353129 cdumez 2018-10-25 16:37:53 -0700 Created attachment 353129 Patch 1472250 2 ews-watchlist 2018-10-25 16:39:40 -0700 Attachment 353129 did not pass style-queue: ERROR: Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:302: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1472420 3 353129 achristensen 2018-10-26 07:19:48 -0700 Comment on attachment 353129 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353129&action=review > Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:-334 > - header->msgh_id |= MessageBodyIsOutOfLine; Did this do nothing? 1472439 4 cdumez 2018-10-26 07:39:51 -0700 (In reply to Alex Christensen from comment #3) > Comment on attachment 353129 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353129&action=review > > > Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:-334 > > - header->msgh_id |= MessageBodyIsOutOfLine; > > Did this do nothing? I merely moved it below. 1472446 5 353129 achristensen 2018-10-26 07:51:29 -0700 Comment on attachment 353129 Patch Sure enough. 1472463 6 353129 commit-queue 2018-10-26 08:34:26 -0700 Comment on attachment 353129 Patch Clearing flags on attachment: 353129 Committed r237460: <https://trac.webkit.org/changeset/237460> 1472464 7 commit-queue 2018-10-26 08:34:27 -0700 All reviewed patches have been landed. Closing bug. 1472465 8 webkit-bug-importer 2018-10-26 08:35:36 -0700 <rdar://problem/45588328> 353129 2018-10-25 16:37:53 -0700 2018-10-26 08:34:26 -0700 Patch bug-190931-20181025163752.patch text/plain 5877 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA2ZDYwMWIxNWU0NmU4YTRi NzcyZWRkYTcwZGRkMDFiNjM5MzZkMGIuLmZhYjEyYTA0OTA5YWNjOWNkMDc1N2I0YWQ1MWY0OTcy NDBlNzIwNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMTAtMjUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBNb2Rlcm5pemUgLyBTaW1wbGlmeSBJ UEM6OkNvbm5lY3Rpb246OnNlbmRPdXRnb2luZ01lc3NhZ2UoKQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwOTMxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rp b25NYWMubW06CisgICAgICAgIChJUEM6OkNvbm5lY3Rpb246OnNlbmRPdXRnb2luZ01lc3NhZ2Up OgorCiAyMDE4LTEwLTI1ICBDbGF1ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW1dQRV1bR1RLXSBGb2xsb3ctdXAgZml4ZXMgdG8gdGhlIGNlcnRpZmljYXRl IGNvZGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvbWFjL0Nvbm5l Y3Rpb25NYWMubW0gYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9tYWMvQ29ubmVjdGlvbk1h Yy5tbQppbmRleCA0YmU4Y2RhNGZiZGJhMzYyZmZiMTliMDI1OGY4M2Y5MjdjMmNkYmI2Li5hMjIx NmE0NGQ2NTIyNDVkNTc3MWZkNDIzY2RhZmVmMGM5NzY4ZmRjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1BsYXRmb3JtL0lQQy9tYWMvQ29ubmVjdGlvbk1hYy5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0L1BsYXRmb3JtL0lQQy9tYWMvQ29ubmVjdGlvbk1hYy5tbQpAQCAtMjk3LDgzICsyOTcsNjIg QEAgYm9vbCBDb25uZWN0aW9uOjpzZW5kT3V0Z29pbmdNZXNzYWdlKHN0ZDo6dW5pcXVlX3B0cjxF bmNvZGVyPiBlbmNvZGVyKQogewogICAgIEFTU0VSVCghbV9wZW5kaW5nT3V0Z29pbmdNYWNoTWVz c2FnZSAmJiAhbV9pc0luaXRpYWxpemluZ1NlbmRTb3VyY2UpOwogCi0gICAgVmVjdG9yPEF0dGFj aG1lbnQ+IGF0dGFjaG1lbnRzID0gZW5jb2Rlci0+cmVsZWFzZUF0dGFjaG1lbnRzKCk7CisgICAg YXV0byBhdHRhY2htZW50cyA9IGVuY29kZXItPnJlbGVhc2VBdHRhY2htZW50cygpOwogICAgIAot ICAgIHNpemVfdCBudW1iZXJPZlBvcnREZXNjcmlwdG9ycyA9IDA7Ci0gICAgc2l6ZV90IG51bWJl ck9mT09MTWVtb3J5RGVzY3JpcHRvcnMgPSAwOwotICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwg YXR0YWNobWVudHMuc2l6ZSgpOyArK2kpIHsKLSAgICAgICAgQXR0YWNobWVudDo6VHlwZSB0eXBl ID0gYXR0YWNobWVudHNbaV0udHlwZSgpOwotICAgICAgICBpZiAodHlwZSA9PSBBdHRhY2htZW50 OjpNYWNoUG9ydFR5cGUpCi0gICAgICAgICAgICBudW1iZXJPZlBvcnREZXNjcmlwdG9ycysrOwot ICAgIH0KLSAgICAKLSAgICBzaXplX3QgbWVzc2FnZVNpemUgPSBNYWNoTWVzc2FnZTo6bWVzc2Fn ZVNpemUoZW5jb2Rlci0+YnVmZmVyU2l6ZSgpLCBudW1iZXJPZlBvcnREZXNjcmlwdG9ycywgbnVt YmVyT2ZPT0xNZW1vcnlEZXNjcmlwdG9ycyk7Ci0KKyAgICBhdXRvIG51bWJlck9mUG9ydERlc2Ny aXB0b3JzID0gc3RkOjpjb3VudF9pZihhdHRhY2htZW50cy5iZWdpbigpLCBhdHRhY2htZW50cy5l bmQoKSwgW10oYXV0byYgYXR0YWNobWVudCkgeyByZXR1cm4gYXR0YWNobWVudC50eXBlKCkgPT0g QXR0YWNobWVudDo6TWFjaFBvcnRUeXBlOyB9KTsKICAgICBib29sIG1lc3NhZ2VCb2R5SXNPT0wg PSBmYWxzZTsKKyAgICBhdXRvIG1lc3NhZ2VTaXplID0gTWFjaE1lc3NhZ2U6Om1lc3NhZ2VTaXpl KGVuY29kZXItPmJ1ZmZlclNpemUoKSwgbnVtYmVyT2ZQb3J0RGVzY3JpcHRvcnMsIG1lc3NhZ2VC b2R5SXNPT0wpOwogICAgIGlmIChtZXNzYWdlU2l6ZSA+IGlubGluZU1lc3NhZ2VNYXhTaXplKSB7 CiAgICAgICAgIG1lc3NhZ2VCb2R5SXNPT0wgPSB0cnVlOwotCi0gICAgICAgIG51bWJlck9mT09M TWVtb3J5RGVzY3JpcHRvcnMrKzsKLSAgICAgICAgbWVzc2FnZVNpemUgPSBNYWNoTWVzc2FnZTo6 bWVzc2FnZVNpemUoMCwgbnVtYmVyT2ZQb3J0RGVzY3JpcHRvcnMsIG51bWJlck9mT09MTWVtb3J5 RGVzY3JpcHRvcnMpOworICAgICAgICBtZXNzYWdlU2l6ZSA9IE1hY2hNZXNzYWdlOjptZXNzYWdl U2l6ZSgwLCBudW1iZXJPZlBvcnREZXNjcmlwdG9ycywgbWVzc2FnZUJvZHlJc09PTCk7CiAgICAg fQogCiAgICAgYXV0byBtZXNzYWdlID0gTWFjaE1lc3NhZ2U6OmNyZWF0ZShtZXNzYWdlU2l6ZSk7 Ci0KICAgICBtZXNzYWdlLT5zZXRNZXNzYWdlUmVjZWl2ZXJOYW1lKGVuY29kZXItPm1lc3NhZ2VS ZWNlaXZlck5hbWUoKS50b1N0cmluZygpKTsKICAgICBtZXNzYWdlLT5zZXRNZXNzYWdlTmFtZShl bmNvZGVyLT5tZXNzYWdlTmFtZSgpLnRvU3RyaW5nKCkpOwogCi0gICAgYm9vbCBpc0NvbXBsZXgg PSAobnVtYmVyT2ZQb3J0RGVzY3JpcHRvcnMgKyBudW1iZXJPZk9PTE1lbW9yeURlc2NyaXB0b3Jz KSA+IDA7Ci0KLSAgICBtYWNoX21zZ19oZWFkZXJfdCogaGVhZGVyID0gbWVzc2FnZS0+aGVhZGVy KCk7CisgICAgYXV0byogaGVhZGVyID0gbWVzc2FnZS0+aGVhZGVyKCk7CiAgICAgaGVhZGVyLT5t c2doX2JpdHMgPSBNQUNIX01TR0hfQklUUyhNQUNIX01TR19UWVBFX0NPUFlfU0VORCwgMCk7CiAg ICAgaGVhZGVyLT5tc2doX3NpemUgPSBtZXNzYWdlU2l6ZTsKICAgICBoZWFkZXItPm1zZ2hfcmVt b3RlX3BvcnQgPSBtX3NlbmRQb3J0OwogICAgIGhlYWRlci0+bXNnaF9sb2NhbF9wb3J0ID0gTUFD SF9QT1JUX05VTEw7CiAgICAgaGVhZGVyLT5tc2doX2lkID0gMDsKLSAgICBpZiAobWVzc2FnZUJv ZHlJc09PTCkKLSAgICAgICAgaGVhZGVyLT5tc2doX2lkIHw9IE1lc3NhZ2VCb2R5SXNPdXRPZkxp bmU7CiAKLSAgICB1aW50OF90KiBtZXNzYWdlRGF0YTsKKyAgICBhdXRvKiBtZXNzYWdlRGF0YSA9 IHJlaW50ZXJwcmV0X2Nhc3Q8dWludDhfdCo+KGhlYWRlciArIDEpOwogCisgICAgYm9vbCBpc0Nv bXBsZXggPSBudW1iZXJPZlBvcnREZXNjcmlwdG9ycyB8fCBtZXNzYWdlQm9keUlzT09MOwogICAg IGlmIChpc0NvbXBsZXgpIHsKICAgICAgICAgaGVhZGVyLT5tc2doX2JpdHMgfD0gTUFDSF9NU0dI X0JJVFNfQ09NUExFWDsKIAotICAgICAgICBtYWNoX21zZ19ib2R5X3QqIGJvZHkgPSByZWludGVy cHJldF9jYXN0PG1hY2hfbXNnX2JvZHlfdCo+KGhlYWRlciArIDEpOwotICAgICAgICBib2R5LT5t c2doX2Rlc2NyaXB0b3JfY291bnQgPSBudW1iZXJPZlBvcnREZXNjcmlwdG9ycyArIG51bWJlck9m T09MTWVtb3J5RGVzY3JpcHRvcnM7Ci0gICAgICAgIHVpbnQ4X3QqIGRlc2NyaXB0b3JEYXRhID0g cmVpbnRlcnByZXRfY2FzdDx1aW50OF90Kj4oYm9keSArIDEpOworICAgICAgICBhdXRvKiBib2R5 ID0gcmVpbnRlcnByZXRfY2FzdDxtYWNoX21zZ19ib2R5X3QqPihtZXNzYWdlRGF0YSk7CisgICAg ICAgIGJvZHktPm1zZ2hfZGVzY3JpcHRvcl9jb3VudCA9IG51bWJlck9mUG9ydERlc2NyaXB0b3Jz ICsgbWVzc2FnZUJvZHlJc09PTDsKKyAgICAgICAgbWVzc2FnZURhdGEgPSByZWludGVycHJldF9j YXN0PHVpbnQ4X3QqPihib2R5ICsgMSk7CiAKLSAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkg PCBhdHRhY2htZW50cy5zaXplKCk7ICsraSkgewotICAgICAgICAgICAgQXR0YWNobWVudCBhdHRh Y2htZW50ID0gYXR0YWNobWVudHNbaV07CisgICAgICAgIGF1dG8gZ2V0RGVzY3JpcHRvckFuZFNr aXAgPSBbXSh1aW50OF90KiYgZGF0YSkgeworICAgICAgICAgICAgcmV0dXJuIHJlaW50ZXJwcmV0 X2Nhc3Q8bWFjaF9tc2dfZGVzY3JpcHRvcl90Kj4oc3RkOjpleGNoYW5nZShkYXRhLCBkYXRhICsg c2l6ZW9mKG1hY2hfbXNnX3BvcnRfZGVzY3JpcHRvcl90KSkpOworICAgICAgICB9OwogCi0gICAg ICAgICAgICBtYWNoX21zZ19kZXNjcmlwdG9yX3QqIGRlc2NyaXB0b3IgPSByZWludGVycHJldF9j YXN0PG1hY2hfbXNnX2Rlc2NyaXB0b3JfdCo+KGRlc2NyaXB0b3JEYXRhKTsKLSAgICAgICAgICAg IHN3aXRjaCAoYXR0YWNobWVudC50eXBlKCkpIHsKLSAgICAgICAgICAgIGNhc2UgQXR0YWNobWVu dDo6TWFjaFBvcnRUeXBlOgorICAgICAgICBmb3IgKGF1dG8mIGF0dGFjaG1lbnQgOiBhdHRhY2ht ZW50cykgeworICAgICAgICAgICAgQVNTRVJUKGF0dGFjaG1lbnQudHlwZSgpID09IEF0dGFjaG1l bnQ6Ok1hY2hQb3J0VHlwZSk7CisgICAgICAgICAgICBpZiAoYXR0YWNobWVudC50eXBlKCkgPT0g QXR0YWNobWVudDo6TWFjaFBvcnRUeXBlKSB7CisgICAgICAgICAgICAgICAgYXV0byogZGVzY3Jp cHRvciA9IGdldERlc2NyaXB0b3JBbmRTa2lwKG1lc3NhZ2VEYXRhKTsKICAgICAgICAgICAgICAg ICBkZXNjcmlwdG9yLT5wb3J0Lm5hbWUgPSBhdHRhY2htZW50LnBvcnQoKTsKICAgICAgICAgICAg ICAgICBkZXNjcmlwdG9yLT5wb3J0LmRpc3Bvc2l0aW9uID0gYXR0YWNobWVudC5kaXNwb3NpdGlv bigpOwotICAgICAgICAgICAgICAgIGRlc2NyaXB0b3ItPnBvcnQudHlwZSA9IE1BQ0hfTVNHX1BP UlRfREVTQ1JJUFRPUjsgICAgICAgICAgICAKLQotICAgICAgICAgICAgICAgIGRlc2NyaXB0b3JE YXRhICs9IHNpemVvZihtYWNoX21zZ19wb3J0X2Rlc2NyaXB0b3JfdCk7Ci0gICAgICAgICAgICAg ICAgYnJlYWs7Ci0gICAgICAgICAgICBkZWZhdWx0OgotICAgICAgICAgICAgICAgIEFTU0VSVF9O T1RfUkVBQ0hFRCgpOworICAgICAgICAgICAgICAgIGRlc2NyaXB0b3ItPnBvcnQudHlwZSA9IE1B Q0hfTVNHX1BPUlRfREVTQ1JJUFRPUjsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCiAgICAg ICAgIGlmIChtZXNzYWdlQm9keUlzT09MKSB7Ci0gICAgICAgICAgICBtYWNoX21zZ19kZXNjcmlw dG9yX3QqIGRlc2NyaXB0b3IgPSByZWludGVycHJldF9jYXN0PG1hY2hfbXNnX2Rlc2NyaXB0b3Jf dCo+KGRlc2NyaXB0b3JEYXRhKTsKKyAgICAgICAgICAgIGhlYWRlci0+bXNnaF9pZCB8PSBNZXNz YWdlQm9keUlzT3V0T2ZMaW5lOwogCisgICAgICAgICAgICBhdXRvKiBkZXNjcmlwdG9yID0gZ2V0 RGVzY3JpcHRvckFuZFNraXAobWVzc2FnZURhdGEpOwogICAgICAgICAgICAgZGVzY3JpcHRvci0+ b3V0X29mX2xpbmUuYWRkcmVzcyA9IGVuY29kZXItPmJ1ZmZlcigpOwogICAgICAgICAgICAgZGVz Y3JpcHRvci0+b3V0X29mX2xpbmUuc2l6ZSA9IGVuY29kZXItPmJ1ZmZlclNpemUoKTsKICAgICAg ICAgICAgIGRlc2NyaXB0b3ItPm91dF9vZl9saW5lLmNvcHkgPSBNQUNIX01TR19WSVJUVUFMX0NP UFk7CiAgICAgICAgICAgICBkZXNjcmlwdG9yLT5vdXRfb2ZfbGluZS5kZWFsbG9jYXRlID0gZmFs c2U7CiAgICAgICAgICAgICBkZXNjcmlwdG9yLT5vdXRfb2ZfbGluZS50eXBlID0gTUFDSF9NU0df T09MX0RFU0NSSVBUT1I7Ci0KLSAgICAgICAgICAgIGRlc2NyaXB0b3JEYXRhICs9IHNpemVvZiht YWNoX21zZ19vb2xfZGVzY3JpcHRvcl90KTsKICAgICAgICAgfQotCi0gICAgICAgIG1lc3NhZ2VE YXRhID0gZGVzY3JpcHRvckRhdGE7Ci0gICAgfSBlbHNlCi0gICAgICAgIG1lc3NhZ2VEYXRhID0g KHVpbnQ4X3QqKShoZWFkZXIgKyAxKTsKKyAgICB9CiAKICAgICAvLyBDb3B5IHRoZSBkYXRhIGlm IGl0IGlzIG5vdCBiZWluZyBzZW50IG91dC1vZi1saW5lLgogICAgIGlmICghbWVzc2FnZUJvZHlJ c09PTCkK