190928 2018-10-25 16:19:38 -0700 [LFC][IFC] Find floating constraints for a given vertical position 2018-10-26 07:30:51 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham ews-watchlist koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1472237 0 zalan 2018-10-25 16:19:38 -0700 ssia. 1472244 1 353128 zalan 2018-10-25 16:26:57 -0700 Created attachment 353128 Patch 1472422 2 ews-watchlist 2018-10-26 07:23:57 -0700 Attachment 353128 did not pass style-queue: ERROR: Source/WebCore/layout/floats/FloatingState.cpp:126: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/layout/floats/FloatingState.cpp:132: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1472428 3 zalan 2018-10-26 07:29:29 -0700 Committed r237452: <https://trac.webkit.org/changeset/237452> 1472429 4 webkit-bug-importer 2018-10-26 07:30:51 -0700 <rdar://problem/45586923> 353128 2018-10-25 16:26:57 -0700 2018-10-26 07:19:58 -0700 Patch Patch.txt text/plain 4350 zalan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5N2RmZmM2NzVjNC4uNWNjOTk0N2YyYTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxOC0xMC0yNSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgor CisgICAgICAgIFtMRkNdW0lGQ10gRmluZCBmbG9hdGluZyBjb25zdHJhaW50cyBmb3IgYSBnaXZl biB2ZXJ0aWNhbCBwb3NpdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTkwOTI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly93d3cudzMub3JnL1RSL0NTUzIyL3Zpc3VyZW4uaHRtbCNpbmxp bmUtZm9ybWF0dGluZworCisgICAgICAgICJJbiBnZW5lcmFsLCB0aGUgbGVmdCBlZGdlIG9mIGEg bGluZSBib3ggdG91Y2hlcyB0aGUgbGVmdCBlZGdlIG9mIGl0cyBjb250YWluaW5nIGJsb2NrIGFu ZCB0aGUgcmlnaHQgZWRnZSB0b3VjaGVzIHRoZSByaWdodCBlZGdlIG9mIGl0cyBjb250YWluaW5n IGJsb2NrLgorICAgICAgICBIb3dldmVyLCBmbG9hdGluZyBib3hlcyBtYXkgY29tZSBiZXR3ZWVu IHRoZSBjb250YWluaW5nIGJsb2NrIGVkZ2UgYW5kIHRoZSBsaW5lIGJveCBlZGdlLgorICAgICAg ICBUaHVzLCBhbHRob3VnaCBsaW5lIGJveGVzIGluIHRoZSBzYW1lIGlubGluZSBmb3JtYXR0aW5n IGNvbnRleHQgZ2VuZXJhbGx5IGhhdmUgdGhlIHNhbWUgd2lkdGgKKyAgICAgICAgKHRoYXQgb2Yg dGhlIGNvbnRhaW5pbmcgYmxvY2spLCB0aGV5IG1heSB2YXJ5IGluIHdpZHRoIGlmIGF2YWlsYWJs ZSBob3Jpem9udGFsIHNwYWNlIGlzIHJlZHVjZWQgZHVlIHRvIGZsb2F0cy4iCisKKyAgICAgICAg VGhpcyBwYXRjaCBhZGRzIHN1cHBvcnQgZm9yIHJldHJpZXZpbmcgbGVmdC9yaWdodCBjb25zdHJh aW50cyBmb3IgYSBnaXZlbiBsaW5lICh2ZXJ0aWNhbCBwb3NpdGlvbikuCisKKyAgICAgICAgKiBs YXlvdXQvZmxvYXRzL0Zsb2F0aW5nU3RhdGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0 OjpGbG9hdGluZ1N0YXRlOjpjb25zdHJhaW50cyBjb25zdCk6CisgICAgICAgICogbGF5b3V0L2Zs b2F0cy9GbG9hdGluZ1N0YXRlLmg6CisKIDIwMTgtMTAtMjUgIFphbGFuIEJ1anRhcyAgPHphbGFu QGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXSBJbmxpbmUgZm9ybWF0dGluZyBjb250ZXh0IGhh cyBoaWdoZXIgcHJpb3JpdHkgdGhhbiBibG9jawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2Zsb2F0cy9GbG9hdGluZ1N0YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9m bG9hdHMvRmxvYXRpbmdTdGF0ZS5jcHAKaW5kZXggZmQyZWU3OTA2NzUuLjRkYzQ5YmZjYTE1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZmxvYXRzL0Zsb2F0aW5nU3RhdGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mbG9hdHMvRmxvYXRpbmdTdGF0ZS5jcHAKQEAg LTg2LDYgKzg2LDU0IEBAIHZvaWQgRmxvYXRpbmdTdGF0ZTo6YXBwZW5kKGNvbnN0IEJveCYgbGF5 b3V0Qm94KQogICAgIG1fZmxvYXRzLmFwcGVuZCh7IGxheW91dEJveCwgKnRoaXMgfSk7CiB9CiAK K0Zsb2F0aW5nU3RhdGU6OkNvbnN0cmFpbnRzIEZsb2F0aW5nU3RhdGU6OmNvbnN0cmFpbnRzKExh eW91dFVuaXQgdmVydGljYWxQb3NpdGlvbiwgY29uc3QgQm94JiBmb3JtYXR0aW5nQ29udGV4dFJv b3QpIGNvbnN0Cit7CisgICAgaWYgKGlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIHsgfTsKKwor ICAgIC8vIDEuIENvbnZlcnQgdmVydGljYWwgcG9zaXRpb24gaWYgdGhpcyBmbG9hdGluZyBjb250 ZXh0IGlzIGluaGVyaXRlZC4KKyAgICAvLyAyLiBGaW5kIHRoZSBpbm5lciBsZWZ0L3JpZ2h0IGZs b2F0cyBhdCB2ZXJ0aWNhbFBvc2l0aW9uLgorICAgIC8vIDMuIENvbnZlcnQgbGVmdC9yaWdodCBw b3NpdGlvbnMgYmFjayB0byBmb3JtYXR0aW5nQ29udGV4dFJvb3QncyBjb29yaWRuYXRlIHN5c3Rl bS4KKyAgICBhdXRvIGNvb3JkaW5hdGVNYXBwaW5nSXNSZXF1aXJlZCA9ICZyb290KCkgIT0gJmZv cm1hdHRpbmdDb250ZXh0Um9vdDsKKyAgICBhdXRvIGFkanVzdGVkUG9zaXRpb24gPSBQb3NpdGlv biB7IDAsIHZlcnRpY2FsUG9zaXRpb24gfTsKKworICAgIGlmIChjb29yZGluYXRlTWFwcGluZ0lz UmVxdWlyZWQpCisgICAgICAgIGFkanVzdGVkUG9zaXRpb24gPSBGb3JtYXR0aW5nQ29udGV4dDo6 bWFwQ29vcmRpbmF0ZVRvQW5jZXN0b3IobV9sYXlvdXRDb250ZXh0LCBhZGp1c3RlZFBvc2l0aW9u LCBkb3duY2FzdDxDb250YWluZXI+KGZvcm1hdHRpbmdDb250ZXh0Um9vdCksIGRvd25jYXN0PENv bnRhaW5lcj4ocm9vdCgpKSk7CisKKyAgICBDb25zdHJhaW50cyBjb25zdHJhaW50czsKKyAgICBm b3IgKGludCBpbmRleCA9IG1fZmxvYXRzLnNpemUoKSAtIDE7IGluZGV4ID49IDA7IC0taW5kZXgp IHsKKyAgICAgICAgYXV0byYgZmxvYXRJdGVtID0gbV9mbG9hdHNbaW5kZXhdOworCisgICAgICAg IGlmIChjb25zdHJhaW50cy5sZWZ0ICYmIGZsb2F0SXRlbS5pc0xlZnRQb3NpdGlvbmVkKCkpCisg ICAgICAgICAgICBjb250aW51ZTsKKworICAgICAgICBpZiAoY29uc3RyYWludHMucmlnaHQgJiYg IWZsb2F0SXRlbS5pc0xlZnRQb3NpdGlvbmVkKCkpCisgICAgICAgICAgICBjb250aW51ZTsKKwor ICAgICAgICBhdXRvIHJlY3QgPSBmbG9hdEl0ZW0ucmVjdFdpdGhNYXJnaW4oKTsKKyAgICAgICAg aWYgKCEocmVjdC50b3AoKSA8PSB2ZXJ0aWNhbFBvc2l0aW9uICYmIHZlcnRpY2FsUG9zaXRpb24g PCByZWN0LmJvdHRvbSgpKSkKKyAgICAgICAgICAgIGNvbnRpbnVlOworCisgICAgICAgIGlmIChm bG9hdEl0ZW0uaXNMZWZ0UG9zaXRpb25lZCgpKQorICAgICAgICAgICAgY29uc3RyYWludHMubGVm dCA9IHJlY3QucmlnaHQoKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgY29uc3RyYWludHMu cmlnaHQgPSByZWN0LmxlZnQoKTsKKworICAgICAgICBpZiAoY29uc3RyYWludHMubGVmdCAmJiBj b25zdHJhaW50cy5yaWdodCkKKyAgICAgICAgICAgIGJyZWFrOworICAgIH0KKworICAgIGlmIChj b29yZGluYXRlTWFwcGluZ0lzUmVxdWlyZWQpCisgICAgICAgIGlmIChjb25zdHJhaW50cy5sZWZ0 KQorICAgICAgICAgICAgY29uc3RyYWludHMubGVmdCA9ICpjb25zdHJhaW50cy5sZWZ0IC0gYWRq dXN0ZWRQb3NpdGlvbi54OworCisgICAgICAgIGlmIChjb25zdHJhaW50cy5yaWdodCkgeworICAg ICAgICAgICAgY29uc3RyYWludHMucmlnaHQgPSAqY29uc3RyYWludHMucmlnaHQgLSBhZGp1c3Rl ZFBvc2l0aW9uLng7CisgICAgfQorCisgICAgcmV0dXJuIGNvbnN0cmFpbnRzOworfQorCiBzdGQ6 Om9wdGlvbmFsPExheW91dFVuaXQ+IEZsb2F0aW5nU3RhdGU6OmJvdHRvbShjb25zdCBCb3gmIGZv cm1hdHRpbmdDb250ZXh0Um9vdCwgQ2xlYXIgdHlwZSkgY29uc3QKIHsKICAgICBpZiAobV9mbG9h dHMuaXNFbXB0eSgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zsb2F0cy9G bG9hdGluZ1N0YXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZmxvYXRzL0Zsb2F0aW5nU3Rh dGUuaAppbmRleCA3ZjMyYzU2MDU0OS4uNzczZDFlNTI1ODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9mbG9hdHMvRmxvYXRpbmdTdGF0ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9mbG9hdHMvRmxvYXRpbmdTdGF0ZS5oCkBAIC01OCw2ICs1OCwxMiBAQCBwdWJsaWM6 CiAgICAgc3RkOjpvcHRpb25hbDxMYXlvdXRVbml0PiByaWdodEJvdHRvbShjb25zdCBCb3gmIGZv cm1hdHRpbmdDb250ZXh0Um9vdCkgY29uc3Q7CiAgICAgc3RkOjpvcHRpb25hbDxMYXlvdXRVbml0 PiBib3R0b20oY29uc3QgQm94JiBmb3JtYXR0aW5nQ29udGV4dFJvb3QpIGNvbnN0OwogCisgICAg c3RydWN0IENvbnN0cmFpbnRzIHsKKyAgICAgICAgc3RkOjpvcHRpb25hbDxMYXlvdXRVbml0PiBs ZWZ0OworICAgICAgICBzdGQ6Om9wdGlvbmFsPExheW91dFVuaXQ+IHJpZ2h0OworICAgIH07Cisg ICAgQ29uc3RyYWludHMgY29uc3RyYWludHMoTGF5b3V0VW5pdCB2ZXJ0aWNhbFBvc2l0aW9uLCBj b25zdCBCb3gmIGZvcm1hdHRpbmdDb250ZXh0Um9vdCkgY29uc3Q7CisKICAgICBjbGFzcyBGbG9h dEl0ZW0gewogICAgIHB1YmxpYzoKICAgICAgICAgRmxvYXRJdGVtKGNvbnN0IEJveCYsIGNvbnN0 IEZsb2F0aW5nU3RhdGUmKTsK