190922 2018-10-25 15:46:15 -0700 JSContext Inspector: Broken frontend, DOMAgent is used but does not exist 2018-10-25 16:55:21 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1472208 0 joepeck 2018-10-25 15:46:15 -0700 JSContext Inspector: Broken frontend, DOMAgent is used but does not exist Steps to Reproduce: 1. Attempt to inspect a JSContext (jsc --remote-debug) => Inspector does not show, early error [Error] ReferenceError: Can't find variable: DOMAgent requestDocument (Main.js:23726) ensureDocument (Main.js:23728) DOMManager (Main.js:23716:340) loaded (Main.js:25221:295) initialize (Main.js:25693:92) Global Code (Main.html:43) 1472211 1 webkit-bug-importer 2018-10-25 15:46:53 -0700 <rdar://problem/45569827> 1472214 2 353120 joepeck 2018-10-25 15:52:55 -0700 Created attachment 353120 [PATCH] Proposed Fix 1472215 3 353120 hi 2018-10-25 15:55:46 -0700 Comment on attachment 353120 [PATCH] Proposed Fix r=me While I do think this is a valid solution, I think it would better to wrap the `ensureDocument` call in a similar if (or even introduce a `WI.DOMManager.supported()` like some other managers). I'd prefer to check for support at the construction point rather than right before the call. 1472246 4 joepeck 2018-10-25 16:30:28 -0700 (In reply to Devin Rousso from comment #3) > Comment on attachment 353120 [details] > [PATCH] Proposed Fix > > r=me > > While I do think this is a valid solution, I think it would better to wrap > the `ensureDocument` call in a similar if (or even introduce a > `WI.DOMManager.supported()` like some other managers). I'd prefer to check > for support at the construction point rather than right before the call. Yes. In the near future, agent's won't be available in Manager construction and things like this will only happen when targets are supported. So this is a simple solution for now. 1472256 5 353120 commit-queue 2018-10-25 16:55:20 -0700 Comment on attachment 353120 [PATCH] Proposed Fix Clearing flags on attachment: 353120 Committed r237435: <https://trac.webkit.org/changeset/237435> 1472257 6 commit-queue 2018-10-25 16:55:21 -0700 All reviewed patches have been landed. Closing bug. 353120 2018-10-25 15:52:55 -0700 2018-10-25 16:55:20 -0700 [PATCH] Proposed Fix jscontext-1.patch text/plain 1419 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDg4MTNkZjU0MzYzLi5mNTU5MDNlODJjMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMTAtMjUgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBKU0NvbnRleHQgSW5z cGVjdG9yOiBCcm9rZW4gZnJvbnRlbmQsIERPTUFnZW50IGlzIHVzZWQgYnV0IGRvZXMgbm90IGV4 aXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA5 MjIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1NTY5ODI3PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVy cy9ET01NYW5hZ2VyLmpzOgorICAgICAgICAoV0kuRE9NTWFuYWdlci5wcm90b3R5cGUucmVxdWVz dERvY3VtZW50KToKKyAgICAgICAgRmVhdHVyZSBjaGVjayBmb3IgYWdlbnRzIHRoYXQgbWF5IG5v dCBleGlzdCBpbiBhIEpTQ29udGV4dC4KKwogMjAxOC0xMC0yNCAgRGV2aW4gUm91c3NvICA8ZHJv dXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogcG9wb3ZlcnMgZm9yIGZ1 bmN0aW9uIHNvdXJjZSBjb2RlIGFyZSBtYWxmb3JtZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTU1hbmFnZXIuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9ET01NYW5hZ2VyLmpz CmluZGV4IGEzYzU4ZTJhMjAwLi4yMjk5NWY4NDNhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NTWFuYWdlci5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9ET01NYW5hZ2Vy LmpzCkBAIC04Miw3ICs4Miw4IEBAIFdJLkRPTU1hbmFnZXIgPSBjbGFzcyBET01NYW5hZ2VyIGV4 dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAgICB0aGlzLl9wZW5kaW5nRG9jdW1lbnRSZXF1ZXN0 Q2FsbGJhY2tzID0gbnVsbDsKICAgICAgICAgfQogCi0gICAgICAgIERPTUFnZW50LmdldERvY3Vt ZW50KG9uRG9jdW1lbnRBdmFpbGFibGUuYmluZCh0aGlzKSk7CisgICAgICAgIGlmICh3aW5kb3cu RE9NQWdlbnQpCisgICAgICAgICAgICBET01BZ2VudC5nZXREb2N1bWVudChvbkRvY3VtZW50QXZh aWxhYmxlLmJpbmQodGhpcykpOwogICAgIH0KIAogICAgIGVuc3VyZURvY3VtZW50KCkK