190896 2018-10-24 19:18:42 -0700 Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes 2018-10-25 12:52:39 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue ews-watchlist glenn inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1471992 0 joepeck 2018-10-24 19:18:42 -0700 Add a watchlist message rule to warn about feature checking new inspector protocol changes So if someone adds: Page.newFeature We can add a comment that says "make sure to feature check new protocol APIs in the frontend". 1471993 1 353071 joepeck 2018-10-24 19:19:31 -0700 Created attachment 353071 [PATCH] Proposed Fix 1472151 2 353071 mattbaker 2018-10-25 12:27:08 -0700 Comment on attachment 353071 [PATCH] Proposed Fix r=me 1472155 3 353071 commit-queue 2018-10-25 12:51:50 -0700 Comment on attachment 353071 [PATCH] Proposed Fix Clearing flags on attachment: 353071 Committed r237422: <https://trac.webkit.org/changeset/237422> 1472156 4 commit-queue 2018-10-25 12:51:51 -0700 All reviewed patches have been landed. Closing bug. 1472157 5 webkit-bug-importer 2018-10-25 12:52:39 -0700 <rdar://problem/45563601> 353071 2018-10-24 19:19:31 -0700 2018-10-25 12:51:50 -0700 [PATCH] Proposed Fix warn-1.patch text/plain 2757 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzMmEx MTAxNmIzMS4uODIwOGQ3Nzk5YjggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxOC0xMC0yNCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCBh IHdhdGNobGlzdCBtZXNzYWdlIHJ1bGUgdG8gd2FybiBhYm91dCBmZWF0dXJlIGNoZWNraW5nIG5l dyBpbnNwZWN0b3IgcHJvdG9jb2wgY2hhbmdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwODk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvd2F0 Y2hsaXN0OgorCiAyMDE4LTEwLTIzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAK ICAgICAgICAgW1BTT05dIEFkZCBzdXBwb3J0IGZvciBjcm9zcy1zaXRlIGNsaWVudC1zaWRlIHJl ZGlyZWN0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmln L3dhdGNobGlzdCBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxp c3QKaW5kZXggYjViZjBkZGE2NGYuLjM5ZGU1MzM2MGM5IDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvd2F0Y2hsaXN0CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxpc3QKQEAgLTE5MSw4ICsxOTEsMTEgQEAKICAg ICAgICAgICAgICAgICAgICAgICAgIHIifFRvb2xzL1NjcmlwdHMvZ2VuZXJhdGUtaW5zcGVjdG9y LXByb3RvY29sLWJpbmRpbmdzLnB5IgogICAgICAgICAgICAgICAgICAgICAgICAgciJ8VG9vbHMv U2NyaXB0cy93ZWJraXRweS9pbnNwZWN0b3IiLAogICAgICAgICB9LAorICAgICAgICAiV2ViSW5z cGVjdG9yUHJvdG9jb2wiOiB7CisgICAgICAgICAgICAiZmlsZW5hbWUiOiByIlNvdXJjZS9KYXZh U2NyaXB0Q29yZS9pbnNwZWN0b3IvcHJvdG9jb2wvIiwKKyAgICAgICAgfSwKICAgICAgICAgIldl Ykluc3BlY3RvclJlY29yZGluZyI6IHsKLSAgICAgICAgICAgICJmaWxlbmFtZSI6IHIiU291cmNl L0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9Qcm90b2NvbC9SZWNvcmRpbmdcLmpzb24iCisgICAg ICAgICAgICAiZmlsZW5hbWUiOiByIlNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcHJv dG9jb2wvUmVjb3JkaW5nXC5qc29uIgogICAgICAgICAgICAgICAgICAgICAgICAgciJ8U291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvQ2FsbFRyYWNlci4qIgogICAgICAgICAgICAgICAgICAgICAg ICAgciJ8U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1JlY29yZGluZy4qIgogICAgICAgICAgICAg ICAgICAgICAgICAgciJ8U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvXHcqL1Jl Y29yZGluZy4qXC5qcyIKQEAgLTQzOSw2ICs0NDIsNyBAQAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIlNlZSBodHRwOi8vdHJhYy53ZWJraXQub3JnL3dpa2kvV2ViS2l0R1RLL0Fk ZGluZ05ld1dlYktpdDJBUEkiLCBdLAogICAgICAgICAiQU5HTEUiOiBbICJOb3RlIHRoYXQgdGhl cmUgYXJlIGltcG9ydGFudCBzdGVwcyB0byB0YWtlIHdoZW4gdXBkYXRpbmcgQU5HTEUuICIKICAg ICAgICAgICAgICAgICAgICAiU2VlIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvd2lraS9VcGRhdGlu Z0FOR0xFIiwgXSwKKyAgICAgICAgIldlYkluc3BlY3RvclByb3RvY29sIjogWyAiVGhpcyBwYXRj aCBtb2RpZmllcyB0aGUgaW5zcGVjdG9yIHByb3RvY29sLiBQbGVhc2UgZW5zdXJlIHRoYXQgYW55 IGZyb250ZW5kIGNoYW5nZXMgYXBwcm9wcmlhdGVseSB1c2UgZmVhdHVyZSBjaGVja3MgZm9yIG5l dyBwcm90b2NvbCBmZWF0dXJlcy4iIF0sCiAgICAgICAgICJXZWJJbnNwZWN0b3JHZW5lcmF0b3Ii OiBbICJUaGlzIHBhdGNoIG1vZGlmaWVzIHRoZSBpbnNwZWN0b3IgcHJvdG9jb2wgZ2VuZXJhdG9y LiBQbGVhc2UgZW5zdXJlIHRoYXQgeW91IGhhdmUgcmViYXNlbGluZWQgYW55IGdlbmVyYXRvciB0 ZXN0IHJlc3VsdHMgKGkuZS4sIGJ5IHJ1bm5pbmcgYFRvb2xzL1NjcmlwdHMvcnVuLWluc3BlY3Rv ci1nZW5lcmF0b3ItdGVzdHMgLS1yZXNldC1yZXN1bHRzYCkiIF0sCiAgICAgICAgICJKU0J1aWx0 aW5zR2VuZXJhdG9yIjogWyAiVGhpcyBwYXRjaCBtb2RpZmllcyB0aGUgSlMgYnVpbHRpbnMgY29k ZSBnZW5lcmF0b3IuIFBsZWFzZSBlbnN1cmUgdGhhdCB5b3UgaGF2ZSByZWJhc2VsaW5lZCBhbnkg Z2VuZXJhdG9yIHRlc3QgcmVzdWx0cyAoaS5lLiwgYnkgcnVubmluZyBgVG9vbHMvU2NyaXB0cy9y dW4tYnVpbHRpbnMtZ2VuZXJhdG9yLXRlc3RzIC0tcmVzZXQtcmVzdWx0c2ApIiBdLAogICAgICAg ICAiV2FzbUpTT04iOiBbICJUaGlzIHBhdGNoIG1vZGlmaWVzIG9uZSBvZiB0aGUgd2FzbS5qc29u IGZpbGVzLiBQbGVhc2UgZW5zdXJlIHRoYXQgYW55IGNoYW5nZXMgaW4gb25lIGhhdmUgYmVlbiBt aXJyb3JlZCB0byB0aGUgb3RoZXIuIFlvdSBjYW4gZmluZCB0aGUgd2FzbS5qc29uIGZpbGVzIGF0 IFwiU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vd2FzbS5qc29uXCIgYW5kIFwiSlNUZXN0cy93 YXNtL3dhc20uanNvblwiLiIgXSwK