190893 2018-10-24 17:04:25 -0700 [MSE][WTF][Media] Invalid MediaTime should be falsy 2018-10-26 07:05:33 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply commit-queue jer.noble oldest_to_newest 1471974 0 aboya 2018-10-24 17:04:25 -0700 Currently MediaTime::invalidTime() is evaluated as true in the context of a boolean evaluation. This behavior is surprising and I've already seen some code fall on it. In particular, in SourceBuffer: } else if (trackBuffer.roundedTimestampOffset) { // Reflect the timestamp offset into the sample. sample.offsetTimestampsBy(trackBuffer.roundedTimestampOffset); } There, the intention would be to offset the timestamps of the sample if and only if a valid non-zero timestamp offset exists. But with the current definition of MediaTime::operator bool, an invalid time is true. I definitively did not expect that, did you? This patch includes: 1. A mock MSE test case replicating a bug caused by that assumption. 2. A change in the definition of MediaTime::operator bool() and MediaTime::operator!() so that invalid times are falsy. 3. Additional API tests for conversions of MediaTime to bool. 1471975 1 353066 aboya 2018-10-24 17:12:42 -0700 Created attachment 353066 Patch 1472396 2 353066 jer.noble 2018-10-26 05:31:58 -0700 Comment on attachment 353066 Patch Originally, I decided not to make isInvalid() false because I thought it would be weird to have !isInvalid() == !zero. But I see that floating point NaN is also falsy, so this LGTM. 1472417 3 353066 commit-queue 2018-10-26 07:05:32 -0700 Comment on attachment 353066 Patch Clearing flags on attachment: 353066 Committed r237450: <https://trac.webkit.org/changeset/237450> 1472418 4 commit-queue 2018-10-26 07:05:33 -0700 All reviewed patches have been landed. Closing bug. 353066 2018-10-24 17:12:42 -0700 2018-10-26 07:05:32 -0700 Patch bug-190893-20181025011240.patch text/plain 12923 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDI1YWJiM2M3MWRlNzRmMTAwNjA2NzJi ZWFhYzVkNTYwMzdlM2I3ZDYuLmY1ZTM1MGExMDk1NWQ2NTUyNzc1YTMzZjY3ZjIwNTk4NTVkNmE1 YTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTAtMjQgIEFsaWNpYSBCb3lhIEdhcmPDrWEg IDxhYm95YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtNU0VdW1dURl1bTWVkaWFdIEludmFsaWQg TWVkaWFUaW1lIHNob3VsZCBiZSBmYWxzeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTkwODkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBtb2RpZmllcyB0aGUgZGVmaW5pdGlvbiBvZiBN ZWRpYVRpbWUgc28gdGhhdCBpbnZhbGlkIHRpbWVzCisgICAgICAgIGFyZSBldmFsdWF0ZWQgdG8g ZmFsc2UgaW4gdGhlIGNvbnRleHQgb2YgYSBib29sZWFuIGV4cHJlc3Npb24uCisKKyAgICAgICAg KiB3dGYvTWVkaWFUaW1lLmNwcDoKKyAgICAgICAgKFdURjo6TWVkaWFUaW1lOjpvcGVyYXRvciEg Y29uc3QpOgorICAgICAgICAoV1RGOjpNZWRpYVRpbWU6Om9wZXJhdG9yIGJvb2wgY29uc3QpOgor CiAyMDE4LTEwLTIyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg RGVxdWUncyBjb250YWlucygpIGFuZCBmaW5kSWYoKSBzaG91bGQgYmUgY29uc3QKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9NZWRpYVRp bWUuY3BwCmluZGV4IDRkYzk2NGQ0ZDQ3MjQ0MWU4N2RhYmVlMDNmODEwNGQ1ZmU4NTkzNGYuLjk0 NzEyZWEzYzdkMmEyNTZhNGMwZjY2ZmEwZDUyOGM4MzQ0OWZiZWUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XVEYvd3RmL01lZGlhVGltZS5jcHAKKysrIGIvU291cmNlL1dURi93dGYvTWVkaWFUaW1lLmNw cApAQCAtMzI4LDEzICszMjgsMTUgQEAgTWVkaWFUaW1lIE1lZGlhVGltZTo6b3BlcmF0b3IqKGlu dDMyX3QgcmhzKSBjb25zdAogYm9vbCBNZWRpYVRpbWU6Om9wZXJhdG9yISgpIGNvbnN0CiB7CiAg ICAgcmV0dXJuIChtX3RpbWVGbGFncyA9PSBWYWxpZCAmJiAhbV90aW1lVmFsdWUpCi0gICAgICAg IHx8IChtX3RpbWVGbGFncyA9PSAoVmFsaWQgfCBEb3VibGVWYWx1ZSkgJiYgIW1fdGltZVZhbHVl QXNEb3VibGUpOworICAgICAgICB8fCAobV90aW1lRmxhZ3MgPT0gKFZhbGlkIHwgRG91YmxlVmFs dWUpICYmICFtX3RpbWVWYWx1ZUFzRG91YmxlKQorICAgICAgICB8fCBpc0ludmFsaWQoKTsKIH0K IAogTWVkaWFUaW1lOjpvcGVyYXRvciBib29sKCkgY29uc3QKIHsKICAgICByZXR1cm4gIShtX3Rp bWVGbGFncyA9PSBWYWxpZCAmJiAhbV90aW1lVmFsdWUpCi0gICAgICAgICYmICEobV90aW1lRmxh Z3MgPT0gKFZhbGlkIHwgRG91YmxlVmFsdWUpICYmICFtX3RpbWVWYWx1ZUFzRG91YmxlKTsKKyAg ICAgICAgJiYgIShtX3RpbWVGbGFncyA9PSAoVmFsaWQgfCBEb3VibGVWYWx1ZSkgJiYgIW1fdGlt ZVZhbHVlQXNEb3VibGUpCisgICAgICAgICYmICFpc0ludmFsaWQoKTsKIH0KIAogTWVkaWFUaW1l OjpDb21wYXJpc29uRmxhZ3MgTWVkaWFUaW1lOjpjb21wYXJlKGNvbnN0IE1lZGlhVGltZSYgcmhz KSBjb25zdApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IDZlMjE3YTA3NzE2NzJmY2QzNTQxNzIyN2VmZGEzMjE1MjFjY2M1YjguLjhhZDE3YmYyNWY0 M2Y3NmY2MWUwNjQ3MzQ1ZmQ1MjVhZWUwYzE2NjAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0xMC0yNCAgQWxp Y2lhIEJveWEgR2FyY8OtYSAgPGFib3lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW01TRV1bV1RG XVtNZWRpYV0gSW52YWxpZCBNZWRpYVRpbWUgc2hvdWxkIGJlIGZhbHN5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA4OTMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgYWRkaXRp b25hbCBBUEkgdGVzdHMgZm9yIHRoZSBjb252ZXJzaW9ucyBmcm9tCisgICAgICAgIE1lZGlhVGlt ZSB0byBib29sZWFuLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWVkaWFU aW1lLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDE4LTEwLTIyICBU aW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJ T04gKHIyMzczMzEpOiBJbnRlcmFjdGlvbkRlYWRsb2NrQWZ0ZXJDcmFzaCBBUEkgdGVzdCBmYWls cwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWVkaWFUaW1lLmNw cCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL01lZGlhVGltZS5jcHAKaW5kZXggYzU0 YjJmNjMwOTM3MzlkYWVlM2QyYzFlNzdiZTdkYTU2YWMwMWIwMy4uNzAzYWIxMjVmMzY2OGE0NjE1 Njg3NzBkYmM1ZTA0NzYxYjhlNDlhMiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XVEYvTWVkaWFUaW1lLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dU Ri9NZWRpYVRpbWUuY3BwCkBAIC05Myw2ICs5MywxMCBAQCBURVNUKFdURiwgTWVkaWFUaW1lKQog ICAgIEVYUEVDVF9FUShNZWRpYVRpbWUoLTgsIDEwKSA+PSBNZWRpYVRpbWUoLTEsIDEpLCB0cnVl KTsKICAgICBFWFBFQ1RfVFJVRSgoYm9vbClNZWRpYVRpbWUoMSwgMSkpOwogICAgIEVYUEVDVF9U UlVFKCFNZWRpYVRpbWUoMCwgMSkpOworICAgIEVYUEVDVF9UUlVFKCFNZWRpYVRpbWU6OmludmFs aWRUaW1lKCkpOworICAgIEVYUEVDVF9UUlVFKCFNZWRpYVRpbWU6OmNyZWF0ZVdpdGhEb3VibGUo MC4wLCAxKSk7CisgICAgRVhQRUNUX0ZBTFNFKCFNZWRpYVRpbWUoMSwgMSkpOworICAgIEVYUEVD VF9GQUxTRSgoYm9vbClNZWRpYVRpbWU6OmludmFsaWRUaW1lKCkpOwogCiAgICAgLy8gQWRkaXRp b24gT3BlcmF0b3JzCiAgICAgRVhQRUNUX0VRKE1lZGlhVGltZTo6cG9zaXRpdmVJbmZpbml0ZVRp bWUoKSArIE1lZGlhVGltZTo6cG9zaXRpdmVJbmZpbml0ZVRpbWUoKSwgTWVkaWFUaW1lOjpwb3Np dGl2ZUluZmluaXRlVGltZSgpKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwM2YwNDUyMGNlZjRjYjZjNTQwZmNmMjNlMDI4 NjYyNDFkMGU4NTA3Li5jZDRjMGExNjIyMmJlZGY2NmZlNWU2N2RiMDMxOGQ2ZmEzZGY1MTNhIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMTAtMjQgIEFsaWNpYSBCb3lhIEdhcmPDrWEgIDxh Ym95YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtNU0VdW1dURl1bTWVkaWFdIEludmFsaWQgTWVk aWFUaW1lIHNob3VsZCBiZSBmYWxzeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTkwODkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQSB0ZXN0IGlzIGFkZGVkIHRoYXQgcmVwbGljYXRlcyBhIGJ1ZyBmaXhl ZCBieSB0aGlzIHBhdGNoLgorCisgICAgICAgICogbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNv dXJjZS10aW1lc3RhbXBvZmZzZXQtdGhlbi16ZXJvLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJjZS10aW1lc3RhbXBvZmZzZXQtdGhl bi16ZXJvLmh0bWw6IEFkZGVkLgorCiAyMDE4LTA5LTI4ICBBbGljaWEgQm95YSBHYXJjw61hICA8 YWJveWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbTVNFXSBVc2UgdG9sZXJhbmNlIHdoZW4gZ3Jv d2luZyB0aGUgY29kZWQgZnJhbWUgZ3JvdXAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlh L21lZGlhLXNvdXJjZS9tZWRpYS1zb3VyY2UtdGltZXN0YW1wb2Zmc2V0LXRoZW4temVyby1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNlLXRp bWVzdGFtcG9mZnNldC10aGVuLXplcm8tZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjI4ZmI3MDBj MDI1YjJmZGE2MDRiZTIzNGNhOTJiMDZmNmE5NmExM2UKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9tZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNlLXRpbWVzdGFtcG9mZnNldC10 aGVuLXplcm8tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNTkgQEAKKworRVhQRUNURUQgKHNvdXJj ZS5yZWFkeVN0YXRlID09ICdjbG9zZWQnKSBPSworRVZFTlQoc291cmNlb3BlbikKK1JVTihzb3Vy Y2VCdWZmZXIgPSBzb3VyY2UuYWRkU291cmNlQnVmZmVyKCJ2aWRlby9tb2NrOyBjb2RlY3M9bW9j ayIpKQorUlVOKHNvdXJjZUJ1ZmZlci50aW1lc3RhbXBPZmZzZXQgPSA1KQorUlVOKHNvdXJjZUJ1 ZmZlci5hcHBlbmRCdWZmZXIobWFrZVNpbXBsZUF1ZGlvKDAsIDIwLCAwKSkpCitFVkVOVCh1cGRh dGVlbmQpCitBZnRlciBmaXJzdCBhcHBlbmQ6Cit7UFRTKHs1MDAwLzEwMDAgPSA1LjAwMDAwMH0p LCBEVFMoezUwMDAvMTAwMCA9IDUuMDAwMDAwfSksIGR1cmF0aW9uKHsxMDAwLzEwMDAgPSAxLjAw MDAwMH0pLCBmbGFncygxKSwgZ2VuZXJhdGlvbigwKX0KK3tQVFMoezYwMDAvMTAwMCA9IDYuMDAw MDAwfSksIERUUyh7NjAwMC8xMDAwID0gNi4wMDAwMDB9KSwgZHVyYXRpb24oezEwMDAvMTAwMCA9 IDEuMDAwMDAwfSksIGZsYWdzKDEpLCBnZW5lcmF0aW9uKDApfQore1BUUyh7NzAwMC8xMDAwID0g Ny4wMDAwMDB9KSwgRFRTKHs3MDAwLzEwMDAgPSA3LjAwMDAwMH0pLCBkdXJhdGlvbih7MTAwMC8x MDAwID0gMS4wMDAwMDB9KSwgZmxhZ3MoMSksIGdlbmVyYXRpb24oMCl9Cit7UFRTKHs4MDAwLzEw MDAgPSA4LjAwMDAwMH0pLCBEVFMoezgwMDAvMTAwMCA9IDguMDAwMDAwfSksIGR1cmF0aW9uKHsx MDAwLzEwMDAgPSAxLjAwMDAwMH0pLCBmbGFncygxKSwgZ2VuZXJhdGlvbigwKX0KK3tQVFMoezkw MDAvMTAwMCA9IDkuMDAwMDAwfSksIERUUyh7OTAwMC8xMDAwID0gOS4wMDAwMDB9KSwgZHVyYXRp b24oezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGZsYWdzKDEpLCBnZW5lcmF0aW9uKDApfQore1BU Uyh7MTAwMDAvMTAwMCA9IDEwLjAwMDAwMH0pLCBEVFMoezEwMDAwLzEwMDAgPSAxMC4wMDAwMDB9 KSwgZHVyYXRpb24oezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGZsYWdzKDEpLCBnZW5lcmF0aW9u KDApfQore1BUUyh7MTEwMDAvMTAwMCA9IDExLjAwMDAwMH0pLCBEVFMoezExMDAwLzEwMDAgPSAx MS4wMDAwMDB9KSwgZHVyYXRpb24oezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGZsYWdzKDEpLCBn ZW5lcmF0aW9uKDApfQore1BUUyh7MTIwMDAvMTAwMCA9IDEyLjAwMDAwMH0pLCBEVFMoezEyMDAw LzEwMDAgPSAxMi4wMDAwMDB9KSwgZHVyYXRpb24oezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGZs YWdzKDEpLCBnZW5lcmF0aW9uKDApfQore1BUUyh7MTMwMDAvMTAwMCA9IDEzLjAwMDAwMH0pLCBE VFMoezEzMDAwLzEwMDAgPSAxMy4wMDAwMDB9KSwgZHVyYXRpb24oezEwMDAvMTAwMCA9IDEuMDAw MDAwfSksIGZsYWdzKDEpLCBnZW5lcmF0aW9uKDApfQore1BUUyh7MTQwMDAvMTAwMCA9IDE0LjAw MDAwMH0pLCBEVFMoezE0MDAwLzEwMDAgPSAxNC4wMDAwMDB9KSwgZHVyYXRpb24oezEwMDAvMTAw MCA9IDEuMDAwMDAwfSksIGZsYWdzKDEpLCBnZW5lcmF0aW9uKDApfQore1BUUyh7MTUwMDAvMTAw MCA9IDE1LjAwMDAwMH0pLCBEVFMoezE1MDAwLzEwMDAgPSAxNS4wMDAwMDB9KSwgZHVyYXRpb24o ezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGZsYWdzKDEpLCBnZW5lcmF0aW9uKDApfQore1BUUyh7 MTYwMDAvMTAwMCA9IDE2LjAwMDAwMH0pLCBEVFMoezE2MDAwLzEwMDAgPSAxNi4wMDAwMDB9KSwg ZHVyYXRpb24oezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGZsYWdzKDEpLCBnZW5lcmF0aW9uKDAp fQore1BUUyh7MTcwMDAvMTAwMCA9IDE3LjAwMDAwMH0pLCBEVFMoezE3MDAwLzEwMDAgPSAxNy4w MDAwMDB9KSwgZHVyYXRpb24oezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGZsYWdzKDEpLCBnZW5l cmF0aW9uKDApfQore1BUUyh7MTgwMDAvMTAwMCA9IDE4LjAwMDAwMH0pLCBEVFMoezE4MDAwLzEw MDAgPSAxOC4wMDAwMDB9KSwgZHVyYXRpb24oezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGZsYWdz KDEpLCBnZW5lcmF0aW9uKDApfQore1BUUyh7MTkwMDAvMTAwMCA9IDE5LjAwMDAwMH0pLCBEVFMo ezE5MDAwLzEwMDAgPSAxOS4wMDAwMDB9KSwgZHVyYXRpb24oezEwMDAvMTAwMCA9IDEuMDAwMDAw fSksIGZsYWdzKDEpLCBnZW5lcmF0aW9uKDApfQore1BUUyh7MjAwMDAvMTAwMCA9IDIwLjAwMDAw MH0pLCBEVFMoezIwMDAwLzEwMDAgPSAyMC4wMDAwMDB9KSwgZHVyYXRpb24oezEwMDAvMTAwMCA9 IDEuMDAwMDAwfSksIGZsYWdzKDEpLCBnZW5lcmF0aW9uKDApfQore1BUUyh7MjEwMDAvMTAwMCA9 IDIxLjAwMDAwMH0pLCBEVFMoezIxMDAwLzEwMDAgPSAyMS4wMDAwMDB9KSwgZHVyYXRpb24oezEw MDAvMTAwMCA9IDEuMDAwMDAwfSksIGZsYWdzKDEpLCBnZW5lcmF0aW9uKDApfQore1BUUyh7MjIw MDAvMTAwMCA9IDIyLjAwMDAwMH0pLCBEVFMoezIyMDAwLzEwMDAgPSAyMi4wMDAwMDB9KSwgZHVy YXRpb24oezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGZsYWdzKDEpLCBnZW5lcmF0aW9uKDApfQor e1BUUyh7MjMwMDAvMTAwMCA9IDIzLjAwMDAwMH0pLCBEVFMoezIzMDAwLzEwMDAgPSAyMy4wMDAw MDB9KSwgZHVyYXRpb24oezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGZsYWdzKDEpLCBnZW5lcmF0 aW9uKDApfQore1BUUyh7MjQwMDAvMTAwMCA9IDI0LjAwMDAwMH0pLCBEVFMoezI0MDAwLzEwMDAg PSAyNC4wMDAwMDB9KSwgZHVyYXRpb24oezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGZsYWdzKDEp LCBnZW5lcmF0aW9uKDApfQorUlVOKHNvdXJjZUJ1ZmZlci50aW1lc3RhbXBPZmZzZXQgPSAwKQor UlVOKHNvdXJjZUJ1ZmZlci5hcHBlbmRCdWZmZXIobWFrZVNpbXBsZUF1ZGlvKDAsIDIwLCAxKSkp CitFVkVOVCh1cGRhdGVlbmQpCitBZnRlciBzZWNvbmQgYXBwZW5kOgore1BUUyh7MC8xMDAwID0g MC4wMDAwMDB9KSwgRFRTKHswLzEwMDAgPSAwLjAwMDAwMH0pLCBkdXJhdGlvbih7MTAwMC8xMDAw ID0gMS4wMDAwMDB9KSwgZmxhZ3MoMSksIGdlbmVyYXRpb24oMSl9Cit7UFRTKHsxMDAwLzEwMDAg PSAxLjAwMDAwMH0pLCBEVFMoezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGR1cmF0aW9uKHsxMDAw LzEwMDAgPSAxLjAwMDAwMH0pLCBmbGFncygxKSwgZ2VuZXJhdGlvbigxKX0KK3tQVFMoezIwMDAv MTAwMCA9IDIuMDAwMDAwfSksIERUUyh7MjAwMC8xMDAwID0gMi4wMDAwMDB9KSwgZHVyYXRpb24o ezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGZsYWdzKDEpLCBnZW5lcmF0aW9uKDEpfQore1BUUyh7 MzAwMC8xMDAwID0gMy4wMDAwMDB9KSwgRFRTKHszMDAwLzEwMDAgPSAzLjAwMDAwMH0pLCBkdXJh dGlvbih7MTAwMC8xMDAwID0gMS4wMDAwMDB9KSwgZmxhZ3MoMSksIGdlbmVyYXRpb24oMSl9Cit7 UFRTKHs0MDAwLzEwMDAgPSA0LjAwMDAwMH0pLCBEVFMoezQwMDAvMTAwMCA9IDQuMDAwMDAwfSks IGR1cmF0aW9uKHsxMDAwLzEwMDAgPSAxLjAwMDAwMH0pLCBmbGFncygxKSwgZ2VuZXJhdGlvbigx KX0KK3tQVFMoezUwMDAvMTAwMCA9IDUuMDAwMDAwfSksIERUUyh7NTAwMC8xMDAwID0gNS4wMDAw MDB9KSwgZHVyYXRpb24oezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGZsYWdzKDEpLCBnZW5lcmF0 aW9uKDEpfQore1BUUyh7NjAwMC8xMDAwID0gNi4wMDAwMDB9KSwgRFRTKHs2MDAwLzEwMDAgPSA2 LjAwMDAwMH0pLCBkdXJhdGlvbih7MTAwMC8xMDAwID0gMS4wMDAwMDB9KSwgZmxhZ3MoMSksIGdl bmVyYXRpb24oMSl9Cit7UFRTKHs3MDAwLzEwMDAgPSA3LjAwMDAwMH0pLCBEVFMoezcwMDAvMTAw MCA9IDcuMDAwMDAwfSksIGR1cmF0aW9uKHsxMDAwLzEwMDAgPSAxLjAwMDAwMH0pLCBmbGFncygx KSwgZ2VuZXJhdGlvbigxKX0KK3tQVFMoezgwMDAvMTAwMCA9IDguMDAwMDAwfSksIERUUyh7ODAw MC8xMDAwID0gOC4wMDAwMDB9KSwgZHVyYXRpb24oezEwMDAvMTAwMCA9IDEuMDAwMDAwfSksIGZs YWdzKDEpLCBnZW5lcmF0aW9uKDEpfQore1BUUyh7OTAwMC8xMDAwID0gOS4wMDAwMDB9KSwgRFRT KHs5MDAwLzEwMDAgPSA5LjAwMDAwMH0pLCBkdXJhdGlvbih7MTAwMC8xMDAwID0gMS4wMDAwMDB9 KSwgZmxhZ3MoMSksIGdlbmVyYXRpb24oMSl9Cit7UFRTKHsxMDAwMC8xMDAwID0gMTAuMDAwMDAw fSksIERUUyh7MTAwMDAvMTAwMCA9IDEwLjAwMDAwMH0pLCBkdXJhdGlvbih7MTAwMC8xMDAwID0g MS4wMDAwMDB9KSwgZmxhZ3MoMSksIGdlbmVyYXRpb24oMSl9Cit7UFRTKHsxMTAwMC8xMDAwID0g MTEuMDAwMDAwfSksIERUUyh7MTEwMDAvMTAwMCA9IDExLjAwMDAwMH0pLCBkdXJhdGlvbih7MTAw MC8xMDAwID0gMS4wMDAwMDB9KSwgZmxhZ3MoMSksIGdlbmVyYXRpb24oMSl9Cit7UFRTKHsxMjAw MC8xMDAwID0gMTIuMDAwMDAwfSksIERUUyh7MTIwMDAvMTAwMCA9IDEyLjAwMDAwMH0pLCBkdXJh dGlvbih7MTAwMC8xMDAwID0gMS4wMDAwMDB9KSwgZmxhZ3MoMSksIGdlbmVyYXRpb24oMSl9Cit7 UFRTKHsxMzAwMC8xMDAwID0gMTMuMDAwMDAwfSksIERUUyh7MTMwMDAvMTAwMCA9IDEzLjAwMDAw MH0pLCBkdXJhdGlvbih7MTAwMC8xMDAwID0gMS4wMDAwMDB9KSwgZmxhZ3MoMSksIGdlbmVyYXRp b24oMSl9Cit7UFRTKHsxNDAwMC8xMDAwID0gMTQuMDAwMDAwfSksIERUUyh7MTQwMDAvMTAwMCA9 IDE0LjAwMDAwMH0pLCBkdXJhdGlvbih7MTAwMC8xMDAwID0gMS4wMDAwMDB9KSwgZmxhZ3MoMSks IGdlbmVyYXRpb24oMSl9Cit7UFRTKHsxNTAwMC8xMDAwID0gMTUuMDAwMDAwfSksIERUUyh7MTUw MDAvMTAwMCA9IDE1LjAwMDAwMH0pLCBkdXJhdGlvbih7MTAwMC8xMDAwID0gMS4wMDAwMDB9KSwg ZmxhZ3MoMSksIGdlbmVyYXRpb24oMSl9Cit7UFRTKHsxNjAwMC8xMDAwID0gMTYuMDAwMDAwfSks IERUUyh7MTYwMDAvMTAwMCA9IDE2LjAwMDAwMH0pLCBkdXJhdGlvbih7MTAwMC8xMDAwID0gMS4w MDAwMDB9KSwgZmxhZ3MoMSksIGdlbmVyYXRpb24oMSl9Cit7UFRTKHsxNzAwMC8xMDAwID0gMTcu MDAwMDAwfSksIERUUyh7MTcwMDAvMTAwMCA9IDE3LjAwMDAwMH0pLCBkdXJhdGlvbih7MTAwMC8x MDAwID0gMS4wMDAwMDB9KSwgZmxhZ3MoMSksIGdlbmVyYXRpb24oMSl9Cit7UFRTKHsxODAwMC8x MDAwID0gMTguMDAwMDAwfSksIERUUyh7MTgwMDAvMTAwMCA9IDE4LjAwMDAwMH0pLCBkdXJhdGlv bih7MTAwMC8xMDAwID0gMS4wMDAwMDB9KSwgZmxhZ3MoMSksIGdlbmVyYXRpb24oMSl9Cit7UFRT KHsxOTAwMC8xMDAwID0gMTkuMDAwMDAwfSksIERUUyh7MTkwMDAvMTAwMCA9IDE5LjAwMDAwMH0p LCBkdXJhdGlvbih7MTAwMC8xMDAwID0gMS4wMDAwMDB9KSwgZmxhZ3MoMSksIGdlbmVyYXRpb24o MSl9Cit7UFRTKHsyMDAwMC8xMDAwID0gMjAuMDAwMDAwfSksIERUUyh7MjAwMDAvMTAwMCA9IDIw LjAwMDAwMH0pLCBkdXJhdGlvbih7MTAwMC8xMDAwID0gMS4wMDAwMDB9KSwgZmxhZ3MoMSksIGdl bmVyYXRpb24oMCl9Cit7UFRTKHsyMTAwMC8xMDAwID0gMjEuMDAwMDAwfSksIERUUyh7MjEwMDAv MTAwMCA9IDIxLjAwMDAwMH0pLCBkdXJhdGlvbih7MTAwMC8xMDAwID0gMS4wMDAwMDB9KSwgZmxh Z3MoMSksIGdlbmVyYXRpb24oMCl9Cit7UFRTKHsyMjAwMC8xMDAwID0gMjIuMDAwMDAwfSksIERU Uyh7MjIwMDAvMTAwMCA9IDIyLjAwMDAwMH0pLCBkdXJhdGlvbih7MTAwMC8xMDAwID0gMS4wMDAw MDB9KSwgZmxhZ3MoMSksIGdlbmVyYXRpb24oMCl9Cit7UFRTKHsyMzAwMC8xMDAwID0gMjMuMDAw MDAwfSksIERUUyh7MjMwMDAvMTAwMCA9IDIzLjAwMDAwMH0pLCBkdXJhdGlvbih7MTAwMC8xMDAw ID0gMS4wMDAwMDB9KSwgZmxhZ3MoMSksIGdlbmVyYXRpb24oMCl9Cit7UFRTKHsyNDAwMC8xMDAw ID0gMjQuMDAwMDAwfSksIERUUyh7MjQwMDAvMTAwMCA9IDI0LjAwMDAwMH0pLCBkdXJhdGlvbih7 MTAwMC8xMDAwID0gMS4wMDAwMDB9KSwgZmxhZ3MoMSksIGdlbmVyYXRpb24oMCl9CitFTkQgT0Yg VEVTVAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEt c291cmNlLXRpbWVzdGFtcG9mZnNldC10aGVuLXplcm8uaHRtbCBiL0xheW91dFRlc3RzL21lZGlh L21lZGlhLXNvdXJjZS9tZWRpYS1zb3VyY2UtdGltZXN0YW1wb2Zmc2V0LXRoZW4temVyby5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjU4ZmNhMTE4YzdkMmMxYWU3OTgwYjJiNGJmZjk2NzUwNzgzOWY5MDYKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEtc291 cmNlLXRpbWVzdGFtcG9mZnNldC10aGVuLXplcm8uaHRtbApAQCAtMCwwICsxLDYyIEBACis8IURP Q1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+CisgICAgPHRpdGxlPm1lZGlhLXNvdXJjZS10aW1l c3RhbXBvZmZzZXQtdGhlbi16ZXJvPC90aXRsZT4KKyAgICA8c2NyaXB0IHNyYz0ibW9jay1tZWRp YS1zb3VyY2UuanMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSIuLi92aWRlby10ZXN0Lmpz Ij48L3NjcmlwdD4KKyAgICA8c2NyaXB0PgorICAgIHZhciBzb3VyY2U7CisgICAgdmFyIHNvdXJj ZUJ1ZmZlcjsKKyAgICB2YXIgYnVmZmVyZWRTYW1wbGVzOworCisgICAgaWYgKHdpbmRvdy5pbnRl cm5hbHMpCisgICAgICAgIGludGVybmFscy5pbml0aWFsaXplTW9ja01lZGlhU291cmNlKCk7CisK KyAgICBmdW5jdGlvbiBtYWtlU2ltcGxlQXVkaW8oc3RhcnQsIGVuZCwgZ2VuZXJhdGlvbikgewor ICAgICAgICBjb25zdCBpbml0ID0gbWFrZUFJbml0KDIsIFttYWtlQVRyYWNrKDEsICdtb2NrJywg VFJBQ0tfS0lORC5WSURFTyldKTsKKworICAgICAgICBjb25zdCBzYW1wbGVzID0gW107CisgICAg ICAgIGZvciAobGV0IHRpbWUgPSBzdGFydDsgdGltZSA8IGVuZDsgdGltZSsrKQorICAgICAgICAg ICAgc2FtcGxlcy5wdXNoKG1ha2VBU2FtcGxlKHRpbWUsIHRpbWUsIDEsIDEsIFNBTVBMRV9GTEFH LlNZTkMsIGdlbmVyYXRpb24pKTsKKworICAgICAgICByZXR1cm4gY29uY2F0ZW5hdGVTYW1wbGVz KFtpbml0XS5jb25jYXQoc2FtcGxlcykpOworICAgIH0KKworICAgIHdpbmRvdy5hZGRFdmVudExp c3RlbmVyKCdsb2FkJywgYXN5bmMgKCkgPT4geworICAgICAgICBmaW5kTWVkaWFFbGVtZW50KCk7 CisgICAgICAgIHNvdXJjZSA9IG5ldyBNZWRpYVNvdXJjZSgpOworICAgICAgICB0ZXN0RXhwZWN0 ZWQoJ3NvdXJjZS5yZWFkeVN0YXRlJywgJ2Nsb3NlZCcpOworICAgICAgICBjb25zdCBzb3VyY2VP cGVuZWQgPSB3YWl0Rm9yKHNvdXJjZSwgJ3NvdXJjZW9wZW4nKTsKKworICAgICAgICBjb25zdCB2 aWRlb1NvdXJjZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3NvdXJjZScpOworICAgICAgICB2 aWRlb1NvdXJjZS50eXBlID0gJ2F1ZGlvL21vY2s7IGNvZGVjcz1tb2NrJzsKKyAgICAgICAgdmlk ZW9Tb3VyY2Uuc3JjID0gVVJMLmNyZWF0ZU9iamVjdFVSTChzb3VyY2UpOworICAgICAgICB2aWRl by5hcHBlbmRDaGlsZCh2aWRlb1NvdXJjZSk7CisKKyAgICAgICAgYXdhaXQgc291cmNlT3BlbmVk OworICAgICAgICBydW4oJ3NvdXJjZUJ1ZmZlciA9IHNvdXJjZS5hZGRTb3VyY2VCdWZmZXIoInZp ZGVvL21vY2s7IGNvZGVjcz1tb2NrIiknKTsKKworICAgICAgICBydW4oJ3NvdXJjZUJ1ZmZlci50 aW1lc3RhbXBPZmZzZXQgPSA1Jyk7CisgICAgICAgIHJ1bignc291cmNlQnVmZmVyLmFwcGVuZEJ1 ZmZlcihtYWtlU2ltcGxlQXVkaW8oMCwgMjAsIDApKScpOworICAgICAgICBhd2FpdCB3YWl0Rm9y KHNvdXJjZUJ1ZmZlciwgJ3VwZGF0ZWVuZCcpOworCisgICAgICAgIGJ1ZmZlcmVkU2FtcGxlcyA9 IGludGVybmFscy5idWZmZXJlZFNhbXBsZXNGb3JUcmFja0lEKHNvdXJjZUJ1ZmZlciwgMSk7Cisg ICAgICAgIGNvbnNvbGVXcml0ZSgiQWZ0ZXIgZmlyc3QgYXBwZW5kOiIpOworICAgICAgICBidWZm ZXJlZFNhbXBsZXMuZm9yRWFjaChjb25zb2xlV3JpdGUpOworCisgICAgICAgIHJ1bignc291cmNl QnVmZmVyLnRpbWVzdGFtcE9mZnNldCA9IDAnKTsKKyAgICAgICAgcnVuKCdzb3VyY2VCdWZmZXIu YXBwZW5kQnVmZmVyKG1ha2VTaW1wbGVBdWRpbygwLCAyMCwgMSkpJyk7CisgICAgICAgIGF3YWl0 IHdhaXRGb3Ioc291cmNlQnVmZmVyLCAndXBkYXRlZW5kJyk7CisKKyAgICAgICAgYnVmZmVyZWRT YW1wbGVzID0gaW50ZXJuYWxzLmJ1ZmZlcmVkU2FtcGxlc0ZvclRyYWNrSUQoc291cmNlQnVmZmVy LCAxKTsKKyAgICAgICAgY29uc29sZVdyaXRlKCJBZnRlciBzZWNvbmQgYXBwZW5kOiIpOworICAg ICAgICBidWZmZXJlZFNhbXBsZXMuZm9yRWFjaChjb25zb2xlV3JpdGUpOworCisgICAgICAgIGVu ZFRlc3QoKTsKKyAgICB9KTsKKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorICAgIDx2 aWRlbyBjb250cm9scz48L3ZpZGVvPgorPC9ib2R5PgorPC9odG1sPgo=