19089 2008-05-15 14:53:13 -0700 Editing ASSERT in Range::compareBoundaryPoints 2008-06-05 17:22:12 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 18858 1 eric webkit-unassigned oldest_to_newest 80557 0 eric 2008-05-15 14:53:13 -0700 Editing ASSERT in Range::compareBoundaryPoints ASSERTION FAILED: containerA && containerB (/Users/eseidel/Projects/WebKit/WebCore/dom/Range.cpp:458 static short int WebCore::Range::compareBoundaryPoints(WebCore::Node*, int, WebCore::Node*, int)) Found by the fuzzer. See attached test case. doc.execCommand('inserthorizontalrule'); doc.execCommand('formatblock', 0, '<pre>'); 80558 1 21182 eric 2008-05-15 14:53:37 -0700 Created attachment 21182 causes ASSERT in debug builds 82367 2 21514 justin.garcia 2008-06-05 16:59:54 -0700 Created attachment 21514 patch 82369 3 21515 justin.garcia 2008-06-05 17:03:50 -0700 Created attachment 21515 patch Didn't include the meat of the patch last time. 82370 4 21515 eric 2008-06-05 17:13:03 -0700 Comment on attachment 21515 patch Looks good to me. r+ 82371 5 justin.garcia 2008-06-05 17:22:12 -0700 http://trac.webkit.org/changeset/34390 21182 2008-05-15 14:53:37 -0700 2008-05-15 14:53:37 -0700 causes ASSERT in debug builds reduced-test.html text/html 462 eric PGlmcmFtZSBpZD1mIG5hbWU9ZiBzcmM9ImFib3V0OmJsYW5rIiB3aWR0aD0xMDAlIGhlaWdodD01 MCU+PC9pZnJhbWU+CjxzY3JpcHQ+CnZhciBpZnJhbWUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgiZiIpOwpkb2MgPSBpZnJhbWUuY29udGVudERvY3VtZW50Owpkb2MuYWRkRXZlbnRMaXN0ZW5l cigiY2xpY2siLCBnb3RGb2N1cywgdHJ1ZSk7CmRvYy5kZXNpZ25Nb2RlID0gJ29uJzsKZnVuY3Rp b24gZ290Rm9jdXMoKSB7CiAgZG9jLmV4ZWNDb21tYW5kKCdpbnNlcnRob3Jpem9udGFscnVsZScp OwogIGRvYy5leGVjQ29tbWFuZCgnZm9ybWF0YmxvY2snLCAwLCAnPHByZT4nKTsKfQppZiAod2lu ZG93LmV2ZW50U2VuZGVyKSB7CiAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oMTAwLCAxMDApOwog IGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOwogIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKfQo8L3Nj cmlwdD4K 21514 2008-06-05 16:59:54 -0700 2008-06-05 17:03:50 -0700 patch 19.txt text/plain 2961 justin.garcia SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNDM4OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDgtMDYtMDUgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lh QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDg5PiBFZGl0 aW5nIEFTU0VSVCBpbiBSYW5nZTo6Y29tcGFyZUJvdW5kYXJ5UG9pbnRzCisgICAgICAgIAorICAg ICAgICBBcHBseVN0eWxlQ29tbWFuZDo6YXBwbHlJbmxpbmVTdHlsZSBkb2VzIHNvbWUgd29yayBh bmQgdGhlbiBjaGVja3MgdG8gc2VlCisgICAgICAgIGlmIHRoZSBzdGFydCBvZmZzZXQgb2YgdGhl IFJhbmdlIGl0J3Mgb3BlcmF0aW5nIG9uIGlzIG5vdyBwYXN0IHRoZSBjYXJldE1heE9mZnNldAor ICAgICAgICBvZiB0aGUgc3RhcnQgY29udGFpbmVyLiAgSWYgaXQgaXMsIGFwcGx5SW5saW5lU3R5 bGUgdXBkYXRlcyB0aGUgcG9zaXRpb24gdG8gCisgICAgICAgIFtzdGFydENvbnRhaW5lci0+dHJh dmVyc2VOZXh0Tm9kZSgpLCAwXSBhbmQgdGhlbiBvcGVyYXRlcyBvbiB0aGF0IG5ldyBzdGFydAor ICAgICAgICBwb3NpdGlvbi4KKyAgICAgICAgCisgICAgICAgIGNhcmV0TWF4T2Zmc2V0IHdhcyBp bmNvcnJlY3QgZm9yIGhvcml6b250YWwgcnVsZXMuICBJdCBzaG91bGQgYmUgMSBhbmQgaXQgd2Fz IDAuICBTbywKKyAgICAgICAgaWYgdGhlIGhvcml6b250YWwgcnVsZSB3YXMgdGhlIGxhc3Qgbm9k ZSBpbiB0aGUgZG9jdW1lbnQsIGFwcGx5SW5saW5lU3R5bGUgd291bGQgdXBkYXRlCisgICAgICAg IGl0cyBzdGFydCBwb3NpdGlvbiB0byBbMCwgMF0gYW5kIHRoZW4gdHJ5IHRvIG9wZXJhdGUgb24g dGhhdCBwb3NpdGlvbiwgYXNzdW1pbmcgaXQgd2FzCisgICAgICAgIG5vbi1udWxsLCBsZWFkaW5n IHRvIHRoZSBBU1NFUlQuCisgICAgICAgIAorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmpl Y3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0OjpjYXJldE1heE9mZnNldCk6 CisKIDIwMDgtMDYtMDUgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBKb2huIFN1bGxpdmFuLgpJbmRleDogTGF5b3V0VGVzdHMvZWRp dGluZy9leGVjQ29tbWFuZC8xOTA4OS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC8xOTA4OS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kLzE5MDg5LWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKQEAgLTAsMCArMSwyIEBACitUaGlzIHRlc3RzIHRvIG1ha2Ugc3VyZSBhbiBB U1NFUlQgZG9lc24ndCBmaXJlIHdoZW4gcGVyZm9ybWluZyBhIEZvcm1hdEJsb2NrIG9wZXJhdGlv biBvbiBhIHNlbGVjdGlvbiB0aGF0IGVuZHMganVzdCBhZnRlciBhIGhvcml6b250YWwgcnVsZSB0 aGF0IGlzIHRoZSBsYXN0IGVsZW1lbnQgaW4gdGhlIGRvY3VtZW50LiBUaGUgdGVzdCBzaG91bGQg bm90IGFzc2VydC4KKzxwcmU+PHNwYW4gY2xhc3M9IkFwcGxlLXN0eWxlLXNwYW4iIHN0eWxlPSJm b250LWZhbWlseTogVGltZXM7IGZvbnQtc2l6ZTogMTZweDsgd2hpdGUtc3BhY2U6IG5vcm1hbDsg Ij48aHI+PC9zcGFuPjwvcHJlPgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFu ZC8xOTA4OS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1h bmQvMTkwODkuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0Nv bW1hbmQvMTkwODkuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNSBAQAorPGh0bWw+Cis8 aGVhZD4KKzxzY3JpcHQ+CitmdW5jdGlvbiBydW5UZXN0KCkgeworICAgIGlmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5k dW1wQXNUZXh0KCk7CisgICAgZGl2ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRpdiIpOwor ICAgIGRpdi5mb2N1cygpOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJTZWxlY3RBbGwiKTsK KyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgiRm9ybWF0QmxvY2siLCBmYWxzZSwgIjxwcmU+Iik7 CisgICAgZG9jdW1lbnQuYm9keS5pbm5lclRleHQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi ZGVzY3JpcHRpb24iKS5pbm5lclRleHQgKyAiXG4iICsgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo ImRpdiIpLmlubmVySFRNTDsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25Mb2FkPSJy dW5UZXN0KCkiPjxkaXYgaWQ9ImRlc2NyaXB0aW9uIj5UaGlzIHRlc3RzIHRvIG1ha2Ugc3VyZSBh biBBU1NFUlQgZG9lc24ndCBmaXJlIHdoZW4gcGVyZm9ybWluZyBhIEZvcm1hdEJsb2NrIG9wZXJh dGlvbiBvbiBhIHNlbGVjdGlvbiB0aGF0IGVuZHMganVzdCBhZnRlciBhIGhvcml6b250YWwgcnVs ZSB0aGF0IGlzIHRoZSBsYXN0IGVsZW1lbnQgaW4gdGhlIGRvY3VtZW50LiBUaGUgdGVzdCBzaG91 bGQgbm90IGFzc2VydC4gPC9kaXY+PGRpdiBpZD0iZGl2IiBjb250ZW50RWRpdGFibGU9InRydWUi Pjxocj48L2Rpdj48L2JvZHk+PC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK 21515 2008-06-05 17:03:50 -0700 2008-06-05 17:13:03 -0700 patch 19.txt text/plain 3542 justin.garcia SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNDM4OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDgtMDYtMDUgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lh QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDg5PiBFZGl0 aW5nIEFTU0VSVCBpbiBSYW5nZTo6Y29tcGFyZUJvdW5kYXJ5UG9pbnRzCisgICAgICAgIAorICAg ICAgICBBcHBseVN0eWxlQ29tbWFuZDo6YXBwbHlJbmxpbmVTdHlsZSBkb2VzIHNvbWUgd29yayBh bmQgdGhlbiBjaGVja3MgdG8gc2VlCisgICAgICAgIGlmIHRoZSBzdGFydCBvZmZzZXQgb2YgdGhl IFJhbmdlIGl0J3Mgb3BlcmF0aW5nIG9uIGlzIG5vdyBwYXN0IHRoZSBjYXJldE1heE9mZnNldAor ICAgICAgICBvZiB0aGUgc3RhcnQgY29udGFpbmVyLiAgSWYgaXQgaXMsIGFwcGx5SW5saW5lU3R5 bGUgdXBkYXRlcyB0aGUgcG9zaXRpb24gdG8gCisgICAgICAgIFtzdGFydENvbnRhaW5lci0+dHJh dmVyc2VOZXh0Tm9kZSgpLCAwXSBhbmQgdGhlbiBvcGVyYXRlcyBvbiB0aGF0IG5ldyBzdGFydAor ICAgICAgICBwb3NpdGlvbi4KKyAgICAgICAgCisgICAgICAgIGNhcmV0TWF4T2Zmc2V0IHdhcyBp bmNvcnJlY3QgZm9yIGhvcml6b250YWwgcnVsZXMuICBJdCBzaG91bGQgYmUgMSBhbmQgaXQgd2Fz IDAuICBTbywKKyAgICAgICAgaWYgdGhlIGhvcml6b250YWwgcnVsZSB3YXMgdGhlIGxhc3Qgbm9k ZSBpbiB0aGUgZG9jdW1lbnQsIGFwcGx5SW5saW5lU3R5bGUgd291bGQgdXBkYXRlCisgICAgICAg IGl0cyBzdGFydCBwb3NpdGlvbiB0byBbMCwgMF0gYW5kIHRoZW4gdHJ5IHRvIG9wZXJhdGUgb24g dGhhdCBwb3NpdGlvbiwgYXNzdW1pbmcgaXQgd2FzCisgICAgICAgIG5vbi1udWxsLCBsZWFkaW5n IHRvIHRoZSBBU1NFUlQuCisgICAgICAgIAorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmpl Y3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0OjpjYXJldE1heE9mZnNldCk6 CisKIDIwMDgtMDYtMDUgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBKb2huIFN1bGxpdmFuLgpJbmRleDogV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJPYmplY3QuY3BwCShyZXZpc2lvbiAzNDM4NCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ck9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5OTUsNyArMjk5NSwxMSBAQAogCiBpbnQg UmVuZGVyT2JqZWN0OjpjYXJldE1heE9mZnNldCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIGlzUmVw bGFjZWQoKSA/IChlbGVtZW50KCkgPyBtYXgoMVUsIGVsZW1lbnQoKS0+Y2hpbGROb2RlQ291bnQo KSkgOiAxKSA6IDA7CisgICAgaWYgKGlzUmVwbGFjZWQoKSkKKyAgICAgICAgcmV0dXJuIGVsZW1l bnQoKSA/IG1heCgxVSwgZWxlbWVudCgpLT5jaGlsZE5vZGVDb3VudCgpKSA6IDE7CisgICAgaWYg KGlzSFIoKSkKKyAgICAgICAgcmV0dXJuIDE7CisgICAgcmV0dXJuIDA7CiB9CiAKIHVuc2lnbmVk IFJlbmRlck9iamVjdDo6Y2FyZXRNYXhSZW5kZXJlZE9mZnNldCgpIGNvbnN0CkluZGV4OiBMYXlv dXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kLzE5MDg5LWV4cGVjdGVkLnR4dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kLzE5MDg5LWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvMTkwODktZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIgQEAKK1RoaXMgdGVzdHMgdG8gbWFr ZSBzdXJlIGFuIEFTU0VSVCBkb2Vzbid0IGZpcmUgd2hlbiBwZXJmb3JtaW5nIGEgRm9ybWF0Qmxv Y2sgb3BlcmF0aW9uIG9uIGEgc2VsZWN0aW9uIHRoYXQgZW5kcyBqdXN0IGFmdGVyIGEgaG9yaXpv bnRhbCBydWxlIHRoYXQgaXMgdGhlIGxhc3QgZWxlbWVudCBpbiB0aGUgZG9jdW1lbnQuIFRoZSB0 ZXN0IHNob3VsZCBub3QgYXNzZXJ0LgorPHByZT48c3BhbiBjbGFzcz0iQXBwbGUtc3R5bGUtc3Bh biIgc3R5bGU9ImZvbnQtZmFtaWx5OiBUaW1lczsgZm9udC1zaXplOiAxNnB4OyB3aGl0ZS1zcGFj ZTogbm9ybWFsOyAiPjxocj48L3NwYW4+PC9wcmU+CkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5n L2V4ZWNDb21tYW5kLzE5MDg5Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGlu Zy9leGVjQ29tbWFuZC8xOTA4OS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRp dGluZy9leGVjQ29tbWFuZC8xOTA4OS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE1IEBA Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2Z1bmN0aW9uIHJ1blRlc3QoKSB7CisgICAgaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgd2luZG93LmxheW91dFRlc3RD b250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICBkaXYgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgiZGl2Iik7CisgICAgZGl2LmZvY3VzKCk7CisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIlNl bGVjdEFsbCIpOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJGb3JtYXRCbG9jayIsIGZhbHNl LCAiPHByZT4iKTsKKyAgICBkb2N1bWVudC5ib2R5LmlubmVyVGV4dCA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJkZXNjcmlwdGlvbiIpLmlubmVyVGV4dCArICJcbiIgKyBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgiZGl2IikuaW5uZXJIVE1MOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eSBvbkxvYWQ9InJ1blRlc3QoKSI+PGRpdiBpZD0iZGVzY3JpcHRpb24iPlRoaXMgdGVzdHMgdG8g bWFrZSBzdXJlIGFuIEFTU0VSVCBkb2Vzbid0IGZpcmUgd2hlbiBwZXJmb3JtaW5nIGEgRm9ybWF0 QmxvY2sgb3BlcmF0aW9uIG9uIGEgc2VsZWN0aW9uIHRoYXQgZW5kcyBqdXN0IGFmdGVyIGEgaG9y aXpvbnRhbCBydWxlIHRoYXQgaXMgdGhlIGxhc3QgZWxlbWVudCBpbiB0aGUgZG9jdW1lbnQuIFRo ZSB0ZXN0IHNob3VsZCBub3QgYXNzZXJ0LiA8L2Rpdj48ZGl2IGlkPSJkaXYiIGNvbnRlbnRFZGl0 YWJsZT0idHJ1ZSI+PGhyPjwvZGl2PjwvYm9keT48L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQg b2YgZmlsZQo=