190885 2018-10-24 11:37:15 -0700 [High Sierra / Mojave Debug WK2] Layout Test media/video-restricted-invisible-autoplay-allowed-when-visible.html is a flaky failure 2019-06-12 17:02:24 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 realdawei eric.carlson ap commit-queue eric.carlson jer.noble jlewis3 lforschler ryanhaddad tsavell webkit-bug-importer youennf oldest_to_newest 1471894 0 realdawei 2018-10-24 11:37:15 -0700 The following layout test is failing on [High Sierra Debug WK2] media/video-restricted-invisible-autoplay-allowed-when-visible.html Probable cause: Unknown Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-restricted-invisible-autoplay-allowed-when-visible.html --- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/media/video-restricted-invisible-autoplay-allowed-when-visible-expected.txt +++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/media/video-restricted-invisible-autoplay-allowed-when-visible-actual.txt @@ -3,6 +3,6 @@ RUN(internals.setMediaElementRestrictions(video, "InvisibleAutoplayNotPermitted")) ** setting video.src RUN(document.body.appendChild(video)) -EVENT(play) +FAIL: did not end fast enough END OF TEST 1472075 1 ryanhaddad 2018-10-25 09:31:05 -0700 I can repro the failures locally with: media/video-restricted-invisible-autoplay-allowed-when-visible.html -fg --iter 100 --no-retry I cannot repro the failure after making this change: diff --git a/LayoutTests/media/video-restricted-invisible-autoplay-allowed-when-visible.html b/LayoutTests/media/video-restricted-invisible-autoplay-allowed-when-visible.html index 50b7a1a7d88..a09825fb1a7 100644 --- a/LayoutTests/media/video-restricted-invisible-autoplay-allowed-when-visible.html +++ b/LayoutTests/media/video-restricted-invisible-autoplay-allowed-when-visible.html @@ -19,7 +19,7 @@ function putInDOM() { run('document.body.appendChild(video)'); - failTestIn(250); + failTestIn(2000); } function play() 1472483 2 webkit-bug-importer 2018-10-26 09:54:59 -0700 <rdar://problem/45590590> 1544283 3 371999 eric.carlson 2019-06-12 16:28:53 -0700 Created attachment 371999 Patch 1544286 4 371999 commit-queue 2019-06-12 17:02:22 -0700 Comment on attachment 371999 Patch Clearing flags on attachment: 371999 Committed r246387: <https://trac.webkit.org/changeset/246387> 1544287 5 commit-queue 2019-06-12 17:02:24 -0700 All reviewed patches have been landed. Closing bug. 371999 2019-06-12 16:28:53 -0700 2019-06-12 17:02:22 -0700 Patch bug-190885-20190612162852.patch text/plain 1595 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MzI5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzBkMTk2OGJhOWU3ZmI3NzA4ZTNi MDkzYzA2MDhiM2E0YzdkMzdmMy4uZDg0YzdhYjgxODhhMzU4Y2Y5NjkyN2QwMTRiMjZiOWQwOTIx NzVhMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA2LTEyICBFcmljIENhcmxzb24gIDxl cmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtIaWdoIFNpZXJyYSAvIE1vamF2ZSBE ZWJ1ZyBXSzJdIExheW91dCBUZXN0IG1lZGlhL3ZpZGVvLXJlc3RyaWN0ZWQtaW52aXNpYmxlLWF1 dG9wbGF5LWFsbG93ZWQtd2hlbi12aXNpYmxlLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA4ODUKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzQ1NTkwNTkwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogbWVkaWEvdmlkZW8tcmVzdHJpY3RlZC1pbnZpc2libGUt YXV0b3BsYXktYWxsb3dlZC13aGVuLXZpc2libGUuaHRtbDogSW5jcmVhc2UgdGhlIGFtb3VudCBv ZgorICAgICAgICAgdGltZSBpdCB0YWtlcyBmb3IgdGhlIHRlc3QgdG8gZmFpbCBzbyBpdCBpc24n dCBmbGFreSBvbiBzbG93IG1hY2hpbmVzLgorCiAyMDE5LTA2LTExICBEYW5pZWwgQmF0ZXMgIDxk YWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBTa2lwIHRlc3QgaHR0cC90ZXN0cy9zZWN1cml0 eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvbmF2aWdhdGUtc2VsZi10by1kYXRhLXVybC5odG1sIGFz CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1yZXN0cmljdGVkLWludmlzaWJs ZS1hdXRvcGxheS1hbGxvd2VkLXdoZW4tdmlzaWJsZS5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEv dmlkZW8tcmVzdHJpY3RlZC1pbnZpc2libGUtYXV0b3BsYXktYWxsb3dlZC13aGVuLXZpc2libGUu aHRtbAppbmRleCA1MGI3YTFhN2Q4ODdhYmJmZDIwYmJhZDJhMTFjZDhiZDgyNjM1MzE5Li5hMDk4 MjVmYjFhNzhmNzhhNjA3ZTA0NmE2OTk4MGViYjk2MGIwMDVmIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9tZWRpYS92aWRlby1yZXN0cmljdGVkLWludmlzaWJsZS1hdXRvcGxheS1hbGxvd2VkLXdo ZW4tdmlzaWJsZS5odG1sCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXJlc3RyaWN0ZWQt aW52aXNpYmxlLWF1dG9wbGF5LWFsbG93ZWQtd2hlbi12aXNpYmxlLmh0bWwKQEAgLTE5LDcgKzE5 LDcgQEAKICAgICAgICAgICAgIGZ1bmN0aW9uIHB1dEluRE9NKCkKICAgICAgICAgICAgIHsKICAg ICAgICAgICAgICAgICBydW4oJ2RvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQodmlkZW8pJyk7Ci0g ICAgICAgICAgICAgICAgZmFpbFRlc3RJbigyNTApOworICAgICAgICAgICAgICAgIGZhaWxUZXN0 SW4oMjAwMCk7CiAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIGZ1bmN0aW9uIHBsYXkoKQo=