190867 2018-10-24 04:16:40 -0700 [WPE][GTK] Cleanups to the certificate decoder 2018-10-24 07:56:54 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 csaavedra csaavedra bugs-noreply mcatanzaro zan oldest_to_newest 1471802 0 csaavedra 2018-10-24 04:16:40 -0700 [WPE][GTK] Cleanups to the certificate decoder 1471803 1 353031 csaavedra 2018-10-24 04:17:01 -0700 Created attachment 353031 Patch 1471814 2 353031 csaavedra 2018-10-24 06:45:36 -0700 Comment on attachment 353031 Patch Clearing flags on attachment: 353031 Committed r237380: <https://trac.webkit.org/changeset/237380> 1471815 3 csaavedra 2018-10-24 06:45:40 -0700 All reviewed patches have been landed. Closing bug. 1471831 4 353031 mcatanzaro 2018-10-24 07:56:54 -0700 Comment on attachment 353031 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353031&action=review > Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp:103 > + GRefPtr<GByteArray> certificateData = g_byte_array_sized_new(certificateDataReference.size()); Now, because you did not use adotpGRef(), there are two refs to the GByteArray: the original one, and the GRefPtr's. > Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp:104 > + certificateData = g_byte_array_append(certificateData.get(), certificateDataReference.data(), certificateDataReference.size()); So now the GRefPtr would drop its ref on the original GByteArray and ref the new one. But the original ref on the original GByteArray has been lost. Right? I think you need to use adoptGRef() on the line above. 353031 2018-10-24 04:17:01 -0700 2018-10-24 06:45:36 -0700 Patch bug-190867-20181024141659.patch text/plain 2584 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3Mzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFmMjM0ZjAxNmNjZmYxYjBk ZGRkZWQ0YmYyMmJkMGEyYmI2MGJlODcuLjBkODY5ZWRjYzgyZjQyZjFiZWMwMzgyZjllYzYyMGVl NGYyZWU3M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMTAtMjQgIENsYXVkaW8g U2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtHVEtdIENs ZWFudXBzIHRvIHRoZSBjZXJ0aWZpY2F0ZSBkZWNvZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA4NjcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9zb3VwL1dlYkNvcmVBcmd1bWVudENv ZGVyc1NvdXAuY3BwOgorICAgICAgICAoSVBDOjpBcmd1bWVudENvZGVyPENlcnRpZmljYXRlSW5m bz46OmRlY29kZSk6CisKIDIwMTgtMTAtMjQgIENsYXVkaW8gU2FhdmVkcmEgIDxjc2FhdmVkcmFA aWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXVtHVEtdIENsZWFudXBzIHRvIHRoZSBjZXJ0aWZp Y2F0ZSBlbmNvZGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9zb3VwL1dlYkNv cmVBcmd1bWVudENvZGVyc1NvdXAuY3BwIGIvU291cmNlL1dlYktpdC9TaGFyZWQvc291cC9XZWJD b3JlQXJndW1lbnRDb2RlcnNTb3VwLmNwcAppbmRleCAzMzMxYWIwNGZiMmE3NWJkMzEzMDI4MjEx YmMwNDc3MWIyMGRjODZlLi4xODliODA2ZjkzZmRjOTZmOWM1N2Q4YjUyNTllZTg5ZGQ3YzdkNDhl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9zb3VwL1dlYkNvcmVBcmd1bWVudENv ZGVyc1NvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL3NvdXAvV2ViQ29yZUFyZ3Vt ZW50Q29kZXJzU291cC5jcHAKQEAgLTkzLDIyICs5MywxOCBAQCBib29sIEFyZ3VtZW50Q29kZXI8 Q2VydGlmaWNhdGVJbmZvPjo6ZGVjb2RlKERlY29kZXImIGRlY29kZXIsIENlcnRpZmljYXRlSW5m byYgYwogICAgIGlmICghY2hhaW5MZW5ndGgpCiAgICAgICAgIHJldHVybiB0cnVlOwogCi0gICAg R1Rsc0NlcnRpZmljYXRlKiBpc3N1ZXIgPSBudWxscHRyOwotICAgIEdUbHNCYWNrZW5kKiBiYWNr ZW5kID0gZ190bHNfYmFja2VuZF9nZXRfZGVmYXVsdCgpOworICAgIEdUeXBlIGNlcnRpZmljYXRl VHlwZSA9IGdfdGxzX2JhY2tlbmRfZ2V0X2NlcnRpZmljYXRlX3R5cGUoZ190bHNfYmFja2VuZF9n ZXRfZGVmYXVsdCgpKTsKICAgICBHUmVmUHRyPEdUbHNDZXJ0aWZpY2F0ZT4gY2VydGlmaWNhdGU7 CiAgICAgZm9yICh1aW50MzJfdCBpID0gMDsgaSA8IGNoYWluTGVuZ3RoOyBpKyspIHsKICAgICAg ICAgSVBDOjpEYXRhUmVmZXJlbmNlIGNlcnRpZmljYXRlRGF0YVJlZmVyZW5jZTsKICAgICAgICAg aWYgKCFkZWNvZGVyLmRlY29kZVZhcmlhYmxlTGVuZ3RoQnl0ZUFycmF5KGNlcnRpZmljYXRlRGF0 YVJlZmVyZW5jZSkpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICAgICAgR0J5dGVB cnJheSogY2VydGlmaWNhdGVEYXRhID0gZ19ieXRlX2FycmF5X3NpemVkX25ldyhjZXJ0aWZpY2F0 ZURhdGFSZWZlcmVuY2Uuc2l6ZSgpKTsKLSAgICAgICAgY2VydGlmaWNhdGVEYXRhID0gZ19ieXRl X2FycmF5X2FwcGVuZChjZXJ0aWZpY2F0ZURhdGEsIGNlcnRpZmljYXRlRGF0YVJlZmVyZW5jZS5k YXRhKCksIGNlcnRpZmljYXRlRGF0YVJlZmVyZW5jZS5zaXplKCkpOwotICAgICAgICBHUmVmUHRy PEdCeXRlQXJyYXk+IGNlcnRpZmljYXRlQnl0ZXMgPSBhZG9wdEdSZWYoY2VydGlmaWNhdGVEYXRh KTsKKyAgICAgICAgR1JlZlB0cjxHQnl0ZUFycmF5PiBjZXJ0aWZpY2F0ZURhdGEgPSBnX2J5dGVf YXJyYXlfc2l6ZWRfbmV3KGNlcnRpZmljYXRlRGF0YVJlZmVyZW5jZS5zaXplKCkpOworICAgICAg ICBjZXJ0aWZpY2F0ZURhdGEgPSBnX2J5dGVfYXJyYXlfYXBwZW5kKGNlcnRpZmljYXRlRGF0YS5n ZXQoKSwgY2VydGlmaWNhdGVEYXRhUmVmZXJlbmNlLmRhdGEoKSwgY2VydGlmaWNhdGVEYXRhUmVm ZXJlbmNlLnNpemUoKSk7CiAKICAgICAgICAgY2VydGlmaWNhdGUgPSBhZG9wdEdSZWYoR19UTFNf Q0VSVElGSUNBVEUoZ19pbml0YWJsZV9uZXcoCi0gICAgICAgICAgICBnX3Rsc19iYWNrZW5kX2dl dF9jZXJ0aWZpY2F0ZV90eXBlKGJhY2tlbmQpLCAwLCAwLCAiY2VydGlmaWNhdGUiLCBjZXJ0aWZp Y2F0ZUJ5dGVzLmdldCgpLCAiaXNzdWVyIiwgaXNzdWVyLCBudWxscHRyKSkpOwotCi0gICAgICAg IGlzc3VlciA9IGNlcnRpZmljYXRlLmdldCgpOworICAgICAgICAgICAgY2VydGlmaWNhdGVUeXBl LCBudWxscHRyLCBudWxscHRyLCAiY2VydGlmaWNhdGUiLCBjZXJ0aWZpY2F0ZURhdGEuZ2V0KCks ICJpc3N1ZXIiLCBjZXJ0aWZpY2F0ZS5nZXQoKSwgbnVsbHB0cikpKTsKICAgICB9CiAKICAgICB1 aW50MzJfdCB0bHNFcnJvcnM7Cg==