19085 2008-05-15 12:59:52 -0700 font-family: initial sets font-family differently than font: initial 2008-05-15 14:09:51 -0700 1 1 1 Unclassified WebKit CSS 525.x (Safari 3.1) Mac OS X 10.5 RESOLVED FIXED HasReduction, InRadar P2 Normal --- 1 ddkilzer webkit-unassigned hyatt mitz oldest_to_newest 80535 0 ddkilzer 2008-05-15 12:59:52 -0700 * SUMMARY When using "font-family: initial" to style text, the font-family computed style differs from both using "font: initial" to style text and completely unstyled text. * STEPS TO REPRODUCE 1. Launch Safari/WebKit. 2. Open attached test case. * EXPECTED RESULTS font-family: initial should have a computed font-family property value of "Times" (assuming the default Safari settings). * ACTUAL RESULTS font-family: initial has a computed font-family property value of "''" (that's two single quotes). * REGRESSION This is not a regression. Safari 2.0.4 with original WebKit on Mac OS X 10.4.11 return the null value. 80536 1 21173 ddkilzer 2008-05-15 13:00:17 -0700 Created attachment 21173 Test case 80539 2 ddkilzer 2008-05-15 13:05:19 -0700 <rdar://problem/5939391> 80541 3 21175 ddkilzer 2008-05-15 13:23:52 -0700 Created attachment 21175 Patch v1 Proposed patch and test case. Instead of checking !initialDesc.firstFamily().familyIsEmpty() (which is always true for a new FontDescription()), the line that sets the family could just be removed. I figured this was slightly safer in case the FontDescription default constructor changed in the future. 80542 4 ddkilzer 2008-05-15 13:28:13 -0700 (In reply to comment #3) > Instead of checking !initialDesc.firstFamily().familyIsEmpty() (which is always > true for a new FontDescription()), the line that sets the family could just be > removed. I figured this was slightly safer in case the FontDescription default > constructor changed in the future. I should say initialDesc.firstFamily().familyIsEmpty() is always true (meaning the first family is always empty for a new FontDescription()). 80547 5 21175 hyatt 2008-05-15 13:59:31 -0700 Comment on attachment 21175 Patch v1 r=me 80552 6 ddkilzer 2008-05-15 14:09:51 -0700 Committed revision 33496. 21173 2008-05-15 13:00:17 -0700 2008-05-15 13:00:17 -0700 Test case font-family-initial.html text/html 1038 ddkilzer PGRpdiBpZD0idW5zdHlsZWQiPlVuc3R5bGVkIFRleHQ8L2Rpdj4KPGRpdiBpZD0iZm9udFByb3Bl cnRpZXNJbml0aWFsIiBzdHlsZT0iZm9udC1zdHlsZTogaW5pdGlhbDsgZm9udC12YXJpYW50OiBp bml0aWFsOyBmb250LXdlaWdodDsgaW5pdGlhbDsgZm9udC1zaXplOiBpbml0aWFsOyBmb250LWZh bWlseTogaW5pdGlhbDsiPkZvbnQgUHJvcGVydGllcyBJbml0aWFsPC9kaXY+CjxkaXYgaWQ9ImZv bnRJbml0aWFsIiBzdHlsZT0iZm9udDogaW5pdGlhbDsiPkZvbnQgSW5pdGlhbDwvZGl2Pgo8aHI+ CjxzY3JpcHQ+CmZ1bmN0aW9uIGR1bXBQcm9wZXJ0eShjb21wdXRlZFN0eWxlLCBuYW1lKQp7CiAg ICBkb2N1bWVudC53cml0ZSgiPGRkPjxjb2RlPiIgKyBuYW1lICsgIjogIiArIGNvbXB1dGVkU3R5 bGUuZ2V0UHJvcGVydHlWYWx1ZShuYW1lKSArICI8L2NvZGU+PC9kZD4iKTsKfQoKZnVuY3Rpb24g ZHVtcEVsZW1lbnQodGhlSWQpCnsKICAgIHZhciBlbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQodGhlSWQpOwogICAgZG9jdW1lbnQud3JpdGUoIjxkbD48ZHQ+IiArIGVsZW1lbnQuaW5u ZXJUZXh0ICsgIjwvZHQ+Iik7CiAgICB2YXIgY29tcHV0ZWRTdHlsZSA9IGRvY3VtZW50LmRlZmF1 bHRWaWV3LmdldENvbXB1dGVkU3R5bGUoZWxlbWVudCwgbnVsbCk7CiAgICBkdW1wUHJvcGVydHko Y29tcHV0ZWRTdHlsZSwgImZvbnQtc3R5bGUiKTsKICAgIGR1bXBQcm9wZXJ0eShjb21wdXRlZFN0 eWxlLCAiZm9udC12YXJpYW50Iik7CiAgICBkdW1wUHJvcGVydHkoY29tcHV0ZWRTdHlsZSwgImZv bnQtd2VpZ2h0Iik7CiAgICBkdW1wUHJvcGVydHkoY29tcHV0ZWRTdHlsZSwgImZvbnQtc2l6ZSIp OwogICAgZHVtcFByb3BlcnR5KGNvbXB1dGVkU3R5bGUsICJmb250LWZhbWlseSIpOwogICAgZG9j dW1lbnQud3JpdGUoIjwvZGw+Iik7Cn0KCmR1bXBFbGVtZW50KCJ1bnN0eWxlZCIpOwpkdW1wRWxl bWVudCgiZm9udFByb3BlcnRpZXNJbml0aWFsIik7CmR1bXBFbGVtZW50KCJmb250SW5pdGlhbCIp Owo8L3NjcmlwdD4K 21175 2008-05-15 13:23:52 -0700 2008-05-15 13:59:31 -0700 Patch v1 bug-19085-v1.diff text/plain 4796 ddkilzer SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMzQ5MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDgtMDUtMTUgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxl LmNvbT4KKworICAgICAgICBCdWcgMTkwODU6IGZvbnQtZmFtaWx5OiBpbml0aWFsIHNldHMgZm9u dC1mYW1pbHkgZGlmZmVyZW50bHkgdGhhbiBmb250OiBpbml0aWFsCisKKyAgICAgICAgPGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA4NT4KKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzU5MzkzOTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGVzdDogZmFzdC9jc3MvZm9udC1mYW1pbHktaW5pdGlhbC5odG1sCisKKyAg ICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NT dHlsZVNlbGVjdG9yOjphcHBseVByb3BlcnR5KTogRG9uJ3Qgc2V0IGZhbWlseSBpZiBmaXJzdAor ICAgICAgICBmYW1pbHkgb2YgaW5pdGlhbCBmb250IGRlc2NyaXB0aW9uIGlzIGVtcHR5LgorCiAy MDA4LTA1LTE1ICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhcmluLgpJbmRleDogV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxl Y3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJ KHJldmlzaW9uIDMzNDUxKQorKysgV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTM1NjMsNyArMzU2Myw4IEBAIHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6 YXBwbHlQcm9wZXJ0eShpbnQKICAgICAgICAgICAgIGlmIChmb250RGVzY3JpcHRpb24ua2V5d29y ZFNpemUoKSAmJiBmb250RGVzY3JpcHRpb24uZ2VuZXJpY0ZhbWlseSgpID09IEZvbnREZXNjcmlw dGlvbjo6TW9ub3NwYWNlRmFtaWx5KQogICAgICAgICAgICAgICAgIHNldEZvbnRTaXplKGZvbnRE ZXNjcmlwdGlvbiwgZm9udFNpemVGb3JLZXl3b3JkKENTU1ZhbHVlWHhTbWFsbCArIGZvbnREZXNj cmlwdGlvbi5rZXl3b3JkU2l6ZSgpIC0gMSwgbV9zdHlsZS0+aHRtbEhhY2tzKCksIGZhbHNlKSk7 CiAgICAgICAgICAgICBmb250RGVzY3JpcHRpb24uc2V0R2VuZXJpY0ZhbWlseShpbml0aWFsRGVz Yy5nZW5lcmljRmFtaWx5KCkpOwotICAgICAgICAgICAgZm9udERlc2NyaXB0aW9uLnNldEZhbWls eShpbml0aWFsRGVzYy5maXJzdEZhbWlseSgpKTsKKyAgICAgICAgICAgIGlmICghaW5pdGlhbERl c2MuZmlyc3RGYW1pbHkoKS5mYW1pbHlJc0VtcHR5KCkpCisgICAgICAgICAgICAgICAgZm9udERl c2NyaXB0aW9uLnNldEZhbWlseShpbml0aWFsRGVzYy5maXJzdEZhbWlseSgpKTsKICAgICAgICAg ICAgIGlmIChtX3N0eWxlLT5zZXRGb250RGVzY3JpcHRpb24oZm9udERlc2NyaXB0aW9uKSkKICAg ICAgICAgICAgICAgICBtX2ZvbnREaXJ0eSA9IHRydWU7CiAgICAgICAgICAgICByZXR1cm47Cklu ZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCShyZXZpc2lvbiAzMzQ5MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDA4LTA1LTE1ICBEYXZpZCBLaWx6ZXIgIDxkZGtp bHplckBhcHBsZS5jb20+CisKKyAgICAgICAgQnVnIDE5MDg1OiBmb250LWZhbWlseTogaW5pdGlh bCBzZXRzIGZvbnQtZmFtaWx5IGRpZmZlcmVudGx5IHRoYW4gZm9udDogaW5pdGlhbAorCisgICAg ICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwODU+CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS81OTM5MzkxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9jc3MvZm9udC1mYW1pbHktaW5pdGlhbC1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzL2ZvbnQtZmFtaWx5LWluaXRpYWwu aHRtbDogQWRkZWQuCisKIDIwMDgtMDUtMTUgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4 QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4uCkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2Nzcy9mb250LWZhbWlseS1pbml0aWFsLWV4cGVjdGVkLnR4dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9mb250LWZhbWlseS1pbml0aWFsLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvY3NzL2ZvbnQtZmFtaWx5LWluaXRp YWwtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE0IEBACitVbnN0eWxlZCBG b250IEZhbWlseQorSW5pdGlhbCBGb250IEZhbWlseQorSW5pdGlhbCBGb250CitUZXN0IGZvciBC dWcgMTkwODU6IGZvbnQtZmFtaWx5OiBpbml0aWFsIHNldHMgZm9udC1mYW1pbHkgZGlmZmVyZW50 bHkgdGhhbiBmb250OiBpbml0aWFsCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmll cyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQ QVNTIGluaXRpYWxGb250RmFtaWx5IGlzIHVuc3R5bGVkCitQQVNTIGluaXRpYWxGb250IGlzIHVu c3R5bGVkCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUK KwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jc3MvZm9udC1mYW1pbHktaW5pdGlhbC5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY3NzL2ZvbnQtZmFtaWx5LWluaXRpYWwuaHRt bAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvY3NzL2ZvbnQtZmFtaWx5LWluaXRp YWwuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzNyBAQAorPCFET0NUWVBFIEhUTUwgUFVC TElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4gICAgCis8bGluayBy ZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+ Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4K KzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgd2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKK30KKzwvc2NyaXB0PgorPC9oZWFk PgorPGJvZHk+Cis8ZGl2IGlkPSJ1bnN0eWxlZCI+VW5zdHlsZWQgRm9udCBGYW1pbHk8L2Rpdj4K KzxkaXYgaWQ9ImluaXRpYWxGb250RmFtaWx5IiBzdHlsZT0iZm9udC1mYW1pbHk6IGluaXRpYWw7 Ij5Jbml0aWFsIEZvbnQgRmFtaWx5PC9kaXY+Cis8ZGl2IGlkPSJpbml0aWFsRm9udCIgc3R5bGU9 ImZvbnQ6IGluaXRpYWw7Ij5Jbml0aWFsIEZvbnQ8L2Rpdj4KKzxocj4KKzxwIGlkPSJkZXNjcmlw dGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0PgorZGVzY3JpcHRp b24oIlRlc3QgZm9yIDxhIGhyZWY9XCJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTkwODVcIj5CdWcgMTkwODU6IGZvbnQtZmFtaWx5OiBpbml0aWFsIHNldHMgZm9udC1m YW1pbHkgZGlmZmVyZW50bHkgdGhhbiBmb250OiBpbml0aWFsPC9hPiIpOworCit2YXIgaW5pdGlh bEZvbnRFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImluaXRpYWxGb250Iik7Cit2 YXIgaW5pdGlhbEZvbnRGYW1pbHlFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImlu aXRpYWxGb250RmFtaWx5Iik7Cit2YXIgdW5zdHlsZWRFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoInVuc3R5bGVkIik7CisKK3ZhciBpbml0aWFsRm9udCA9IGRvY3VtZW50LmRlZmF1 bHRWaWV3LmdldENvbXB1dGVkU3R5bGUoaW5pdGlhbEZvbnRFbGVtZW50LCBudWxsKS5nZXRQcm9w ZXJ0eVZhbHVlKCJmb250LWZhbWlseSIpOwordmFyIGluaXRpYWxGb250RmFtaWx5ID0gZG9jdW1l bnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0ZWRTdHlsZShpbml0aWFsRm9udEZhbWlseUVsZW1lbnQs IG51bGwpLmdldFByb3BlcnR5VmFsdWUoImZvbnQtZmFtaWx5Iik7Cit2YXIgdW5zdHlsZWQgPSBk b2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKHVuc3R5bGVkRWxlbWVudCwgbnVs bCkuZ2V0UHJvcGVydHlWYWx1ZSgiZm9udC1mYW1pbHkiKTsKKworc2hvdWxkQmUoImluaXRpYWxG b250RmFtaWx5IiwgInVuc3R5bGVkIik7CitzaG91bGRCZSgiaW5pdGlhbEZvbnQiLCAidW5zdHls ZWQiKTsKKworc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0PgorPHNjcmlwdCBz cmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5Pgor PC9odG1sPgo=