190839 2018-10-23 12:41:14 -0700 CSSCalcOperation constructor wastes 6KB of Vector capacity on cnn.com 2018-11-12 08:50:26 -0800 1 1 1 Unclassified WebKit New Bugs Other All All RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis achristensen commit-queue dbates fred.wang webkit-bug-importer oldest_to_newest 1471644 0 rbuis 2018-10-23 12:41:14 -0700 Tooling from bug 186698: Wasted capacity: 6272 bytes (used 896 of 7168 bytes, utilization: 12.50%) - 56 allocations 1 0x10aaf8335 WebCore::CSSCalcExpressionNodeParser::parseCalc(WebCore::CSSParserTokenRange, WebCore::CSSValueID) 2 0x10aaf8212 WebCore::CSSCalcValue::create(WebCore::CSSValueID, WebCore::CSSParserTokenRange const&, WebCore::CalculationCategory, WebCore::ValueRange) 3 0x10abf88a4 WebCore::CSSPropertyParserHelpers::CalcParser::CalcParser(WebCore::CSSParserTokenRange&, WebCore::CalculationCategory, WebCore::ValueRange) 4 0x10abd33fe WebCore::CSSPropertyParserHelpers::consumeLengthOrPercent(WebCore::CSSParserTokenRange&, WebCore::CSSParserMode, WebCore::ValueRange, WebCore::CSSPropertyParserHelpers::UnitlessQuirk) 5 0x10abd3285 WebCore::consumeWidthOrHeight(WebCore::CSSParserTokenRange&, WebCore::CSSParserContext const&, WebCore::CSSPropertyParserHelpers::UnitlessQuirk) 6 0x10abc2dd6 WebCore::CSSPropertyParser::parseSingleValue(WebCore::CSSPropertyID, WebCore::CSSPropertyID) 7 0x10abc22ef WebCore::CSSPropertyParser::parseValueStart(WebCore::CSSPropertyID, bool) 8 0x10abc0923 WebCore::CSSPropertyParser::parseValue(WebCore::CSSPropertyID, bool, WebCore::CSSParserTokenRange const&, WebCore::CSSParserContext const&, WTF::Vector<WebCore::CSSProperty, 256ul, WTF::CrashOnOverflow, 16ul>&, WebCore::StyleRuleBase::Type) 1471652 1 352991 rbuis 2018-10-23 12:53:39 -0700 Created attachment 352991 Patch 1471663 2 352991 dbates 2018-10-23 14:06:21 -0700 Comment on attachment 352991 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352991&action=review > Source/WebCore/css/CSSCalculationValue.cpp:665 > + m_children.reserveInitialCapacity(2); > + m_children.uncheckedAppend(WTFMove(leftSide)); > + m_children.uncheckedAppend(WTFMove(rightSide)); Can we make m_children have inline capacity 2 and then just insert the left and right children using operator[]? 1471779 3 rbuis 2018-10-23 23:38:41 -0700 I think it is hard to do that since m_children is also being used by the other constructor as a variable sized Vector, and lots of existing methods rely on m_children (doubleValue, computeLengthPx etc.). Maybe it is possible with lots of refactoring but it may need polymorphism for instance. Probably not worth it IMHO. WDYT? 1475041 4 352991 fred.wang 2018-11-05 05:23:07 -0800 Comment on attachment 352991 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352991&action=review > Source/WebCore/ChangeLog:3 > + CSSCalcOperation ctor wastes 6KB of Vector capacity on cnn.com Can we please write "constructor" everywhere in this patch and for the bug title? > Source/WebCore/ChangeLog:8 > + The CSSCalcOperation ctor that takes a left and rightSide parameter leftSide and rightSide parameters 1475051 5 353854 rbuis 2018-11-05 06:07:37 -0800 Created attachment 353854 Patch 1477586 6 353854 commit-queue 2018-11-12 08:49:59 -0800 Comment on attachment 353854 Patch Clearing flags on attachment: 353854 Committed r238089: <https://trac.webkit.org/changeset/238089> 1477587 7 commit-queue 2018-11-12 08:50:00 -0800 All reviewed patches have been landed. Closing bug. 1477588 8 webkit-bug-importer 2018-11-12 08:50:26 -0800 <rdar://problem/45990829> 352991 2018-10-23 12:53:39 -0700 2018-11-05 06:07:34 -0800 Patch bug-190839-20181023215340.patch text/plain 1680 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjkxYWFhMGI4NjhhYTI1 OWM0NmZmNzEzMGY5ODdjNDFlOGYwMGY2Zi4uMTcyMzkxYzAxYjgyMmNmNDM4NTU3ZTBhNjlhM2Yx MTgwM2Y1Mzg0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTEwLTIzICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgQ1NTQ2FsY09wZXJhdGlvbiBjdG9y IHdhc3RlcyA2S0Igb2YgVmVjdG9yIGNhcGFjaXR5IG9uIGNubi5jb20KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDgzOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBDU1NDYWxjT3BlcmF0aW9uIGN0 b3IgdGhhdCB0YWtlcyBhIGxlZnQgYW5kIHJpZ2h0U2lkZSBwYXJhbWV0ZXIKKyAgICAgICAgd2Fz dGVzIG1lbW9yeSBzaW5jZSBpdCB3aWxsIGFsd2F5cyBoYXZlIHNpemUgMiBidXQgY2xhaW1zIHRo ZQorICAgICAgICBkZWZhdWx0IFZlY3RvciBzaXplLiBTbyBtYWtlIHN1cmUgdG8gcmVzZXJ2ZSBh biBpbml0aWFsIGNhcGFjaXR5IG9mIDIuCisKKyAgICAgICAgKiBjc3MvQ1NTQ2FsY3VsYXRpb25W YWx1ZS5jcHA6CisKIDIwMTgtMTAtMjMgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIzNzI4MC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlvblZhbHVlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlvblZhbHVlLmNwcAppbmRleCA5YTk0YTJmZWU1NzRjZTdi YjdmNzhhNDlhMTA5ZmMwM2M1NDY1ODg5Li4wNTg3MmUyYjIyNDM4YmUyMDNhNTM2ZjkwYmNiZmZl YjMwNGJjMDA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ2FsY3VsYXRpb25W YWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NhbGN1bGF0aW9uVmFsdWUuY3Bw CkBAIC02NjAsOCArNjYwLDkgQEAgcHJpdmF0ZToKICAgICAgICAgOiBDU1NDYWxjRXhwcmVzc2lv bk5vZGUoY2F0ZWdvcnksIGlzSW50ZWdlclJlc3VsdChvcCwgbGVmdFNpZGUuZ2V0KCksIHJpZ2h0 U2lkZS5nZXQoKSkpCiAgICAgICAgICwgbV9vcGVyYXRvcihvcCkKICAgICB7Ci0gICAgICAgIG1f Y2hpbGRyZW4uYXBwZW5kKFdURk1vdmUobGVmdFNpZGUpKTsKLSAgICAgICAgbV9jaGlsZHJlbi5h cHBlbmQoV1RGTW92ZShyaWdodFNpZGUpKTsKKyAgICAgICAgbV9jaGlsZHJlbi5yZXNlcnZlSW5p dGlhbENhcGFjaXR5KDIpOworICAgICAgICBtX2NoaWxkcmVuLnVuY2hlY2tlZEFwcGVuZChXVEZN b3ZlKGxlZnRTaWRlKSk7CisgICAgICAgIG1fY2hpbGRyZW4udW5jaGVja2VkQXBwZW5kKFdURk1v dmUocmlnaHRTaWRlKSk7CiAgICAgfQogCiAgICAgQ1NTQ2FsY09wZXJhdGlvbihDYWxjdWxhdGlv bkNhdGVnb3J5IGNhdGVnb3J5LCBDYWxjT3BlcmF0b3Igb3AsIFZlY3RvcjxSZWY8Q1NTQ2FsY0V4 cHJlc3Npb25Ob2RlPj4mJiBjaGlsZHJlbikK 353854 2018-11-05 06:07:37 -0800 2018-11-12 08:49:59 -0800 Patch bug-190839-20181105150737.patch text/plain 1721 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3Nzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzNlYTA4M2ZhZmU2MzU1 ODlmNzAwNzhhMWNlMzhkN2YzYmNjMDQ1Ny4uMTA4MzYyMWM5MDM0YjA1ZTJmNjQ1MDhjYmZjMzIw NjdkYzYyZDk2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTExLTA1ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgQ1NTQ2FsY09wZXJhdGlvbiBjb25z dHJ1Y3RvciB3YXN0ZXMgNktCIG9mIFZlY3RvciBjYXBhY2l0eSBvbiBjbm4uY29tCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA4MzkKKworICAgICAg ICBSZXZpZXdlZCBieSBGcsOpZMOpcmljIFdhbmcuCisKKyAgICAgICAgVGhlIENTU0NhbGNPcGVy YXRpb24gY3RvciB0aGF0IHRha2VzIGEgbGVmdFNpZGUgYW5kIHJpZ2h0U2lkZSBwYXJhbWV0ZXIK KyAgICAgICAgd2FzdGVzIG1lbW9yeSBzaW5jZSBpdCB3aWxsIGFsd2F5cyBoYXZlIHNpemUgMiBi dXQgY2xhaW1zIHRoZQorICAgICAgICBkZWZhdWx0IFZlY3RvciBzaXplLiBTbyBtYWtlIHN1cmUg dG8gcmVzZXJ2ZSBhbiBpbml0aWFsIGNhcGFjaXR5IG9mIDIuCisKKyAgICAgICAgKiBjc3MvQ1NT Q2FsY3VsYXRpb25WYWx1ZS5jcHA6CisKIDIwMTgtMTEtMDUgIFBoaWxpcHBlIE5vcm1hbmQgIDxw bm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIE1vdmUgZWxlbWVudHMg cmVnaXN0cmF0aW9uIHRvIEdTdHJlYW1lckNvbW1vbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU0NhbGN1bGF0aW9uVmFsdWUuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0Nh bGN1bGF0aW9uVmFsdWUuY3BwCmluZGV4IDlhOTRhMmZlZTU3NGNlN2JiN2Y3OGE0OWExMDlmYzAz YzU0NjU4ODkuLjA1ODcyZTJiMjI0MzhiZTIwM2E1MzZmOTBiY2JmZmViMzA0YmMwMDkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlvblZhbHVlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ2FsY3VsYXRpb25WYWx1ZS5jcHAKQEAgLTY2MCw4ICs2NjAs OSBAQCBwcml2YXRlOgogICAgICAgICA6IENTU0NhbGNFeHByZXNzaW9uTm9kZShjYXRlZ29yeSwg aXNJbnRlZ2VyUmVzdWx0KG9wLCBsZWZ0U2lkZS5nZXQoKSwgcmlnaHRTaWRlLmdldCgpKSkKICAg ICAgICAgLCBtX29wZXJhdG9yKG9wKQogICAgIHsKLSAgICAgICAgbV9jaGlsZHJlbi5hcHBlbmQo V1RGTW92ZShsZWZ0U2lkZSkpOwotICAgICAgICBtX2NoaWxkcmVuLmFwcGVuZChXVEZNb3ZlKHJp Z2h0U2lkZSkpOworICAgICAgICBtX2NoaWxkcmVuLnJlc2VydmVJbml0aWFsQ2FwYWNpdHkoMik7 CisgICAgICAgIG1fY2hpbGRyZW4udW5jaGVja2VkQXBwZW5kKFdURk1vdmUobGVmdFNpZGUpKTsK KyAgICAgICAgbV9jaGlsZHJlbi51bmNoZWNrZWRBcHBlbmQoV1RGTW92ZShyaWdodFNpZGUpKTsK ICAgICB9CiAKICAgICBDU1NDYWxjT3BlcmF0aW9uKENhbGN1bGF0aW9uQ2F0ZWdvcnkgY2F0ZWdv cnksIENhbGNPcGVyYXRvciBvcCwgVmVjdG9yPFJlZjxDU1NDYWxjRXhwcmVzc2lvbk5vZGU+PiYm IGNoaWxkcmVuKQo=