190801 2018-10-22 12:49:50 -0700 Don't waste time under -setupInteraction under -initWithFrame for unparented WKWebViews 2018-10-23 13:10:44 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton bdakin commit-queue megan_gardner ryanhaddad webkit-bug-importer wenson_hsieh oldest_to_newest 1471303 0 thorton 2018-10-22 12:49:50 -0700 Don't waste time under -setupInteraction under -initWithFrame for unparented WKWebViews 1471304 1 352902 thorton 2018-10-22 12:50:11 -0700 Created attachment 352902 Patch 1471305 2 thorton 2018-10-22 12:50:13 -0700 <rdar://problem/43674361> 1471306 3 352902 megan_gardner 2018-10-22 12:52:19 -0700 Comment on attachment 352902 Patch Assuming all bots pass 1471345 4 352902 commit-queue 2018-10-22 14:22:45 -0700 Comment on attachment 352902 Patch Clearing flags on attachment: 352902 Committed r237331: <https://trac.webkit.org/changeset/237331> 1471346 5 commit-queue 2018-10-22 14:22:46 -0700 All reviewed patches have been landed. Closing bug. 1471396 6 ryanhaddad 2018-10-22 15:59:24 -0700 (In reply to WebKit Commit Bot from comment #4) > Committed r237331: <https://trac.webkit.org/changeset/237331> This appears to have caused API test failures on iOS: Failed TestWebKitAPI.WebKit.InteractionDeadlockAfterCrash /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:70 Value of: highlightLongPressRecognizer Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:74 Value of: shouldBegin Actual: false Expected: true Timeout TestWebKitAPI.ActionSheetTests.DismissingActionSheetShouldNotDismissPresentingViewController https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/builds/491/steps/run-api-tests/logs/stdio 1471403 7 thorton 2018-10-22 16:34:32 -0700 Technically a good change. I’ll fix it (by parenting the view). 1471460 8 thorton 2018-10-22 18:52:26 -0700 (In reply to Tim Horton from comment #7) > Technically a good change. I’ll fix it (by parenting the view). Ryan, https://trac.webkit.org/changeset/237346/webkit should do the trick. 1471587 9 ryanhaddad 2018-10-23 08:54:43 -0700 (In reply to Tim Horton from comment #8) > (In reply to Tim Horton from comment #7) > > Technically a good change. I’ll fix it (by parenting the view). > > Ryan, https://trac.webkit.org/changeset/237346/webkit should do the trick. That did indeed! We are still seeing TestWebKitAPI.ActionSheetTests.DismissingActionSheetShouldNotDismissPresentingViewController time out, though. Sorry for not making it clear that both were caused by this change. 1471632 10 thorton 2018-10-23 11:52:58 -0700 (In reply to Ryan Haddad from comment #9) > (In reply to Tim Horton from comment #8) > > (In reply to Tim Horton from comment #7) > > > Technically a good change. I’ll fix it (by parenting the view). > > > > Ryan, https://trac.webkit.org/changeset/237346/webkit should do the trick. > That did indeed! We are still seeing > TestWebKitAPI.ActionSheetTests. > DismissingActionSheetShouldNotDismissPresentingViewController time out, > though. Sorry for not making it clear that both were caused by this change. Interesting! I'll take a peek. 1471658 11 thorton 2018-10-23 13:10:44 -0700 (In reply to Tim Horton from comment #10) > (In reply to Ryan Haddad from comment #9) > > (In reply to Tim Horton from comment #8) > > > (In reply to Tim Horton from comment #7) > > > > Technically a good change. I’ll fix it (by parenting the view). > > > > > > Ryan, https://trac.webkit.org/changeset/237346/webkit should do the trick. > > That did indeed! We are still seeing > > TestWebKitAPI.ActionSheetTests. > > DismissingActionSheetShouldNotDismissPresentingViewController time out, > > though. Sorry for not making it clear that both were caused by this change. > > Interesting! I'll take a peek. Very similar problem, the view isn't in-window. Not sure yet exactly why it's not, since from code inspection it looks like it should be, but it's possible we just have to wait for a transition. 352902 2018-10-22 12:50:11 -0700 2018-10-22 14:22:45 -0700 Patch bug-190801-20181022125010.patch text/plain 4232 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBjMmY2ZDg2NmNjYmFlNThk YWI0ZDUzNDg1YzMwNDEyNTBhZTczY2EuLmUxODlhM2Q4YmViZDc1MDExZGRlY2RjMDBmOGRhMmNm MmRiYzI2NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTgtMTAtMjIgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3Qgd2FzdGUgdGlt ZSB1bmRlciAtc2V0dXBJbnRlcmFjdGlvbiB1bmRlciAtaW5pdFdpdGhGcmFtZSBmb3IgdW5wYXJl bnRlZCBXS1dlYlZpZXdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTA4MDEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQzNjc0MzYxPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3Lm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9jb21tb25Jbml0 aWFsaXphdGlvbldpdGhQcm9jZXNzUG9vbDpjb25maWd1cmF0aW9uOl0pOgorICAgICAgICAoLVtX S0NvbnRlbnRWaWV3IGRpZE1vdmVUb1dpbmRvd10pOgorICAgICAgICBEZWZlciB0aGUgZmlyc3Qg Y2FsbCB0byBXS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ncyAtc2V0dXBJbnRlcmFjdGlvbgorICAg ICAgICB1bnRpbCB0aGUgdmlldyBpcyBwYXJlbnRlZC4gVGhpcyBhdm9pZHMgYSBmZXcgbWlsbGlz ZWNvbmRzIG9mIHVubmVjZXNzYXJ5CisgICAgICAgIHdvcmsgZm9yIHZpZXdzIHRoYXQgYXJlIG5l dmVyIHBhcmVudGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb24uaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBzZXR1cEludGVyYWN0aW9uXSk6Cisg ICAgICAgICgtW1dLQ29udGVudFZpZXcgY2xlYW51cEludGVyYWN0aW9uXSk6CisgICAgICAgIEtl ZXAgdHJhY2sgb2YgdGhlIGN1cnJlbnQgc3RhdGUgb2YgV0tDb250ZW50Vmlld0ludGVyYWN0aW9u J3MgZ2VzdHVyZXMuCisgICAgICAgIFVzZSB0aGlzIHRvIG1ha2UgaXQgT0sgdG8gY2FsbCAtc2V0 dXBJbnRlcmFjdGlvbiBtdWx0aXBsZSB0aW1lcy4KKwogMjAxOC0xMC0xOSAgQnJlbnQgRnVsZ2hh bSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBBbGxvdyBXZWJDb250ZW50IHByb2Nl c3MgdG8gY2hlY2sgc29tZSBmaWxlIHN5c3RlbSBmZWF0dXJlcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbQppbmRleCAyYWQ0ZGVjN2YwMzUyYjE4ODY1M2M3 YWE5MThjYTQ2Njc1MDlhMWYzLi5kNGRjZjdhYjBiYWY1ZmU3NDc1ZWQ2MmQ1ZmQ1Y2Y5NWNiYjE0 YTEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll dy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbQpA QCAtMjE4LDcgKzIxOCw2IEBAIC0gKGluc3RhbmNldHlwZSlfY29tbW9uSW5pdGlhbGl6YXRpb25X aXRoUHJvY2Vzc1Bvb2w6KFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2wmKXByCiAgICAgW3NlbGYgYWRk U3VidmlldzpfZml4ZWRDbGlwcGluZ1ZpZXcuZ2V0KCldOwogICAgIFtfZml4ZWRDbGlwcGluZ1Zp ZXcgYWRkU3Vidmlldzpfcm9vdENvbnRlbnRWaWV3LmdldCgpXTsKIAotICAgIFtzZWxmIHNldHVw SW50ZXJhY3Rpb25dOwogICAgIFtzZWxmIHNldFVzZXJJbnRlcmFjdGlvbkVuYWJsZWQ6WUVTXTsK IAogICAgIHNlbGYubGF5ZXIuaGl0VGVzdHNBc09wYXF1ZSA9IFlFUzsKQEAgLTI3Nyw2ICsyNzYs MTQgQEAgLSAodm9pZCl3aWxsTW92ZVRvV2luZG93OihVSVdpbmRvdyAqKW5ld1dpbmRvdwogICAg IH0KIH0KIAorLSAodm9pZClkaWRNb3ZlVG9XaW5kb3cKK3sKKyAgICBbc3VwZXIgZGlkTW92ZVRv V2luZG93XTsKKworICAgIGlmIChzZWxmLndpbmRvdykKKyAgICAgICAgW3NlbGYgc2V0dXBJbnRl cmFjdGlvbl07Cit9CisKIEFMTE9XX0RFUFJFQ0FURURfREVDTEFSQVRJT05TX0JFR0lOCiAtIChX S0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIgKilicm93c2luZ0NvbnRleHRDb250cm9sbGVyCiB7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLmgKaW5kZXggMDdhNGFkM2IxOGJhMWFjYWMxYjhkODlkMTUzMzlkNzQyZjk1NWVk Mi4uODk2NTE0YmVmYmQ2MTBlZmQwMWMyNTIzMWIzOTJiZmQ2OWY2NTNiMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u aApAQCAtMjc3LDYgKzI3Nyw4IEBAIHN0cnVjdCBXS0F1dG9Db3JyZWN0aW9uRGF0YSB7CiAKICAg ICBCT09MIF9mb2N1c1JlcXVpcmVzU3Ryb25nUGFzc3dvcmRBc3Npc3RhbmNlOwogCisgICAgQk9P TCBfaGFzU2V0VXBJbnRlcmFjdGlvbnM7CisKICNpZiBFTkFCTEUoREFUQV9JTlRFUkFDVElPTikK ICAgICBXZWJLaXQ6OkRyYWdEcm9wSW50ZXJhY3Rpb25TdGF0ZSBfZHJhZ0Ryb3BJbnRlcmFjdGlv blN0YXRlOwogICAgIFJldGFpblB0cjxVSURyYWdJbnRlcmFjdGlvbj4gX2RyYWdJbnRlcmFjdGlv bjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tCmluZGV4IDQ1NjUwNzM1MDRmZjI3OGZjZWU2MGMyNjdhZDIzMzY3M2Y3 ZjkzNjMuLjE2ZmRkYWJlYThiMGQ5ZjAzNWExYTZmODU3ZjcwODdiMjYyOWNkZjAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5tbQpAQCAtNjI1LDYgKzYyNSw5IEBAIC0gKHZvaWQpX2NyZWF0ZUFuZENvbmZpZ3VyZUxv bmdQcmVzc0dlc3R1cmVSZWNvZ25pemVyCiAKIC0gKHZvaWQpc2V0dXBJbnRlcmFjdGlvbgogewor ICAgIGlmIChfaGFzU2V0VXBJbnRlcmFjdGlvbnMpCisgICAgICAgIHJldHVybjsKKwogICAgIGlm ICghX2ludGVyYWN0aW9uVmlld3NDb250YWluZXJWaWV3KSB7CiAgICAgICAgIF9pbnRlcmFjdGlv blZpZXdzQ29udGFpbmVyVmlldyA9IGFkb3B0TlMoW1tVSVZpZXcgYWxsb2NdIGluaXRdKTsKICAg ICAgICAgW19pbnRlcmFjdGlvblZpZXdzQ29udGFpbmVyVmlldyBsYXllcl0ubmFtZSA9IEAiSW50 ZXJhY3Rpb25WaWV3c0NvbnRhaW5lciI7CkBAIC03MTMsMTAgKzcxNiwxNSBAQCAtICh2b2lkKXNl dHVwSW50ZXJhY3Rpb24KICAgICBfZGF0YUxpc3RUZXh0U3VnZ2VzdGlvbnNJbnB1dFZpZXcgPSBu aWw7CiAgICAgX2RhdGFMaXN0VGV4dFN1Z2dlc3Rpb25zID0gbmlsOwogI2VuZGlmCisKKyAgICBf aGFzU2V0VXBJbnRlcmFjdGlvbnMgPSBZRVM7CiB9CiAKIC0gKHZvaWQpY2xlYW51cEludGVyYWN0 aW9uCiB7CisgICAgaWYgKCFfaGFzU2V0VXBJbnRlcmFjdGlvbnMpCisgICAgICAgIHJldHVybjsK KwogICAgIF93ZWJTZWxlY3Rpb25Bc3Npc3RhbnQgPSBuaWw7CiAgICAgX3RleHRTZWxlY3Rpb25B c3Npc3RhbnQgPSBuaWw7CiAgICAgCkBAIC04MTMsNiArODIxLDggQEAgLSAodm9pZCljbGVhbnVw SW50ZXJhY3Rpb24KICAgICBfZGF0YUxpc3RUZXh0U3VnZ2VzdGlvbnNJbnB1dFZpZXcgPSBuaWw7 CiAgICAgX2RhdGFMaXN0VGV4dFN1Z2dlc3Rpb25zID0gbmlsOwogI2VuZGlmCisKKyAgICBfaGFz U2V0VXBJbnRlcmFjdGlvbnMgPSBOTzsKIH0KIAogLSAodm9pZClfcmVtb3ZlRGVmYXVsdEdlc3R1 cmVSZWNvZ25pemVycwo=