190796 2018-10-22 09:39:02 -0700 Deque's contains() and findIf() should be const 2018-10-22 14:06:33 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen aestes benjamin cmarcelo commit-queue dbates ews-watchlist ggaren koivisto rniwa webkit-bug-importer youennf oldest_to_newest 1471243 0 cdumez 2018-10-22 09:39:02 -0700 Deque's contains() and findIf() should be const as they do not modify the container. 1471252 1 352895 cdumez 2018-10-22 10:10:54 -0700 Created attachment 352895 Patch 1471267 2 352895 koivisto 2018-10-22 11:31:41 -0700 Comment on attachment 352895 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352895&action=review > Source/WTF/wtf/Deque.h:407 > + return std::find_if(begin(), end(), predicate); Considering how few clients this stuff has, maybe they could just do this themselves. 1471274 3 352895 cdumez 2018-10-22 11:40:03 -0700 Comment on attachment 352895 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352895&action=review >> Source/WTF/wtf/Deque.h:407 >> + return std::find_if(begin(), end(), predicate); > > Considering how few clients this stuff has, maybe they could just do this themselves. I considered that but I personally do not like the std::algorithm functions as they are too verbose. I like that our container types have their own less verbose convenience methods. 1471333 4 352895 commit-queue 2018-10-22 14:05:09 -0700 Comment on attachment 352895 Patch Clearing flags on attachment: 352895 Committed r237329: <https://trac.webkit.org/changeset/237329> 1471334 5 commit-queue 2018-10-22 14:05:11 -0700 All reviewed patches have been landed. Closing bug. 1471337 6 webkit-bug-importer 2018-10-22 14:06:33 -0700 <rdar://problem/45465502> 352895 2018-10-22 10:10:54 -0700 2018-10-22 14:05:09 -0700 Patch bug-190796-20181022101053.patch text/plain 5745 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3Mjc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGE1NjQ2MzNjNDBlNmEyMWYyZGYwZTll MDYwMjUwN2M2OWM4NDE3YWUuLjlmOWM3ODgxNDI2YWI0ZTU4OTFiZDY3NTUyYzRlYzc5ODFjYWM1 MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMTAtMjIgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBEZXF1ZSdzIGNvbnRhaW5zKCkgYW5kIGZpbmRJZigpIHNo b3VsZCBiZSBjb25zdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTkwNzk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRGVxdWUncyBjb250YWlucygpIGFuZCBmaW5kSWYoKSBzaG91bGQgYmUgY29uc3QgYXMg dGhleSBkbyBub3QgbW9kaWZ5IHRoZSBjb250YWluZXIuCisKKyAgICAgICAgKiB3dGYvRGVxdWUu aDoKKyAgICAgICAgKFdURjo6aW5saW5lQ2FwYWNpdHk+OjpmaW5kSWYpOgorICAgICAgICAoV1RG OjppbmxpbmVDYXBhY2l0eT46OmZpbmRJZiBjb25zdCk6CisgICAgICAgIChXVEY6OmlubGluZUNh cGFjaXR5Pjo6Y29udGFpbnMgY29uc3QpOgorICAgICAgICAoV1RGOjppbmxpbmVDYXBhY2l0eT46 OmNvbnRhaW5zKTogRGVsZXRlZC4KKwogMjAxOC0xMC0xOCAgQWxleGV5IFByb3NrdXJ5YWtvdiAg PGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBTd2l0Y2ggZnJvbSBQTEFURk9STShJT1MpIHRvIFBM QVRGT1JNKElPU19GQU1JTFkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFmYTAyNTE1NmE3Mzc0OGI5ODVhMDcyOTE1 NTZhN2Q2MzU4OTlmNjcuLjRmMzMyYTc5MWY1ODcxMzRhOThkNTdiMTEwZmU3YWVlMGRkODhhMGQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTAtMjIgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBEZXF1ZSdzIGNvbnRhaW5zKCkgYW5kIGZpbmRJZigp IHNob3VsZCBiZSBjb25zdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTkwNzk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTWFyayBtZXRob2QgYXMgY29uc3Qgbm93IHRoYXQgRGVxdWUncyBpbXBsZW1lbnRh dGlvbiBhbGxvd3MgaXQgdG8gYmUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Bv b2wuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6aGFzU3VzcGVuZGVkUGFn ZVByb3h5Rm9yIGNvbnN0KToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6Omhhc1N1 c3BlbmRlZFBhZ2VQcm94eUZvcik6IERlbGV0ZWQuCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBy b2Nlc3NQb29sLmg6CisKIDIwMTgtMTAtMTggIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5j b20+CiAKICAgICAgICAgRW5hYmxlIFdLUHJlZmVyZW5jZXMuX2xvd1Bvd2VyVmlkZW9BdWRpb0J1 ZmZlclNpemVFbmFibGVkIGJ5IGRlZmF1bHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Rl cXVlLmggYi9Tb3VyY2UvV1RGL3d0Zi9EZXF1ZS5oCmluZGV4IDg0NDAyNDA2NmZkOGU3MWY2Zjgx YTczY2UwMjJiZmU4NjZiOTY3YTIuLjJlMDBmZjUyZTZhMjA1ZThhYjMxYzgzZmYyZjdjZWRlMTJk M2Q3YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0RlcXVlLmgKKysrIGIvU291cmNlL1dU Ri93dGYvRGVxdWUuaApAQCAtMzIsNiArMzIsNyBAQAogLy8gRklYTUU6IENvdWxkIG1vdmUgd2hh dCBWZWN0b3IgYW5kIERlcXVlIHNoYXJlIGludG8gYSBzZXBhcmF0ZSBmaWxlLgogLy8gRGVxdWUg ZG9lc24ndCBhY3R1YWxseSB1c2UgVmVjdG9yLgogCisjaW5jbHVkZSA8YWxnb3JpdGhtPgogI2lu Y2x1ZGUgPGl0ZXJhdG9yPgogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KIApAQCAtNzUsNyArNzYs NyBAQCBwdWJsaWM6CiAgICAgY29uc3RfcmV2ZXJzZV9pdGVyYXRvciByYmVnaW4oKSBjb25zdCB7 IHJldHVybiBjb25zdF9yZXZlcnNlX2l0ZXJhdG9yKGVuZCgpKTsgfQogICAgIGNvbnN0X3JldmVy c2VfaXRlcmF0b3IgcmVuZCgpIGNvbnN0IHsgcmV0dXJuIGNvbnN0X3JldmVyc2VfaXRlcmF0b3Io YmVnaW4oKSk7IH0KICAgICAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiBib29sIGNvbnRhaW5z KGNvbnN0IFUmKTsKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiBib29sIGNvbnRhaW5zKGNvbnN0 IFUmKSBjb25zdDsKIAogICAgIFQmIGZpcnN0KCkgeyBBU1NFUlQobV9zdGFydCAhPSBtX2VuZCk7 IHJldHVybiBtX2J1ZmZlci5idWZmZXIoKVttX3N0YXJ0XTsgfQogICAgIGNvbnN0IFQmIGZpcnN0 KCkgY29uc3QgeyBBU1NFUlQobV9zdGFydCAhPSBtX2VuZCk7IHJldHVybiBtX2J1ZmZlci5idWZm ZXIoKVttX3N0YXJ0XTsgfQpAQCAtMTEzLDggKzExNCw4IEBAIHB1YmxpYzoKIAogICAgIHZvaWQg Y2xlYXIoKTsKIAotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFByZWRpY2F0ZT4KLSAgICBpdGVyYXRv ciBmaW5kSWYoUHJlZGljYXRlJiYpOworICAgIHRlbXBsYXRlPHR5cGVuYW1lIFByZWRpY2F0ZT4g aXRlcmF0b3IgZmluZElmKGNvbnN0IFByZWRpY2F0ZSYpOworICAgIHRlbXBsYXRlPHR5cGVuYW1l IFByZWRpY2F0ZT4gY29uc3RfaXRlcmF0b3IgZmluZElmKGNvbnN0IFByZWRpY2F0ZSYpIGNvbnN0 OwogCiBwcml2YXRlOgogICAgIGZyaWVuZCBjbGFzcyBEZXF1ZUl0ZXJhdG9yQmFzZTxULCBpbmxp bmVDYXBhY2l0eT47CkBAIC0zOTQsMTQgKzM5NSwxNiBAQCBpbmxpbmUgdm9pZCBEZXF1ZTxULCBp bmxpbmVDYXBhY2l0eT46OmNsZWFyKCkKIAogdGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlu bGluZUNhcGFjaXR5PgogdGVtcGxhdGU8dHlwZW5hbWUgUHJlZGljYXRlPgotaW5saW5lIGF1dG8g RGVxdWU8VCwgaW5saW5lQ2FwYWNpdHk+OjpmaW5kSWYoUHJlZGljYXRlJiYgcHJlZGljYXRlKSAt PiBpdGVyYXRvcgoraW5saW5lIGF1dG8gRGVxdWU8VCwgaW5saW5lQ2FwYWNpdHk+OjpmaW5kSWYo Y29uc3QgUHJlZGljYXRlJiBwcmVkaWNhdGUpIC0+IGl0ZXJhdG9yCiB7Ci0gICAgaXRlcmF0b3Ig ZW5kX2l0ZXJhdG9yID0gZW5kKCk7Ci0gICAgZm9yIChpdGVyYXRvciBpdCA9IGJlZ2luKCk7IGl0 ICE9IGVuZF9pdGVyYXRvcjsgKytpdCkgewotICAgICAgICBpZiAocHJlZGljYXRlKCppdCkpCi0g ICAgICAgICAgICByZXR1cm4gaXQ7Ci0gICAgfQotICAgIHJldHVybiBlbmRfaXRlcmF0b3I7Cisg ICAgcmV0dXJuIHN0ZDo6ZmluZF9pZihiZWdpbigpLCBlbmQoKSwgcHJlZGljYXRlKTsKK30KKwor dGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5PgordGVtcGxhdGU8dHlw ZW5hbWUgUHJlZGljYXRlPgoraW5saW5lIGF1dG8gRGVxdWU8VCwgaW5saW5lQ2FwYWNpdHk+Ojpm aW5kSWYoY29uc3QgUHJlZGljYXRlJiBwcmVkaWNhdGUpIGNvbnN0IC0+IGNvbnN0X2l0ZXJhdG9y Cit7CisgICAgcmV0dXJuIHN0ZDo6ZmluZF9pZihiZWdpbigpLCBlbmQoKSwgcHJlZGljYXRlKTsK IH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5PgpAQCAtNDQw LDEzICs0NDMsMTAgQEAgdm9pZCBEZXF1ZTxULCBpbmxpbmVDYXBhY2l0eT46OmV4cGFuZENhcGFj aXR5KCkKIAogdGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5PgogdGVt cGxhdGU8dHlwZW5hbWUgVT4KLWJvb2wgRGVxdWU8VCwgaW5saW5lQ2FwYWNpdHk+Ojpjb250YWlu cyhjb25zdCBVJiBzZWFyY2hWYWx1ZSkKK2Jvb2wgRGVxdWU8VCwgaW5saW5lQ2FwYWNpdHk+Ojpj b250YWlucyhjb25zdCBVJiBzZWFyY2hWYWx1ZSkgY29uc3QKIHsKLSAgICBmb3IgKGF1dG8mIHZh bHVlIDogKnRoaXMpIHsKLSAgICAgICAgaWYgKHZhbHVlID09IHNlYXJjaFZhbHVlKQotICAgICAg ICAgICAgcmV0dXJuIHRydWU7Ci0gICAgfQotICAgIHJldHVybiBmYWxzZTsKKyAgICBhdXRvIGVu ZEl0ZXJhdG9yID0gZW5kKCk7CisgICAgcmV0dXJuIHN0ZDo6ZmluZChiZWdpbigpLCBlbmRJdGVy YXRvciwgc2VhcmNoVmFsdWUpICE9IGVuZEl0ZXJhdG9yOwogfQogCiB0ZW1wbGF0ZTx0eXBlbmFt ZSBULCBzaXplX3QgaW5saW5lQ2FwYWNpdHk+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQ cm9jZXNzUG9vbC5jcHAKaW5kZXggNzMxZWY0YjM5MjVmNTVjZTAxNGY3ZDNhNzRiOTJhYTczNGM2 NjFkYi4uYTQyOGRhYzdhN2Q1MjAyNzUzYWQ0MDlkMTc0NjlmOGE3MzY4ODk5ZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcApAQCAtMjIyNiw3ICsyMjI2LDcg QEAgc3RkOjp1bmlxdWVfcHRyPFN1c3BlbmRlZFBhZ2VQcm94eT4gV2ViUHJvY2Vzc1Bvb2w6OnRh a2VTdXNwZW5kZWRQYWdlUHJveHkoU3VzcGUKICAgICB9KTsKIH0KIAotYm9vbCBXZWJQcm9jZXNz UG9vbDo6aGFzU3VzcGVuZGVkUGFnZVByb3h5Rm9yKFdlYlByb2Nlc3NQcm94eSYgcHJvY2VzcykK K2Jvb2wgV2ViUHJvY2Vzc1Bvb2w6Omhhc1N1c3BlbmRlZFBhZ2VQcm94eUZvcihXZWJQcm9jZXNz UHJveHkmIHByb2Nlc3MpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1fc3VzcGVuZGVkUGFnZXMuZmlu ZElmKFsmcHJvY2Vzc10oYXV0byYgc3VzcGVuZGVkUGFnZSkgewogICAgICAgICByZXR1cm4gJnN1 c3BlbmRlZFBhZ2UtPnByb2Nlc3MoKSA9PSAmcHJvY2VzczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9XZWJQcm9jZXNzUG9vbC5oCmluZGV4IDc4ODhjM2NiMTgwN2VkMTM0NThjOTg4Zjc3ZWFiNTU0 ODRiOTg4ZTkuLjlkMGY1ZDk1YmJiZTg2ZjYwOTQxMjRiNDRmNmVlNjNlMjVlNzE5ZGUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmgKKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuaApAQCAtNDQ2LDcgKzQ0Niw3IEBA IHB1YmxpYzoKICAgICB2b2lkIGFkZFN1c3BlbmRlZFBhZ2VQcm94eShzdGQ6OnVuaXF1ZV9wdHI8 U3VzcGVuZGVkUGFnZVByb3h5PiYmKTsKICAgICB2b2lkIHJlbW92ZUFsbFN1c3BlbmRlZFBhZ2VQ cm94aWVzRm9yUGFnZShXZWJQYWdlUHJveHkmKTsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8U3VzcGVu ZGVkUGFnZVByb3h5PiB0YWtlU3VzcGVuZGVkUGFnZVByb3h5KFN1c3BlbmRlZFBhZ2VQcm94eSYp OwotICAgIGJvb2wgaGFzU3VzcGVuZGVkUGFnZVByb3h5Rm9yKFdlYlByb2Nlc3NQcm94eSYpOwor ICAgIGJvb2wgaGFzU3VzcGVuZGVkUGFnZVByb3h5Rm9yKFdlYlByb2Nlc3NQcm94eSYpIGNvbnN0 OwogCiAgICAgdm9pZCBkaWRSZWFjaEdvb2RUaW1lVG9QcmV3YXJtKCk7CiAK