190791 2018-10-22 05:54:24 -0700 Some internal projects include wtf headers and build with C++11 2018-10-26 01:26:38 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller achristensen ap benjamin cdumez cmarcelo commit-queue dbates ews-watchlist webkit-bug-importer oldest_to_newest 1471199 0 keith_miller 2018-10-22 05:54:24 -0700 Some internal projects include wtf headers and build with C++11 1471200 1 352887 keith_miller 2018-10-22 05:56:25 -0700 Created attachment 352887 Patch 1471211 2 352887 achristensen 2018-10-22 07:34:21 -0700 Comment on attachment 352887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352887&action=review > Source/WTF/ChangeLog:3 > + Some internal projects include wtf headers and build with C++11 Those projects should probably update *and* stop including wtf headers. 1471308 3 352903 keith_miller 2018-10-22 13:06:06 -0700 Created attachment 352903 Patch 1471309 4 352887 keith_miller 2018-10-22 13:07:52 -0700 Comment on attachment 352887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352887&action=review >> Source/WTF/ChangeLog:3 >> + Some internal projects include wtf headers and build with C++11 > > Those projects should probably update *and* stop including wtf headers. Ugh, I agree... I'm working on it internally <rdar://problem/45395767> but for now we need to make sure B&I doesn't roll us back again. 1471360 5 352903 ap 2018-10-22 15:00:56 -0700 Comment on attachment 352903 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352903&action=review > Source/WTF/wtf/MathExtras.h:215 > template <typename T> constexpr unsigned getLSBSet(T value) Downstream projects don't need getLSBSet. Would this more straightforward fix work? // FIXME: Remove the #if check once downstream projects stop including WTF, and/or they upgrade to C++14 (rdar://........) #if WTF_CPP_STD_VER >= 14 template <typename T> constexpr unsigned getLSBSet(T value) { ... } #endif 1471372 6 352903 keith_miller 2018-10-22 15:06:38 -0700 Comment on attachment 352903 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352903&action=review >> Source/WTF/wtf/MathExtras.h:215 >> template <typename T> constexpr unsigned getLSBSet(T value) > > Downstream projects don't need getLSBSet. Would this more straightforward fix work? > > // FIXME: Remove the #if check once downstream projects stop including WTF, and/or they upgrade to C++14 (rdar://........) > #if WTF_CPP_STD_VER >= 14 > template <typename T> constexpr unsigned getLSBSet(T value) > { > ... > } > #endif In theory but there's always the risk that some other header in WebKit uses getLSBSet and you'd get an undefined identifier build error. 1471405 7 ap 2018-10-22 16:41:09 -0700 Sure, but in theory some other header in WebKit could be using it and expecting it to be constexpr. 1471492 8 keith_miller 2018-10-22 21:47:01 -0700 (In reply to Alexey Proskuryakov from comment #7) > Sure, but in theory some other header in WebKit could be using it and > expecting it to be constexpr. True, but then neither solution would work. This is mostly just a stopgap until projects including WTF headers either stop or switch to C++14. 1471794 9 353029 keith_miller 2018-10-24 02:10:04 -0700 Created attachment 353029 Patch 1471848 10 ap 2018-10-24 09:23:30 -0700 The latest patch breaks the build. Have you considered adding a canary file to WTF that builds these headers with C++11? That way we can catch build failures earlier. 1471954 11 353059 keith_miller 2018-10-24 15:30:48 -0700 Created attachment 353059 Patch 1472015 12 353078 keith_miller 2018-10-25 00:30:43 -0700 Created attachment 353078 Patch 1472357 13 353078 commit-queue 2018-10-26 01:25:51 -0700 Comment on attachment 353078 Patch Clearing flags on attachment: 353078 Committed r237448: <https://trac.webkit.org/changeset/237448> 1472358 14 commit-queue 2018-10-26 01:25:53 -0700 All reviewed patches have been landed. Closing bug. 1472359 15 webkit-bug-importer 2018-10-26 01:26:38 -0700 <rdar://problem/45581277> 352887 2018-10-22 05:56:25 -0700 2018-10-22 13:06:02 -0700 Patch bug-190791-20181022135621.patch text/plain 1654 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGU3ZDFkNDk1MmUxNmRlMTA3OTY5ZGEz ZWUwN2VlMzQxYmMzMDliYzUuLjc1MzE4NTJjYWRiZTI4OTU0MDgxZjA5NmNmYTc3MTc0MmExZTg3 NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTAtMjIgIEtlaXRoIE1pbGxlciAgPGtlaXRo X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgU29tZSBpbnRlcm5hbCBwcm9qZWN0cyBpbmNs dWRlIHd0ZiBoZWFkZXJzIGFuZCBidWlsZCB3aXRoIEMrKzExCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA3OTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDKysxMSBkb2Vzbid0IHN1cHBvcnQgY29uc3Rl eHByIGZ1bmN0aW9ucyB0aGF0IGNvbnRhaW4KKyAgICAgICAgc3RhdGVtZW50cy4gU28gd2Ugc2hv dWxkIG9ubHkgbWFyayBmdW5jdGlvbnMgd2l0aCBzdGF0ZW1lbnRzIGFzCisgICAgICAgIGNvbnN0 ZXhwciBpZiB3ZSBhcmUgYnVpbGRpbmcgd2l0aCBDKysxNCBvciBsYXRlci4KKworICAgICAgICAq IHd0Zi9NYXRoRXh0cmFzLmg6CisgICAgICAgIChnZXRMU0JTZXQpOgorCiAyMDE4LTEwLTE3ICBD b21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMjM3MjA4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTWF0 aEV4dHJhcy5oIGIvU291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oCmluZGV4IDFiNjk3OGQ0OTFj NzRlMTZhM2QxMjRjMWRlZmY4OGUzN2U5ZjhjOTYuLjRkNmZlOTczNGU2ODkyZmYzMjVkMjY2MmRm NGNkN2UwN2M1NmMxNjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaAor KysgYi9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmgKQEAgLTIwNiw3ICsyMDYsMTQgQEAgdGVt cGxhdGU8dHlwZW5hbWUgVD4gY29uc3RleHByIGJvb2wgaGFzVHdvT3JNb3JlQml0c1NldChUIHZh bHVlKQogICAgIHJldHVybiAhaGFzWmVyb09yT25lQml0c1NldCh2YWx1ZSk7CiB9CiAKKyNpZiBQ TEFURk9STShEQVJXSU4pICYmIFdURl9DUFBfU1REX1ZFUiA8PSAxMQorLy8gRklYTUU6IFNvbWUg RGFyd2luIHByb2plY3RzIHNoYW1lbGVzc2x5IGluY2x1ZGUgV1RGIGhlYWRlcnMgYW5kIGRvbid0 IGJ1aWxkIHdpdGggQysrMTQuLi4KKy8vIFNpbmNlIEMrKzExIGFuZCBiZWZvcmUgZG9uJ3Qgc3Vw cG9ydCBjb25zdGV4cHIgc3RhdGVtZW50cyB3ZSBjYW4ndCBtYXJrIHRoaXMgZnVuY3Rpb24KKy8v IGNvbnN0ZXhwci4KIHRlbXBsYXRlIDx0eXBlbmFtZSBUPiBjb25zdGV4cHIgdW5zaWduZWQgZ2V0 TFNCU2V0KFQgdmFsdWUpCisjZWxzZQordGVtcGxhdGUgPHR5cGVuYW1lIFQ+IHVuc2lnbmVkIGdl dExTQlNldChUIHZhbHVlKQorI2VuZGlmCiB7CiAgICAgdHlwZWRlZiB0eXBlbmFtZSBzdGQ6Om1h a2VfdW5zaWduZWQ8VD46OnR5cGUgVW5zaWduZWRUOwogICAgIHVuc2lnbmVkIHJlc3VsdCA9IDA7 Cg== 352903 2018-10-22 13:06:06 -0700 2018-10-24 02:10:00 -0700 Patch bug-190791-20181022220605.patch text/plain 1654 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGU3ZDFkNDk1MmUxNmRlMTA3OTY5ZGEz ZWUwN2VlMzQxYmMzMDliYzUuLjc1MzE4NTJjYWRiZTI4OTU0MDgxZjA5NmNmYTc3MTc0MmExZTg3 NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTAtMjIgIEtlaXRoIE1pbGxlciAgPGtlaXRo X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgU29tZSBpbnRlcm5hbCBwcm9qZWN0cyBpbmNs dWRlIHd0ZiBoZWFkZXJzIGFuZCBidWlsZCB3aXRoIEMrKzExCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA3OTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDKysxMSBkb2Vzbid0IHN1cHBvcnQgY29uc3Rl eHByIGZ1bmN0aW9ucyB0aGF0IGNvbnRhaW4KKyAgICAgICAgc3RhdGVtZW50cy4gU28gd2Ugc2hv dWxkIG9ubHkgbWFyayBmdW5jdGlvbnMgd2l0aCBzdGF0ZW1lbnRzIGFzCisgICAgICAgIGNvbnN0 ZXhwciBpZiB3ZSBhcmUgYnVpbGRpbmcgd2l0aCBDKysxNCBvciBsYXRlci4KKworICAgICAgICAq IHd0Zi9NYXRoRXh0cmFzLmg6CisgICAgICAgIChnZXRMU0JTZXQpOgorCiAyMDE4LTEwLTE3ICBD b21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMjM3MjA4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTWF0 aEV4dHJhcy5oIGIvU291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oCmluZGV4IDFiNjk3OGQ0OTFj NzRlMTZhM2QxMjRjMWRlZmY4OGUzN2U5ZjhjOTYuLjkwNDRiZDMwODU5Y2QwMGFlN2QxNzgzNTQ2 ZDJkNzc5NWVkYzA3NzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaAor KysgYi9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmgKQEAgLTIwNiw3ICsyMDYsMTQgQEAgdGVt cGxhdGU8dHlwZW5hbWUgVD4gY29uc3RleHByIGJvb2wgaGFzVHdvT3JNb3JlQml0c1NldChUIHZh bHVlKQogICAgIHJldHVybiAhaGFzWmVyb09yT25lQml0c1NldCh2YWx1ZSk7CiB9CiAKKyNpZiBQ TEFURk9STShEQVJXSU4pICYmIFdURl9DUFBfU1REX1ZFUiA8PSAxMQorLy8gRklYTUU6IFNvbWUg RGFyd2luIHByb2plY3RzIHNoYW1lbGVzc2x5IGluY2x1ZGUgV1RGIGhlYWRlcnMgYW5kIGRvbid0 IGJ1aWxkIHdpdGggQysrMTQuLi4KKy8vIFNpbmNlIEMrKzExIGFuZCBiZWZvcmUgZG9uJ3Qgc3Vw cG9ydCBjb25zdGV4cHIgc3RhdGVtZW50cyB3ZSBjYW4ndCBtYXJrIHRoaXMgZnVuY3Rpb24KKy8v IGNvbnN0ZXhwci4KK3RlbXBsYXRlIDx0eXBlbmFtZSBUPiB1bnNpZ25lZCBnZXRMU0JTZXQoVCB2 YWx1ZSkKKyNlbHNlCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gY29uc3RleHByIHVuc2lnbmVkIGdl dExTQlNldChUIHZhbHVlKQorI2VuZGlmCiB7CiAgICAgdHlwZWRlZiB0eXBlbmFtZSBzdGQ6Om1h a2VfdW5zaWduZWQ8VD46OnR5cGUgVW5zaWduZWRUOwogICAgIHVuc2lnbmVkIHJlc3VsdCA9IDA7 Cg== 353029 2018-10-24 02:10:04 -0700 2018-10-24 15:30:37 -0700 Patch bug-190791-20181024111003.patch text/plain 1740 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGU3ZDFkNDk1MmUxNmRlMTA3OTY5ZGEz ZWUwN2VlMzQxYmMzMDliYzUuLjA0ZTliODI1YjZkMmRkOWYzYjQxMjQzYmI1OGJhOTlkNDZjM2Jh N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTAtMjIgIEtlaXRoIE1pbGxlciAgPGtlaXRo X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgU29tZSBpbnRlcm5hbCBwcm9qZWN0cyBpbmNs dWRlIHd0ZiBoZWFkZXJzIGFuZCBidWlsZCB3aXRoIEMrKzExCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA3OTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDKysxMSBkb2Vzbid0IHN1cHBvcnQgY29uc3Rl eHByIGZ1bmN0aW9ucyB0aGF0IGNvbnRhaW4KKyAgICAgICAgc3RhdGVtZW50cy4gVGhpcyBwYXRj aCByZW1vdmVzIGdldExTQlNldCBzZXQgZnJvbSBidWlsZHMgYmVmb3JlCisgICAgICAgIEMrKzE0 IHRvIGF2b2lkIHRoaXMgZm9yIG5vdy4KKworICAgICAgICAqIHd0Zi9NYXRoRXh0cmFzLmg6Cisg ICAgICAgIChnZXRMU0JTZXQpOgorCiAyMDE4LTEwLTE3ICBDb21taXQgUXVldWUgIDxjb21taXQt cXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjM3 MjA4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oIGIvU291cmNlL1dU Ri93dGYvTWF0aEV4dHJhcy5oCmluZGV4IDFiNjk3OGQ0OTFjNzRlMTZhM2QxMjRjMWRlZmY4OGUz N2U5ZjhjOTYuLmNjZThlMDg0OGU4Y2FiZjJlYjE0MDIxZmI4ZTg2NDFjZjc0Y2M2MmYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9N YXRoRXh0cmFzLmgKQEAgLTIwNiw2ICsyMDYsOSBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBjb25z dGV4cHIgYm9vbCBoYXNUd29Pck1vcmVCaXRzU2V0KFQgdmFsdWUpCiAgICAgcmV0dXJuICFoYXNa ZXJvT3JPbmVCaXRzU2V0KHZhbHVlKTsKIH0KIAorLy8gRklYTUU6IFNvbWUgRGFyd2luIHByb2pl Y3RzIHNoYW1lbGVzc2x5IGluY2x1ZGUgV1RGIGhlYWRlcnMgYW5kIGRvbid0IGJ1aWxkIHdpdGgg QysrMTQuLi4gU2VlOiByZGFyOi8vcHJvYmxlbS80NTM5NTc2NworLy8gU2luY2UgQysrMTEgYW5k IGJlZm9yZSBkb24ndCBzdXBwb3J0IGNvbnN0ZXhwciBzdGF0ZW1lbnRzIHdlIGNhbid0IG1hcmsg dGhpcyBmdW5jdGlvbiBjb25zdGV4cHIuCisjaWYgUExBVEZPUk0oREFSV0lOKSAmJiBXVEZfQ1BQ X1NURF9WRVIgPj0gMTQKIHRlbXBsYXRlIDx0eXBlbmFtZSBUPiBjb25zdGV4cHIgdW5zaWduZWQg Z2V0TFNCU2V0KFQgdmFsdWUpCiB7CiAgICAgdHlwZWRlZiB0eXBlbmFtZSBzdGQ6Om1ha2VfdW5z aWduZWQ8VD46OnR5cGUgVW5zaWduZWRUOwpAQCAtMjE3LDYgKzIyMCw3IEBAIHRlbXBsYXRlIDx0 eXBlbmFtZSBUPiBjb25zdGV4cHIgdW5zaWduZWQgZ2V0TFNCU2V0KFQgdmFsdWUpCiAKICAgICBy ZXR1cm4gcmVzdWx0OwogfQorI2VuZGlmCiAKIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSBU IGRpdmlkZVJvdW5kZWRVcChUIGEsIFQgYikKIHsK 353059 2018-10-24 15:30:48 -0700 2018-10-25 00:30:40 -0700 Patch bug-190791-20181025003045.patch text/plain 1720 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGU3ZDFkNDk1MmUxNmRlMTA3OTY5ZGEz ZWUwN2VlMzQxYmMzMDliYzUuLjA0ZTliODI1YjZkMmRkOWYzYjQxMjQzYmI1OGJhOTlkNDZjM2Jh N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTAtMjIgIEtlaXRoIE1pbGxlciAgPGtlaXRo X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgU29tZSBpbnRlcm5hbCBwcm9qZWN0cyBpbmNs dWRlIHd0ZiBoZWFkZXJzIGFuZCBidWlsZCB3aXRoIEMrKzExCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA3OTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDKysxMSBkb2Vzbid0IHN1cHBvcnQgY29uc3Rl eHByIGZ1bmN0aW9ucyB0aGF0IGNvbnRhaW4KKyAgICAgICAgc3RhdGVtZW50cy4gVGhpcyBwYXRj aCByZW1vdmVzIGdldExTQlNldCBzZXQgZnJvbSBidWlsZHMgYmVmb3JlCisgICAgICAgIEMrKzE0 IHRvIGF2b2lkIHRoaXMgZm9yIG5vdy4KKworICAgICAgICAqIHd0Zi9NYXRoRXh0cmFzLmg6Cisg ICAgICAgIChnZXRMU0JTZXQpOgorCiAyMDE4LTEwLTE3ICBDb21taXQgUXVldWUgIDxjb21taXQt cXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjM3 MjA4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oIGIvU291cmNlL1dU Ri93dGYvTWF0aEV4dHJhcy5oCmluZGV4IDFiNjk3OGQ0OTFjNzRlMTZhM2QxMjRjMWRlZmY4OGUz N2U5ZjhjOTYuLjAzNDg0MjM2ZWQ5MmQ1ZWRmYjg5YjBhNTg1NDVlNjlmMTk1OWRiZWEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9N YXRoRXh0cmFzLmgKQEAgLTIwNiw2ICsyMDYsOSBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBjb25z dGV4cHIgYm9vbCBoYXNUd29Pck1vcmVCaXRzU2V0KFQgdmFsdWUpCiAgICAgcmV0dXJuICFoYXNa ZXJvT3JPbmVCaXRzU2V0KHZhbHVlKTsKIH0KIAorLy8gRklYTUU6IFNvbWUgRGFyd2luIHByb2pl Y3RzIHNoYW1lbGVzc2x5IGluY2x1ZGUgV1RGIGhlYWRlcnMgYW5kIGRvbid0IGJ1aWxkIHdpdGgg QysrMTQuLi4gU2VlOiByZGFyOi8vcHJvYmxlbS80NTM5NTc2NworLy8gU2luY2UgQysrMTEgYW5k IGJlZm9yZSBkb24ndCBzdXBwb3J0IGNvbnN0ZXhwciBzdGF0ZW1lbnRzIHdlIGNhbid0IG1hcmsg dGhpcyBmdW5jdGlvbiBjb25zdGV4cHIuCisjaWYgV1RGX0NQUF9TVERfVkVSID49IDE0CiB0ZW1w bGF0ZSA8dHlwZW5hbWUgVD4gY29uc3RleHByIHVuc2lnbmVkIGdldExTQlNldChUIHZhbHVlKQog ewogICAgIHR5cGVkZWYgdHlwZW5hbWUgc3RkOjptYWtlX3Vuc2lnbmVkPFQ+Ojp0eXBlIFVuc2ln bmVkVDsKQEAgLTIxNyw2ICsyMjAsNyBAQCB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gY29uc3RleHBy IHVuc2lnbmVkIGdldExTQlNldChUIHZhbHVlKQogCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KKyNl bmRpZgogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgVCBkaXZpZGVSb3VuZGVkVXAoVCBh LCBUIGIpCiB7Cg== 353078 2018-10-25 00:30:43 -0700 2018-10-26 01:25:51 -0700 Patch bug-190791-20181025093042.patch text/plain 1749 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGU3ZDFkNDk1MmUxNmRlMTA3OTY5ZGEz ZWUwN2VlMzQxYmMzMDliYzUuLjA0ZTliODI1YjZkMmRkOWYzYjQxMjQzYmI1OGJhOTlkNDZjM2Jh N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTAtMjIgIEtlaXRoIE1pbGxlciAgPGtlaXRo X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgU29tZSBpbnRlcm5hbCBwcm9qZWN0cyBpbmNs dWRlIHd0ZiBoZWFkZXJzIGFuZCBidWlsZCB3aXRoIEMrKzExCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA3OTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDKysxMSBkb2Vzbid0IHN1cHBvcnQgY29uc3Rl eHByIGZ1bmN0aW9ucyB0aGF0IGNvbnRhaW4KKyAgICAgICAgc3RhdGVtZW50cy4gVGhpcyBwYXRj aCByZW1vdmVzIGdldExTQlNldCBzZXQgZnJvbSBidWlsZHMgYmVmb3JlCisgICAgICAgIEMrKzE0 IHRvIGF2b2lkIHRoaXMgZm9yIG5vdy4KKworICAgICAgICAqIHd0Zi9NYXRoRXh0cmFzLmg6Cisg ICAgICAgIChnZXRMU0JTZXQpOgorCiAyMDE4LTEwLTE3ICBDb21taXQgUXVldWUgIDxjb21taXQt cXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjM3 MjA4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oIGIvU291cmNlL1dU Ri93dGYvTWF0aEV4dHJhcy5oCmluZGV4IDFiNjk3OGQ0OTFjNzRlMTZhM2QxMjRjMWRlZmY4OGUz N2U5ZjhjOTYuLmQxNmY2NTljNjgxZmFjMGU2N2VmOWQ2ZmIwMjZkMzlkNTQ3ZTY0NjkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9N YXRoRXh0cmFzLmgKQEAgLTIwNiw2ICsyMDYsOSBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBjb25z dGV4cHIgYm9vbCBoYXNUd29Pck1vcmVCaXRzU2V0KFQgdmFsdWUpCiAgICAgcmV0dXJuICFoYXNa ZXJvT3JPbmVCaXRzU2V0KHZhbHVlKTsKIH0KIAorLy8gRklYTUU6IFNvbWUgRGFyd2luIHByb2pl Y3RzIHNoYW1lbGVzc2x5IGluY2x1ZGUgV1RGIGhlYWRlcnMgYW5kIGRvbid0IGJ1aWxkIHdpdGgg QysrMTQuLi4gU2VlOiByZGFyOi8vcHJvYmxlbS80NTM5NTc2NworLy8gU2luY2UgQysrMTEgYW5k IGJlZm9yZSBkb24ndCBzdXBwb3J0IGNvbnN0ZXhwciBzdGF0ZW1lbnRzIHdlIGNhbid0IG1hcmsg dGhpcyBmdW5jdGlvbiBjb25zdGV4cHIuCisjaWYgIWRlZmluZWQoV1RGX0NQUF9TVERfVkVSKSB8 fCBXVEZfQ1BQX1NURF9WRVIgPj0gMTQKIHRlbXBsYXRlIDx0eXBlbmFtZSBUPiBjb25zdGV4cHIg dW5zaWduZWQgZ2V0TFNCU2V0KFQgdmFsdWUpCiB7CiAgICAgdHlwZWRlZiB0eXBlbmFtZSBzdGQ6 Om1ha2VfdW5zaWduZWQ8VD46OnR5cGUgVW5zaWduZWRUOwpAQCAtMjE3LDYgKzIyMCw3IEBAIHRl bXBsYXRlIDx0eXBlbmFtZSBUPiBjb25zdGV4cHIgdW5zaWduZWQgZ2V0TFNCU2V0KFQgdmFsdWUp CiAKICAgICByZXR1cm4gcmVzdWx0OwogfQorI2VuZGlmCiAKIHRlbXBsYXRlPHR5cGVuYW1lIFQ+ IGlubGluZSBUIGRpdmlkZVJvdW5kZWRVcChUIGEsIFQgYikKIHsK