19077 2008-05-15 07:01:12 -0700 [Qt] Clicking on a link with target=_blank doesn't do anything 2009-11-30 10:00:30 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED Qt P2 Normal --- 1 marco.barisione marco.barisione hausmann jedrzej.nowacki oldest_to_newest 80498 0 marco.barisione 2008-05-15 07:01:12 -0700 window.open() from js opens a new window but clicking on <a target="_blank" href="#">..</a> doesn't do anything. I will attach a patch ASAP. 80501 1 21163 marco.barisione 2008-05-15 07:48:35 -0700 Created attachment 21163 Show the window containing the newly created QWebPage Can newPage->view() be null in this case? 80895 2 21163 hausmann 2008-05-19 07:14:10 -0700 Comment on attachment 21163 Show the window containing the newly created QWebPage I don't think this is the right place to call show(). dispatchCreatePage() is called from FrameLoader::continueAfterNewWindowPolicy, which shortly afterwards calls FrameLoaderClient::dispatchShow(). That function is currently not implemented and I believe that's where a show() call should go. 80965 3 marco.barisione 2008-05-20 02:58:54 -0700 Oh, right. I didn't know of dispatchShow. I will update the patch as soon as possible. 81183 4 marco.barisione 2008-05-22 03:57:04 -0700 If the browser wants to open the new page in a tab instead of using a separate window then showing the toplevel windows is not the best idea. How about adding a virtual method QWebPage::showWindow() with a default implentation that shows the toplevel window? I proposed something similar also for the GTK port, see bug #19143. 81275 5 hausmann 2008-05-23 01:27:58 -0700 I agree about not calling show() on the QWidget directly. Unfortunately we cannot add virtual functions to QWebPage as it breaks binary compatibility. Fortunately a more consistent API would be to add a signal, similar to menuBarVisibilityChangeRequested or statusBarVisibilityChangeRequested. By default QWebView could connect the signal to its own private slot to call QWidget::show()/hide() accordingly. This way the implementation of ChromeClientQt::show() and FrameLoaderClientQt::dispatchShow() can both be changed to emit the new signal. (In the windows port they also both map to the same call) 167286 6 jedrzej.nowacki 2009-11-30 10:00:30 -0800 Hi, I tried the issue with this test case on the trunk: <html> <body> <a target="_blank" href="#">blank</a> <a onClick="window.open()">blankJS</a> </body> </html> in both cases a new window was created. It seems that the problem is resolved. I'm not assigned to the bug, so if I missed something feel free to reopen it. 21163 2008-05-15 07:48:35 -0700 2008-05-19 07:14:10 -0700 Show the window containing the newly created QWebPage qt-show-page.patch text/plain 1603 marco.barisione SW5kZXg6IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRR dC5jcHAJKHJldmlzaW9uZSAzMzQ4NCkKKysrIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFt ZUxvYWRlckNsaWVudFF0LmNwcAkoY29waWEgbG9jYWxlKQpAQCAtODU4LDYgKzg1OCwxMyBAQAog ICAgIFFXZWJQYWdlICpuZXdQYWdlID0gbV93ZWJGcmFtZS0+cGFnZSgpLT5jcmVhdGVXaW5kb3co UVdlYlBhZ2U6OldlYkJyb3dzZXJXaW5kb3cpOwogICAgIGlmICghbmV3UGFnZSkKICAgICAgICAg cmV0dXJuIDA7CisgICAgUVdpZGdldCogdmlldyA9IG5ld1BhZ2UtPnZpZXcoKTsKKyAgICBpZiAo IXZpZXcpIHsKKyAgICAgICAgLy8gRklYTUU6IENhbiB0aGlzIGhhcHBlbj8KKyAgICAgICAgZGVs ZXRlIG5ld1BhZ2U7CisgICAgICAgIHJldHVybiAwOworICAgIH0KKyAgICB2aWV3LT50b3BMZXZl bFdpZGdldCgpLT5zaG93KCk7CiAgICAgcmV0dXJuIG5ld1BhZ2UtPm1haW5GcmFtZSgpLT5kLT5m cmFtZTsKIH0KIApJbmRleDogV2ViS2l0L3F0L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbmUgMzM0ODYpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9n CShjb3BpYSBsb2NhbGUpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDgtMDUtMTUgIE1hcmNvIEJhcmlz aW9uZSAgPG1hcmNvQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTkwNzcKKyAgICAgICAgW1F0XSBDbGlja2luZyBvbiBhIGxpbmsgd2l0aCB0YXJnZXQ9 X2JsYW5rIGRvZXNuJ3QgZG8gYW55dGhpbmcKKworICAgICAgICBUaGUgbmV3IHdpbmRvdyBpcyBj cmVhdGVkIGlmIHRoZSBwcm9ncmFtIHVzaW5nIFdlYktpdCBvdmVycmlkZXMKKyAgICAgICAgUVdl YlBhZ2U6OmNyZWF0ZVdpbmRvdygpIGJ1dCBpdCdzIG5vdCBzaG93bi4KKyAgICAgICAgVGhlIGJl aGF2aW9yIG9mIFFXZWJQYWdlOjpjcmVhdGVXaW5kb3coKSBpcyByaWdodCBiZWNhdXNlIHdpbmRv d3MKKyAgICAgICAgb3BlbmVkIHZpYSBKYXZhU2NyaXB0IHdpdGggd2luZG93Lm9wZW4oKSBtdXN0 IGJlIHNob3duIG9ubHkgd2hlbgorICAgICAgICBDaHJvbWVDbGllbnQ6OnNob3coKSBpcyBjYWxs ZWQuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50UXQ6OmRpc3BhdGNoQ3JlYXRlUGFn ZSk6IFNob3cgdGhlIG5ld2x5CisgICAgICAgIGNyZWF0ZWQgd2luZG93LgorCiAyMDA4LTA1LTEz ICBBbmR5IFNoYXcgIDxhbmR5QHRyb2xsdGVjaC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg U2ltb24uCg==