190748 2018-10-19 01:04:19 -0700 [Win] Assertion fails while destructing local static AtomicString of FontCache::lastResortFallbackFont 2018-10-23 22:00:49 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham don.olmstead ews-watchlist mmaxfield pvollan rniwa webkit-bug-importer oldest_to_newest 1470824 0 fujii 2018-10-19 01:04:19 -0700 [WinCairo] Assertion failure "The string being removed is atomic in the string table of an other thread!" WinCairo, WK1, Debug build, trunk@237282 1. Start MiniBrowser 2. Go to https://webkit.org/ 3. Close Window 4. Assertion fails Callstack: > WTF.dll!WTFCrash() Line 255 C++ > WTF.dll!WTF::AtomicStringImpl::remove(WTF::AtomicStringImpl * string) Line 489 C++ > WTF.dll!WTF::StringImpl::~StringImpl() Line 119 C++ > [External Code] > WTF.dll!WTF::StringImpl::destroy(WTF::StringImpl * stringImpl) Line 151 C++ > WebKit2.dll!WTF::StringImpl::deref() Line 1058 C++ > WebKit2.dll!WTF::derefIfNotNull<WTF::StringImpl>(WTF::StringImpl * ptr) Line 45 C++ > WebKit2.dll!WTF::RefPtr<WTF::StringImpl,WTF::DumbPtrTraits<WTF::StringImpl> >::~RefPtr<WTF::StringImpl,WTF::DumbPtrTraits<WTF::StringImpl> >() Line 69 C++ > WebKit2.dll!WTF::String::~String() Line 377 C++ > [External Code] > WebKit2.dll!WebKit::callExit(IPC::Connection * __formal) Line 163 C++ > WebKit2.dll!IPC::Connection::connectionDidClose() Line 824 C++ > WebKit2.dll!IPC::Connection::readEventHandler() Line 159 C++ > WebKit2.dll!IPC::Connection::invokeReadEventHandler::__l2::<lambda>() Line 238 C++ > WebKit2.dll!WTF::Function<void __cdecl(void)>::CallableWrapper<void <lambda>(void) >::call() Line 101 C++ > WTF.dll!WTF::Function<void __cdecl(void)>::operator()() Line 57 C++ > WTF.dll!WTF::WorkQueue::performWorkOnRegisteredWorkThread() Line 62 C++ > WTF.dll!WTF::WorkQueue::workThreadCallback(void * context) Line 44 C++ > [External Code] The following assertion failed. > ASSERT_WITH_MESSAGE(iterator != atomicStringTable.end(), "The string being removed is atomic in the string table of an other thread!"); But, atomicStringTable was null. I guess the real problem is String's dtor was called in _exit. 1470826 1 fujii 2018-10-19 02:14:39 -0700 (In reply to Fujii Hironori from comment #0) > WinCairo, WK1, Debug build, trunk@237282 Oops. I tested with WK2. 1470827 2 fujii 2018-10-19 02:16:20 -0700 The string was "Lucida Sans Unicode". It is https://github.com/WebKit/webkit/blob/53d0b766f0692da943a7b01af78940a41581b702/Source/WebCore/platform/graphics/win/FontCacheWin.cpp#L358 1470828 3 352775 fujii 2018-10-19 02:20:22 -0700 Created attachment 352775 WIP patch 1470836 4 352780 fujii 2018-10-19 04:10:55 -0700 Created attachment 352780 Patch 1471321 5 352780 don.olmstead 2018-10-22 13:22:09 -0700 Comment on attachment 352780 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352780&action=review > Source/WebCore/platform/graphics/win/FontCacheWin.cpp:354 > - static AtomicString fallbackFonts[] = { > - AtomicString("Times New Roman", AtomicString::ConstructFromLiteral), > - AtomicString("Microsoft Sans Serif", AtomicString::ConstructFromLiteral), > - AtomicString("Tahoma", AtomicString::ConstructFromLiteral), > - AtomicString("Lucida Sans Unicode", AtomicString::ConstructFromLiteral), > - AtomicString("Arial", AtomicString::ConstructFromLiteral) > + const auto fallbackFontNames = { Does NeverDestroyed not work in this context? 1471450 6 352780 fujii 2018-10-22 17:59:20 -0700 Comment on attachment 352780 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352780&action=review Thank you very much for reviewing my patch. >> Source/WebCore/platform/graphics/win/FontCacheWin.cpp:354 >> + const auto fallbackFontNames = { > > Does NeverDestroyed not work in this context? I don't use NeverDestroyed because this code path is executed just only once. I think NeverDestroyed should be use only for instances which are used all the time. 1471482 7 fujii 2018-10-22 20:51:53 -0700 Review, please. 1471540 8 352780 mmaxfield 2018-10-23 04:24:59 -0700 Comment on attachment 352780 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352780&action=review >>> Source/WebCore/platform/graphics/win/FontCacheWin.cpp:354 >>> + const auto fallbackFontNames = { >> >> Does NeverDestroyed not work in this context? > > I don't use NeverDestroyed because this code path is executed just only once. I think NeverDestroyed should be use only for instances which are used all the time. Using string literals still makes them live forever, so I'm not sure why one is preferable over the other. We should be using NeverDestroyed instead. 1471749 9 353019 fujii 2018-10-23 20:17:03 -0700 Created attachment 353019 Patch You are right. Applied the review feedback. 1471762 10 353019 fujii 2018-10-23 21:59:13 -0700 Comment on attachment 353019 Patch Clearing flags on attachment: 353019 Committed r237375: <https://trac.webkit.org/changeset/237375> 1471763 11 fujii 2018-10-23 21:59:15 -0700 All reviewed patches have been landed. Closing bug. 1471764 12 webkit-bug-importer 2018-10-23 22:00:49 -0700 <rdar://problem/45510349> 352775 2018-10-19 02:20:22 -0700 2018-10-19 04:10:51 -0700 WIP patch a.diff text/plain 1760 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9Gb250Q2Fj aGVXaW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0ZvbnRDYWNo ZVdpbi5jcHAKaW5kZXggYmQzNDI1MzE2MzYuLmRlYWFlMDdmMjg1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vRm9udENhY2hlV2luLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vRm9udENhY2hlV2luLmNwcApAQCAt MzUxLDE3ICszNTEsMTggQEAgUmVmPEZvbnQ+IEZvbnRDYWNoZTo6bGFzdFJlc29ydEZhbGxiYWNr Rm9udChjb25zdCBGb250RGVzY3JpcHRpb24mIGZvbnREZXNjcmlwdGkKICAgICAvLyBTZWFyY2gg YWxsIHR5cGljYWwgV2luZG93cy1pbnN0YWxsZWQgZnVsbCBVbmljb2RlIGZvbnRzLgogICAgIC8v IFNvcnRlZCBieSBtb3N0IHRvIGxlYXN0IGdseXBocyBhY2NvcmRpbmcgdG8gaHR0cDovL2VuLndp a2lwZWRpYS5vcmcvd2lraS9Vbmljb2RlX3R5cGVmYWNlcwogICAgIC8vIFN0YXJ0IHdpdGggVGlt ZXMgTmV3IFJvbWFuIGFsc28gc2luY2UgaXQgaXMgdGhlIGRlZmF1bHQgaWYgdGhlIHVzZXIgZG9l c24ndCBjaGFuZ2UgcHJlZnMuCi0gICAgc3RhdGljIEF0b21pY1N0cmluZyBmYWxsYmFja0ZvbnRz W10gPSB7Ci0gICAgICAgIEF0b21pY1N0cmluZygiVGltZXMgTmV3IFJvbWFuIiwgQXRvbWljU3Ry aW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCksCi0gICAgICAgIEF0b21pY1N0cmluZygiTWljcm9z b2Z0IFNhbnMgU2VyaWYiLCBBdG9taWNTdHJpbmc6OkNvbnN0cnVjdEZyb21MaXRlcmFsKSwKLSAg ICAgICAgQXRvbWljU3RyaW5nKCJUYWhvbWEiLCBBdG9taWNTdHJpbmc6OkNvbnN0cnVjdEZyb21M aXRlcmFsKSwKLSAgICAgICAgQXRvbWljU3RyaW5nKCJMdWNpZGEgU2FucyBVbmljb2RlIiwgQXRv bWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCksCi0gICAgICAgIEF0b21pY1N0cmluZygi QXJpYWwiLCBBdG9taWNTdHJpbmc6OkNvbnN0cnVjdEZyb21MaXRlcmFsKQorICAgIGNvbnN0IGF1 dG8gZmFsbGJhY2tGb250TmFtZXMgPSB7CisgICAgICAgICJUaW1lcyBOZXcgUm9tYW4iLAorICAg ICAgICAiTWljcm9zb2Z0IFNhbnMgU2VyaWYiLAorICAgICAgICAiVGFob21hIiwKKyAgICAgICAg Ikx1Y2lkYSBTYW5zIFVuaWNvZGUiLAorICAgICAgICAiQXJpYWwiLAogICAgIH07CiAgICAgUmVm UHRyPEZvbnQ+IHNpbXBsZUZvbnQ7Ci0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBXVEZfQVJS QVlfTEVOR1RIKGZhbGxiYWNrRm9udHMpOyArK2kpIHsKLSAgICAgICAgaWYgKHNpbXBsZUZvbnQg PSBmb250Rm9yRmFtaWx5KGZvbnREZXNjcmlwdGlvbiwgZmFsbGJhY2tGb250c1tpXSkpIHsKLSAg ICAgICAgICAgIGZhbGxiYWNrRm9udE5hbWUuZ2V0KCkgPSBmYWxsYmFja0ZvbnRzW2ldOworICAg IGZvciAoYXV0byYgZm9udE5hbWVMaXRlcmFsIDogZmFsbGJhY2tGb250TmFtZXMpIHsKKyAgICAg ICAgQXRvbWljU3RyaW5nIGZvbnROYW1lKGZvbnROYW1lTGl0ZXJhbCk7CisgICAgICAgIGlmIChz aW1wbGVGb250ID0gZm9udEZvckZhbWlseShmb250RGVzY3JpcHRpb24sIGZvbnROYW1lKSkgewor ICAgICAgICAgICAgZmFsbGJhY2tGb250TmFtZS5nZXQoKSA9IFdURk1vdmUoZm9udE5hbWUpOwog ICAgICAgICAgICAgcmV0dXJuICpzaW1wbGVGb250OwogICAgICAgICB9CiAgICAgfQo= 352780 2018-10-19 04:10:55 -0700 2018-10-23 20:17:00 -0700 Patch bug-190748-20181019201054.patch text/plain 3100 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTVhMDc2ODkzODQzMGM0 ZTk3N2U4YmRmNzE3Zjk1YTAzZDA0M2EyOS4uODU2NDljZGZlMTFjZGRlYTc5OTFkY2JiZTEzYzkx OTkyOTkwMmMwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTEwLTE5ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWly b10gQXNzZXJ0aW9uIGZhaWxzIHdoaWxlIGRlc3RydWN0aW5nIGxvY2FsIHN0YXRpYyBBdG9taWNT dHJpbmcgb2YgRm9udENhY2hlOjpsYXN0UmVzb3J0RmFsbGJhY2tGb250CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA3NDgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb250Q2FjaGU6Omxhc3RSZXNvcnRG YWxsYmFja0ZvbnQgaGFkIGxvY2FsIHN0YXRpYyBBdG9taWNTdHJpbmcKKyAgICAgICAgdmFyaWFi bGVzIHdoaWNoIGFyZSBub3QgY2Fwc3VsZWQgYnkgTmV2ZXJEZXN0cm95ZWQuIFRoZW4sIHRob3Nl CisgICAgICAgIHZhcmlhYmxlcyBhcmUgZGVzdHJ1Y3RlZCB3aGVuIFdlYlByb2Nlc3MgZXhpdHMu CisKKyAgICAgICAgQ2hhbmdlZCB0aG9zZSBBdG9taWNTdHJpbmcgdG8gc2ltcGxlIHN0cmluZyBs aXRlcmFscy4KKworICAgICAgICBUaGlzIGNoYW5nZSBjYW4ndCBiZSB0ZXN0ZWQgYXV0b21hdGlj YWxseSBiZWNhdXNlIFdlYktpdFRlc3RSdW5uZXIKKyAgICAgICAgZG9lc24ndCBzdXBwb3J0IFdp bmRvd3MgcG9ydCB5ZXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vRm9udENh Y2hlV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6bGFzdFJlc29ydEZhbGxi YWNrRm9udCk6IFJlbmFtZWQKKyAgICAgICAgJ2ZhbGxiYWNrRm9udHMnIHRvICdmYWxsYmFja0Zv bnROYW1lcycsIGFuZCBjaGFuZ2VkIHRvIHNpbXBsZQorICAgICAgICBzdHJpbmcgbGl0ZXJhbHMu CisKIDIwMTgtMTAtMTggIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAK ICAgICAgICAgW01lZGlhU3RyZWFtXSBBbGxvdyBwb3J0cyB0byBvcHRpb25hbGx5IGRvIHNjcmVl biBjYXB0dXJlIGluIHRoZSBVSSBwcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy93aW4vRm9udENhY2hlV2luLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3dpbi9Gb250Q2FjaGVXaW4uY3BwCmluZGV4IGJkMzQyNTMxNjM2MTkx MzJjYTMzYmJmYjQ2ZjJmMjJiNTAzOTVhNjQuLmRlYWFlMDdmMjg1NzU4YjQzYjZlNWJmYTdlYjYw MzI2M2ZjM2YyMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3dpbi9Gb250Q2FjaGVXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3dpbi9Gb250Q2FjaGVXaW4uY3BwCkBAIC0zNTEsMTcgKzM1MSwxOCBAQCBSZWY8Rm9udD4g Rm9udENhY2hlOjpsYXN0UmVzb3J0RmFsbGJhY2tGb250KGNvbnN0IEZvbnREZXNjcmlwdGlvbiYg Zm9udERlc2NyaXB0aQogICAgIC8vIFNlYXJjaCBhbGwgdHlwaWNhbCBXaW5kb3dzLWluc3RhbGxl ZCBmdWxsIFVuaWNvZGUgZm9udHMuCiAgICAgLy8gU29ydGVkIGJ5IG1vc3QgdG8gbGVhc3QgZ2x5 cGhzIGFjY29yZGluZyB0byBodHRwOi8vZW4ud2lraXBlZGlhLm9yZy93aWtpL1VuaWNvZGVfdHlw ZWZhY2VzCiAgICAgLy8gU3RhcnQgd2l0aCBUaW1lcyBOZXcgUm9tYW4gYWxzbyBzaW5jZSBpdCBp cyB0aGUgZGVmYXVsdCBpZiB0aGUgdXNlciBkb2Vzbid0IGNoYW5nZSBwcmVmcy4KLSAgICBzdGF0 aWMgQXRvbWljU3RyaW5nIGZhbGxiYWNrRm9udHNbXSA9IHsKLSAgICAgICAgQXRvbWljU3RyaW5n KCJUaW1lcyBOZXcgUm9tYW4iLCBBdG9taWNTdHJpbmc6OkNvbnN0cnVjdEZyb21MaXRlcmFsKSwK LSAgICAgICAgQXRvbWljU3RyaW5nKCJNaWNyb3NvZnQgU2FucyBTZXJpZiIsIEF0b21pY1N0cmlu Zzo6Q29uc3RydWN0RnJvbUxpdGVyYWwpLAotICAgICAgICBBdG9taWNTdHJpbmcoIlRhaG9tYSIs IEF0b21pY1N0cmluZzo6Q29uc3RydWN0RnJvbUxpdGVyYWwpLAotICAgICAgICBBdG9taWNTdHJp bmcoIkx1Y2lkYSBTYW5zIFVuaWNvZGUiLCBBdG9taWNTdHJpbmc6OkNvbnN0cnVjdEZyb21MaXRl cmFsKSwKLSAgICAgICAgQXRvbWljU3RyaW5nKCJBcmlhbCIsIEF0b21pY1N0cmluZzo6Q29uc3Ry dWN0RnJvbUxpdGVyYWwpCisgICAgY29uc3QgYXV0byBmYWxsYmFja0ZvbnROYW1lcyA9IHsKKyAg ICAgICAgIlRpbWVzIE5ldyBSb21hbiIsCisgICAgICAgICJNaWNyb3NvZnQgU2FucyBTZXJpZiIs CisgICAgICAgICJUYWhvbWEiLAorICAgICAgICAiTHVjaWRhIFNhbnMgVW5pY29kZSIsCisgICAg ICAgICJBcmlhbCIsCiAgICAgfTsKICAgICBSZWZQdHI8Rm9udD4gc2ltcGxlRm9udDsKLSAgICBm b3IgKHNpemVfdCBpID0gMDsgaSA8IFdURl9BUlJBWV9MRU5HVEgoZmFsbGJhY2tGb250cyk7ICsr aSkgewotICAgICAgICBpZiAoc2ltcGxlRm9udCA9IGZvbnRGb3JGYW1pbHkoZm9udERlc2NyaXB0 aW9uLCBmYWxsYmFja0ZvbnRzW2ldKSkgewotICAgICAgICAgICAgZmFsbGJhY2tGb250TmFtZS5n ZXQoKSA9IGZhbGxiYWNrRm9udHNbaV07CisgICAgZm9yIChhdXRvJiBmb250TmFtZUxpdGVyYWwg OiBmYWxsYmFja0ZvbnROYW1lcykgeworICAgICAgICBBdG9taWNTdHJpbmcgZm9udE5hbWUoZm9u dE5hbWVMaXRlcmFsKTsKKyAgICAgICAgaWYgKHNpbXBsZUZvbnQgPSBmb250Rm9yRmFtaWx5KGZv bnREZXNjcmlwdGlvbiwgZm9udE5hbWUpKSB7CisgICAgICAgICAgICBmYWxsYmFja0ZvbnROYW1l LmdldCgpID0gV1RGTW92ZShmb250TmFtZSk7CiAgICAgICAgICAgICByZXR1cm4gKnNpbXBsZUZv bnQ7CiAgICAgICAgIH0KICAgICB9Cg== 353019 2018-10-23 20:17:03 -0700 2018-10-23 21:59:13 -0700 Patch bug-190748-20181024121702.patch text/plain 2372 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWQ0ZmE2ODE5MmVhOTYx ZGFmYTE4ZDgzNWI0MWVkMTI2YThlOTU4NS4uNzYxMjg4OTNhMmJiNjM1MGEwN2I2OTBkMjY3Nzhi ZjRhNjU1MDk5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE4LTEwLTIzICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIEFz c2VydGlvbiBmYWlscyB3aGlsZSBkZXN0cnVjdGluZyBsb2NhbCBzdGF0aWMgQXRvbWljU3RyaW5n IG9mIEZvbnRDYWNoZTo6bGFzdFJlc29ydEZhbGxiYWNrRm9udAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNzQ4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9udENhY2hlOjpsYXN0UmVzb3J0RmFsbGJh Y2tGb250IGhhZCBsb2NhbCBzdGF0aWMgQXRvbWljU3RyaW5nCisgICAgICAgIHZhcmlhYmxlcyB3 aGljaCBhcmUgbm90IGNhcHN1bGVkIGJ5IE5ldmVyRGVzdHJveWVkLiBIZW5jZSwgdGhvc2UKKyAg ICAgICAgdmFyaWFibGVzIGFyZSBkZXN0cnVjdGVkIG9uIElQQyB0aHJlYWQgd2hlbiBXZWJQcm9j ZXNzIGV4aXRzLgorCisgICAgICAgIENoYW5nZWQgdGhvc2UgQXRvbWljU3RyaW5nIHRvIE5ldmVy RGVzdHJveWVkPEF0b21pY1N0cmluZz4gbm90IHRvCisgICAgICAgIGJlIGRlc3RydWN0ZWQgb24g ZXhpdC4KKworICAgICAgICBUaGlzIGNoYW5nZSBjYW4ndCBiZSB0ZXN0ZWQgYXV0b21hdGljYWxs eSBiZWNhdXNlIFdlYktpdFRlc3RSdW5uZXIKKyAgICAgICAgZG9lc24ndCBzdXBwb3J0IFdpbmRv d3MgcG9ydCB5ZXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vRm9udENhY2hl V2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6bGFzdFJlc29ydEZhbGxiYWNr Rm9udCk6IENoYW5nZWQKKyAgICAgICAgZmFsbGJhY2tGb250cydzIHR5cGUgZnJvbSBBdG9taWNT dHJpbmcgYXJyYXkgdG8KKyAgICAgICAgTmV2ZXJEZXN0cm95ZWQ8QXRvbWljU3RyaW5nPiBhcnJh eS4KKwogMjAxOC0xMC0yMyAgSnVzdGluIEZhbiAgPGp1c3Rpbl9mYW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFtXZWJHUFVdIFJlbmFtZSBvbGQgR1BVKiBpbXBsZW1lbnRhdGlvbiBmaWxlcyB0byBH UFVMZWdhY3kqIGZvciBXZWJNZXRhbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvd2luL0ZvbnRDYWNoZVdpbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy93aW4vRm9udENhY2hlV2luLmNwcAppbmRleCBiZDM0MjUzMTYzNjE5MTMyY2Ez M2JiZmI0NmYyZjIyYjUwMzk1YTY0Li4yODE2Y2I1ODYxYTBjZGFhYjI2ZmZjZWMxYThhOWFkOGYx NWY1MzdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4v Rm9udENhY2hlV2luLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93 aW4vRm9udENhY2hlV2luLmNwcApAQCAtMzUxLDcgKzM1MSw3IEBAIFJlZjxGb250PiBGb250Q2Fj aGU6Omxhc3RSZXNvcnRGYWxsYmFja0ZvbnQoY29uc3QgRm9udERlc2NyaXB0aW9uJiBmb250RGVz Y3JpcHRpCiAgICAgLy8gU2VhcmNoIGFsbCB0eXBpY2FsIFdpbmRvd3MtaW5zdGFsbGVkIGZ1bGwg VW5pY29kZSBmb250cy4KICAgICAvLyBTb3J0ZWQgYnkgbW9zdCB0byBsZWFzdCBnbHlwaHMgYWNj b3JkaW5nIHRvIGh0dHA6Ly9lbi53aWtpcGVkaWEub3JnL3dpa2kvVW5pY29kZV90eXBlZmFjZXMK ICAgICAvLyBTdGFydCB3aXRoIFRpbWVzIE5ldyBSb21hbiBhbHNvIHNpbmNlIGl0IGlzIHRoZSBk ZWZhdWx0IGlmIHRoZSB1c2VyIGRvZXNuJ3QgY2hhbmdlIHByZWZzLgotICAgIHN0YXRpYyBBdG9t aWNTdHJpbmcgZmFsbGJhY2tGb250c1tdID0geworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxB dG9taWNTdHJpbmc+IGZhbGxiYWNrRm9udHNbXSA9IHsKICAgICAgICAgQXRvbWljU3RyaW5nKCJU aW1lcyBOZXcgUm9tYW4iLCBBdG9taWNTdHJpbmc6OkNvbnN0cnVjdEZyb21MaXRlcmFsKSwKICAg ICAgICAgQXRvbWljU3RyaW5nKCJNaWNyb3NvZnQgU2FucyBTZXJpZiIsIEF0b21pY1N0cmluZzo6 Q29uc3RydWN0RnJvbUxpdGVyYWwpLAogICAgICAgICBBdG9taWNTdHJpbmcoIlRhaG9tYSIsIEF0 b21pY1N0cmluZzo6Q29uc3RydWN0RnJvbUxpdGVyYWwpLAo=