190747 2018-10-19 00:50:38 -0700 [WinCairo] ASSERTION FAILED: !m_preparingToPlay in MediaPlayerPrivateMediaFoundation::prepareToPlay 2019-05-28 21:39:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=156284 InRadar P2 Normal --- 1 fujii fujii achristensen don.olmstead pvollan ross.kirsling webkit-bug-importer oldest_to_newest 1470823 0 fujii 2018-10-19 00:50:38 -0700 [WinCairo] ASSERTION FAILED: !m_preparingToPlay in MediaPlayerPrivateMediaFoundation::prepareToPlay WinCairo, WK1, Debug build, trunk@237282 1. Start MiniBrowser 2. Menu > New WebKitLegacy Window 3. Go to https://www.youtube.com/ 4. ASSERTION FAILED: !m_preparingToPlay Log: > ASSERTION FAILED: !m_preparingToPlay > c:\webkit\ga\source\webcore\platform\graphics\win\mediaplayerprivatemediafoundation.cpp(197) : WebCore::MediaPlayerPrivateMediaFoundation::prepareToPlay Callstack: > WTF.dll!WTFCrash() Line 255 C++ > WebKit.dll!WTFCrashWithInfo(int __formal, const char * __formal, const char * __formal, int __formal) Line 551 C++ > WebKit.dll!WebCore::MediaPlayerPrivateMediaFoundation::prepareToPlay() Line 197 C++ > WebKit.dll!WebCore::MediaPlayerPrivateMediaFoundation::onTopologySet() Line 922 C++ > WebKit.dll!WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent::__l11::<lambda>() Line 535 C++ > WebKit.dll!WTF::Function<void __cdecl(void)>::CallableWrapper<void <lambda>(void) >::call() Line 101 C++ > WTF.dll!WTF::Function<void __cdecl(void)>::operator()() Line 57 C++ > WTF.dll!WTF::dispatchFunctionsFromMainThread() Line 118 C++ > WTF.dll!WTF::ThreadingWindowWndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 48 C++ > [External Code] > WebKit.dll!WebKitMessageLoop::run(HACCEL__ * hAccelTable) Line 96 C++ > MiniBrowserLib.dll!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 89 C++ > MiniBrowserLib.dll!dllLauncherEntryPoint(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 106 C++ > MiniBrowser.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 230 C++ > [External Code] No problem happens in WK2 Window. 1470837 1 fujii 2018-10-19 04:13:34 -0700 Following test cases are crashing due to this bug. fast/canvas/webgl/texImage2D-video-flipY-false.html fast/canvas/webgl/texImage2D-video-flipY-true.html 1539480 2 fujii 2019-05-27 20:24:01 -0700 m_preparingToPlay has been introduced in Bug 156284. 1539487 3 fujii 2019-05-27 22:09:01 -0700 MediaPlayerPrivateMediaFoundation::prepareToPlay is called from HTMLMediaElement::prepareToPlay first. > WebKit.dll!WebCore::MediaPlayerPrivateMediaFoundation::prepareToPlay() Line 193 C++ > WebKit.dll!WebCore::MediaPlayer::prepareToPlay() Line 554 C++ > WebKit.dll!WebCore::HTMLMediaElement::prepareToPlay() Line 2958 C++ > WebKit.dll!WebCore::HTMLMediaElement::load::<unnamed-tag>::operator()() Line 1183 C++ > WebKit.dll!WTF::Detail::CallableWrapper<`lambda at ..\..\Source\WebCore\html/HTMLMediaElement.cpp:1181:46',void>::call() Line 52 C++ > WebKit.dll!WTF::Function<void ()>::operator()() Line 79 C++ > WebKit.dll!WebCore::GenericTaskQueue<WebCore::Timer,unsigned int>::enqueueTask::<unnamed-tag>::operator()() Line 107 C++ > WebKit.dll!WTF::Detail::CallableWrapper<`lambda at ..\..\Source\WebCore\platform\GenericTaskQueue.h:101:31',void>::call() Line 52 C++ > WebKit.dll!WTF::Function<void ()>::operator()() Line 79 C++ > WebKit.dll!WebCore::TaskDispatcher<WebCore::Timer>::dispatchOneTask() Line 111 C++ > WebKit.dll!WebCore::TaskDispatcher<WebCore::Timer>::sharedTimerFired() Line 86 C++ > WebKit.dll!WebCore::TaskDispatcher<WebCore::Timer>::sharedTimer::<unnamed-tag>::operator()() Line 60 C++ > WebKit.dll!WTF::Detail::CallableWrapper<`lambda at ..\..\Source\WebCore\platform/GenericTaskQueue.cpp:60:40',void>::call() Line 52 C++ > WebKit.dll!WTF::Function<void ()>::operator()() Line 79 C++ > WebKit.dll!WebCore::Timer::fired() Line 127 C++ > WebKit.dll!WebCore::ThreadTimers::sharedTimerFiredInternal() Line 129 C++ > WebKit.dll!WebCore::ThreadTimers::setSharedTimer::<unnamed-tag>::operator()() Line 69 C++ > WebKit.dll!WTF::Detail::CallableWrapper<`lambda at ..\..\Source\WebCore\platform/ThreadTimers.cpp:69:41',void>::call() Line 52 C++ > WebKit.dll!WTF::Function<void ()>::operator()() Line 79 C++ > WebKit.dll!WebCore::MainThreadSharedTimer::fired() Line 84 C++ > WebKit.dll!WebCore::TimerWindowWndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 89 C++ > [External Code] > WebKit.dll!WebKitMessageLoop::run(HACCEL__ * hAccelTable) Line 94 C++ > MiniBrowserLib.dll!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 97 C++ > MiniBrowserLib.dll!dllLauncherEntryPoint(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 115 C++ > MiniBrowser.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 232 C++ > [External Code] And, called from onTopologySet next, and the assertion fails. > WebKit.dll!WebCore::MediaPlayerPrivateMediaFoundation::prepareToPlay() Line 193 C++ > WebKit.dll!WebCore::MediaPlayerPrivateMediaFoundation::onTopologySet() Line 917 C++ > WebKit.dll!WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent::<unnamed-tag>::operator()() Line 531 C++ > WebKit.dll!WTF::Detail::CallableWrapper<`lambda at ..\..\Source\WebCore\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp:527:26',void>::call() Line 52 C++ > WTF.dll!WTF::Function<void ()>::operator()() Line 79 C++ > WTF.dll!WTF::dispatchFunctionsFromMainThread() Line 113 C++ > WTF.dll!WTF::ThreadingWindowWndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 48 C++ > [External Code] > WebKit.dll!WebKitMessageLoop::run(HACCEL__ * hAccelTable) Line 94 C++ > MiniBrowserLib.dll!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 97 C++ > MiniBrowserLib.dll!dllLauncherEntryPoint(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 115 C++ > MiniBrowser.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 232 C++ > [External Code] 1539521 4 370720 fujii 2019-05-28 03:19:09 -0700 Created attachment 370720 Patch 1539886 5 370720 fujii 2019-05-28 21:38:30 -0700 Comment on attachment 370720 Patch Clearing flags on attachment: 370720 Committed r245846: <https://trac.webkit.org/changeset/245846> 1539887 6 fujii 2019-05-28 21:38:33 -0700 All reviewed patches have been landed. Closing bug. 1539888 7 webkit-bug-importer 2019-05-28 21:39:16 -0700 <rdar://problem/51208080> 370720 2019-05-28 03:19:09 -0700 2019-05-28 21:38:30 -0700 Patch bug-190747-20190528191908.patch text/plain 3561 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1ODA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmJmODBiMzhhNDhlZGU4 NTBiMzRlMTE1ODg0OGJiNzRjMTk2MzhlYy4uYWExNjMwNTQ1NTE3MGFjYmRkMjcxNjllOWVlNTNj OGY1ZDM2NGIyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE5LTA1LTI4ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWly b10gQVNTRVJUSU9OIEZBSUxFRDogIW1fcHJlcGFyaW5nVG9QbGF5IGluIE1lZGlhUGxheWVyUHJp dmF0ZU1lZGlhRm91bmRhdGlvbjo6cHJlcGFyZVRvUGxheQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNzQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSFRNTE1lZGlhRWxlbWVudDo6cHJlcGFyZVRvUGxh eSBoYWQgYSBhc3NlcnRpb24gZW5zdXJpbmcgdGhhdCBpdAorICAgICAgICB3YXMgbm90IGNhbGxl ZCB0d2ljZS4gSG93ZXZlciwgaXQgd2FzIGNhbGxlZCB0d2ljZS4gVGhlIGZpcnN0IGZyb20KKyAg ICAgICAgSFRNTE1lZGlhRWxlbWVudDo6bG9hZCwgdGhlIHNlY29uZCBmcm9tCisgICAgICAgIE1l ZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6b25Ub3BvbG9neVNldC4KKworICAgICAg ICBwcmVwYXJlVG9QbGF5IHN0YXJ0ZWQgbG9hZGluZy4gQW5kLCBsb2FkaW5nIHNob3VsZCBiZSBz dGFydGVkCisgICAgICAgIGFmdGVyIG9uVG9wb2xvZ3lTZXQgaXMgY2FsbGVkIGJhY2suCisKKyAg ICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uOjpvblRvcG9sb2d5 U2V0KTogTW92ZWQgY29kZSBmcm9tIHByZXBhcmVUb1BsYXkuCisgICAgICAgIChXZWJDb3JlOjpN ZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OnByZXBhcmVUb1BsYXkpOiBEZWxldGVk IGFuZCBtb3ZlZCB0aGUgY29kZSB0byBvblRvcG9sb2d5U2V0LgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uaDogUmVtb3Zl ZCBwcmVwYXJlVG9QbGF5IGRlY2xhcmF0aW9uLgorCiAyMDE5LTA1LTI3ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBVc2UgV1BFQmFj a2VuZC1mZG8gZm9yIGFjY2VsZXJhdGluZyBjb21wb3NpdGluZyBpbiBXYXlsYW5kIGluc3RlYWQg b2YgdGhlIG5lc3RlZCBjb21wb3NpdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVN ZWRpYUZvdW5kYXRpb24uY3BwCmluZGV4IGVmYjE1NWY0ODJiMzI3N2RiYjMyMWJjOTlkN2FiOTM5 MjA4YjY2ZjEuLmEzOWI1OTIxN2U2NTAwMDExNTAxZTljY2ViMThkMDllYmYzYjBlNzUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclBy aXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwCkBAIC0xODUs MTUgKzE4NSw2IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uOjpjYW5j ZWxMb2FkKCkKICAgICBub3RJbXBsZW1lbnRlZCgpOwogfQogCi12b2lkIE1lZGlhUGxheWVyUHJp dmF0ZU1lZGlhRm91bmRhdGlvbjo6cHJlcGFyZVRvUGxheSgpCi17Ci0gICAgLy8gV2UgY2FsbCBz dGFydFNlc3Npb24oKSB0byBzdGFydCBidWZmZXJpbmcgdmlkZW8gZGF0YS4KLSAgICAvLyBXaGVu IHdlIGhhdmUgcmVjZWl2ZWQgZW5vdWdoIGRhdGEsIHdlIHBhdXNlLCBzbyB0aGF0IHdlIGRvbid0 IGFjdHVhbGx5IHN0YXJ0IHRoZSBwbGF5YmFjay4KLSAgICBBU1NFUlQobV9wYXVzZWQpOwotICAg IEFTU0VSVCghbV9wcmVwYXJpbmdUb1BsYXkpOwotICAgIG1fcHJlcGFyaW5nVG9QbGF5ID0gc3Rh cnRTZXNzaW9uKCk7Ci19Ci0KIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9u OjpwbGF5KCkKIHsKICAgICBtX3BhdXNlZCA9ICFzdGFydFNlc3Npb24oKTsKQEAgLTkxNCw3ICs5 MDUsMTEgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246Om9uVG9wb2xv Z3lTZXQoKQogICAgIH0KIAogICAgIC8vIEl0IGlzIGV4cGVjdGVkIHRoYXQgd2Ugc3RhcnQgYnVm ZmVyaW5nIGRhdGEgZnJvbSB0aGUgbmV0d29yayBub3cuCi0gICAgcHJlcGFyZVRvUGxheSgpOwor ICAgIC8vIFdlIGNhbGwgc3RhcnRTZXNzaW9uKCkgdG8gc3RhcnQgYnVmZmVyaW5nIHZpZGVvIGRh dGEuCisgICAgLy8gV2hlbiB3ZSBoYXZlIHJlY2VpdmVkIGVub3VnaCBkYXRhLCB3ZSBwYXVzZSwg c28gdGhhdCB3ZSBkb24ndCBhY3R1YWxseSBzdGFydCB0aGUgcGxheWJhY2suCisgICAgQVNTRVJU KG1fcGF1c2VkKTsKKyAgICBBU1NFUlQoIW1fcHJlcGFyaW5nVG9QbGF5KTsKKyAgICBtX3ByZXBh cmluZ1RvUGxheSA9IHN0YXJ0U2Vzc2lvbigpOwogfQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0 ZU1lZGlhRm91bmRhdGlvbjo6b25CdWZmZXJpbmdTdGFydGVkKCkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZv dW5kYXRpb24uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBs YXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uaAppbmRleCAzODVjMjNlYzMyMjkwMDExNzJlZGU0 ZTg4MDBiZDZjNzZkNGZhYjdlLi5kODVmMTc1OTAyMDZjMTc4NGZlYTI0ZWI2NmZiOGU1YWYwOTE2 YTcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vTWVk aWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5oCkBA IC01OSw4ICs1OSw2IEBAIHB1YmxpYzoKICAgICB2b2lkIGxvYWQoY29uc3QgU3RyaW5nJiB1cmwp IG92ZXJyaWRlOwogICAgIHZvaWQgY2FuY2VsTG9hZCgpIG92ZXJyaWRlOwogCi0gICAgdm9pZCBw cmVwYXJlVG9QbGF5KCkgb3ZlcnJpZGU7Ci0KICAgICB2b2lkIHBsYXkoKSBvdmVycmlkZTsKICAg ICB2b2lkIHBhdXNlKCkgb3ZlcnJpZGU7CiAK