190737 2018-10-18 14:47:42 -0700 Remove PLATFORM(IOS) for now 2018-10-18 17:56:21 -0700 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap benjamin cdumez cmarcelo dbates ews-watchlist thorton webkit-bug-importer oldest_to_newest 1470695 0 ap 2018-10-18 14:47:42 -0700 Need to wait until most in-flight patches that expect PLATFORM(IOS) to be true on all iOS family OSes are no longer relevant. It's better to have them break the build than for the conflict to go unnoticed. In a few weeks, will reintroduce PLATFORM(IOS) with the new meaning. 1470698 1 352737 ap 2018-10-18 14:53:13 -0700 Created attachment 352737 proposed patch 1470700 2 ews-watchlist 2018-10-18 14:56:27 -0700 Attachment 352737 did not pass style-queue: ERROR: Source/WTF/wtf/Platform.h:376: CPP comments are not allowed in Platform.h, please use C comments /* ... */ [build/cpp_comment] [5] ERROR: Source/WTF/wtf/Platform.h:377: CPP comments are not allowed in Platform.h, please use C comments /* ... */ [build/cpp_comment] [5] ERROR: Source/WTF/wtf/Platform.h:527: CPP comments are not allowed in Platform.h, please use C comments /* ... */ [build/cpp_comment] [5] ERROR: Source/WTF/wtf/Platform.h:528: CPP comments are not allowed in Platform.h, please use C comments /* ... */ [build/cpp_comment] [5] ERROR: Source/WTF/wtf/Platform.h:531: CPP comments are not allowed in Platform.h, please use C comments /* ... */ [build/cpp_comment] [5] ERROR: Source/WTF/wtf/Platform.h:532: CPP comments are not allowed in Platform.h, please use C comments /* ... */ [build/cpp_comment] [5] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1470703 3 352738 ap 2018-10-18 14:58:40 -0700 Created attachment 352738 proposed patch Oops, thank you style queue. 1470745 4 352748 ap 2018-10-18 17:00:33 -0700 Created attachment 352748 proposed patch With fewer mistakes... 1470754 5 ap 2018-10-18 17:55:21 -0700 Committed http://trac.webkit.org/r237277 1470755 6 webkit-bug-importer 2018-10-18 17:56:21 -0700 <rdar://problem/45391620> 352737 2018-10-18 14:53:13 -0700 2018-10-18 14:58:40 -0700 proposed patch RemovePlatformIOS.txt text/plain 1693 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzcyNjgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE4LTEwLTE4ICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBQTEFURk9STShJT1MpIGZvciBub3cK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDczNwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1Bs YXRmb3JtLmg6CisKIDIwMTgtMTAtMTggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5j b20+CiAKICAgICAgICAgU3dpdGNoIGZyb20gUExBVEZPUk0oSU9TKSB0byBQTEFURk9STShJT1Nf RkFNSUxZKQpJbmRleDogU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiAyMzcyNjgpCisrKyBTb3VyY2UvV1RG L3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNzMsNyArMzczLDggQEAKIC8qIE9T KE1BQ19PU19YKSAtIG1hY09TIChub3QgaW5jbHVkaW5nIGlPUyBmYW1pbHkpICovCiAjaWYgT1Mo REFSV0lOKQogI2lmIFRBUkdFVF9PU19JUEhPTkUKLSNkZWZpbmUgV1RGX09TX0lPUyAxCisvLyBG SVhNRSAoTm92ZW1iZXIgMjAxOCk6IEFkZCBXVEZfT1NfSU9TIG9uY2UgbW9zdCBwYXRjaGVzIHRo YXQgdXNlZCBpdCBhcyBhbiBvbGQKKy8vIHZlcnNpb24gb2YgUExBVEZPUk0oSU9TX0ZBTUlMWSkg YXJlIG5vIGxvbmdlciByZWxldmFudC4KICNkZWZpbmUgV1RGX09TX0lPU19GQU1JTFkgMQogI2Vs aWYgVEFSR0VUX09TX01BQwogI2RlZmluZSBXVEZfT1NfTUFDX09TX1ggMQpAQCAtNTIzLDEwICs1 MjQsMTIgQEAKICNlbGlmIE9TKE1BQ19PU19YKQogI2RlZmluZSBXVEZfUExBVEZPUk1fTUFDIDEK ICNlbGlmIE9TKElPUykKLSNkZWZpbmUgV1RGX1BMQVRGT1JNX0lPUyAxCisvLyBGSVhNRSAoTm92 ZW1iZXIgMjAxOCk6IEFkZCBXVEZfUExBVEZPUk1fSU9TIG9uY2UgbW9zdCBwYXRjaGVzIHRoYXQg dXNlZCBpdCBhcyBhbiBvbGQKKy8vIHZlcnNpb24gb2YgUExBVEZPUk0oSU9TX0ZBTUlMWSkgYXJl IG5vIGxvbmdlciByZWxldmFudC4KICNkZWZpbmUgV1RGX1BMQVRGT1JNX0lPU19GQU1JTFkgMQog I2lmIFRBUkdFVF9PU19TSU1VTEFUT1IKLSNkZWZpbmUgV1RGX1BMQVRGT1JNX0lPU19TSU1VTEFU T1IgMQorLy8gRklYTUUgKE5vdmVtYmVyIDIwMTgpOiBBZGQgV1RGX1BMQVRGT1JNX0lPU19TSU1V TEFUT1Igb25jZSBtb3N0IHBhdGNoZXMgdGhhdCB1c2VkIGl0IGFzIGFuIG9sZAorLy8gdmVyc2lv biBvZiBQTEFURk9STShJT1NfRkFNSUxZKSBhcmUgbm8gbG9uZ2VyIHJlbGV2YW50LgogI2RlZmlu ZSBXVEZfUExBVEZPUk1fSU9TX0ZBTUlMWV9TSU1VTEFUT1IgMQogI2VuZGlmCiAjaWYgZGVmaW5l ZChUQVJHRVRfT1NfSU9TTUFDKSAmJiBUQVJHRVRfT1NfSU9TTUFDCg== 352738 2018-10-18 14:58:40 -0700 2018-10-18 17:00:33 -0700 proposed patch RemovePlatformIOS.txt text/plain 1698 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzcyNjgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE4LTEwLTE4ICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBQTEFURk9STShJT1MpIGZvciBub3cK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDczNwor CisgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIb3J0b24uCisKKyAgICAgICAgKiB3dGYvUGxhdGZv cm0uaDoKKwogMjAxOC0xMC0xOCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4K IAogICAgICAgICBTd2l0Y2ggZnJvbSBQTEFURk9STShJT1MpIHRvIFBMQVRGT1JNKElPU19GQU1J TFkpCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDIzNzI2OCkKKysrIFNvdXJjZS9XVEYvd3Rm L1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTM3Myw3ICszNzMsOCBAQAogLyogT1MoTUFD X09TX1gpIC0gbWFjT1MgKG5vdCBpbmNsdWRpbmcgaU9TIGZhbWlseSkgKi8KICNpZiBPUyhEQVJX SU4pCiAjaWYgVEFSR0VUX09TX0lQSE9ORQotI2RlZmluZSBXVEZfT1NfSU9TIDEKKy8qIEZJWE1F IChOb3ZlbWJlciAyMDE4KTogQWRkIFdURl9PU19JT1Mgb25jZSBtb3N0IHBhdGNoZXMgdGhhdCB1 c2VkIGl0IGFzIGFuIG9sZAorICogdmVyc2lvbiBvZiBQTEFURk9STShJT1NfRkFNSUxZKSBhcmUg bm8gbG9uZ2VyIHJlbGV2YW50LiAqLwogI2RlZmluZSBXVEZfT1NfSU9TX0ZBTUlMWSAxCiAjZWxp ZiBUQVJHRVRfT1NfTUFDCiAjZGVmaW5lIFdURl9PU19NQUNfT1NfWCAxCkBAIC01MjMsMTAgKzUy NCwxMiBAQAogI2VsaWYgT1MoTUFDX09TX1gpCiAjZGVmaW5lIFdURl9QTEFURk9STV9NQUMgMQog I2VsaWYgT1MoSU9TKQotI2RlZmluZSBXVEZfUExBVEZPUk1fSU9TIDEKKy8qIEZJWE1FIChOb3Zl bWJlciAyMDE4KTogQWRkIFdURl9QTEFURk9STV9JT1Mgb25jZSBtb3N0IHBhdGNoZXMgdGhhdCB1 c2VkIGl0IGFzIGFuIG9sZAorICogdmVyc2lvbiBvZiBQTEFURk9STShJT1NfRkFNSUxZKSBhcmUg bm8gbG9uZ2VyIHJlbGV2YW50LiAqLwogI2RlZmluZSBXVEZfUExBVEZPUk1fSU9TX0ZBTUlMWSAx CiAjaWYgVEFSR0VUX09TX1NJTVVMQVRPUgotI2RlZmluZSBXVEZfUExBVEZPUk1fSU9TX1NJTVVM QVRPUiAxCisvKiBGSVhNRSAoTm92ZW1iZXIgMjAxOCk6IEFkZCBXVEZfUExBVEZPUk1fSU9TX1NJ TVVMQVRPUiBvbmNlIG1vc3QgcGF0Y2hlcyB0aGF0IHVzZWQgaXQgYXMgYW4gb2xkCisgKiB2ZXJz aW9uIG9mIFBMQVRGT1JNKElPU19GQU1JTFkpIGFyZSBubyBsb25nZXIgcmVsZXZhbnQuICovCiAj ZGVmaW5lIFdURl9QTEFURk9STV9JT1NfRkFNSUxZX1NJTVVMQVRPUiAxCiAjZW5kaWYKICNpZiBk ZWZpbmVkKFRBUkdFVF9PU19JT1NNQUMpICYmIFRBUkdFVF9PU19JT1NNQUMK 352748 2018-10-18 17:00:33 -0700 2018-10-18 17:00:33 -0700 proposed patch RemovePlatformIOS.txt text/plain 1769 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzcyNzQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE4LTEwLTE4ICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBQTEFURk9STShJT1MpIGZvciBub3cK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDczNwor CisgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIb3J0b24uCisKKyAgICAgICAgKiB3dGYvUGxhdGZv cm0uaDoKKwogMjAxOC0xMC0xOCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4K IAogICAgICAgICBTd2l0Y2ggZnJvbSBQTEFURk9STShJT1MpIHRvIFBMQVRGT1JNKElPU19GQU1J TFkpCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDIzNzI3NCkKKysrIFNvdXJjZS9XVEYvd3Rm L1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTM3Myw3ICszNzMsOCBAQAogLyogT1MoTUFD X09TX1gpIC0gbWFjT1MgKG5vdCBpbmNsdWRpbmcgaU9TIGZhbWlseSkgKi8KICNpZiBPUyhEQVJX SU4pCiAjaWYgVEFSR0VUX09TX0lQSE9ORQotI2RlZmluZSBXVEZfT1NfSU9TIDEKKy8qIEZJWE1F IChOb3ZlbWJlciAyMDE4KTogQWRkIFdURl9PU19JT1Mgb25jZSBtb3N0IHBhdGNoZXMgdGhhdCB1 c2VkIGl0IGFzIGFuIG9sZAorICogdmVyc2lvbiBvZiBQTEFURk9STShJT1NfRkFNSUxZKSBhcmUg bm8gbG9uZ2VyIHJlbGV2YW50LiAqLwogI2RlZmluZSBXVEZfT1NfSU9TX0ZBTUlMWSAxCiAjZWxp ZiBUQVJHRVRfT1NfTUFDCiAjZGVmaW5lIFdURl9PU19NQUNfT1NfWCAxCkBAIC01MjIsMTEgKzUy MywxMyBAQAogLyogSlNDT25seSBkb2VzIG5vdCBwcm92aWRlIFBMQVRGT1JNKCkgbWFjcm8gKi8K ICNlbGlmIE9TKE1BQ19PU19YKQogI2RlZmluZSBXVEZfUExBVEZPUk1fTUFDIDEKLSNlbGlmIE9T KElPUykKLSNkZWZpbmUgV1RGX1BMQVRGT1JNX0lPUyAxCisjZWxpZiBPUyhJT1NfRkFNSUxZKQor LyogRklYTUUgKE5vdmVtYmVyIDIwMTgpOiBBZGQgV1RGX1BMQVRGT1JNX0lPUyBvbmNlIG1vc3Qg cGF0Y2hlcyB0aGF0IHVzZWQgaXQgYXMgYW4gb2xkCisgKiB2ZXJzaW9uIG9mIFBMQVRGT1JNKElP U19GQU1JTFkpIGFyZSBubyBsb25nZXIgcmVsZXZhbnQuICovCiAjZGVmaW5lIFdURl9QTEFURk9S TV9JT1NfRkFNSUxZIDEKICNpZiBUQVJHRVRfT1NfU0lNVUxBVE9SCi0jZGVmaW5lIFdURl9QTEFU Rk9STV9JT1NfU0lNVUxBVE9SIDEKKy8qIEZJWE1FIChOb3ZlbWJlciAyMDE4KTogQWRkIFdURl9Q TEFURk9STV9JT1NfU0lNVUxBVE9SIG9uY2UgbW9zdCBwYXRjaGVzIHRoYXQgdXNlZCBpdCBhcyBh biBvbGQKKyAqIHZlcnNpb24gb2YgUExBVEZPUk0oSU9TX0ZBTUlMWSkgYXJlIG5vIGxvbmdlciBy ZWxldmFudC4gKi8KICNkZWZpbmUgV1RGX1BMQVRGT1JNX0lPU19GQU1JTFlfU0lNVUxBVE9SIDEK ICNlbmRpZgogI2lmIGRlZmluZWQoVEFSR0VUX09TX0lPU01BQykgJiYgVEFSR0VUX09TX0lPU01B Qwo=