190735 2018-10-18 14:28:24 -0700 [WebVTT] Region parameter and value should be separated by ':' 2018-10-18 15:32:24 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue eric.carlson webkit-bug-importer oldest_to_newest 1470677 0 pvollan 2018-10-18 14:28:24 -0700 See https://w3c.github.io/webvtt/#region-settings. 1470681 1 webkit-bug-importer 2018-10-18 14:29:36 -0700 <rdar://problem/45384472> 1470686 2 352734 pvollan 2018-10-18 14:34:53 -0700 Created attachment 352734 Patch 1470704 3 352734 pvollan 2018-10-18 15:06:39 -0700 Comment on attachment 352734 Patch Thanks for reviewing! 1470714 4 352734 commit-queue 2018-10-18 15:32:23 -0700 Comment on attachment 352734 Patch Clearing flags on attachment: 352734 Committed r237270: <https://trac.webkit.org/changeset/237270> 1470715 5 commit-queue 2018-10-18 15:32:24 -0700 All reviewed patches have been landed. Closing bug. 352734 2018-10-18 14:34:53 -0700 2018-10-18 15:32:23 -0700 Patch bug-190735-20181018143453.patch text/plain 3596 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNzI2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTEwLTE4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViVlRUXSBSZWdpb24g cGFyYW1ldGVyIGFuZCB2YWx1ZSBzaG91bGQgYmUgc2VwYXJhdGVkIGJ5ICc6JworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNzM1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBzcGVjaWZpZWQg aW4gaHR0cHM6Ly93M2MuZ2l0aHViLmlvL3dlYnZ0dC8jcmVnaW9uLXNldHRpbmdzLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cy4gTW9kaWZpZWQgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBo dG1sL3RyYWNrL1ZUVFJlZ2lvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWVFRSZWdpb246OnNl dFJlZ2lvblNldHRpbmdzKToKKwogMjAxOC0xMC0xOCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJp c3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIENsZWFuIHVwIEZyYW1lTG9hZGVyIHR3by1z dGF0ZSBlbnVtcwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9WVFRSZWdpb24uY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svVlRUUmVnaW9uLmNwcAko cmV2aXNpb24gMjM3MjU3KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9WVFRSZWdpb24u Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzAsOCArMTcwLDggQEAgdm9pZCBWVFRSZWdpb246OnNl dFJlZ2lvblNldHRpbmdzKGNvbnN0IAogICAgICAgICAvLyBTY2FuIHRoZSBuYW1lIHBhcnQuCiAg ICAgICAgIFJlZ2lvblNldHRpbmcgbmFtZSA9IHNjYW5TZXR0aW5nTmFtZShpbnB1dCk7CiAKLSAg ICAgICAgLy8gVmVyaWZ5IHRoYXQgd2UncmUgbG9va2luZyBhdCBhICc9Jy4KLSAgICAgICAgaWYg KG5hbWUgPT0gTm9uZSB8fCAhaW5wdXQuc2NhbignPScpKSB7CisgICAgICAgIC8vIFZlcmlmeSB0 aGF0IHdlJ3JlIGxvb2tpbmcgYXQgYSAnOicuCisgICAgICAgIGlmIChuYW1lID09IE5vbmUgfHwg IWlucHV0LnNjYW4oJzonKSkgewogICAgICAgICAgICAgaW5wdXQuc2tpcFVudGlsPGlzSFRNTFNw YWNlPFVDaGFyPj4oKTsKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICB9CkluZGV4OiBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzcwMDApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxMyBAQAorMjAxOC0xMC0xOCAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxh bkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYlZUVF0gUmVnaW9uIHBhcmFtZXRlciBhbmQgdmFs dWUgc2hvdWxkIGJlIHNlcGFyYXRlZCBieSAnOicKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDczNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogbWVkaWEvdHJhY2svY2FwdGlvbnMtd2VidnR0L2NhcHRp b25zLXJlZ2lvbnMudnR0OgorICAgICAgICAqIG1lZGlhL3RyYWNrL2NhcHRpb25zLXdlYnZ0dC9o ZWFkZXItcmVnaW9ucy52dHQ6CisKIDIwMTgtMTAtMDkgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRz QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdGhlIGZyYW1lcygpIHRpbWluZyBmdW5jdGlv bgpJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svY2FwdGlvbnMtd2VidnR0L2NhcHRpb25z LXJlZ2lvbnMudnR0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21lZGlhL3RyYWNrL2NhcHRp b25zLXdlYnZ0dC9jYXB0aW9ucy1yZWdpb25zLnZ0dAkocmV2aXNpb24gMjM3MjU3KQorKysgTGF5 b3V0VGVzdHMvbWVkaWEvdHJhY2svY2FwdGlvbnMtd2VidnR0L2NhcHRpb25zLXJlZ2lvbnMudnR0 CSh3b3JraW5nIGNvcHkpCkBAIC0xLDExICsxLDExIEBACiBXRUJWVFQgRklMRQogCiBSRUdJT04K LWlkPWZyZWQKLXdpZHRoPTUwJQotbGluZXM9MgotcmVnaW9uYW5jaG9yPTUwJSwxMDAlCi12aWV3 cG9ydGFuY2hvcj0xMCUsNDAlCitpZDpmcmVkCit3aWR0aDo1MCUKK2xpbmVzOjIKK3JlZ2lvbmFu Y2hvcjo1MCUsMTAwJQordmlld3BvcnRhbmNob3I6MTAlLDQwJQogCiAxCiAwMDowMDowMC4wMDAg LS0+IDAwOjAwOjAxLjUwMCByZWdpb246ZnJlZApJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvdHJh Y2svY2FwdGlvbnMtd2VidnR0L2hlYWRlci1yZWdpb25zLnZ0dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9tZWRpYS90cmFjay9jYXB0aW9ucy13ZWJ2dHQvaGVhZGVyLXJlZ2lvbnMudnR0CShy ZXZpc2lvbiAyMzcyNTcpCisrKyBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay9jYXB0aW9ucy13ZWJ2 dHQvaGVhZGVyLXJlZ2lvbnMudnR0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDI4ICsxLDI4IEBACiBX RUJWVFQgRklMRQogCiBSRUdJT04KLWlkPXJlZ2lvbl93aXRob3V0X3NldHRpbmdzCitpZDpyZWdp b25fd2l0aG91dF9zZXR0aW5ncwogCiBSRUdJT04KLWlkPXJlZ2lvbl93aXRoX2FsbF9zZXR0aW5n cwotd2lkdGg9MzIlCi1saW5lcz01Ci1yZWdpb25hbmNob3I9NDElLDIwJQotdmlld3BvcnRhbmNo b3I9MzElLDg0JQotc2Nyb2xsPXVwCitpZDpyZWdpb25fd2l0aF9hbGxfc2V0dGluZ3MKK3dpZHRo OjMyJQorbGluZXM6NQorcmVnaW9uYW5jaG9yOjQxJSwyMCUKK3ZpZXdwb3J0YW5jaG9yOjMxJSw4 NCUKK3Njcm9sbDp1cAogCiBSRUdJT04KLWlkPXJlZ2lvbl9mbG9hdGluZ19wb2ludF9hbmNob3IK LXJlZ2lvbmFuY2hvcj00MS4xMzMlLDIwLjQyJQotdmlld3BvcnRhbmNob3I9MzIuMzMlLDMyLjQ0 JQoraWQ6cmVnaW9uX2Zsb2F0aW5nX3BvaW50X2FuY2hvcgorcmVnaW9uYW5jaG9yOjQxLjEzMyUs MjAuNDIlCit2aWV3cG9ydGFuY2hvcjozMi4zMyUsMzIuNDQlCiAKIFJFR0lPTgotaWQ9bm90X3Vu aXF1ZV9pZAotd2lkdGg9NDIlCitpZDpub3RfdW5pcXVlX2lkCit3aWR0aDo0MiUKIAogUkVHSU9O Ci1pZD1ub3RfdW5pcXVlX2lkCi13aWR0aD02NyUKK2lkOm5vdF91bmlxdWVfaWQKK3dpZHRoOjY3 JQogCiBSRUdJT04KIGludmFsaWRfc2V0dGluZ3MgdmFsdWVzIGJ1dCByZWdpb24gc3RpbGwgY3Jl YXRlZAo=