190730 2018-10-18 13:37:19 -0700 [WebVTT] The TextTrackLoader parameter in TextTrackLoaderClient virtual methods should be a reference 2018-10-18 14:30:38 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham calvaris cdumez commit-queue dbates eric.carlson esprehn+autocc ews-watchlist gyuyoung.kim japhet philipj webkit-bug-importer oldest_to_newest 1470643 0 pvollan 2018-10-18 13:37:19 -0700 It is currently a pointer. 1470644 1 webkit-bug-importer 2018-10-18 13:38:06 -0700 <rdar://problem/45382278> 1470645 2 352725 pvollan 2018-10-18 13:39:37 -0700 Created attachment 352725 Patch 1470647 3 352725 cdumez 2018-10-18 13:44:32 -0700 Comment on attachment 352725 Patch r=me if the bots are happy. 1470650 4 352725 pvollan 2018-10-18 13:54:18 -0700 Comment on attachment 352725 Patch Thanks for reviewing! 1470683 5 352725 commit-queue 2018-10-18 14:30:36 -0700 Comment on attachment 352725 Patch Clearing flags on attachment: 352725 Committed r237265: <https://trac.webkit.org/changeset/237265> 1470684 6 commit-queue 2018-10-18 14:30:38 -0700 All reviewed patches have been landed. Closing bug. 352725 2018-10-18 13:39:37 -0700 2018-10-18 14:30:36 -0700 Patch bug-190730-20181018133937.patch text/plain 5400 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNzI2MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTEwLTE4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViVlRUXSBUaGUgVGV4 dFRyYWNrTG9hZGVyIHBhcmFtZXRlciBpbiBUZXh0VHJhY2tMb2FkZXJDbGllbnQgdmlydHVhbCBt ZXRob2RzIHNob3VsZCBiZSBhIHJlZmVyZW5jZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNzMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3Iu CisKKyAgICAgICAgKiBodG1sL3RyYWNrL0xvYWRhYmxlVGV4dFRyYWNrLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkxvYWRhYmxlVGV4dFRyYWNrOjpuZXdDdWVzQXZhaWxhYmxlKToKKyAgICAgICAg KFdlYkNvcmU6OkxvYWRhYmxlVGV4dFRyYWNrOjpjdWVMb2FkaW5nQ29tcGxldGVkKToKKyAgICAg ICAgKFdlYkNvcmU6OkxvYWRhYmxlVGV4dFRyYWNrOjpuZXdSZWdpb25zQXZhaWxhYmxlKToKKyAg ICAgICAgKiBodG1sL3RyYWNrL0xvYWRhYmxlVGV4dFRyYWNrLmg6CisgICAgICAgICogbG9hZGVy L1RleHRUcmFja0xvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0VHJhY2tMb2FkZXI6 OmN1ZUxvYWRUaW1lckZpcmVkKToKKyAgICAgICAgKFdlYkNvcmU6OlRleHRUcmFja0xvYWRlcjo6 bmV3UmVnaW9uc1BhcnNlZCk6CisgICAgICAgICogbG9hZGVyL1RleHRUcmFja0xvYWRlci5oOgor CiAyMDE4LTEwLTE4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAg ICAgICAgIFtHVEtdIGZhc3QvY3NzL3BzZXVkby12aXNpdGVkLWJhY2tncm91bmQtY29sb3Itb24t aW5wdXQuaHRtbCBpcyBmYWlsaW5nIHNpbmNlIHIyMzc0MjUKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2h0bWwvdHJhY2svTG9hZGFibGVUZXh0VHJhY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2h0bWwvdHJhY2svTG9hZGFibGVUZXh0VHJhY2suY3BwCShyZXZpc2lvbiAyMzcyNTcp CisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL0xvYWRhYmxlVGV4dFRyYWNrLmNwcAkod29y a2luZyBjb3B5KQpAQCAtODYsOSArODYsOSBAQCB2b2lkIExvYWRhYmxlVGV4dFRyYWNrOjpsb2Fk VGltZXJGaXJlZCgpCiAgICAgICAgIG1fdHJhY2tFbGVtZW50LT5kaWRDb21wbGV0ZUxvYWQoSFRN TFRyYWNrRWxlbWVudDo6RmFpbHVyZSk7CiB9CiAKLXZvaWQgTG9hZGFibGVUZXh0VHJhY2s6Om5l d0N1ZXNBdmFpbGFibGUoVGV4dFRyYWNrTG9hZGVyKiBsb2FkZXIpCit2b2lkIExvYWRhYmxlVGV4 dFRyYWNrOjpuZXdDdWVzQXZhaWxhYmxlKFRleHRUcmFja0xvYWRlciYgbG9hZGVyKQogewotICAg IEFTU0VSVF9VTlVTRUQobG9hZGVyLCBtX2xvYWRlci5nZXQoKSA9PSBsb2FkZXIpOworICAgIEFT U0VSVF9VTlVTRUQobG9hZGVyLCBtX2xvYWRlci5nZXQoKSA9PSAmbG9hZGVyKTsKIAogICAgIFZl Y3RvcjxSZWZQdHI8VGV4dFRyYWNrQ3VlPj4gbmV3Q3VlczsKICAgICBtX2xvYWRlci0+Z2V0TmV3 Q3VlcyhuZXdDdWVzKTsKQEAgLTEwNiw5ICsxMDYsOSBAQCB2b2lkIExvYWRhYmxlVGV4dFRyYWNr OjpuZXdDdWVzQXZhaWxhYmxlCiAgICAgICAgIGNsaWVudCgpLT50ZXh0VHJhY2tBZGRDdWVzKCp0 aGlzLCAqbV9jdWVzKTsKIH0KIAotdm9pZCBMb2FkYWJsZVRleHRUcmFjazo6Y3VlTG9hZGluZ0Nv bXBsZXRlZChUZXh0VHJhY2tMb2FkZXIqIGxvYWRlciwgYm9vbCBsb2FkaW5nRmFpbGVkKQordm9p ZCBMb2FkYWJsZVRleHRUcmFjazo6Y3VlTG9hZGluZ0NvbXBsZXRlZChUZXh0VHJhY2tMb2FkZXIm IGxvYWRlciwgYm9vbCBsb2FkaW5nRmFpbGVkKQogewotICAgIEFTU0VSVF9VTlVTRUQobG9hZGVy LCBtX2xvYWRlci5nZXQoKSA9PSBsb2FkZXIpOworICAgIEFTU0VSVF9VTlVTRUQobG9hZGVyLCBt X2xvYWRlci5nZXQoKSA9PSAmbG9hZGVyKTsKIAogICAgIGlmICghbV90cmFja0VsZW1lbnQpCiAg ICAgICAgIHJldHVybjsKQEAgLTExOCw5ICsxMTgsOSBAQCB2b2lkIExvYWRhYmxlVGV4dFRyYWNr OjpjdWVMb2FkaW5nQ29tcGxlCiAgICAgbV90cmFja0VsZW1lbnQtPmRpZENvbXBsZXRlTG9hZChs b2FkaW5nRmFpbGVkID8gSFRNTFRyYWNrRWxlbWVudDo6RmFpbHVyZSA6IEhUTUxUcmFja0VsZW1l bnQ6OlN1Y2Nlc3MpOwogfQogCi12b2lkIExvYWRhYmxlVGV4dFRyYWNrOjpuZXdSZWdpb25zQXZh aWxhYmxlKFRleHRUcmFja0xvYWRlciogbG9hZGVyKQordm9pZCBMb2FkYWJsZVRleHRUcmFjazo6 bmV3UmVnaW9uc0F2YWlsYWJsZShUZXh0VHJhY2tMb2FkZXImIGxvYWRlcikKIHsKLSAgICBBU1NF UlRfVU5VU0VEKGxvYWRlciwgbV9sb2FkZXIuZ2V0KCkgPT0gbG9hZGVyKTsKKyAgICBBU1NFUlRf VU5VU0VEKGxvYWRlciwgbV9sb2FkZXIuZ2V0KCkgPT0gJmxvYWRlcik7CiAKICAgICBWZWN0b3I8 UmVmUHRyPFZUVFJlZ2lvbj4+IG5ld1JlZ2lvbnM7CiAgICAgbV9sb2FkZXItPmdldE5ld1JlZ2lv bnMobmV3UmVnaW9ucyk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL0xvYWRhYmxl VGV4dFRyYWNrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9Mb2Fk YWJsZVRleHRUcmFjay5oCShyZXZpc2lvbiAyMzcyNTcpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1s L3RyYWNrL0xvYWRhYmxlVGV4dFRyYWNrLmgJKHdvcmtpbmcgY29weSkKQEAgLTUzLDkgKzUzLDkg QEAgcHVibGljOgogcHJpdmF0ZToKICAgICBMb2FkYWJsZVRleHRUcmFjayhIVE1MVHJhY2tFbGVt ZW50JiwgY29uc3QgU3RyaW5nJiBraW5kLCBjb25zdCBTdHJpbmcmIGxhYmVsLCBjb25zdCBTdHJp bmcmIGxhbmd1YWdlKTsKIAotICAgIHZvaWQgbmV3Q3Vlc0F2YWlsYWJsZShUZXh0VHJhY2tMb2Fk ZXIqKSBmaW5hbDsKLSAgICB2b2lkIGN1ZUxvYWRpbmdDb21wbGV0ZWQoVGV4dFRyYWNrTG9hZGVy KiwgYm9vbCBsb2FkaW5nRmFpbGVkKSBmaW5hbDsKLSAgICB2b2lkIG5ld1JlZ2lvbnNBdmFpbGFi bGUoVGV4dFRyYWNrTG9hZGVyKikgZmluYWw7CisgICAgdm9pZCBuZXdDdWVzQXZhaWxhYmxlKFRl eHRUcmFja0xvYWRlciYpIGZpbmFsOworICAgIHZvaWQgY3VlTG9hZGluZ0NvbXBsZXRlZChUZXh0 VHJhY2tMb2FkZXImLCBib29sIGxvYWRpbmdGYWlsZWQpIGZpbmFsOworICAgIHZvaWQgbmV3UmVn aW9uc0F2YWlsYWJsZShUZXh0VHJhY2tMb2FkZXImKSBmaW5hbDsKICAgICB2b2lkIG5ld1N0eWxl U2hlZXRzQXZhaWxhYmxlKFRleHRUcmFja0xvYWRlciYpIGZpbmFsOwogCiAgICAgQXRvbWljU3Ry aW5nIGlkKCkgY29uc3QgZmluYWw7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvVGV4dFRy YWNrTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvVGV4dFRy YWNrTG9hZGVyLmNwcAkocmV2aXNpb24gMjM3MjU3KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVy L1RleHRUcmFja0xvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY1LDExICs2NSwxMSBAQCB2 b2lkIFRleHRUcmFja0xvYWRlcjo6Y3VlTG9hZFRpbWVyRmlyZWQoCiB7CiAgICAgaWYgKG1fbmV3 Q3Vlc0F2YWlsYWJsZSkgewogICAgICAgICBtX25ld0N1ZXNBdmFpbGFibGUgPSBmYWxzZTsKLSAg ICAgICAgbV9jbGllbnQubmV3Q3Vlc0F2YWlsYWJsZSh0aGlzKTsKKyAgICAgICAgbV9jbGllbnQu bmV3Q3Vlc0F2YWlsYWJsZSgqdGhpcyk7CiAgICAgfQogICAgIAogICAgIGlmIChtX3N0YXRlID49 IEZpbmlzaGVkKQotICAgICAgICBtX2NsaWVudC5jdWVMb2FkaW5nQ29tcGxldGVkKHRoaXMsIG1f c3RhdGUgPT0gRmFpbGVkKTsKKyAgICAgICAgbV9jbGllbnQuY3VlTG9hZGluZ0NvbXBsZXRlZCgq dGhpcywgbV9zdGF0ZSA9PSBGYWlsZWQpOwogfQogCiB2b2lkIFRleHRUcmFja0xvYWRlcjo6Y2Fu Y2VsTG9hZCgpCkBAIC0xNzgsNyArMTc4LDcgQEAgdm9pZCBUZXh0VHJhY2tMb2FkZXI6Om5ld0N1 ZXNQYXJzZWQoKQogCiB2b2lkIFRleHRUcmFja0xvYWRlcjo6bmV3UmVnaW9uc1BhcnNlZCgpCiB7 Ci0gICAgbV9jbGllbnQubmV3UmVnaW9uc0F2YWlsYWJsZSh0aGlzKTsKKyAgICBtX2NsaWVudC5u ZXdSZWdpb25zQXZhaWxhYmxlKCp0aGlzKTsKIH0KIAogdm9pZCBUZXh0VHJhY2tMb2FkZXI6Om5l d1N0eWxlU2hlZXRzUGFyc2VkKCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9UZXh0VHJh Y2tMb2FkZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvVGV4dFRyYWNr TG9hZGVyLmgJKHJldmlzaW9uIDIzNzI1NykKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9UZXh0 VHJhY2tMb2FkZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNDUsOSArNDUsOSBAQCBjbGFzcyBUZXh0 VHJhY2tMb2FkZXJDbGllbnQgewogcHVibGljOgogICAgIHZpcnR1YWwgflRleHRUcmFja0xvYWRl ckNsaWVudCgpID0gZGVmYXVsdDsKICAgICAKLSAgICB2aXJ0dWFsIHZvaWQgbmV3Q3Vlc0F2YWls YWJsZShUZXh0VHJhY2tMb2FkZXIqKSA9IDA7Ci0gICAgdmlydHVhbCB2b2lkIGN1ZUxvYWRpbmdD b21wbGV0ZWQoVGV4dFRyYWNrTG9hZGVyKiwgYm9vbCBsb2FkaW5nRmFpbGVkKSA9IDA7Ci0gICAg dmlydHVhbCB2b2lkIG5ld1JlZ2lvbnNBdmFpbGFibGUoVGV4dFRyYWNrTG9hZGVyKikgPSAwOwor ICAgIHZpcnR1YWwgdm9pZCBuZXdDdWVzQXZhaWxhYmxlKFRleHRUcmFja0xvYWRlciYpID0gMDsK KyAgICB2aXJ0dWFsIHZvaWQgY3VlTG9hZGluZ0NvbXBsZXRlZChUZXh0VHJhY2tMb2FkZXImLCBi b29sIGxvYWRpbmdGYWlsZWQpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgbmV3UmVnaW9uc0F2YWls YWJsZShUZXh0VHJhY2tMb2FkZXImKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIG5ld1N0eWxlU2hl ZXRzQXZhaWxhYmxlKFRleHRUcmFja0xvYWRlciYpID0gMDsKIH07CiAK